Age | Commit message (Collapse) | Author |
|
Change-Id: I33813be65bcb44c11a35bc97d963057418a28d9e
Reviewed-on: https://gerrit.libreoffice.org/50984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
There are occasional failures of Jenkins "Daily Screenshot Build on Windows"
like <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/324/console>
and <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/332/console>,
always failing with
> C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/test/source/screenshot_test.cxx(84) : error : Assertion
> Test name: ReportdesignDialogsTest::openAnyDialog
> assertion failed
> - Expression: aNew.IsOpen()
> - Failed to open <C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png>: 796
(where 796 is ERRCODE_IO_NOTEXISTSPATH). Beats me how that can happen, when
ScreenshotTest::implSaveScreenshot first creates the dir and then the file-in-
dir (and it is rather unlikely that something else deletes the dir in the
meantime, for various builds of that Jenkins bot, always for the same dir
workdir/screenshots/modules/dbreport/ui/condformatdialog/), and why it always
happens for exactly the same file,
workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png during
CppunitTest_reportdesign_dialogs_test.
However, one curiosity was that the dir's URL was computed with
m_directories.getURLFromWorkdir(aDirname);
(without a leading slash inserted before aDirname) while the file's pathname was
computed with
m_directories.getPathFromWorkdir("/" + aDirname + ...)
(with a leading slash inserted before aDirname). Turns out that SvFileStream
accepts a URL as well as a pathname, so normalize the computation of the dir's
and the file's URL. Maybe that will give a clue why that Jenkins bot sometimes
fails.
Change-Id: I53b59b51ffc4355c45aa0ca72f6e187cf2010f92
|
|
Change-Id: If0bfa9fb465f37e0ccce5b2fa4e909baaac1df50
Reviewed-on: https://gerrit.libreoffice.org/50722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I31f190a1232331dd2076cdb8583e2036887f4f9f
Reviewed-on: https://gerrit.libreoffice.org/50441
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I894b2e2534efeb5369c491053caf56f67dc56618
Reviewed-on: https://gerrit.libreoffice.org/50411
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
...regression introduced with eff70347190a6642fd62a9e0b20e4366c39fbc7a
"tdf#45904 Move _XFunctionDescriptions Java test to C++" (where
java.util.Random.nextInt(n) returned a value 0 <= x < n), apparently causing
sporadic failures of CppunitTest_sc_functionlistobj like <https://
ci.libreoffice.org/job/lo_gerrit/27696/Config=linux_clang_dbgutil_64/console>
> ##Failure Location unknown## : Error
> Test name: sc_apitest::ScFunctionListObj::testGetById
> An uncaught exception of type com.sun.star.lang.IndexOutOfBoundsException
Also verify that nCount is not negative, so that the requirements of the
std::uniform_int_distribution ctor are guaranteed to be satisfied.
Change-Id: I90a5dc234fdd07f52fea69ae1d406f0818efb007
|
|
The "xlink" prefix for the "xlink:href" attribute on the "image" element
was not bound.
Change-Id: I473a0b1612b4842cf84a264960bb28a9f19600e5
Reviewed-on: https://gerrit.libreoffice.org/49612
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: If391071a7e44c2fbeaaa0fa46f6043f30e777cec
Reviewed-on: https://gerrit.libreoffice.org/49125
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ia4ebe9d0418e33d245437a49c7ce9551b4a06e82
Reviewed-on: https://gerrit.libreoffice.org/49124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326
Reviewed-on: https://gerrit.libreoffice.org/49062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331
Reviewed-on: https://gerrit.libreoffice.org/49061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I24d3641feb34e66959ff2afe4cdb3546e7cd7ca4
Reviewed-on: https://gerrit.libreoffice.org/48732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad
Reviewed-on: https://gerrit.libreoffice.org/48546
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5d698303a901ee103fdd4ffdea34809142afa0e5
Reviewed-on: https://gerrit.libreoffice.org/48463
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
...that fails for me on at least one macOS and Windows machine each (with 180
and 230, resp., instead of 116), and where it is unclear why only a value of 116
would be correct (and where that specific check was not present before
95307f2ca73480176634e5cc46d96a19b735e87b "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++", cf. my comment from 2018-01-17 at
<https://gerrit.libreoffice.org/#/c/47625/> "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++")
Change-Id: I16475ecaa853220ffe9e1d6dcf403302b04f4572
Reviewed-on: https://gerrit.libreoffice.org/48215
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Icdc30eb65b10a72b66f26c0d55844b8fb433f090
Reviewed-on: https://gerrit.libreoffice.org/47976
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I5f7cd029e27be24415c075c4589e71eeae5d6ac2
|
|
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files
Change-Id: Ia0835f0d9fe59bf0cb42210e4a6be1f022259a8d
|
|
Change-Id: I68dcabd15b4b318a833a893b4de96c64ffd2a164
Reviewed-on: https://gerrit.libreoffice.org/47625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Id4265dd6a8123624bccdfe343655525948cadee7
Reviewed-on: https://gerrit.libreoffice.org/47623
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I0a0e07a6a71ed95d783d35b7d94b857074ec3450
Reviewed-on: https://gerrit.libreoffice.org/47523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ie00a963c5eb575ae1e96f6e1aa10da1a2ce421e4
Reviewed-on: https://gerrit.libreoffice.org/47485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
As far as I see the old qadevOOo/runner/lib/MultiPropertyTest.java
didn't assert the content of the property value (only avoided the set of
the property if the value was null or void), the new C++ version asserts
both the type and the value. Asserting the type is probably a good
thing, but asserting the value is problematic, at least the test failed
for me without these tweaks.
Change-Id: I688486025e6118ad4c8907de6cb2629dd008f8fd
Reviewed-on: https://gerrit.libreoffice.org/47475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Change-Id: I53e9a449cb18c26187f3b1676f8ab67918128499
Reviewed-on: https://gerrit.libreoffice.org/47447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ib26a2d2a05d926a0d031c86812456996cb368792
Reviewed-on: https://gerrit.libreoffice.org/47361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I7cd358845a048e6eb6df9bd42d022357e553981c
Reviewed-on: https://gerrit.libreoffice.org/47355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I3f4ad9eff0730d3deea96b37fa7f36dfd038b214
Reviewed-on: https://gerrit.libreoffice.org/47301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Fixes #i90346.
Change-Id: Iec7e5ebfe28d3d26f5c50950ee2d3f5fc890da65
Reviewed-on: https://gerrit.libreoffice.org/47292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ie61537af3dd30e47cc5a9ab925e636686c0325f4
Reviewed-on: https://gerrit.libreoffice.org/47291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I313f3a56fd99e7fb29e6f729cfe13e99adf1fed6
Reviewed-on: https://gerrit.libreoffice.org/47289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ic3c1e6d793d4405c2dc4b8e7d1d7b87ed94fc6c3
Reviewed-on: https://gerrit.libreoffice.org/46579
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I95c20893878385ef173875956d3d7166b0e9e563
Reviewed-on: https://gerrit.libreoffice.org/46578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Id851121d424e88d28f0c941d50ab115eba5cea18
Reviewed-on: https://gerrit.libreoffice.org/46485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ib3e3722c1a4799ebb0cbb78f458abd6b967d6ba1
Reviewed-on: https://gerrit.libreoffice.org/46263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.
Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2de8448564c963d3361a828bb96dcdb15eddf717
Reviewed-on: https://gerrit.libreoffice.org/46151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iee6753fd60fefc1ecd17ba8fe0acef58f17d64e6
Reviewed-on: https://gerrit.libreoffice.org/46076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I5ba1733a8e675048366651aa5f3affc9c249622c
Reviewed-on: https://gerrit.libreoffice.org/46066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I5a452f10799f78a6f83136bec4e1346c4ec8edf8
Reviewed-on: https://gerrit.libreoffice.org/46063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b
Reviewed-on: https://gerrit.libreoffice.org/45959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaea5b7abc0a289035c7a230c0034d2422cc4ae5f
Reviewed-on: https://gerrit.libreoffice.org/46001
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ie2c8e55cabd6adcd523baf2f75c5f2decaf8fe87
Reviewed-on: https://gerrit.libreoffice.org/45772
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Fix for #i84761.
Change-Id: I3ea608ce60ecc274bc2af9eb1d8117372b663a6f
Reviewed-on: https://gerrit.libreoffice.org/45637
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I371951b0e5a0f8c6fe796ff94dc60e07944c3f0f
Reviewed-on: https://gerrit.libreoffice.org/45758
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I102b726e673f69bfe64eff7e28e380dd6f15f1f8
Reviewed-on: https://gerrit.libreoffice.org/45629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I5e6ee9f44223c4b0b92ec32bb508d5b6c988689f
Reviewed-on: https://gerrit.libreoffice.org/45265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Fixes #i109517 for sc.ScCellObj by adding a note/comment during
the set up of the test in sccellobj.cxx and allows to re-enabled
the test.
Change-Id: Ic7aa6bcb2606f555a76612a6f50c200d738674db
Reviewed-on: https://gerrit.libreoffice.org/44617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: Ibc99dc0d50e612bc6cdebaf5f9c5f828e5af859f
Reviewed-on: https://gerrit.libreoffice.org/45123
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I057447494ff488546d43d2d3068a65d5c0d402e0
Reviewed-on: https://gerrit.libreoffice.org/45120
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I1e5346e2f014b412a2f8be08553c8eeff37920f9
Reviewed-on: https://gerrit.libreoffice.org/44840
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|