summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)Author
2015-10-16convert PASSED to COMPLETED in 'make check' test messagesNoel Grandin
Change-Id: I5501f4f40024d3a47bb7007896e07c6252151cf6
2015-10-15cppcheck:variableScopeNoel Grandin
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12loplugin:mergeclassesNoel Grandin
Change-Id: I555e3db911a97e798ce9f10c76d7fe187ea550a7
2015-10-09Related tdf#94557: Combo box entries are case-sensitive (sometimes)Julien Nabet
Revert partly http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f33f10309b0ee384a75a7a854858b068d60495 author Julien Nabet <serval2412@yahoo.fr> 2015-03-16 21:31:23 (GMT) committer Caolán McNamara <caolanm@redhat.com> 2015-03-26 14:14:44 (GMT) commit 76f33f10309b0ee384a75a7a854858b068d60495 (patch) tree e12e3b6f2ca46cb9998b93b5c1bb3406408ad3cb parent 6c4100cf81e1678ff386549c0cdaa2f73a154ddc (diff) tdf#67990: Management of case in combobox See comments of tdf#94557 for more information Change-Id: I0432db0c3f76c20e55d8fecb69734952dc0cf53b Reviewed-on: https://gerrit.libreoffice.org/19260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-01remove old standalone Sun bug numbersNoel Grandin
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-29Fix typosAndrea Gelmini
Change-Id: Ifddd2533b767924791338555031b848c59980c52 Reviewed-on: https://gerrit.libreoffice.org/18989 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-09-29toolkit: convert alloca() to std::unique_ptrMichael Stahl
Change-Id: Ie50b4a1a189fffdaa6a0b26040c2e7c4cc42cd69
2015-09-21convert Link<> to typedNoel Grandin
Change-Id: If3e2b00092440ebd42ae5b73ae2b0e44c3702683
2015-09-20convert Link<> to typedNoel Grandin
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511 Reviewed-on: https://gerrit.libreoffice.org/18700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-18boost->stdCaolán McNamara
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-16boost->stdCaolán McNamara
Change-Id: Ic18be8b86727dd1179a7e39c70493d088ed00557
2015-09-14convert Link<> to typedNoel Grandin
Change-Id: I1c501671d72edd5b998e80c7fa1e91dbeb507af8
2015-09-12Use better/auto int types, remove a couple of OUStrings copiesMatteo Casalin
Change-Id: I911742bddba1dac2641d7d2ac1dad0ed195474dd
2015-09-11convert Link<> to typedNoel Grandin
Change-Id: I70d7c7ae4fc68d2f36a00d7c1b6eba71f63872d7
2015-09-11convert Link<> to typedNoel Grandin
and remove unused maChildEventListeners Change-Id: I845a9af608c3429cf9ccb0e8041f24f423839513
2015-09-09Get rid of OSL_UNUSEDStephan Bergmann
In many cases it was originally used to silence warnings about variables used only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is based on SAL_WARN etc. In some other cases it was apparently used as a speculative debugging aid, to have a value assigned to a variable to be easily able to view the value in a debugger. And in some cases it was used with (otherwise ignored) return values of (typically SQL-related) function calls, but it is probably better to eventually find and fix all the problematic ones among such calls via function declarations annotated SAL_WARN_UNUSED_RESULT. Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
2015-09-08toolkit: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: If62a0c3da7f9732a60316dfd49323f6ab838fb6d Reviewed-on: https://gerrit.libreoffice.org/18396 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: I03529fd3a769d0ebf1f17e3885cd6ecb691a8678
2015-08-28make PostUserEvent Link<> typedNoel Grandin
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-21Remove demonstrated-useless comphelper::compareStephan Bergmann
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-08-06toolkit: don't let ToolkitWorkerFunction join its own threadMichael Stahl
Change-Id: I6694bf83e1e5ba6563d399e454442ce3574e8d26
2015-08-03vcl:: replace boost::function with std::functionMichael Stahl
Change-Id: Ibcc536558f26ed15c59263c25bfeb690950dd3d0
2015-08-03inline some use-once typedefsNoel Grandin
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d Reviewed-on: https://gerrit.libreoffice.org/17495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27inline a bunch of use-once macrosNoel Grandin
no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-24Resolves: tdf#90609 SolarMutex assert on threaded loadCaolán McNamara
Change-Id: I81a784ab506d0d3ae266d7341b8ff7a163dcd8d2
2015-07-24convert ImageAlign to enum classNoel Grandin
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
2015-07-24convert WALLPAPER constants to scoped enumNoel Grandin
Change-Id: I3b4b4e8a94904e22823a263bd5446a2e1aa47661
2015-07-19Fix typosAndrea Gelmini
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c Reviewed-on: https://gerrit.libreoffice.org/17187 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann
Change-Id: I9875ceec4276382d4bf96bc7e150d594df646602
2015-07-14loplugin:unusedmethods toolkit,packageNoel Grandin
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd Reviewed-on: https://gerrit.libreoffice.org/17031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-04Fix typosAndrea Gelmini
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec Reviewed-on: https://gerrit.libreoffice.org/16712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-28coverity#1308539 Uncaught exceptionCaolán McNamara
Change-Id: Id9cad4eaccd71c769fea06d71bbfdd03e8c112ae
2015-06-20gb_OBJCXXFLAGS requires -lobjcStephan Bergmann
...as it causes at least recent Clang trunk (towards 3.7) to emit .cfi_personality 155, ___objc_personality_v0 where __objc_personality_v0 is exported from /usr/lib/libobjc.A.dylib Change-Id: If4ccf15b2c3167185ba50d78ecf4379e02814933
2015-06-17Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:redundantAssignmentNoel Grandin
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15java: 'final static' to 'static final'Noel Grandin
this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11speed up Java unit tests by removing sleepsNoel Grandin
and replacing them with a call to XToolkitExperimental:: processEventsToIdle Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932 Reviewed-on: https://gerrit.libreoffice.org/16201 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-09java:Non-synchronized method should not override a synchronized methodNoel Grandin
Change-Id: I46307828757ee1142747c14d2942515340083605
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Ib636a7566825dd4bd30cc7e8c2e6b744b619b59b
2015-06-08vclptr fix in ScrollableWrapperNoel Grandin
Change-Id: I28b0c9712d3eb35181ccd323e583d947db06094d