summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)Author
2020-07-06exile fmtfield.hxx to toolkit headersCaolán McNamara
Change-Id: I4d16dd079d4f8900d5e04677742679d6592f7066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-05return a reference instead of a pointerCaolán McNamara
Change-Id: Ib8b9133991a9c36e737171ae6dfb6a87cc91e1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03change FormattedField so it doesn't inherit from Formatter but provides oneCaolán McNamara
Change-Id: I728380fb4e2ed914c4b96c0915075af097846c55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03remove some dead WindowType valuesNoel Grandin
Change-Id: I7eb67e48a87e8cc2babbd46d482294877b08ab99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: toolkitStephan Bergmann
Change-Id: I40eb6de30065fe00d5214e0a00b38d02b0deea52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97708 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23move ListBox to toolkit-only headersCaolán McNamara
Change-Id: I6266dedb17cd7c3b730fc69804695536fef37cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-23FixedBitmap can be in a toolkit only headerCaolán McNamara
Change-Id: I22bb548f7f0c1ef0de157f99915fbaf6473c284b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-21don't include vcl/fmtfield.hxx from public hxxCaolán McNamara
Change-Id: I99077c7fe204ab86eef2c5d7dce1a902d7d10df9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMichael Warner
Change-Id: Id747848b222f69af3293a2095a62542f1e1116d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95215 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-02Fix typoAndrea Gelmini
Change-Id: I6b6cf2a8c6faa461515e8548d3db67e453351085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95361 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-01Revert "tdf#125609 toolkit: don't use XTabController::getControls"Noel Grandin
This reverts LO6.4 commit 5cf057c3365a0feafc8f2e4f4a9e24d69a581999, in order to fix tdf#133158. This commit is obsolete, but was left in place since it seemed to have fixed a problem (in =gtk3 anyway). But now SAL_USE_VCLPLUGIN=gen behaves differently, so obviously a fix in one place must have broken another. Better the problems you have always known than a new problem, especially since this patch isn't used to fix anything specific in gtk3 anymore (since those changes were also reverted). An earlier gerrit version of this revert (which didn't just have an ignore-this-clang-rule exception) half-worked, but failed if multiple documents were opened. Change-Id: Ie8ddb7b9669fa46067d04c35e157ea08701df0da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-28Resolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-22PaintToDevice doesn't use its Size argumentCaolán McNamara
Change-Id: I45ce895ac67be9aaf137e0e4c79954488f23a6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-22remove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20move ComboBox to toolkit-only headersCaolán McNamara
Change-Id: If5f0ab1fba8fa7302b7c0e8d2b25761ab64c97e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-20fix -Werror=maybe-uninitializedNoel Grandin
Change-Id: I718016b5f9120c18868ed798785af1f8108be25b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-18tdf#133142 UnoControlTabPageContainer: Handle tab property changesMichael Weghorn
In the model, changing a tab page's title or enabled/disabled status is done via methods 'XTabPageModel.setTitle' and 'XTabPageModel.setEnabled'. Changes to the title and enabled/disabled status are propagated to the tab page container containing the tab page (s.a. 25c692c2a94ab83c2c859ac5ab334b62ac8b825e ("ControlModelContainerBase: Use property for enabled status", 2020-05-15)). Make 'VCLXTabPageContainer' derive from 'XPropertiesChangeListener' and implement the 'propertiesChange' method defined in that interface to handle property changes for the tab pages and have 'UnoControlTabPageContainer' forward 'PropertyChangeEvent's to its peer so they can be handled there. This way, changes for those tab page properties via UNO are now properly updated in the UI as well. Change-Id: I6fa1fadf781575c4ad1d066aed9c3a651b10869d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94402 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-15ControlModelContainerBase: Use property for enabled statusMichael Weghorn
Use the property BASEPROPERTY_ENABLED for getting and setting the status instead of handling it in a custom bool member variable. This way, property changes are also automatically propagated and can be handled by the corresponding listeners. Change-Id: I3a36ac8738a7caae987894ac9dd271d2713c1e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94310 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-15Forward 'removeTabPageContainerListener' as suchMichael Weghorn
Calling 'addTabPageContainerListener' for the peer instead looks like it was probably a copy paste mistake when adding this forwarding in both, 'UnoControlTabPageContainer::addTabPageContainerListener', and 'UnoControlTabPageContainer::removeTabPageContainerListener' in commit 559f957fc3e4295b049866efe3582b2aaa17c414 ("tabcontrol: notify tab listener", 2010-09-06). Change-Id: I98f20b9cb3e658143b362118189adfbed85f3b43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94262 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-14UnoEditControl: Don't initialize members twiceMichael Weghorn
'mnMaxTextLen' and 'mbSetMaxTextLenInPeer' are already assigned the same values in the member initializer list. Change-Id: I498ff981c25f6b5395400c75ad8c7e0f20ff3a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94180 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-14Rename ContainerControl_IBase -> ControlContainer_IBaseMichael Weghorn
The only class inheriting from it is ControlContainerBase, so make the naming more consistent, also to match the naming pattern used elsewhere. Change-Id: I91739fb105f97605a3c279100b8c4e666aa3b010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94139 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-13fix ScriptEventContainer::isEmptyNoel Grandin
which was relying on the nElementCount field, which was not being updated. Just delete it and check the map. Change-Id: If543abcc7c1778a27675a1df69a54325024234b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-11tdf#132832 calcAdjustedSize: Take max width into accountMichael Weghorn
Actually take into account the preferred width when calculating the size of radio button, checkbox and hyperlink controls. This e.g. makes word wrap work properly when the multiline property is set for a checkbox, radio or hyperlink control and the single line text exceeds the preferred width, rather than keeping the whole text in one line that exceeds the preferred width. Change-Id: Id04668e4e1afe7c10a28468eff05cf04c10ae3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93947 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-11Fix 32bit linux buildSamuel Mehrbrodt
Change-Id: I4faf3fb20c632163f98264d162bbf85f80b3603d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93797 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-10compact namespace in testtools..toolkitNoel Grandin
Change-Id: Iae1a7d3e2f14ee98ad486b4423208d2c29039346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09Just use initializer list for Sequence<OUString>Michael Weghorn
Change-Id: I4732e238053b8c9e6813f1bbecd6f613922cb521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93748 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-09toolkit: Use lambda instead of FindControlModel functorMichael Weghorn
Change-Id: I04cbd84196b5bf31caa4da3140dc65b1dfa20127 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93746 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-05-08remove TriStateBox classCaolán McNamara
Change-Id: Ia6c76a9f0fc0be7790d0c801cbca4a7b8d478976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-08split button.hxx into toolkit-only pieceCaolán McNamara
Change-Id: I792efb417504a3b55043ff4fc3fd3597a9b953f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-07Add comment about insertion orderSamuel Mehrbrodt
Change-Id: I650316c0c4bc31a861b3d96586a6a0aae57bd054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93537 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-07Test keeping element order in EventContainerSamuel Mehrbrodt
Change-Id: Ic33d8a83305f70bb3eb60f44da0d9ac0d2b47e16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93570 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-07Revert "remove some "optimisation" insanity in ScriptEventContainer"Samuel Mehrbrodt
This broke the event order in basic dialog xml, which in turn broke macro signatures. This reverts commit 85f08e3e34bea01456eaf8989ac4f77d3900d5c5. Change-Id: I49ef2eb200571a0fd862770abc4331b6ea053e2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93564 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-06Resolves: tdf#132581 allow disabling the auto-group RadioButton featureCaolán McNamara
the older way of doing things is to dig around contiguous radiobuttons to see what is part of the group, while the contemporary one is to explicitly use group() to set the members. A problem of the legacy way of doing it is that the results during setup and teardown of a collection of radiobuttons can be misleading. Change-Id: I6c590d0fb6fc6db3f5e5ba4397a62930a5c8f3f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06Move all public Java classes to libreoffice.jarSamuel Mehrbrodt
This moves the classes from juh.jar and ridl.jar to libreoffice.jar The goal is to have one single jar (and Java module, will be added later) which developers can include to work with LO. juh.jar and ridl.jar are kept as basically empty jars with libreoffice.jar on its classpath to keep backwards compatibility. This is a continuation of ae855bf48163ff64d94cfc34aff8e37abdb5518d and a preparation to have Java 9 module support. Change-Id: Ifbbfb97f60373d14256e62ae3122913bd17d5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23Fix typoAndrea Gelmini
Change-Id: Id2b8dd8c1d465a438ce6dfc859b007c5bfd98c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92080 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10Make BitmapPrimitive2D vcl-independentArmin Le Grand
as preparation to have drawinglayer module independent from vcl in the future Change-Id: Iaa01370f27b51cba5114a54f37d1ec73d0719918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92048 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-03-29Fix is_typed_flags for MessBoxStyle (toolkit/msgbox)Julien Nabet
Change-Id: I40a2c8b2ad562a6378b5337f53af59577cd5ce0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-21simplify codeNoel Grandin
These methods are virtual, so the check does nothing useful. Possibly back when this code was introduced, the methods were not. This was introduced in commit 411f66186e228 Date: Mon Jan 31 07:58:15 2005 +0000 INTEGRATION: CWS vcl34 (1.49.26); FILE MERGED 2005/01/06 14:13:03 ssa 1.49.26.1: #i37461# get/setOutputsize has to check for DockingWindow to call proper method to solve https://bz.apache.org/ooo/show_bug.cgi?id=37461 I have checked, and the bug does not come back. Change-Id: I540b85eccbf7107ee640f09b41340dc906995557 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90795 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-20Dispose dialog created during testStephan Bergmann
I experienced crashes during shutdown of CppunitTest_toolkit at least with --enable-lto, [...] > OK (2) > warn:vcl:109889:109889:vcl/source/app/svmain.cxx:460: DeInitVCL: some top Windows are still alive > text = "" type = "N7toolkit16ScrollableDialogE", ptr = 0x216b740 > > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:1065: Desktop disposed before terminating it > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:179: Desktop not terminated before being destructed > warn:unotools.config:109889:109889:unotools/source/config/configmgr.cxx:140: ConfigManager not empty > cppunittester: /home/sbergman/lo2/core/include/vcl/vclptr.hxx:106: VclPtr<reference_type>::~VclPtr() [with reference_type = vcl::Window]: Assertion `m_rInnerRef.get() == nullptr || vclmain::isAlive()' failed. Change-Id: I419b7ef8e23c94a906e3de6b3a55b63e13650abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90790 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-15Revert "loplugin:constfields in toolkit"Noel Grandin
This reverts commit 175834ce6a3ba707a6d34aa8de7351574381f481. Change-Id: I4b524ca1aa9aed2273b5d891a02fc0b360abc94c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-07clang-format toolkit, tools, uui with under 5-percent lines of changeMuhammet Kara
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I4952f350f4d22913ea94689b902ffa26c223ff96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90152 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-03-03inline some use-once constantsNoel Grandin
Change-Id: I201b195438ef3df067cfa6db97c3b37b23061142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89887 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>