summaryrefslogtreecommitdiff
path: root/toolkit
AgeCommit message (Collapse)Author
2013-12-17No need for implbase1.hxx to include XComponentContext.hppStephan Bergmann
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up, of course. Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17fdo#72598 Remove SunStudio cruft from code baseJelle van der Waa
Change-Id: I6f75d0df0ddafc892fef0ce1bfdcdd6c70151afc Reviewed-on: https://gerrit.libreoffice.org/7104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-13UNOWindowData has been dead since the year 2000 at leastTor Lillqvist
Change-Id: I8d3079f5b508008a4c25a4baa604fc89c81aab33
2013-12-13Drop duplicate #includeTakeshi Abe
Change-Id: I63612bc5bd4e13fcc5c4e57ac73bd9c7bbf4f0e6
2013-12-12simplify - use OUString::startsWith where possibleNoel Grandin
Convert code like if( !aStr.isEmpty() && aStr[0] == 'x' ) to if( aStr.startsWith("x") ) Change-Id: Iabc3a44ed3be2d29eed876e0eeef212ccd271edf
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-09fix equalsAscii conversion. Noticed in fdo#72391Noel Grandin
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3 "convert equalsAsciiL calls to startWith calls where possible" I incorrectly converted equalsAsciiL calls to startsWith calls. This commit fixes those places to use the == OUString operator. Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-06Clean up includes of comphelper/stl_types.hxxStephan Bergmann
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06Get rid of DECLARE_STL_MAPStephan Bergmann
Change-Id: Ifbda934a89087fcc1c031978d3e5b5783722b328
2013-12-05Resolves: #i123795# variable names should not confuse vcl...Herbert Dürr
Window and cocoa NSWindow types VCL's Window type and Cocoa's NSWindow type are quite different. Naming variables as if they were the same introduces gratuitous complexity especially when debugging stacks where both types are used. The names of NSView type variables have been adjusted too. (cherry picked from commit 5e6120c21a979c05bc6b9297035e31a47b98b785) Conflicts: vcl/aqua/source/app/vclnsapp.mm vcl/aqua/source/gdi/salgdi.cxx vcl/aqua/source/gdi/salgdiutils.cxx vcl/aqua/source/window/salframe.cxx vcl/aqua/source/window/salobj.cxx vcl/inc/vcl/sysdata.hxx vcl/source/window/syschild.cxx vcl/source/window/window.cxx Change-Id: Ic4143dfddfa9502a529c871ac4ce0bea413b6ce9
2013-12-04convert OutputDevice::HasGlyphs from xub_StrLen->sal_Int32Noel Grandin
Change-Id: Ic8f0ae3d263d6cb02e6faa7226db0241681fc45f
2013-12-03_SV_WORKWIN is nowhereTor Lillqvist
Change-Id: I736162269041a7ee0266566c00fd16f0a9629cd2
2013-11-26Integrate branch of IAccessible2Steve Yin
Change-Id: I95b681a7aa171c321a876e6a38392e30583d7a5b
2013-11-19convert equalsAsciiL calls to startWith calls where possibleNoel Grandin
Simplify code like: aStr.equalsAsciiL( "%", 1 ) to aStr.startsWith( "%" ) Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-15Remove unused parts of TkResMgrStephan Bergmann
Change-Id: I33f6bb8756a3bab054068a73c8e3d71b414ddfe0
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-11convert OUString 0==compareToAscii to equalsAsciiNoel Grandin
Convert code like: 0 == aStr.compareToAscii("XXX") to aStr.equalsAscii("XXX") which is both clearer and faster. Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-07fdo#63020: Replace ::comphelper::stl_begin()...Marcos Paulo de Souza
And use some templates inside include/com/sun/star/uno/Sequence.hxx Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47 Reviewed-on: https://gerrit.libreoffice.org/6599 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07remove unnecessary use of OUString constructor in TOOLKIT moduleNoel Grandin
Change-Id: I0cc8c507ede20d5db1942b75e0c4b660dcd66c97
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-10-28remove some stray using rtl::OUStringThomas Arnhold
Change-Id: I47d84f1b0c758bd390d8a5c1895dbb3548999bb6
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22fdo#54938: Adapt supportsService implementations..Marcos Paulo de Souza
to cppu::supportsService Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14 Reviewed-on: https://gerrit.libreoffice.org/6370 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-11remove redundant X11 linkage in toolkit.Michael Meeks
Change-Id: I73badeb7763da155296ff5bb673b36411e10791b
2013-10-04VCLXToolkit::reschedule(): lock SolarMutexDavid Ostrovsky
... otherwise Yield() will return with the SolarMutex not locked, triggering the assertion in ImplYield(). Change-Id: I6e44ce95517702ff5f316f7ea1df3aefc31588f6
2013-10-04require OAccessibleContextHelper to be initialized with SolarMutexMichael Stahl
OAccessibleContextHelper methods are locked by OExternalLockGuard which effectively only locks its ExternalMutex (i.e. SolarMutex); so ensure that all sub-classes actually pass in a SolarMutex by removing the default constructor. (since these classes are in comphelper they can only use the SolarMutex indirectly) This uncovers that AccessibleToolPanelDeckTabBarItem and OAccessibleControlContext did not pass in SolarMutex before. Change-Id: Ib9085eeee6225f7c74b158e72f04b1bf62622071
2013-10-02toolkit: avoid deadlock in UnoControl::setDesignMode()Michael Stahl
Avoid deadlock by disposing the accesibility context without the Mutex locked, since it will eventually try to acquire the SolarMutex... Thread 1 in UnoControl::getPosSize() calling from sdr::contact::ControlHolder::getPosSize() Thread 2 calling from UnoControl::setDesignMode() trying to get SolarMutex in VCLXWindow::disposing() Change-Id: I7d0ffe4fa0f8cd0c48e9b9b5e923ce229f97ca57
2013-09-17convert TOOLKIT module from String to OUStringNoel Grandin
Change-Id: Ibc5ffbffa0ddc6a80c3a95406b324cda09f7c9e1
2013-09-13String to OUStringThomas Arnhold
This removes nearly all ToLowerAscii() calls. Conflicts: linguistic/source/convdic.cxx linguistic/source/convdiclist.cxx linguistic/source/dlistimp.cxx sc/source/filter/html/htmlexp.cxx Change-Id: Iddcaacfb7383e1df3d2f13751a3c788eba953fdd Reviewed-on: https://gerrit.libreoffice.org/5895 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-09-03Remove more unused methodsMarcos Paulo de Souza
Change-Id: I79548f9dd1b83ef940e7a1302cf7b728610fed4a Reviewed-on: https://gerrit.libreoffice.org/5757 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-08-27Shouldn't be removedJulien Nabet
Thank you Thorsten! (See https://gerrit.libreoffice.org/#/c/5639/) Change-Id: I933a318ba83c63fa2d7eaa0ecb616b1d3a14b097
2013-08-28sal_Bool to boolTakeshi Abe
Change-Id: I63a05b7ba0954dbc18932de9cbdea4f0c1a18422
2013-08-27Simplify a bit iterator + remove double checkJulien Nabet
Change-Id: I4a12bacc1a3774741cf4bf3eb6770e16d0cecc6e Reviewed-on: https://gerrit.libreoffice.org/5639 Reviewed-by: Thorsten Behrens <tbehrens@suse.com> Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-08-27callcatcher: update unused code, esp unused Resource based ctorCaolán McNamara
e.g. no ImageRadioButton is now loaded from any res/rsc file, so that ctor and associated code paths can be stripped out Change-Id: Ic4cf19d45adb7c734f150e0b89eef193157a74a7
2013-08-24build on higher debug levelsCaolán McNamara
Change-Id: I7f4d85f3e26ab8b19dae05c6907840b97a8af1d6
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-10callcatcher: update unused codeCaolán McNamara
mostly ResId using ctors left stranded post .ui conversion Change-Id: I06689eea30ee9146ba05294f52056c0d263695f5
2013-08-08vcl, sw: fix the inheritance of SwComboBox from ComboBox a bitMichael Stahl
Remove the silly overloading, and introduce virtual methods. Change-Id: If54a6a3fb7464283f80d3387ae23db234690f8a3
2013-08-05Adapt UnoControlModel::read/writeStephan Bergmann
...to 8ee69b0ba13f74d1515fac71df92947eb6328ab1 "fdo#67235 adapt form control code to time nanosecond API change, step 3." It is a bit unclear to me how exactly this code is used, so to be safe, just read and write in the old format (of using a single integer to represent a Date resp. Time) at least for now, loosing nanosecond precision and the UTC flag. Change-Id: Ib5148f750a420ad09366c79b68370ad0efd501f4
2013-08-04fdo#67235 adapt form control code to time nanosecond API change, step 3Lionel Elie Mamane
Change-Id: I4899c89ee5b2a54c9c05b531ab284365f1558e3d Reviewed-on: https://gerrit.libreoffice.org/5270 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-08-02fdo#67235 adapt form control code to time nanosecond API changeLionel Elie Mamane
Conflicts: offapi/type_reference/offapi.rdb Change-Id: If68ecf0691919d71d06d7b97d46db115013f9805 Reviewed-on: https://gerrit.libreoffice.org/5149 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2013-07-28More details in debug outputLionel Elie Mamane
In particular, give type and message of exception when unexpectedly caught. Also miscellaneous other details. Change-Id: I87d71028dbc902e1770fee4c3643c85e75b7646d
2013-07-18fdo#66762 - Other: com.sun.star.awt.DisplayAccess removedNoel Grandin
API_CHANGE: I removed the undocumented internal API "com.sun.star.awt.DisplayAccess" in commit dde234b6955a421d51d2b37e4fc3972c660146f0 "fdo#46808, remove awt::DisplayAccess service." However, it appears someone was actually using this. Now, at the same time, we have a method in XToolkit, getWorkArea(), which looks like it was designed to return this exact information, but which has been returning zero for as far back as our commit history goes. So, to kill two birds with one stone, this commit changes getWorkArea() to return the information the customer needs, to wit, the size and position of the primary display. Change-Id: I76300bac604e9e4b7be95b0872a7f95cb6781903 Reviewed-on: https://gerrit.libreoffice.org/4919 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-07-17Mark as constTakeshi Abe
Change-Id: I59ac01eacf31061093b83ab3057963de7ea4a2e7
2013-07-15i#108348 API CHANGE: add IsUTC to css.util.DateTime etc.Michael Stahl
Add IsUTC member to: com.sun.star.util.DateTime com.sun.star.util.DateTimeRange com.sun.star.util.Time Add new stucts with explicit time zones: com.sun.star.util.DateTimeWithTimezone com.sun.star.util.DateWithTimezone com.sun.star.util.TimeWithTimezone Adapt the sax::Converter to read/write timezones, and fix the unit test. Everything else just uses default (no time zone), this commit is just to fix the API. STRUCT: /UCR/com/sun/star/util/DateTime nFields1 = 7 != nFields2 = 8 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/DateTimeRange nFields1 = 14 != nFields2 = 15 Registry2 contains 1 more fields STRUCT: /UCR/com/sun/star/util/Time nFields1 = 4 != nFields2 = 5 Registry2 contains 1 more fields Conflicts: sc/source/filter/oox/unitconverter.cxx Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18 Reviewed-on: https://gerrit.libreoffice.org/4833 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-07-11Resolves: #i121544# - Clean-up MessageBox APIAriel Constenla-Haile
(cherry picked from commit 27cfcb1e9d103b3e49c1263b1fa59fee8b187b21) Conflicts: desktop/test/deployment/active/active_native.cxx desktop/test/deployment/passive/Dispatch.java desktop/test/deployment/passive/passive_native.cxx odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java odk/examples/DevelopersGuide/GUI/MessageBox.java odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx odk/examples/java/Inspector/Inspector.java offapi/com/sun/star/awt/MessageBoxButtons.idl offapi/com/sun/star/awt/MessageBoxResults.idl offapi/com/sun/star/awt/XMessageBox.idl offapi/com/sun/star/awt/XMessageBoxFactory.idl offapi/com/sun/star/awt/makefile.mk offapi/type_reference/types.rdb sdext/source/minimizer/unodialog.cxx toolkit/inc/toolkit/awt/vclxtoolkit.hxx toolkit/source/awt/vclxtoolkit.cxx toolkit/source/layout/core/root.cxx Change-Id: I170b494fb96362bb25ba8d0f2518d4e46934dd67 Related: #i121544# - Clean-up MessageBox API (post fix) (cherry picked from commit c9f7a06e7798bcd5253844c49d210ea9345bd4b8) Conflicts: sw/inc/pch/precompiled_sw.hxx Change-Id: Ib8b1e7aaac769feff5206fcdd238c487a6130dd1 Related: #i121544# - Fix header guards Found by: Tsutomu Uchino (cherry picked from commit 82194a19ff4f29c8451c8e6ab6fe4f1b9d08df27) Conflicts: offapi/com/sun/star/awt/MessageBoxType.idl Change-Id: Ide8ba697fbc80395d2f30a068a0820a6afa3332f
2013-07-11fdo#66718: Demote SystemClipboard.createUnix to an internal hackStephan Bergmann
...see <https://bugs.freedesktop.org/show_bug.cgi?id=66718#c8> for details. Change-Id: I6e786ce21f41e51b480d0113ac0bd6a0013f4fb1