summaryrefslogtreecommitdiff
path: root/tools/source/generic
AgeCommit message (Collapse)Author
2016-03-17loplugin:constantparam in toolsNoel Grandin
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-02tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Sedat Ak
Change-Id: I956832e69f25ddc25523ffc1c0f289aecf930f68 Reviewed-on: https://gerrit.libreoffice.org/21927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-01loplugin:unuseddefaultparam in toolsNoel Grandin
Change-Id: I2a974ba76566700c2037fcb38de3ecfea9d2651d
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-15cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I92f41cde892d47abcd31e2b85ace7d228cbfd9fe
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15loplugin:unusedmethods unused return value in include/toolsNoel Grandin
Change-Id: I77a6a46ca20cb41ed73050185fb2064a1bbf2009 Reviewed-on: https://gerrit.libreoffice.org/21485 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-29tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Sedat Ak
Change-Id: I373afdd529b403ee2aa314ee5380fb4667717a3f Reviewed-on: https://gerrit.libreoffice.org/20265 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-20don't warn on Color streaming missing Solar VersionCaolán McNamara
Change-Id: I47e6a21fde77028c7a717b095883497888806501
2015-11-17use unique_ptr for pImpl in tools/Noel Grandin
Change-Id: I7ac7eca32a67524f6c87696c16b16128e6d8518b
2015-11-11stream version doesn't matter hereCaolán McNamara
Change-Id: I318b0268143bef376f324afdd42692991c3bab4c
2015-11-11stream version doesn't matter hereCaolán McNamara
Change-Id: I5871028b6c32194257d3a5f8bdf838cd0c277349
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ia5acfb564f913d52cd25b5d64d06b5280b94cb72
2015-11-08tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Sedat Ak
Change-Id: Ieef535e34f5acd9139c3ee1e9e6c650fc5fe92e4 Reviewed-on: https://gerrit.libreoffice.org/19842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-06Return earlyJulien Nabet
Change-Id: Ifef410c1495d1a2b99693f4669d81d6293f74f6a Reviewed-on: https://gerrit.libreoffice.org/19834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-05(Poly)Polygons: sal_uIntPtr to sal_uInt32/sdt::size_t/enumMatteo Casalin
Change-Id: I167d656f419ddbeb72960b8510fb8084605d4d5c
2015-11-05class PolyOptimizeData is never instantiatedMatteo Casalin
Change-Id: I136b3b1d572e4401d89d50f543150d71dbe44d16
2015-10-19convert DBG_ASSERTWARNING to SAL_WARN_IFNoel Grandin
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes much more sense. Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-15Reuse FRound from tools/helpers.hxxStephan Bergmann
Change-Id: I74ec4fc6a685c59dbc79978bf8a9afff0a1f9501
2015-10-15cppcheck:variableScopeNoel Grandin
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-08tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Aybuke Ozdemir
Change-Id: Id9bc24079d3840277d6fc10197a4f27373f4bd25 Reviewed-on: https://gerrit.libreoffice.org/19225 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Iec5a5fe5f14a9dcdbd7644bf67d4a985e42cd957
2015-09-29Fix typosAndrea Gelmini
Change-Id: Ifddd2533b767924791338555031b848c59980c52 Reviewed-on: https://gerrit.libreoffice.org/18989 Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org> Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-08-27this farcical staroffice 5.0 related junk can at least be constCaolán McNamara
Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6
2015-08-27Remove redundant if (zero is already handled earlier)Stephan Bergmann
Change-Id: Iaab5763d4fbde431bac6f7ecbf4527ad889b6891
2015-08-27Avoid slightly silly warnings from ClangTor Lillqvist
Clang (at least the one from newest Xcode 7 Beta) warn both that fResult "is used uninitialized whenever 'if' condition is false" *and* that the very same "condition is always true". Change-Id: I9e2424e7323046edbfe1af3c9f960df49e0809dd
2015-08-27Again add ability to change tint/shade of a color + unit testTomaž Vajngerl
Change-Id: I4c06290f09e5bfecd2c1de896e19cb5036a3a0e9
2015-08-17Put Line under tools namespaceNorbert Thiebaud
Change-Id: I7442848951c0d4579fb2a2a3eef3bfed7135aac4 Reviewed-on: https://gerrit.libreoffice.org/17791 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-07-30loplugin:unusedmethodsNoel Grandin
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Iedee28da32a4333a414e06877f87851345bb4e9b
2015-06-04convert B2VectorContinuity to scoped enumNoel Grandin
Change-Id: Ifa401dd0d2d1bef8c0ae2987d2aee86100b59816
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I955b04396d27e88ce228f180275955071da83ec6
2015-05-25callcatcher: update unused codeCaolán McNamara
Change-Id: I735264eb32ebdd165d23a4717f0329f666b8b140
2015-05-19tools: check for data loss in WriteFractionMichael Stahl
Currently it's only used in VCL's MapMode. Change-Id: Ib8ce09fadc704bc4d592d333d4cf3bddc9185036
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann
Change-Id: Ic4b6409013a19a78025973b26318ef05611a6984
2015-05-07Add ability to change tint/shade of a color.Tomaž Vajngerl
Change-Id: I6933393732d23fe9386cb8b768676887c026bd39
2015-04-29Clean up tools/link.hxxStephan Bergmann
Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: Id1c743da4294b667438a2c075de4634bb2c85ff3
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-17SvStream: WriteUChar -> WriteBoolStephan Bergmann
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I5493b2337dad102a4b22c6a6d646b4b0fd04e247
2015-03-23Rectangle::toString(): output position, then sizeMiklos Vajna
This order seems to be less confusing. Change-Id: I95a7e3e2f6244915c820bb86e67745a777714e2d
2015-03-19loplugin:constantfunction: toolsNoel Grandin
Change-Id: I3a29d90c60157dceb1da2225f4517ef3d193815e