summaryrefslogtreecommitdiff
path: root/tools
AgeCommit message (Collapse)Author
2016-07-20convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 272a8afa60fe9a6b497c69a58b0054ad5b880690) Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55
2016-07-20Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. (cherry picked from commit 14cd5182c5f64c43581c82db8c958369152226ac) Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-07-20Fix typosAndrea Gelmini
Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 64d624b65124ac02d8ee59b135593fd9d8eb9067) Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
2016-07-12Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> (cherry picked from commit a238b1f8d304bf1e2ffb357937f3ec888ee8ac89) Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
2016-02-22WaE vs2015 bug, add a temporary warning disableNorbert Thiebaud
Microsoft say that the warning c4592 we get there in vs2015-r1 is a bug on their side. Ignore it for now Change-Id: I820840a50932e42371947cdc10d1e09278f744ca Reviewed-on: https://gerrit.libreoffice.org/22593 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> (cherry picked from commit 981a62f8511416e679a35cdb11195e2149d81138) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-12-14tdf#96206: Avoid scaling objects while copying to clipboardMike Kaganski
... to prevent duplicating masters on slide copy-paste. Also fixed a 10-year copy-paste error (pRefPage wasn't replaced with pNPage). Fixed argument evaluation order issue (aStream.GetEndOfData() depends on Flush() but doesn't call it, so will return incorrect result if called before aStream.GetBuffer()). Replaced compare of hashes with results of stringify(), because it removes useless overhead (hashes are calculated from stringify() anyway, and are not cached anywhere). Removed Flush() called from SvMemoryStream::GetBuffer(), because it calls GetData(), which calls Flush() itself. Thanks to Andras Timar for unit test framework. Change-Id: Ia46d4e9a017fc628d424949a9d229045a249a4ca Reviewed-on: https://gerrit.libreoffice.org/20367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 6381fe554aec600d13d0359903216811d644dd36) Reviewed-on: https://gerrit.libreoffice.org/20694 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-25loplugin:unusedfields in include/toolkit,include/toolsNoel Grandin
Change-Id: I22966b66b1b8e4dff2e565de456f21a668f33f28
2015-11-24loplugin:unusedfields in tools/Noel Grandin
Change-Id: Ic460bf42cbcf356cdcebbd5060a0dad3d3caa4ef
2015-11-20don't warn on Color streaming missing Solar VersionCaolán McNamara
Change-Id: I47e6a21fde77028c7a717b095883497888806501
2015-11-17use unique_ptr for pImpl in tools/Noel Grandin
Change-Id: I7ac7eca32a67524f6c87696c16b16128e6d8518b
2015-11-17Don't assume sal_Unicode is unsigned shortStephan Bergmann
Change-Id: Idcfa500c491fcedfff7d4c6e1bef25fd2d948d36
2015-11-17Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)Stephan Bergmann
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-13underscores are reservedTomaž Vajngerl
Change-Id: Iee60389ccc9e348db6ed00e48e32b1e86f17b530
2015-11-13improve compile time SSE2 detection, fix broken android buildTomaž Vajngerl
Prereq. to enable runtime SSE2 detection is that the compiler supports it in the first place. MSVS and GCC use different compiler flags for this so use __LO_SSE2_AVAILABLE__ to make this build platform independent. emmintrin.h is unavailable on ARM Android so include this and compile the SSE2 specific code only when we are sure we can build SSE2 code (__LO_SSE2_AVAILABLE__ is defined). Change-Id: I212c4e0b99a314d087b9def822a81325b25f3469
2015-11-13remove SSE detection code (but keep SSE2)Tomaž Vajngerl
For corner case CPUs out there that support SSE and not SSE2 it makes more sense to use the "fallback" code path instead of writing a SSE only version. For this reason detecting SSE is not relevant anymore - so removing it. Change-Id: I3f1425af2cb5cdf9fba699e2996014598a15b5c1
2015-11-13tools: runtime SSE/SSE2 detectionTomaž Vajngerl
Change-Id: I29330061e2986ec2ae899c2f3a63d0eadd9cc194
2015-11-11stream version doesn't matter hereCaolán McNamara
Change-Id: I318b0268143bef376f324afdd42692991c3bab4c
2015-11-11stream version doesn't matter hereCaolán McNamara
Change-Id: I5871028b6c32194257d3a5f8bdf838cd0c277349
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11new loplugin: memoryvarNoel Grandin
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: Ia5acfb564f913d52cd25b5d64d06b5280b94cb72
2015-11-09com::sun::star->css in tools/ and ucb/Noel Grandin
Change-Id: I695ff721efd63b8ca0dd3c61ba5a4fef2c43cde6 Reviewed-on: https://gerrit.libreoffice.org/19854 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-08tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Sedat Ak
Change-Id: Ieef535e34f5acd9139c3ee1e9e6c650fc5fe92e4 Reviewed-on: https://gerrit.libreoffice.org/19842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-06Return earlyJulien Nabet
Change-Id: Ifef410c1495d1a2b99693f4669d81d6293f74f6a Reviewed-on: https://gerrit.libreoffice.org/19834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I88a3396746bf12c08265600072a368c9bbf5744e
2015-11-05(Poly)Polygons: sal_uIntPtr to sal_uInt32/sdt::size_t/enumMatteo Casalin
Change-Id: I167d656f419ddbeb72960b8510fb8084605d4d5c
2015-11-05class PolyOptimizeData is never instantiatedMatteo Casalin
Change-Id: I136b3b1d572e4401d89d50f543150d71dbe44d16
2015-10-28Date: avoid temporary conversions to sal_uIntPtrMatteo Casalin
Change-Id: Ib52c5d1a55d17c572fd5be9a3ce36c6de7965220
2015-10-28Date: group common codeMatteo Casalin
Change-Id: I4d1bf6591d54621c33dc2ff0be0ecb59f1839581
2015-10-28Rename (private) Date::init and reuse itMatteo Casalin
Change-Id: I3123876860cf6cce1e16c8f516f3d08fa7e15d83
2015-10-28Date: use support function for mapping years to daysMatteo Casalin
and reduce scope for other local support functions. Change-Id: Id0d6b9a04ff67620f6dca39d62443a3f191d75ee
2015-10-28Avoid intermediate cast to sal_uIntPtrMatteo Casalin
Change-Id: Ia7b5f519e381318f1d1cd6d0f982d22e8bbdffa7
2015-10-27sal_uIntPtr to sal_uInt64, sal_uLong to sal_Size for streamsMatteo Casalin
Change-Id: I062f1f6c5b20ca47734a9a3cd1a229d51763a206
2015-10-27loplugin:unusedmethodsNoel Grandin
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-23Remove obsolete version map filesStephan Bergmann
Change-Id: Ic179264fe306bb2bca9797f10e26c0224fb1dd00
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: Ia24ec98bfec36aa758fb1c5a6ec095c5047242a2
2015-10-19loplugin:defaultparamsStephan Bergmann
Change-Id: I3c9be2a7e192fea7c415721872a803659a300282
2015-10-19convert DBG_ASSERTWARNING to SAL_WARN_IFNoel Grandin
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes much more sense. Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19convert remaing DBG_WARNING to SAL_INFONoel Grandin
and drop the macro Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-15Reuse FRound from tools/helpers.hxxStephan Bergmann
Change-Id: I74ec4fc6a685c59dbc79978bf8a9afff0a1f9501
2015-10-15cppcheck:variableScopeNoel Grandin
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-09Move SolarMutex down from tools to comphelper/ to make life easier.Michael Meeks
Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5 Reviewed-on: https://gerrit.libreoffice.org/19271 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-10-08tdf#57950 Replace chained O(U)StringBuffer::append() with operator+Aybuke Ozdemir
Change-Id: Id9bc24079d3840277d6fc10197a4f27373f4bd25 Reviewed-on: https://gerrit.libreoffice.org/19225 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-05Add isSchemeEqualTo(), isAnyKnownWebDAVScheme() to INetURLObjectGiuseppe Castagno
...which will be used when rebasing <https://gerrit.libreoffice.org/#/c/17189> "tdf#82744: fix WebDAV lock/unlock behaviour - part 3" on top of d3de490437df4c9093f32e97fc185066d64c0f46 "Add vnd.sun.star.webdavs URL scheme." Change-Id: I19bd715d755a6f070b95ce897d8a1bbb4910d537 Reviewed-on: https://gerrit.libreoffice.org/18151 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Ic4aba87fa750824a366fba18fcfa46fa11d31e78
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Iec5a5fe5f14a9dcdbd7644bf67d4a985e42cd957
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: Ia1f6433000fe48ec6249b1cfb26668b665b2d15a
2015-10-01tdf#94559: third step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in oox, reportdesign, svl, svtools, svx, tools Change-Id: I1f85ff92267a0668eba625fa61b4f07feb8f3d4e Reviewed-on: https://gerrit.libreoffice.org/19002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>