Age | Commit message (Collapse) | Author |
|
Change-Id: I779bb5cf991e1fee1e2a2c0a4cd45af3c5f502bd
Reviewed-on: https://gerrit.libreoffice.org/8327
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7f341a10d2fffb8eda45478756bc221127ab72cf
|
|
Change-Id: I860e6db6ea4a7a7194283ba4fc23ae30cb1de4f8
Reviewed-on: https://gerrit.libreoffice.org/8201
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib604b25f8c2855439171e0606838b7cc36161976
|
|
Change-Id: I5cd642db4e0595c96e1af8adf7c7a45f589a259e
|
|
Change-Id: I9dc0525e04de5ae79205872b779dcd0115a9cc14
|
|
This is not valid C++ and GCC now resolves the virtual calls and inlines
destructor that leads to undefined symbols.
Change-Id: I841d25bc6f994f0e73665b174994f9471597131e
|
|
Change-Id: I3aad235d92b3972b44199294c0f3de65ad57f450
|
|
Convert the template based read_lenPrefixed methods to regular
methods.
Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I72c9a16c5236824424b33df353606e3e14aa4607
|
|
Change-Id: Id5bd445ad4f2397cbff01099ba3779736bb47e61
|
|
Change-Id: Ib029e08f7dc29330b1a0b5d93c1c0a356dbd59dd
|
|
as preparation for converting the SvStream::operator>> methods on
primitive types
Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
ResMgr::GetLang() has been deprecated for a long time now. It is used
by only one function,
SubstitutePathVariables::SetPredefinedPathVariables() in the framework
module. I have therefore removed it from ResMgr and placed it as a
function in framework/source/services/substitutepathvars.cxx where it
is actually used.
Change-Id: I5f0d8f701aa45f8653020affeff6339f8fc9bc0e
Reviewed-on: https://gerrit.libreoffice.org/7791
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5ae5318685ffe45bd9616d06eea21a93585715f2
|
|
Change-Id: Ica1af6017aedf94ad4daa92352691675bf6378fd
|
|
Change-Id: Ia3fd76aa70564cbc683d0d66cc39aa368bea29d9
|
|
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Valgrind is capable of detecting such bugs. No need for extra macros.
Change-Id: Id75ca6991af0bf75e979c7bc2da452f323f389ea
Reviewed-on: https://gerrit.libreoffice.org/7531
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5237197595b1b892e7720de13fc835b64470505e
|
|
Change-Id: I92fd33e020772eac735f133f467207da9635e9b4
|
|
--enable-dbgutils
|
|
...introduced in c648d0872058941ed18499a8bf1993037d9b5532 "convert
SvStream::operator<< overloads to more explicit methods."
Change-Id: I8343cd3d1e92ccd3ca3fc6292ebd1114ada444e1
|
|
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
|
|
Change-Id: I1cb9aa1a06fde24d0b7c7ec0ad56994598ee1d4b
|
|
Change-Id: I0e4fab72a6384eab41eeb1357eaf88be876a6b52
|
|
Change-Id: I643f7d13b95c6bb89ee00be706e384338ed8b79a
|
|
Change-Id: I1317aebafaae3c80a2016d23f93411a610fa349d
|
|
Change-Id: I7b48d8b9e162f9e4447bfcfcc0bbd1158bd35f5b
|
|
Change-Id: Ib851cbe072bca0d594440cc28164e112d0fe37cb
|
|
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteUInt32.
Note that the rewriter is not perfect, and hand-tweaking the output
is necessary.
Change-Id: I0291c8192ca74d6334ed3cf8cb713212b2f0c67d
Reviewed-on: https://gerrit.libreoffice.org/7307
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Convert code like:
OUStringBuffer sVal(OUString("0x"));
to:
OUStringBuffer sVal("0x");
Change-Id: Idc5a3f6a8bf1dc33f93c2b488f866c8ea58d582a
|
|
It is no longer necessary to cast to sal_Unicode when calling
OUStringBuffer::append
Change-Id: Iab3d1e12eef472cfe11f1d0d1969ca404091dd7d
|
|
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
|
|
After the move now other classes can convert DateTime to OString also
Reviewed on:
https://gerrit.libreoffice.org/6816
Change-Id: I0ceb9a5cc26103a6cb36d7765a717770ec3fbe7d
|
|
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
|
|
Change-Id: I179cc3dc58484ab1e21af3b1d776188d52f3974c
|
|
Change-Id: Ia52a898fa0a6b47eb7f78b03ef8c8648ddf72e28
|
|
It inherits from SvStream, so it could be used easily.
Basically, it's just a simple wrapper around
osl_executeProcess_WithRedirectedIO() and osl_readFile().
Change-Id: Ifa225c87d2c9be7e71ea113b0832a4fe83ec65b3
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
There were only a couple of real bugs fixed, but we're a little
bit safer now.
This also fixes the assert and the comment in OUString::operator[]
about this.
Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
hammer silver nails into coffin and bury in concrete
Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
|
|
Change-Id: I287a92de9ae30255990595263c3302d753fdbccf
|
|
Change-Id: Id881fe3f9c7c89a7bcc1a5d8f653e18494ffa913
|
|
Change-Id: I566e3ade54962bbc6ace9b757f79c1b8ed9ffd00
|