summaryrefslogtreecommitdiff
path: root/tools
AgeCommit message (Collapse)Author
2017-01-19new loplugin: useuniqueptr: sot..toolsNoel Grandin
Change-Id: Ided435d016ae28e7c3f2726e41eedd981572ae10 Reviewed-on: https://gerrit.libreoffice.org/33263 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17replace boost::checked_deleter with std::default_deleteJochen Nitschke
and remove all traces of boost/checked_delete.hpp Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2 Reviewed-on: https://gerrit.libreoffice.org/33182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-02ofz#372 check if ImplSplit succeededCaolán McNamara
Change-Id: I1e34295fe3ee5f77e787f583616d52fa92a0eca4
2016-12-21Dispatch to platform-specific strm*.cxx directly in Library_tl.mkStephan Bergmann
Change-Id: Ief526a06034b2408326273e43bec3b43a415b996
2016-12-19no need to wrap calls to SAL_INFO in #ifdef DBG_UTILNoel Grandin
Change-Id: Ic373a8f145f3f78c3f109e36a9c1dd9156f0dd75 Reviewed-on: https://gerrit.libreoffice.org/32034 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12coverity#1371265 Missing move assignment operatorCaolán McNamara
Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831
2016-12-09CppunitTest_tools_test: fix loplugin:cppunitassertequals warningsMiklos Vajna
Change-Id: I6738b6b5159403f1654b401a27f08fc829521e73
2016-12-08OSL_TRACE -> SAL in sw..ucbNoel Grandin
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5 Reviewed-on: https://gerrit.libreoffice.org/31762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07convert PolyFlags to scoped enumNoel Grandin
and remove the XPolyFlags enum, which has the same values and was being converted to PolyFlags anyhow Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41 Reviewed-on: https://gerrit.libreoffice.org/31627 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06convert PolyStyle to scoped enumNoel Grandin
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e Reviewed-on: https://gerrit.libreoffice.org/31633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert EscapeType to scoped enumNoel Grandin
Change-Id: Ic688a9803772a7ce39d03374986118d85807c18c
2016-12-05convert FSysStyle to o3tl::typed_flagsNoel Grandin
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-11-29Use derived classes' methods instead of Pair::A/BMike Kaganski
Change-Id: I7ffd9a23dbd00672630bc8412e95525a920c5065 Reviewed-on: https://gerrit.libreoffice.org/31379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-11-25introduce DBG_UNHANDLED_EXCEPTION_WHEN for calls with an explanatory messageEike Rathke
Change-Id: Ic80f2ed2c0fdff20d1ee1968bec2840bf914fb5e
2016-11-24replace custom list with std::forward_listJochen Nitschke
cppcheck warns with publicAllocationError in INetMIMECharsetList_Impl::prepend(...) > { m_pFirst = new Node(rCharset, m_pFirst); }<--- Possible leak > in public function. The pointer 'm_pFirst' is not deallocated before > it is allocated. We got a single linked list here which is correctly deallocated in dtor. But with C++11 std::forward_list there is no reason to implement or own list. Change-Id: Ia6582061c1e5f1284bd81fafef88ce475ee891aa Reviewed-on: https://gerrit.libreoffice.org/31132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26loplugin:expandablemethods in toolkit..toolsNoel Grandin
Change-Id: I7221bf131d28804ee93474b11973bbc066cc2764 Reviewed-on: https://gerrit.libreoffice.org/30268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21loplugin:expandablemethodds in include/tools..unotoolsNoel Grandin
Change-Id: I5607d4a2a81de1a3ae329acd1e90280a21522f06 Reviewed-on: https://gerrit.libreoffice.org/30097 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: toolsStephan Bergmann
Change-Id: I6f02d9607405e144727f925c8f8a1de6041688b9 Reviewed-on: https://gerrit.libreoffice.org/29844 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-12GetAutoHelpId logically can only return an empty string nowCaolán McNamara
Change-Id: Ie7368f083a5aa6bcfb249375fbae1f4cd92e02ba
2016-10-12drop RSC_DOCKINGWINDOW*Caolán McNamara
Change-Id: Ibcddc2def40e15f4a2f92fec13c1c3fd2f824d68
2016-10-10no numericfield, spinfield or spinbutton loaded from .src nowCaolán McNamara
Change-Id: I90e4390d1fadcbb18036861dc9b9d39fa8a73551
2016-10-10rename SetResMgr to ClearResMgrNoel Grandin
since that is it's only use. Also clean up the comment block nearby. Change-Id: Iff67aeec176963132bb8a1e64e0c81853f0912d7 Reviewed-on: https://gerrit.libreoffice.org/29654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-09no ComboBoxes loaded from .src anymoreCaolán McNamara
Change-Id: Ic497dddfe326e9cc06e71c39284b2848d17ae0c8
2016-10-09tools: use rtl/character.hxx in tools/source/inet/inetmsg.cxxArnaud Versini
Change-Id: I5e4b2abd5487a383af6a8e37a4c33a90d91ec2e4 Reviewed-on: https://gerrit.libreoffice.org/29610 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-08no radiobuttons or checkboxes loaded from src files anymoreCaolán McNamara
Change-Id: Ie10ebcf56a6145c8edeb903bed1beb0cf5cf8a7a
2016-10-08TOOLS: Remove SvStream::ImpInit()Arnaud Versini
Change-Id: I7a089e77586041bce662c33a5610df122d5a74be Reviewed-on: https://gerrit.libreoffice.org/27940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-07no CheckBox loaded from src files anymoreCaolán McNamara
Change-Id: I3211707d38c15a6fd3edcbe70fc3cee9b65dd6f6
2016-10-07don't call inflateEnd if inflateInit failedDavid Tardon
This fixes the following valgrind message: ==12572== Conditional jump or move depends on uninitialised value(s) ==12572== at 0x1505C89C: inflateEnd (inflate.c:1258) ==12572== by 0xD17644D: ZCodec::EndCompression() (zcodec.cxx:106) ==12572== by 0xD17724E: ZCodec::AttemptDecompression(SvStream&, SvStream&) (zcodec.cxx:405) ==12572== by 0x5F17020A: PlainTextFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (filterdetect.cxx:157) ==12572== by 0x3C3F098C: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1040) ==12572== by 0x3C3F0449: filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::list<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString&) (typedetection.cxx:946) ==12572== by 0x3C3ED6A1: filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (typedetection.cxx:427) ==12572== by 0x49B232CF: OwnView_Impl::GetFilterNameFromExtentionAndInStream(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (ownview.cxx:219) ==12572== by 0x49B011EB: OleEmbeddedObject::TryToConvertToOOo() (oleembed.cxx:268) ==12572== by 0x49B03AD1: OleEmbeddedObject::doVerb(int) (oleembed.cxx:837) ==12572== by 0x9F5C353: SfxInPlaceClient::DoVerb(long) (ipclient.cxx:946) ==12572== by 0x402D395A: SwWrtShell::LaunchOLEObj(long) (wrtsh1.cxx:588) ==12572== Change-Id: I51c0fbdc185897c60f6c0099b96c6ca9c25a35ba
2016-10-06drop loading Colors from src filesCaolán McNamara
Change-Id: I43f2fda133371a1284a53beeeb774552210c7e3f
2016-10-06no MetricFields are loaded from .src files nowCaolán McNamara
Change-Id: I4b30cbc7bc6a3a3a635c3889d43b7fa6513209f5
2016-10-03loplugin:countusersofdefaultparams in sw..vclNoel Grandin
Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-27Add note that Rectangle::toString() format now has a stability requirementTor Lillqvist
De facto, at least. Change-Id: Ie83f275d376841a7e4e9f7e80895165fe70a69b9
2016-09-16loplogin:singlevalfields in include/Noel Grandin
Change-Id: I27842162fcf82120ecb811ee8e89e187430931fc Reviewed-on: https://gerrit.libreoffice.org/28931 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15tools: SvFileStream::LockRange/UnlockRange take 64 bit positionsMichael Stahl
Change-Id: I85d9cc00daaaa127817aaaa6f54d3e6f86907fb6
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-02coverity#1371213 Missing move assignment operatorCaolán McNamara
Change-Id: I2454a230cd9a524086beba1a2ca32ea0b70bf17e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (tools)Stephan Bergmann
Change-Id: I624505ceee232a531826915755717f2e09dc0a72
2016-08-29cid#1371171 Missing move assignment operatorNoel Grandin
Change-Id: I3150428f130823cdb1584e30c54f5591896214cf
2016-08-29cid#1371160 Missing move assignment operatorNoel Grandin
Change-Id: Ifcddd08cd1ec6bfb7679ee0433524c4bd68803dd
2016-07-27loplugin:countusersofdefaultparams in tools..xmlsecurityNoel Grandin
find methods with default params with only zero or one call site Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0 Reviewed-on: https://gerrit.libreoffice.org/27512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-16nBufSiz can be a non-class local constantMatteo Casalin
Change-Id: I2a7d32eabd01622261a1163781ac2a8b64bdee3f
2016-07-16Reduce #include dependenciesMatteo Casalin
Change-Id: I5c6c379717869028102ab2a1ae7929dfbc447904
2016-07-13loplugin:constparams in toolsNoel Grandin
Change-Id: Iea05efbb90a0a95fefd18ae9673095a31422f06c Reviewed-on: https://gerrit.libreoffice.org/27137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>