summaryrefslogtreecommitdiff
path: root/ucb/source/ucp
AgeCommit message (Collapse)Author
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26loplugin: unnecessary destructor test..unotoolsNoel Grandin
Change-Id: I1fd8a3f39b875d1920759f42e37f4c9d6785d62e Reviewed-on: https://gerrit.libreoffice.org/33573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26loplugin:dynexcspecStephan Bergmann
Change-Id: I5e30befa9338bfd72e237e2bdb7c157526d32b85
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I5091c2b4550dee1f0b602a5337e17fe78b9d07f9
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I1fa141ee0d8d818f3ed5b31faa1ac578ba791e39
2017-01-26loplugin:salboolStephan Bergmann
Change-Id: I9c34c84d14084e84ab7d9fda78955cf2aebaf5dc
2017-01-20new loplugin: useuniqueptr: ucb..ucbhelperNoel Grandin
Change-Id: Ib19ca3225b96d1bfec8a43bb762e16597f33b690 Reviewed-on: https://gerrit.libreoffice.org/33297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ucbStephan Bergmann
Change-Id: I39a50e3f066776ac670a99120e12624af39fa83a
2017-01-09ucb: cmis::DataSupplier::queryContent() looks rather questionableMichael Stahl
It's not immediately obvious if the caller is responsible for checking the index validity here, but all the other sub-classes of ResultSetDataSupplier that i looked at do check the index so do the same here. Change-Id: Ib0c5c38cb28282f08752cdb03202e4d6f3566693
2017-01-09New loplugin:externvar: ucbStephan Bergmann
Change-Id: Idfab6f0d16b85ca280056db88264e5234361bce0
2016-12-30unexpected exception seen in tinderboxCaolán McNamara
#1 0x00002b464842f53a in __GI_abort () at abort.c:89 save_stage = 2 act = {__sigaction_handler = {sa_handler = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>, sa_sigaction = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>}, sa_mask = {__val = {47580863731936, 47582668825824, 47580850742064, 47580863731456, 2, 47580871027780, 0, 47582668825824, 47580863731456, 47580873315224, 47580863731936, 47582791173728, 47582791173728, 1, 33350960, 47582668313696}}, sa_flags = -1151509448, sa_restorer = 0x1fce530} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00002b4648e3efdd in __gnu_cxx::__verbose_terminate_handler() () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95 terminating = true t = <optimized out> #3 0x00002b4648e3ce56 in __cxxabiv1::__terminate(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:47 #4 0x00002b4648e3cea1 in std::terminate() () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:57 #5 0x00002b4648e3ceb6 in __cxxabiv1::__unexpected(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:63 #6 0x00002b4648e3cae2 in __cxxabiv1::__cxa_call_unexpected(void*) (exc_obj_in=0x2b46b40ad4b0) at ../../../../libstdc++-v3/libsupc++/eh_personality.cc:759 info = {Start = 47582791163104, LPStart = 47582996646024, ttype_base = 0, TType = 0x2b46bb5d5e30 "", action_table = 0xffffffff <error: Cannot access memory at address 0xffffffff>, ttype_encoding = 1 ´\001´, call_site_encoding = 0 ´\000´} xh_lsda = 0x2b46c7aab0d4 "\377\233\261\201\200\200" xh_switch_value = -1 exc_obj = 0x2b46b40ad4b0 xh_terminate_handler = 0x2b4648e3ee70 <__gnu_cxx::__verbose_terminate_handler()> #7 0x00002b46c79c6af9 in webdav_ucp::DAVResourceAccess::GET(std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, webdav_ucp::DAVResource&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x2b46b410ceb0, rHeaderNames=std::__debug::vector of length 0, capacity 0, rResource=..., xEnv=uno::Reference to ((anonymous namespace)::UpdateInformationProvider *) 0x2b46bb153918) at /home/tinderbox/master/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx:497 errorCount = 0 bRetry = false xStream = empty uno::Reference Change-Id: Iaa3ec435af6bed267235a9025fc9334058f20475
2016-12-22Revert "[API CHANGE] createSecurityContext() was always called with an empty ↵Tor Lillqvist
string" I got cold feet. I don't want to have to revert this many years later instead, when some obscure 3rd-party software stops working. This reverts commit e1ce7bad62f07faf8f21adac6c3848d142f61953.
2016-12-21[API CHANGE] createSecurityContext() was always called with an empty stringTor Lillqvist
So drop the parameter then and propagate fallout in the Windows implementation in xmlsecurity. The NSS implementation already ignored the parameter completely. This interface is not 'published' and the parameter was even marked as 'reserved for internal use' so I doubt any external code has used it. Change-Id: I5915b941b79cfddadc8137c32ed07c20c9ccaa37
2016-12-19vcl: separate ImplImageTree - ImageTree singleton and public ifaceTomaž Vajngerl
ImplImageTree was used outside of VCL which is not consistent with the name and the header also contains a lot of implementation detail. This separates the implementation to ImplImageTree and the public interface and singleton to ImageTree only. Change-Id: I3a26444f0f6971a6b1d83472e9cef19c93192d3e Reviewed-on: https://gerrit.libreoffice.org/32134 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-14Merge shell into TaskManager base classStephan Bergmann
(arbitrarily decided to keep the latter, being the less odd class name) Change-Id: I5c061a0f12b8f3095e283b4896f7c910948ac50f
2016-12-13loplugin:staticanonymousTor Lillqvist
Change-Id: I8c08a303026219dbf87af7165a3f9a99134d5091
2016-12-13loplugin:salboolTor Lillqvist
Change-Id: Ia2a2c900bf8bf8ecee2edf130b8ca58f7f35b6aa
2016-12-13loplugin:stringconstantTor Lillqvist
Change-Id: Ifc100e8ece6ea826b745919583beac315c41b100
2016-12-13loplugin:nullptrTor Lillqvist
Change-Id: I2cd1e82d86d8776155db2f70bc92c7c448f81ce0
2016-12-13loplugin:overrideTor Lillqvist
Change-Id: Idb5e16bae0fe573b22c86d1c4d6d4ab8da790557
2016-12-13loplugin:refcountingTor Lillqvist
Change-Id: I5ca4c1599a1abc4281bac9a4d0164d4b0cb3e24a
2016-12-12-Werror,-Wimplicit-fallthroughTor Lillqvist
Change-Id: I7ea9c1af7568ce37f29df14f8dc4345031c20eb8
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-11cmis: add error handling on checkinThorsten Behrens
Change-Id: I3951a237789ee4b7697f70bc527ffbb6a626206a Reviewed-on: https://gerrit.libreoffice.org/31776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-12-09loplugin:refcountingTor Lillqvist
Fixes: "uno::Reference field with template parameter that does not contain ::static_type() css::uno::Reference<SerfInputStream>, parent is http_dav_ucp::SerfGetReqProcImpl, should probably be using rtl::Reference instead [loplugin:refcounting]" Change-Id: I43211bb397031a4961df77ee39038e6ef9da6bb1
2016-12-08loplugin:overrideparamTor Lillqvist
Change-Id: I9b70fbc344a02a058fbb7af694edad560244c930
2016-12-08loplugin:overrideTor Lillqvist
Change-Id: I57b5572d81e6da53d82fbbb6dbcb35c9802ec3f1
2016-12-08loplugin:nullptrTor Lillqvist
Change-Id: Id8fd27ed20bc67a49d6863b63b07cf1573733744
2016-12-05fix the generally unused non-neon webdav MapDAVExceptionCaolán McNamara
Change-Id: I82caa1686a8855c484050f129d5095f95eab7ece
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-23New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUStringStephan Bergmann
Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
2016-11-23loplugin:unnecessaryoverride (dtors) in ucbStephan Bergmann
Change-Id: Ic19075cf0b237415c47a358c677eb19969e98fa5
2016-11-22remove some more global OUStringsNoel Grandin
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18loplugin:datamembershadowNoel Grandin
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16straighten weirdo exception message, inserting a comma and a blank helps..Eike Rathke
Has ever been like that since commit 54bd83fe93ff3253fbcde2f8c0b97eccbdac52e5 Date: Thu Oct 31 15:24:42 2002 +0000 Change-Id: Ifa52dc10458a91054675900a55c1eee14899d80d
2016-11-13Change remaining sal_Int32 to ContinuationFlags ...Korrawit Pruegsanusak
from 7f97b5e72c61066ea1ddd0f782e50070ce5f6363 Change-Id: I064e35f879ecba61d7ef71a0a177e760c3d263c4 Reviewed-on: https://gerrit.libreoffice.org/30793 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:unnecessaryvirtual in test..vbahelperNoel Grandin
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27Cosmetic: Move function member around...Giuseppe Castagno
...so it's nearer to the other function member that uses the class variables it initializes. Change-Id: I199621fbcad36313e0948627d47445a1de211d02 Reviewed-on: https://gerrit.libreoffice.org/30313 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26const-ness fixesStephan Bergmann
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26loplugin:expandablemethods in ucb..ucbhelperNoel Grandin
Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2 Reviewed-on: https://gerrit.libreoffice.org/30266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23Fix typosAndrea Gelmini
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-21tdf#102499 (9): Fix eXo Platform WebDAV on 'Save Remote File'Giuseppe Castagno
Change-Id: I2d2aceed3804f653b79d48eeb02468fc77374eb7 Reviewed-on: https://gerrit.libreoffice.org/29884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-21tdf#102499 (8): Return empty property when not present.Giuseppe Castagno
Change-Id: If5afa4f33ac5b5dfec123960c2e9660183576256 Reviewed-on: https://gerrit.libreoffice.org/30142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-19loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231 Reviewed-on: https://gerrit.libreoffice.org/29997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18ucb: fix handling of >>= with rhs AnyJochen Nitschke
>>= for rhs Any is always true, check result with hasValue() instead. bool convert<uno::Any>(...) always returns false and assigns the 3rd parameter to the 4th. do the assign directly and check result with hasValue(). Change-Id: I0ae985cc0837abf1108930d593edae69de2ae549 Reviewed-on: https://gerrit.libreoffice.org/29977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13tdf#102499 (7): Caching connect timeout or cannot connect.Giuseppe Castagno
An unofficial HTTP response status code is defined and used internally in LibreOffice WebDAV ucp provider in order to catch either the DAVException::DAV_HTTP_TIMEOUT state or the DAVException::DAV_HTTP_CONNECT state. Change-Id: Iec4927d18ace5384fed16a7ec2a2620dc8305c5b Reviewed-on: https://gerrit.libreoffice.org/29757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-10 11:41:39 +0000