summaryrefslogtreecommitdiff
path: root/ucb/source
AgeCommit message (Collapse)Author
2018-03-04Remove unnecessary INetProtocol::Webdav[s] againStephan Bergmann
...that 65abd11d68ba9f849d89b98b6a56071411875c89 "Support for webdav:// and webdavs:// schemes from command line" had added for no good reason, and are removed again on the same grounds as eda273fd46e63daa4f15525e05b695450df53cea "Remove unnecessary INetProtocol::VndSunStarWebdavs again". Change-Id: I29135207dfdffcc818664432a11fa3b5b3a0561a Reviewed-on: https://gerrit.libreoffice.org/50748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-04Remove unnecessary INetProtocol::VndSunStarWebdavs againStephan Bergmann
...that 65abd11d68ba9f849d89b98b6a56071411875c89 "Support for webdav:// and webdavs:// schemes from command line" had added for no good reason. See the discussion linked from the commit message of d3de490437df4c9093f32e97fc185066d64c0f46 "Add vnd.sun.star.webdavs URL scheme" why this had deliberately not been added when adding the vnd.sun.star.webdavs scheme. Change-Id: I5728ab0d2517dae54a3536a347a83ff4cbfc18fa Reviewed-on: https://gerrit.libreoffice.org/50734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-04Change INetURLObject::isSchemeEqualTo parameter to u16string_viewStephan Bergmann
Change-Id: I003fa0c6f9c485d0579f3dd18331e63548a3777c Reviewed-on: https://gerrit.libreoffice.org/50728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-02usb: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I17030fc129de3e79965a1abe140fa0c28b949035 Reviewed-on: https://gerrit.libreoffice.org/49053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-02loplugin:useuniqueptr in TaskManager::UnqPathDataNoel Grandin
Change-Id: I6b6e7b59113fcae8dfafa4ed8586b87d2c82489e Reviewed-on: https://gerrit.libreoffice.org/49092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Support for webdav:// and webdavs:// schemes from command lineVasily Melenchuk
We have currently support for WebDAV schemes as vnd.sun.star.webdav:// but it is not user and tools friendly. Some related refactoring in ucb to reuse existing code instead of manual parsing of URLs. Change-Id: Ib14411796d6cf11afd80d5132abe67d4e46a42e1 Reviewed-on: https://gerrit.libreoffice.org/48585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-29make memory management more explicit in BaseContextNoel Grandin
Change-Id: I3afdfd7b461c6eccc57c23314f992900d14bd7d8 Reviewed-on: https://gerrit.libreoffice.org/48708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in BaseContentNoel Grandin
Change-Id: I03a6942e883b75e86f4ee4e7d01198dada70238f Reviewed-on: https://gerrit.libreoffice.org/48707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in DataSupplier_ImplNoel Grandin
Change-Id: Iaa25aee42d59b481a6b6edf015fe57dbd81cfa3e Reviewed-on: https://gerrit.libreoffice.org/48706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in ResultSetBaseNoel Grandin
Change-Id: If1fca43f953acaa4d16ef6094b6e0e218e5f6307 Reviewed-on: https://gerrit.libreoffice.org/48705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in FTPContentProviderNoel Grandin
Change-Id: I3b5a53e274a75078534d0b7f783a7d7d107043d8 Reviewed-on: https://gerrit.libreoffice.org/48704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-29loplugin:useuniqueptr in XResultSet_implNoel Grandin
Change-Id: I2f333d0d0784fc76f6a3b7a6a9e61b82b856afa0 Reviewed-on: https://gerrit.libreoffice.org/48703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-26loplugin:useuniqueptr in SortedResultSetNoel Grandin
Change-Id: Ib57cf4b30afda6f5e0d024a0c72417f6b1786e9a Reviewed-on: https://gerrit.libreoffice.org/48588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-26loplugin:useuniqueptr in PersistentPropertySet_ImplNoel Grandin
Change-Id: I78259770767fd3bbe3217f20a513703e7347288f Reviewed-on: https://gerrit.libreoffice.org/48587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-26loplugin:useuniqueptr in SortedDynamicResultSetNoel Grandin
Change-Id: Ife4849926f26631bbe65bd22158165fac306cd43 Reviewed-on: https://gerrit.libreoffice.org/48586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in ContentResultSetWrapperNoel Grandin
Change-Id: I798e5b06a5b2f9377f22a86f7b630ffdc20e10c6 Reviewed-on: https://gerrit.libreoffice.org/48559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24sal_Bool -> bool (remaining uses of css::uno::Any::has)Stephan Bergmann
Change-Id: I041540307d48083955a74d20f73219ac458037fe Reviewed-on: https://gerrit.libreoffice.org/48482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19loplugin:unusedmethods also check for functions returning boolNoel Grandin
we were previously excluding them Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11 Reviewed-on: https://gerrit.libreoffice.org/48167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-17loplugin:unnecessaryparen extend to delete statementsNoel Grandin
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1 Reviewed-on: https://gerrit.libreoffice.org/48027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Id3d1a07922d4ca05e3bbf61d4b5797a30fc5b23a Reviewed-on: https://gerrit.libreoffice.org/47872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16Fix typosAndrea Gelmini
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2 Reviewed-on: https://gerrit.libreoffice.org/47858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-15Fix typosAndrea Gelmini
Change-Id: I4c5965438eb28b853ce4ea826139faab567415e1 Reviewed-on: https://gerrit.libreoffice.org/47873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-12More loplugin:cstylecast: ucbStephan Bergmann
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I17a91ab6117f1d451fa8daec2a6f9542fc9ed2df
2018-01-09loplugin:convertlong in ucb,sotNoel Grandin
Change-Id: I6fa355448834701f11b84584649dfcdecd0f7b2c Reviewed-on: https://gerrit.libreoffice.org/47596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04drop ULONG typedefNoel Grandin
Change-Id: I25d0851bd82838f12a4edb3eb9f322bdf30cc175 Reviewed-on: https://gerrit.libreoffice.org/47342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:passstuffbyref improved return in ucb,connectivityNoel Grandin
Change-Id: Ib2590648c9dced87693a58a506cb62d04e37b18d Reviewed-on: https://gerrit.libreoffice.org/47149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19remove unused typedefsNoel Grandin
Change-Id: I6fd7a9fed3a80c91a3766fceefd43c5db0aa5275 Reviewed-on: https://gerrit.libreoffice.org/46763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19inline use-once typedefsNoel Grandin
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14No need to keep these whitelisted functions decorated with SAL_CALLStephan Bergmann
The only effect SAL_CALL effectively has on LO-internal code is to change non- static member functions from __thiscall to __cdecl in MSVC (where all other functions are __cdecl by default, anyway). (For 3rd-party code, it could be argued that SAL_CALL is useful on function declarations in the URE stable interface other than non-static member functions, too, in case 3rd-party code uses a compiler switch to change the default calling convention to something other than __cdecl. But loplugin:salcall exempts the URE stable interface, anyway.) One could argue that SAL_CALL, even if today it effectively only affects non- static member functions in MSVC, could be extended in the future to affect more functions on more platforms. However, the current code would already not support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c "loplugin:salcall fix functions" changed FrameControl_createInstance in UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even though its address (in ctl_component_getFacrory, in the same file) is passed to cppuhelper::createSingleFactory as an argument of type cppu::ComponentInstantiation, which is a pointer to SAL_CALL function. Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6 Reviewed-on: https://gerrit.libreoffice.org/46436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:salcall handle static methodsNoel Grandin
Change-Id: Id6820abec4b8ca8bee26d62b333fd30b42a14aec Reviewed-on: https://gerrit.libreoffice.org/46007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06loplugin:salcall handle virtual methodsNoel Grandin
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42 Reviewed-on: https://gerrit.libreoffice.org/45851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30loplugin:unnecessaryparen: signed numeric literalsStephan Bergmann
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64 Reviewed-on: https://gerrit.libreoffice.org/45549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-26Build as C++17 when GCC/Clang supports itStephan Bergmann
...and the gperf being used no longer emits "register" in C++ code. Unlike Clang with -Wdynamic-exception-spec ignored, at least GCC 7.2 -std=gnu++17 always makes dynamic exception specs hard errors, which would cause errors both when building StaticLibrary_libcmis and when including libcmis/libcmis.hxx in ucb/source/ucp/cmis/. So patch away all dynamic exception specifications from all external/libcmis include files indirectly included via libcmis/libcmis.hxx, and (to silence the remaining dynamic exception specifications in the innards of external/libcmis, which I did not feel like also patching away) build StaticLibrary_libcmis as C++03 if necessary, and wait for upstream libcmis to eventually be ported to C++17. And external/firebird needs to be built with CXXFLAGS_CXX11 (which amounts to C++17 with this patch) since 9206a08ada00e8762c4a634f242bd566028964bb "Upgrade to ICU 60.1", so the relevant dynamic exception specifications had to be patched away from its innards. Change-Id: I3a0c9ec83c7c1d413559459631970f69ab977f31 Reviewed-on: https://gerrit.libreoffice.org/43851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-24loplugin:countusersofdefaultparams in sw (1)Noel Grandin
Change-Id: I0d14f9c375f93079aef21ca4f1132adc4e1fe06c Reviewed-on: https://gerrit.libreoffice.org/45207 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22loplugin:simplifybool re-activate the !! warningNoel Grandin
Change-Id: Iac7d82a1c228734177be536e9a6c41803c03637b Reviewed-on: https://gerrit.libreoffice.org/45035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20look for =() in loplugin:unnecessaryparenNoel Grandin
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-18loplugin:flatten in toolkit..writerfilterNoel Grandin
Change-Id: I4da2a768b6b55869c3a3d6f8a8d50dc018709acd Reviewed-on: https://gerrit.libreoffice.org/44865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09RegexpMap::map: use range-based forMike Kaganski
Change-Id: I90ae184e3400f7a35419a705c62c482932065b0f Reviewed-on: https://gerrit.libreoffice.org/44524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-07loplugin:unnecessaryparenStephan Bergmann
Change-Id: Icb5dacd41bc5753ffa2498fdd244b1f78483699f
2017-11-07loplugin:flattenStephan Bergmann
Change-Id: Id43a9752ff21258296e56c8dc765c3618d360c7a
2017-11-07loplugin:includeform: automatic rewrite in --with-webdav=serf codeStephan Bergmann
Change-Id: Ida1b0c2942071d5ee8a25dd1817e8608761732ac
2017-11-04Replace last list by vector in ucbJulien Nabet
Change-Id: Idde1489fd8203c503347d14965487dd20cc6573f Reviewed-on: https://gerrit.libreoffice.org/44300 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03Replace lists by vector or deque in ucb/ucbhelperJulien Nabet
Change-Id: I9f72d7c8ab48f8dc2eec779db2f40531a33db6f9 Reviewed-on: https://gerrit.libreoffice.org/44238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-02improve constparam lopluginNoel Grandin
lots of little fixes to make the logic less pessimistic Change-Id: If368822984250b11b98c56f5890177a1402e8660 Reviewed-on: https://gerrit.libreoffice.org/44168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27Replace lists by vectors in filtask (ucb)Julien Nabet
Change-Id: I5b4359727ebf58bc121325d490e63f2c919dd7ab Reviewed-on: https://gerrit.libreoffice.org/43921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-27Replace list by vector in ucbstore (ucb)Julien Nabet
Change-Id: I1ff394ecd1fe805d671d666d8bc2522c33c40b50 Reviewed-on: https://gerrit.libreoffice.org/43922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23loplugin:includeform: ucbStephan Bergmann
Change-Id: Ifa5d2d7c4a8f9464dfcfea7f50e8a6a79043be08
2017-10-23overload std::hash for OUString and OStringNoel Grandin
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>