summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Expand)Author
2015-12-16Related tdf#90700 Add configuration for web connection timeout.Giuseppe Castagno
2015-12-15tdf#95792: fix saving file the first time on some WebDAV servers.Giuseppe Castagno
2015-12-15Some WebDAV server answer without 'DAV:' XML namespace.Giuseppe Castagno
2015-12-14Fix tdf#90700 Notify connect timeout early.Giuseppe Castagno
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
2015-12-02Add/change some logs in WebDAV ucb.ucp layer.Giuseppe Castagno
2015-11-30loplugin:unusedfieldsNoel Grandin
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin
2015-11-26loplugin:unusedfields variousNoel Grandin
2015-11-24loplugin:unusedfields in ucb/Noel Grandin
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin
2015-11-17use unique_ptr for pImpl in ucb/Noel Grandin
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin
2015-11-11new loplugin: memoryvarNoel Grandin
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
2015-11-09com::sun::star->css in tools/ and ucb/Noel Grandin
2015-11-06coverity#1338238 Uncaught exceptionCaolán McNamara
2015-11-06coverity#1338237 Uncaught exceptionCaolán McNamara
2015-11-06coverity#1338236 Uncaught exceptionCaolán McNamara
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
2015-11-04yyyyyNoel Grandin
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin
2015-11-01Remove last stdio.h from ucb moduleJulien Nabet
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin
2015-10-26tdf#75637: Resolve help images via a vnd.libreoffice.image UCPStephan Bergmann
2015-10-23ucb: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
2015-10-15cppcheck:variableScopeNoel Grandin
2015-10-13tdf#91054 cleanup weirdo function prototypeskerem
2015-10-13remove some useless commentsNoel Grandin
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
2015-10-12loplugin:mergeclassesNoel Grandin
2015-10-11cppcheck: Prefer prefix ++/-- operators for non-primitive typesJulien Nabet
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann
2015-10-05tdf#83531 Opening WebDAV URL WebDav fails if write is restrictedGiuseppe Castagno
2015-10-05tdf#82744: fix WebDAV lock/unlock behaviour - part 3Giuseppe Castagno
2015-10-01remove old standalone Sun bug numbersNoel Grandin
2015-09-30Fix typosAndrea Gelmini
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
2015-09-24boost->stdCaolán McNamara
2015-09-23boost::scoped_ptr->std::unique_ptrCaolán McNamara
2015-09-17"unnamed namespaces don't work well yet" is no longer trueStephan Bergmann
2015-09-16Related rhbz#1259746: Buffer file content read from GIO UCPStephan Bergmann
2015-09-10ucb: fix another duplicate WeakImplHelper<XInteractionRequest>Michael Stahl
2015-09-10ucb: fix mergedlib duplicate WeakImplHelper<XInteractionRequest>Michael Stahl
w]' | c++filt >SVXCORESYMS > nm -D --def instdir/program/libsvxlo.so | grep -ivw '[vw]' | c++filt >SVXSYMS > n=$(cat TOKENS | wc -l) > for ((i=1;i<="$n";++i)); do > tok=$(head -n "$i" TOKENS | tail -1) > printf @ > grep -Fw "$tok" SVXCORESYMS >/dev/null && printf svxcore > printf @ > grep -Fw "$tok" SVXSYMS >/dev/null && printf svx > printf '@ ' > head -n "$i" LINES | tail -1 > done to generate 640 output lines detailing for each SVX_DLLPUBLIC name occurrene whether it is mentioned in exports from neither (@@@), only from svx (@@svx@), only from svxcore (@svxcore@@), or from both libraries (@svxcore@svx@). The numbers that gives is 10 @@@ 180 @@svx@ 424 @svxcore@@ 26 @svxcore@svx@ The 10 @@@ ask for follow-up clean up, but most of them are just left as SVX_DLLPUBLIC for now. The exceptions are sxv::ITextProvider (include/svx/itextprovider.hxx) and SdrCustomShapeGeometryItem::PropertyPairHash (include/svx/sdasitm.hxx, where PropertyPairHash is a member struct of SVXCORE_DLLPUBLIC SdrCustomShapeGeometryItem). Keeping them as SVX_DLLPUBLIC would cause "unresolved externals" errors when linking Library_svxcore on Windows. The 180 @@svx@ are fine to keep as-is, and the 424 @svxcore@@ need rewriting. The 26 @svxcore@svx@ needed manual inspection to decide (in some cases, the chosen name in TOKENS was a too generic function name like Fill, in other cases it was the name of a class exported from one library but also mentioned in the arguments of a function exported from the other). And for sdr::table::SdrTableObj the class itself is defined in svxcore while the static member functions ExportAsRTF and ImportAsRTF are defined in svx. But MSVC does not allow to mark the class as SVXCORE_DLLPUBLIC and the two static member functions as SVX_DLLPLUBIC, so move the two functions out of the class. (There appears to be no real necessity that they were static member functions in the first place; they don't even need to be friends of the class. Nevertheless, this mixture of functionality from svxcore and svx in include/svx/svdotable.hxx may ask for follow-up clean up, one way or another.) All the output lines that need rewriting (all the @svxcore@@ ones, and the manually picked subset of @@@ and @svxcore@svx@ ones) are copied into a new file CHANGE (containing 451 lines). Then > sed -E -e 's|^@.*@.*@ ([^:]+):([0-9]+):.*$|sed -i -e "\2 s/SVX_DLLPUBLIC/SVXCORE_DLLPUBLIC/" \1|' <CHANGE >COMMANDS > . COMMANDS to do the changes. Change-Id: If9b6dd1c9e9ba2eb883dbdac4385d28c6fc8a203 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87794 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2020-01-10tdf#42949 Fix IWYU warnings in svx/inc/ and svx/source/inc/Gabor Kelemen Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic19dbb807b6c35e7772878e53a4f00bbb8688b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85788 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2019-09-03loplugin:constmethod in svxNoel Grandin Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2019-03-27return unique_ptr from FmXFormShell::GetConversionMenu_LockNoel Grandin Change-Id: I8b262c18862429f8b6822742fb8fa454af1090a6 Reviewed-on: https://gerrit.libreoffice.org/69802 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2018-10-08loplugin:constfields in svxNoel Grandin Change-Id: I643e8686e015ca85dd96221f1c93038f4fddf27b Reviewed-on: https://gerrit.libreoffice.org/61182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-10-24loplugin:finalclasses in svxNoel Grandin Change-Id: I74296e2185902498cd569ecde83905f718a41e84 Reviewed-on: https://gerrit.libreoffice.org/43715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-10-23loplugin:includeform: svxStephan Bergmann Change-Id: I4057fe05983fb2b63b592ffd325894c12b9cb5b2 2017-09-01tdf#111970 svx: use SolarMutex for locking in FmXFormShellMichael Stahl FmXFormShell has a confusing mess of 3 of its own locks plus some SolarMutexGuards in a couple functions. But despite all that, most members are accessed without any locking. First, add a "_Lock" suffix to all (non-API) functions that access members or call into VCL, then add SolarMutexGuard in all API entry points that call _Lock functions, and finally remove the existing silly mutex members. This should also fix the reported assertion (which probably doesn't happen on master any more since the Scheduler has its own mutex now). Change-Id: I215cdfe49ffe675229baa4b19ab419f440f0ffb0 2017-06-12cleanup unused css/frame/* includesJochen Nitschke Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-04-27Translate German comments (rest of svx/ except svx/source/form/)Johnny_M Change-Id: Ib0fccc41c71902861f450c6184f57be2c5da0811 Reviewed-on: https://gerrit.libreoffice.org/36804 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> 2017-04-20Translate German comments (leftovers in svx/source/inc/, etc.)Johnny_M Translated leftovers in: - svx/source/inc/ which slipped through on the commit 324adfcc2c3aa5d3590a38fadca2af7cd9125b47 (and a correction of "ist" to "list" in an unrelated comment) - svx/source/form/formcontroller.cxx which slipped through on the commit ea8f69e4a8ca8c3912aacb9838d7c5bb20b47f46 Change-Id: Ida5b3d0e685558bc2d8facba02fa80ae9e92eab3 Reviewed-on: https://gerrit.libreoffice.org/36648 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> 2017-04-18Translate German comments in svx/source/inc/Johnny_M Change-Id: I7eef0061245460fa0b570eea36d4e415c4c6d716 2017-04-18convert RID_FMSHELL_CONVERSIONMENU menu to .uiCaolán McNamara Change-Id: I6b38611063690a4038862f3a2810dd3c695b62d2 2017-03-03Remove redundant 'inline' keywordStephan Bergmann ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2017-01-26Remove dynamic exception specificationsStephan Bergmann ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2017-01-16new loplugin: useuniqueptr: svxNoel Grandin Change-Id: I0eb3d43d7bcfc491df16a72997a0720a6aec2c5c Reviewed-on: https://gerrit.libreoffice.org/32959 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> 2016-10-20loplugin:expandablemethodds in svxNoel Grandin Change-Id: I45447b6f5cf7e17d6e81e8c931b07b26d41b9a8c Reviewed-on: https://gerrit.libreoffice.org/30057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann ...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c 2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e 2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2016-07-27loplugin:countusersofdefaultparams in svxNoel Grandin Change-Id: Ic46a0dcce477c8b27aa2d4771c48fd45ad73718c Reviewed-on: https://gerrit.libreoffice.org/27574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2016-07-15new loplugin unnecessary overrideNoel Grandin Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> 2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann Change-Id: Ie219b6b6cc876cb46faadd7aa9c4f997702781bb