summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I5bd4f30d7b614af34b5ca2edca06bab9350ca206
2015-06-24Get rid of comphelper::string::is*Ascii functionsStephan Bergmann
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-23Revert "Typo: iff->if"Julien Nabet
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-19fix assert on loading kde98819-1.htmlCaolán McNamara
Change-Id: I3f8ccf2d0642657b3768a237c96f15cf7a7aff97
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41 Reviewed-on: https://gerrit.libreoffice.org/16295 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:unreadVariableNoel Grandin
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-14cppcheck: redundantCondition [part2]Julien Nabet
Change-Id: I23e8a4834fa7858adb292ce0a4dfa5dab1ab5f00
2015-06-11java:regulatize the order of 'final' and public/privateNoel Grandin
Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11convert expressions like 'size() == 0' to 'empty()'Noel Grandin
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-09java:remove unused importsNoel Grandin
Change-Id: I47be43c4ac50ee3938dc09d0206132fa7452017c
2015-06-09more exception handling cleanup in Java unit testsNoel Grandin
Change-Id: I8a826c1b31f99e8d1592f284094ff921ddac74ad
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: I9408d28393ff3654dd81c0240d7665b72b3c189c
2015-06-02loplugin:loopvartoosmallNoel Grandin
Change-Id: I809e408c994222cfa95ba8f56e4db7bd96be7080
2015-06-01loplugin:loopvartoosmallNoel Grandin
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-05-21tdf#91054: cleanup weirdo function prototypesJens Carl
cleanup the folders chart2/ and ucb/ Change-Id: Ia5f230703e55da5710eaa52bbd9e22a6395a49ad Reviewed-on: https://gerrit.libreoffice.org/15832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-18Remove include stdio (part2)Julien Nabet
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: Iea68c4e466dd8e1cb7164959a680e5e52542166b
2015-04-30Bin some pointless comments and reduce some vertical whitespaceTor Lillqvist
Bin pointless '// predeclarations' or '// forward declarations' comments. If a programmer doesn't know what a forward declaration is, well, why read C++ source code? Also bin some pointless '// end of namespace foo' comments after namespace blocks just a handful of lines long, and some superfluous vertical whitespace. Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: I1890703bf1277ad83f578e1527db81a6e8f49fd3
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-20java: remove some unused codeNoel Grandin
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-09loplugin:staticmethodsNoel Grandin
Change-Id: I2177e424d54dc2b5e26b7bbfe073b524e9cc5bab Reviewed-on: https://gerrit.libreoffice.org/15187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-07cppcheck: should be passed by referenceCaolán McNamara
Change-Id: I3d606615769f70ed29884e4c83164ccf15478132
2015-04-07loplugin:staticmethodsNoel Grandin
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-01Add support for cppu::UnoType<void>Stephan Bergmann
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: I8d1a4fda1cdd679f20de37271f7b832da4fb0c9a
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I4df86baf0106283c78942c40a4b5830dd9c91195
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Ibd269ae3147ce95f3f093e10ab736e8287e7098c
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I6a27fd990895ff36b35d2de6278ca0416e6c00f7
2015-03-24loplugin:constantfunction: variousNoel Grandin
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-03Improve loplugin:passstuffbyrefStephan Bergmann
Change-Id: I88ab4c51ff59312127681d3087d22b9c79192b94
2015-02-23file UCP: Ensure myLocalTime is initializedStephan Bergmann
When a file's time is epoch (1970-01-01 00:00:00, i.e., TimeValue temp is all zero) and the TZ is UTC or westward, osl_getLocalTimeFromSystemTime returns false and leaves myLocalTime uninitialized. That e.g. confuses getModuleByUrl (scripting/source/pyprov/pythonscript.py), potentially re-loading a Python script with epoch time (as happens e.g. for the share/Scripts/python/ files in an xdg-app installation of LO) every time it is accessed, falsely assuming it has changed on disk since last load. Change-Id: I8d4228feb28e2697a7021e3488ae2c09e8439ed8
2015-02-21Typo: trough->throughJulien Nabet
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
2015-02-10drop some unbuilt test codeCaolán McNamara
Change-Id: I7e0651ccb248034bafffb1c46e6266fa396eede1
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I2f0cbeebce5d3bb087128bae32816a89f1f1d222
2015-02-05try to avoid overflows in some compare functionsMichael Stahl
Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: ucbStephan Bergmann
Change-Id: I07c4b9b4bd61611ac11de6c70a0ca1c89cd10b3d
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b Reviewed-on: https://gerrit.libreoffice.org/13967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-15rhbz#1163106: tdoc_ucp: fix life cycle of OfficeDocumentsCloseListenerMichael Stahl
The tdoc_ucp::OfficeDocumentsManager lives until the service manager is disposed on shutdown, but if the database stuff isn't disposed in due time then a document may call the notifyClosing() on the listener after the OfficeDocumentsManager dies; probably something is leaking the ODatabaseContext... Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22
generated by cgit (git 2.34.1) at 2025-01-23 15:24:28 +0000