summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: ucbStephan Bergmann
Change-Id: I07c4b9b4bd61611ac11de6c70a0ca1c89cd10b3d
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b Reviewed-on: https://gerrit.libreoffice.org/13967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-15rhbz#1163106: tdoc_ucp: fix life cycle of OfficeDocumentsCloseListenerMichael Stahl
The tdoc_ucp::OfficeDocumentsManager lives until the service manager is disposed on shutdown, but if the database stuff isn't disposed in due time then a document may call the notifyClosing() on the listener after the OfficeDocumentsManager dies; probably something is leaking the ODatabaseContext... Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
2015-01-02Fix simple typos.Andrea Gelmini
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-20onedrive: Improve fallback dialog and instructionsAdolfo Jayme Barrientos
Reviewed on: https://gerrit.libreoffice.org/13500 Change-Id: I95df1d1b5589f89bfaa48c0833d92e3225b497a6
2014-12-19ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I29c99157e9698e4af1d42a5c708cf4ec4753cf34
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ie889b3e74160e9ba121ba8351d9e12f6d273c573
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15OneDrive authfallback request is now issuedMihai Varga
Change-Id: I9ee1f087322d80cbdf8ca369fccb6b6b0336062e
2014-12-15OneDrive binding settingsMihai Varga
Change-Id: I72c97931098c1a029d39532e3433c0aeaba73e3f
2014-12-12ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I6839e032c981fcff472f29c51c84503d6370fd1c
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18Need <cppuhelper/queryinterface.hxx> here, too, I assumeTor Lillqvist
Change-Id: Ic91023c0a5a70072fcffaaa5e16fc2e415c2e1ee
2014-11-18Need <cppuhelper/queryinterface.hxx> nowTor Lillqvist
Change-Id: Ib5683580273430a61e4daff84cd03b3b559fac0f
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06coverity#983989 Uncaught exceptionCaolán McNamara
Change-Id: I7508ee67a10b43686600b41dd58c1a8a5aa90c51
2014-11-06coverity#983985 Uncaught exceptionCaolán McNamara
Change-Id: I0082d75aa2c00daa35d8d72e44fbb6da161f9774
2014-11-06coverity#983984 Uncaught exceptionCaolán McNamara
Change-Id: I6a166a1691e39e21a4d765ca7dd0a7fcfba8126b
2014-11-05markup with event type not checker typeCaolán McNamara
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-10-31coverity#707418 Uncaught exceptionCaolán McNamara
and coverity#707419 Uncaught exception coverity#707420 Uncaught exception Change-Id: I98d752c14be5f7b1fccb4bdf2eeefb6bbfe12e0e
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-28coverity#704085 Unchecked return valueCaolán McNamara
other patterns aren't really the same as this one Change-Id: Ie26fd5c01d156004f755017a859679e904a29520
2014-10-17coverity#1247636 Uncaught exceptionCaolán McNamara
Change-Id: If9d635b7345683da0bf6ef7c7b0ffba0450f5dbd
2014-10-17java: final fields that can be staticNoel Grandin
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11coverity#983990 Uncaught exceptionCaolán McNamara
Change-Id: I78c58822cc92c8964e0b69f44d841c5cdb84b1bb
2014-10-11coverity#1130163 Unchecked return valueCaolán McNamara
Change-Id: Iffc4ba146ac8f851239e93a1ace53c6b34234824
2014-10-10coverity#1241375 Uncaught exceptionCaolán McNamara
and coverity#1241356 Uncaught exception coverity#1241415 Uncaught exception coverity#1241449 Uncaught exception coverity#1241146 Uncaught exception coverity#1241169 Uncaught exception coverity#1241408 Uncaught exception coverity#1241452 Uncaught exception coverity#1241443 Uncaught exception coverity#1241236 Uncaught exception coverity#1241157 Uncaught exception coverity#1241283 Uncaught exception coverity#1241409 Uncaught exception coverity#1241229 Uncaught exception coverity#1241387 Uncaught exception coverity#1241050 Uncaught exception coverity#1241371 Uncaught exception coverity#1241048 Uncaught exception coverity#1241112 Uncaught exception coverity#1241351 Uncaught exception coverity#1241370 Uncaught exception coverity#1241329 Uncaught exception coverity#1241162 Uncaught exception coverity#1241103 Uncaught exception coverity#1241342 Uncaught exception coverity#1241271 Uncaught exception coverity#1241219 Uncaught exception coverity#1241245 Uncaught exception Change-Id: I3418bb54b5c385110201a99a339eba0d0d3048f5
2014-10-08spelling: instanciated -> instantiatedNoel Grandin
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macroMichael Stahl
This is supported in GCC 4.6.0 already: https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macroMichael Stahl
This has been supported by GCC and clang for a very long time. Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-01Remove leftover SAL_WNODEPRECATED_DECLARATIONS_PUSH/POPStephan Bergmann
...from times when code used std::auto_ptr. Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
2014-10-01ucb: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: I779b7a172cecd927f7d18fcbbc0f898f18089d0a
2014-10-01Fix warnings in ucb/source/ucp/webdav/ (--with-webdav=serf)Stephan Bergmann
Change-Id: I6e45a8b00952dc3ef54f29536cf333bfdcee787d
2014-10-01Tired of seing changes made to effectively dead workben codeStephan Bergmann
Change-Id: I437fdceedac57bbeea7fd2a5fb7098bb71e0b259
2014-10-01fdo#82577: Handle TimeNoel Grandin
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
2014-09-25coverity#1240266 Logically dead codeCaolán McNamara
Change-Id: I97256c687c6d56beef2c3664bbba8c43f685228b
generated by cgit (git 2.34.1) at 2024-08-03 07:24:09 +0000