summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-12coverity#1397041 Unchecked return valueCaolán McNamara
Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679
2016-12-11fix out of bounds accessJochen Nitschke
since commit 96ec36cf261eec3ec07f3caa2673a916571c4287 Date: Thu Dec 8 21:49:47 2016 +0100 ucb: replace "SimpleList" trash found by cppcheck Change-Id: I13d62bdb6cb1a714182f90078d4a2990c790301a Reviewed-on: https://gerrit.libreoffice.org/31856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-11cmis: add error handling on checkinThorsten Behrens
Change-Id: I3951a237789ee4b7697f70bc527ffbb6a626206a Reviewed-on: https://gerrit.libreoffice.org/31776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-12-09loplugin:refcountingTor Lillqvist
Fixes: "uno::Reference field with template parameter that does not contain ::static_type() css::uno::Reference<SerfInputStream>, parent is http_dav_ucp::SerfGetReqProcImpl, should probably be using rtl::Reference instead [loplugin:refcounting]" Change-Id: I43211bb397031a4961df77ee39038e6ef9da6bb1
2016-12-09ucb: replace "SimpleList" trashMichael Stahl
* pointless use of void* * stupid casting everywhere * ridiculously overloaded Remove() * defensively programmed implementation Change-Id: I1c86ffac636cafbe3e13e668a65a2b14377b6e95
2016-12-08OSL_TRACE -> SAL in sw..ucbNoel Grandin
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5 Reviewed-on: https://gerrit.libreoffice.org/31762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08-Werror=return-local-addrStephan Bergmann
(the first case with OUString would technically be OK, but better change all three of them) regression introduced with 0e4ca9b0cfe015f7ab3b964d1b90de7c2cba42de "Clean up uses of Any::getValue() in ucb"; thanks to tml for finding it via --enable-fuzz-options Change-Id: I79e70cff8d8b96e1eb6b0bacda52be06eb0f108b
2016-12-08loplugin:overrideparamTor Lillqvist
Change-Id: I9b70fbc344a02a058fbb7af694edad560244c930
2016-12-08loplugin:overrideTor Lillqvist
Change-Id: I57b5572d81e6da53d82fbbb6dbcb35c9802ec3f1
2016-12-08loplugin:nullptrTor Lillqvist
Change-Id: Id8fd27ed20bc67a49d6863b63b07cf1573733744
2016-12-05fix the generally unused non-neon webdav MapDAVExceptionCaolán McNamara
Change-Id: I82caa1686a8855c484050f129d5095f95eab7ece
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-23New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUStringStephan Bergmann
Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
2016-11-23loplugin:unnecessaryoverride (dtors) in ucbStephan Bergmann
Change-Id: Ic19075cf0b237415c47a358c677eb19969e98fa5
2016-11-22remove some more global OUStringsNoel Grandin
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18loplugin:datamembershadowNoel Grandin
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16straighten weirdo exception message, inserting a comma and a blank helps..Eike Rathke
Has ever been like that since commit 54bd83fe93ff3253fbcde2f8c0b97eccbdac52e5 Date: Thu Oct 31 15:24:42 2002 +0000 Change-Id: Ifa52dc10458a91054675900a55c1eee14899d80d
2016-11-13Change remaining sal_Int32 to ContinuationFlags ...Korrawit Pruegsanusak
from 7f97b5e72c61066ea1ddd0f782e50070ce5f6363 Change-Id: I064e35f879ecba61d7ef71a0a177e760c3d263c4 Reviewed-on: https://gerrit.libreoffice.org/30793 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:unnecessaryvirtual in test..vbahelperNoel Grandin
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01Cosmetic: Namespaces, better make use of the 'using-directive'Giuseppe Castagno
Change-Id: If27709a2d8d8f231be9be0231d522f2a71e5fcae Reviewed-on: https://gerrit.libreoffice.org/30457 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27Cosmetic: Move function member around...Giuseppe Castagno
...so it's nearer to the other function member that uses the class variables it initializes. Change-Id: I199621fbcad36313e0948627d47445a1de211d02 Reviewed-on: https://gerrit.libreoffice.org/30313 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26const-ness fixesStephan Bergmann
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26WebDAV: Small cosmetic to unit checks.Giuseppe Castagno
Change server name in URI test strings. Pass by const lvalue reference [loplugin:passstuffbyref]. Change-Id: Ic0134f0690a8e6b9abb7d0764efaeeaf3a167bcf Reviewed-on: https://gerrit.libreoffice.org/30284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26loplugin:expandablemethods in ucb..ucbhelperNoel Grandin
Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2 Reviewed-on: https://gerrit.libreoffice.org/30266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23Fix typosAndrea Gelmini
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-21tdf#102499 (9): Fix eXo Platform WebDAV on 'Save Remote File'Giuseppe Castagno
Change-Id: I2d2aceed3804f653b79d48eeb02468fc77374eb7 Reviewed-on: https://gerrit.libreoffice.org/29884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-21tdf#102499 (8): Return empty property when not present.Giuseppe Castagno
Change-Id: If5afa4f33ac5b5dfec123960c2e9660183576256 Reviewed-on: https://gerrit.libreoffice.org/30142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-19loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231 Reviewed-on: https://gerrit.libreoffice.org/29997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18ucb: fix handling of >>= with rhs AnyJochen Nitschke
>>= for rhs Any is always true, check result with hasValue() instead. bool convert<uno::Any>(...) always returns false and assigns the 3rd parameter to the 4th. do the assign directly and check result with hasValue(). Change-Id: I0ae985cc0837abf1108930d593edae69de2ae549 Reviewed-on: https://gerrit.libreoffice.org/29977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13tdf#102499 (7): Caching connect timeout or cannot connect.Giuseppe Castagno
An unofficial HTTP response status code is defined and used internally in LibreOffice WebDAV ucp provider in order to catch either the DAVException::DAV_HTTP_TIMEOUT state or the DAVException::DAV_HTTP_CONNECT state. Change-Id: Iec4927d18ace5384fed16a7ec2a2620dc8305c5b Reviewed-on: https://gerrit.libreoffice.org/29757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12tdf#102499 (6): Cache OPTIONS if not present or if lifetime differentGiuseppe Castagno
Add the OPTIONS information and response status code into the cache: - if the OPTIONS information is already cached, update the cache only if the lifetime is different; - if the OPTIONS information is not cached, cache it. Add some new functions in DAVOptions to support the change and remove a function no longer used. Change-Id: I2f28f0ee793ec7d898caa61cc0a4962334e6e068 Reviewed-on: https://gerrit.libreoffice.org/29733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-11tdf#102499 (5): Deal with HTTP unofficial response status codesGiuseppe Castagno
A reference can be found here: <https://en.wikipedia.org/wiki/List_of_HTTP_status_codes> (retrieved 2016-09-13). Changes done: Add set of 'HEAD method not available' before using fall back GET method. Add new method in OPTIONS cache. Add response status code if fall-back GET didn't succeeded. Add copy-assignement operator to DAVOptions. Fix behaviour of GET fall back when HEAD missing. Change-Id: I6aad0e22bb444abf37b90186588f64f79b03cc3d Reviewed-on: https://gerrit.libreoffice.org/29680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-05tdf#102499 (3): Change caching model for HTTP response status codeGiuseppe Castagno
Instead of caching only a single status flag, now both the HTTP response status code and the message accompanying it are cached. Change-Id: If7352f6b0cb7c7dab6af3cede96647308baa5ce2 Reviewed-on: https://gerrit.libreoffice.org/29538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-03tdf#101094 (36): Fix behaviour of GET in fetching Headers onlyGiuseppe Castagno
Implement a better way to GET only headers, as HEAD method substitute. Wrote a new version of GET, specifically for 'no payload' service because sometimes neon was returning an internal error about: 'Compressed response was truncated' but without a specific error state. Change-Id: I84a3e5635193c3f68d335eba7af41b05980f4192 Reviewed-on: https://gerrit.libreoffice.org/29502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-03loplugin:countusersofdefaultparams in sw..vclNoel Grandin
Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03tdf#101094 (35): Add OPTIONS as pre-check in direct WebDAV open() methodGiuseppe Castagno
The function call will act as a precheck on Web resource access error when accessing the open directly without the normal file open procedure, e.g. accessing Web resource property values first. An example of this direct open call are the extension fetching and the extension update check. Change-Id: I765a2fe29f432a07a649e5a35440ae351c681af9 Reviewed-on: https://gerrit.libreoffice.org/29454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01tdf#101094 (34): Fix test and missing field value in comparision operatorGiuseppe Castagno
Change-Id: I6be4a7861f2a978c260defd54dcbc8d124017439 Reviewed-on: https://gerrit.libreoffice.org/29431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26tdf#102499 (2): Refactor the WebDAV resource access retryGiuseppe Castagno
Change-Id: Ia29560d54a61f1238f3b4e945d78308a3a68c483 Reviewed-on: https://gerrit.libreoffice.org/29269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26tdf#101094 (33): Fix: use the correct exceptionGiuseppe Castagno
Change-Id: I41e7cc0a1e176e44cb1b3fb87269eb6e052c6478 Reviewed-on: https://gerrit.libreoffice.org/29273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26convert CONTINUATION constants to typed_flags_setNoel Grandin
Change-Id: I38333e5d229aa520fbe0a8ad72007c503853956e
2016-09-25tdf#102499 (1): Add WebDAV test to check HTTP reponse status codes retryGiuseppe Castagno
Change-Id: I4ff36df3ac1cc0788322768378fb74f70892f922 Reviewed-on: https://gerrit.libreoffice.org/29245 Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19tdf#101094 (32): Use a partial GET as a fall-back for HEAD...Giuseppe Castagno
... partial GET means a GET with no data returned, to test for resource 'real' availability in case HEAD fails or is disabled. At the same time disable use of HEAD method on the resource for the whole access procedure. This change is needed to manage web servers that don't permit the use of either HEAD or OPTIONS methods. To accomodate pure web sites that enable only GET to fetch contents. Change-Id: If52316ddd6ce637fb7d2ef518423de246ee2dcfb Reviewed-on: https://gerrit.libreoffice.org/28992 Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
generated by cgit (git 2.34.1) at 2025-02-28 04:57:53 +0000