summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2016-09-07-Werror=unused-but-set-variableNoel Grandin
Change-Id: I1a7ed38a95b06029d821b000324b2cc880df1ebb
2016-09-07loplugin:constantparam in framework..vbahelperNoel Grandin
Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc
2016-08-29WebDAV: Make some SAL_WARN log wording a bit betterGiuseppe Castagno
Change-Id: Ib854d1ac74e952c786136176899e533804eb1e61 Reviewed-on: https://gerrit.libreoffice.org/28459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-29cppcheck: noExplicitConstructorGiuseppe Castagno
Change-Id: Ifa588c37added377d753cb7b32a6f1e6a3672c94 Reviewed-on: https://gerrit.libreoffice.org/28453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-28tdf#101094 (29) Fix for IIS 10.0 disabled OPTIONS methodGiuseppe Castagno
When OPTIONS methods (or verb) is disabled (or denied) on a IIS 10.0 web server, error 404 (e.g. 'Not Found') is emitted, so we need to deal with it. Change-Id: Ifd6df0ea4b89824133e212f73950d6c3acd00dd7 Reviewed-on: https://gerrit.libreoffice.org/28430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-26tdf#101094 (28): Put back the thread mutex guard...Giuseppe Castagno
...the one I wrongly removed in commit 72589082945e5a197f3fb4b884f48dd4ae275e5f Change-Id: I9f8e2f34a91b0fe481b1fe0f4655e3899a0589a6 Reviewed-on: https://gerrit.libreoffice.org/28412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-26tdf#101094 (27): Add a mutex guard to OPTIONS neon dispatch callsGiuseppe Castagno
This is a sort of follow up to commit: 510da29131e56ba0e1783e505e7131e6f7e0d6b4: "forced to make certain neon api calls thread-safe due to cups rhbz#637738 libgcrypt that's been initialized already by cups to be non-threadsafe is therefore then also non-threadsafe. neon uses libgcrypt. So in the (as this is the usual circumstance) case that cups is initialized before neon, then libgcrypt is not threadsafe even though neon attempt to initialize it as such." Change-Id: I1f868642ac15bf9fa25d3edd46390467d8fce1f5 Reviewed-on: https://gerrit.libreoffice.org/28401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-25cid#1371328 Misused comma operatorNoel Grandin
Change-Id: I3e585fb44612cb7ab2e6f04570b233310b01d8c8
2016-08-25cid#1371332 Misused comma operatorNoel Grandin
Change-Id: Ib7ba126d53e81dbd65451aa4bb33033f468ca295
2016-08-23Related: tdf#82677, remove cached element when appropriateGiuseppe Castagno
Change-Id: I6f9e1218c2767ec69ca371c4f5a12c2f385c7363 Reviewed-on: https://gerrit.libreoffice.org/28275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-23Related: tdf#82677, add cache use in Content::getProperties()Giuseppe Castagno
Change-Id: I47f583c808498aaf0f7cca1749fb5ef841ad10f3 Reviewed-on: https://gerrit.libreoffice.org/28274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-23Related: tdf#82677, implement a PROPFIND 'propname' request cacheGiuseppe Castagno
PROPFIND 'propname' is the special usage to retrieve all the properties available on the URI resource, their names only. See <https://tools.ietf.org/html/rfc4918#section-9.1> for PROPFIND 'propname' definition. Add cache usage in Content::getProperties as well. The caching model is simple: a simple lifetime limit of 10 seconds to declare the property name list stale and request another list, accessing the Net. This should reduce the number of PROPFIND calls on the Net. Change-Id: Ie4ebd946dd81583dc964a62c7744f3e2c716c737 Reviewed-on: https://gerrit.libreoffice.org/28273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-22ucbhelper::Std{In,Out}putStream are only used in ucb/source/ucb/cmis/Stephan Bergmann
...where their use of boost::shared_ptr (instead of std::shared_ptr) matches the use in libcmis, but makes them unlikely to be useful anywhere else. So move them into ucb/source/ucb/cmis/. Change-Id: I68359be6b43d6889af4f241dcdcbdc0d9d70d717
2016-08-21tdf#101094 (26): Fix possible early relase of cache mutexGiuseppe Castagno
Change-Id: If42393b2738ab107d380e55a0cbf2d6fa9940130 Reviewed-on: https://gerrit.libreoffice.org/28265 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
2016-08-19coverity#1371438 Uncaught exceptionCaolán McNamara
Change-Id: I83818be02fd7479bf6990dde076aad582a7f8f44
2016-08-19coverity#1371439 Uncaught exceptionCaolán McNamara
Change-Id: I642be9296babf077588eaf4c9da0aa11dc184fa0
2016-08-19Related: coverity#1371328 rename variable slightlyCaolán McNamara
Change-Id: I5cd6e9f4f5b3d9d7086229e4753d443d0f82bed7
2016-08-18cppcheck: noCopyConstructorCaolán McNamara
Change-Id: Id5323cb6f52666f85965e11b07e4f2bca8af4e78
2016-08-16tdf#101094 (25): Make a std::less explicit, add/remove TODOs...Giuseppe Castagno
... and a bit of function member signature change. Change-Id: I0d41277bca3991c7c105400e932df96f7bcf0d79 Reviewed-on: https://gerrit.libreoffice.org/28172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-16tdf#101094 (24): Simplify cache removal: DESTROY, PROPPATCH, MOVEGiuseppe Castagno
Plus another PUT forgotten on a previuos commit. Change-Id: I9e15cae2e858884cfd4c827ae767a2c5fcef1782 Reviewed-on: https://gerrit.libreoffice.org/28158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-15loplugin:unusedenumconstants in unotools..xmlhelpNoel Grandin
Change-Id: Id7ddc0fc1f57c5e8e7fb002e31d54fb8e9f8ffab Reviewed-on: https://gerrit.libreoffice.org/28050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-14tdf#101094 (23): Simplify cache removal: MOVE, COPYGiuseppe Castagno
Change-Id: Ia9ef644359c34ac30b78d48c79e8bc9d5c639f92 Reviewed-on: https://gerrit.libreoffice.org/28111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-12Cppcheck: Variable is reassigned a value before the old one has been usedGiuseppe Castagno
Change-Id: Id49254f3f3b230de4e7d3f116b52a38f6042f6c1 Reviewed-on: https://gerrit.libreoffice.org/28070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-12Related: tdf#99499, add a limit to the number of http redirectionsGiuseppe Castagno
Check for maximum number of redirections according to <https://tools.ietf.org/html/rfc7231#section-6.4>. A practical limit can be 5, due to old RFC: <https://tools.ietf.org/html/rfc2068#section-10.3>, this limit is reported also in more recent RFCs, see final paragraph of RFC7231, 6.4. Change-Id: I2b394ef8d1ef391a527df349aa749819c496657b Reviewed-on: https://gerrit.libreoffice.org/28066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-11tdf#101094 (22): Simplify cache removal: MKCOL, PUTGiuseppe Castagno
Change-Id: Id2c9f87e408b6754e17ef3792691d848deabfcd5 Reviewed-on: https://gerrit.libreoffice.org/28056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-11tdf#101094 (21): Simplify cache removal: LOCK, UNLOCKGiuseppe Castagno
Change-Id: Ib963fc6e0834606dcb6f42b3c0df5a408ebc5351 Reviewed-on: https://gerrit.libreoffice.org/28030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-11loplugin:countusersofdefaultparams in svl..unodevtoolsNoel Grandin
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2 Reviewed-on: https://gerrit.libreoffice.org/28017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-10tdf#101385: don't try to get SharePoint folder outside of allowed rangeMike Kaganski
for a given site. This patch uses the fact that getFolderByServerRelativeUrl API returns site's root folder if used with empty path (''). Hopefully this isn't otherwise context-dependent, so that it doesn't return other folders in some unknown circumstances. More correct would be instead to use the site's root path directly, like '/sites/mysite'. But I don't know a reliable way to filter the API part from the base URI. To make use of the corrected SharePoint repository root id, the patch also redirects all cases where "/" object is queried, to session's getRootFolder(). libcmis part of the patch will hopefully soon be merged upstream. Change-Id: I0f3b9930748de3fe4763eb27721739f097b9892d Reviewed-on: https://gerrit.libreoffice.org/27987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-08-03tdf#101094 (20) OPTIONS: Check for Class1 DAV before unlockGiuseppe Castagno
Change-Id: I890a44bb98577de006355d8394d46baeeaadb13f Reviewed-on: https://gerrit.libreoffice.org/27837 Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-01Related: tdf#96410 eXo Platform WebDAV: where lock fails...Giuseppe Castagno
...because apparently eXo Platform WebDAV does not support or supports poorly this section <http://tools.ietf.org/html/rfc4918#section-7.3> of RFC4918. It returns HTTP error 404 instead. Change-Id: I74cc99b29afa62110470e9ca785fce36e3d04bb2 Reviewed-on: https://gerrit.libreoffice.org/27755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-31Revert "tdf#101094 (20) OPTIONS: Add mechanism to manage not found Web URL: ↵Giuseppe Castagno
HEAD" This reverts commit 0acd13ec38fad1a63b86d2428299e469227a9069. Because it introduces a bug in saving a new file on a WebDAV server. Need to find a better solution. Change-Id: Ie353fac7203d599989ca67cf89c81c1a95f5b47e Reviewed-on: https://gerrit.libreoffice.org/27744 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-30tdf#101094 (20) OPTIONS: Add mechanism to manage not found Web URL: HEADGiuseppe Castagno
Change-Id: Ia941cfb68924140c3ab171d4ed2c4e8675947ca3 Reviewed-on: https://gerrit.libreoffice.org/27724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (19) OPTIONS: Add mechanism to manage not found Web URL: GETGiuseppe Castagno
Change-Id: Ie3da55d230631c50968b00cdea176f30051abf37 Reviewed-on: https://gerrit.libreoffice.org/27699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (18) OPTIONS: Update OPTIONS cache lifetime if not foundGiuseppe Castagno
Change-Id: I1b37bba50cd41ab5eeb960927148cf6b005f3fd4 Reviewed-on: https://gerrit.libreoffice.org/27698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (17) OPTIONS: Options cache removal: COPYGiuseppe Castagno
Change-Id: Ifa60eabd0a31b66074d79b30a5be7d497585f602 4a2c233261211b13ed06d05278bf42e446330487 Reviewed-on: https://gerrit.libreoffice.org/27696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (16) OPTIONS: Options cache removal: MOVEGiuseppe Castagno
Change-Id: I7a610003295aa174d655f1e847e6d9a19d84a197 Reviewed-on: https://gerrit.libreoffice.org/27695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (15) OPTIONS: Options cache removal: MKCOLGiuseppe Castagno
Change-Id: I752ab44b88935da75198d27f8b490f97c863408f Reviewed-on: https://gerrit.libreoffice.org/27694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (14) OPTIONS: Options cache removal: PUTGiuseppe Castagno
Change-Id: I251bbb101b4be851deaab66cbe4e10ff1fa3376e Reviewed-on: https://gerrit.libreoffice.org/27691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (13) OPTIONS: Options cache removal: LOCK, UNLOCKGiuseppe Castagno
Change-Id: Ib5e52973252b3af7b0fbe440806eb1e669670299 Reviewed-on: https://gerrit.libreoffice.org/27686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (12) OPTIONS: Add options cache ctrl in getResourceOptionsGiuseppe Castagno
Change-Id: If4f53e8efc51e5ec33747dfcbe8f4294bbd6160b Reviewed-on: https://gerrit.libreoffice.org/27685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (11): Add WebDAV options cache configuration param.Giuseppe Castagno
Added in officecfg five new properties to be able to set cache lifetime if needed. The new properties are available in advanced, expert configuration only, in org.openoffice.Inet.Settings. Default values are as follows (value is in seconds): OptsCacheLifeImplWeb = 300 when the web resource is Web only, implementing OPTIONS. Min. 0 sec (no caching) max. 3600 sec (1h). OptsCacheLifeDAV = 60 when the web resource is WebDAV. Min. 0 sec (no caching) max. 3600 sec (1h). OptsCacheLifeDAVLocked = 600 when the web resource is WebDAV and it's locked by this LO instance (e.g. lock store has a lock to it). Min. 0 sec (no caching) max. 3600 sec (1h). OptsCacheLifeNotImpl = 3600 when the web resource does not implement OPTIONS method. Min. 0 sec (no caching) max. 43200 sec (12h). OptsCacheLifeNotFound = 15 when the requested web resource is not found on server. Min. 0 sec (no caching) max. 30 sec. Change-Id: I719b97645e1d91a29134820b77678fd88fcb9ac2 Reviewed-on: https://gerrit.libreoffice.org/27684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (10) OPTIONS: Add a simple options cache classGiuseppe Castagno
Added behavioral unit tests as well. Change-Id: I30f84c8f814d3460a421428ebe0d2fbc32c5c433 Reviewed-on: https://gerrit.libreoffice.org/27668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (9) OPTIONS: Add options check in Content::getPropertiesGiuseppe Castagno
Change-Id: I1937d51158f67055ed4bbeb60dafbf8ffee090ae Reviewed-on: https://gerrit.libreoffice.org/27667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (8) OPTIONS: Add options check in Content::resourceTypeForLocksGiuseppe Castagno
Change-Id: Ia1bcc1be9e61626da2d60ea679d4b6e7e114ac9f Reviewed-on: https://gerrit.libreoffice.org/27661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-29tdf#101094 (7) OPTIONS: Remove resourceTypeForLocks before unlockGiuseppe Castagno
Not needed, unlock() checks if a lock is present first. If present, it means that LOCK is available, inferring the presence of UNLOCK availability. Change-Id: I007c4b02b27e8a40f15721c0308c894ad6f482fd Reviewed-on: https://gerrit.libreoffice.org/27660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-28tdf#101094 (6) OPTIONS: Do not retry on HTTP error 501Giuseppe Castagno
HTTP error 501 the server tells us the used method is not implemented, non need to retry. Change-Id: I4529d2bc27a87e8f3463ded578c6c55e0701ae17 Reviewed-on: https://gerrit.libreoffice.org/27636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-28tdf#101094 (5) OPTIONS: Add options check in Content::getResourceTypeGiuseppe Castagno
Added some verbose SAL_INFO to detail server responses to PROPFIND. Corrected a wrong comment and beautified a bit code I introduced in commit 3b26a2a403ca5e99b0dd07d042d47501c091af16. Change-Id: Id59749fe60fe0b451d8e0f4093d7902fe94bbed0 Reviewed-on: https://gerrit.libreoffice.org/27635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-07-28ucb: fix deadlocks in tdoc UCP OfficeDocumentsManagerMichael Stahl
Reduce scope of MutexGuards so that UNO methods are called without the mutex locked. This avoids deadlocks in CppunitTest_sw_mailmerge after using SolarMutex in dbaccess' ModelMethodGuard. Change-Id: I0229ebc2983c85e2003d51053a6bd130240274c7 Reviewed-on: https://gerrit.libreoffice.org/27582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-07-28tdf#101094 (4) OPTIONS: Add member function getResourceOptionsGiuseppe Castagno
Change-Id: Ia98456842f666ad97a9a8ffc82e787c0c88066f6 Reviewed-on: https://gerrit.libreoffice.org/27608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>