Age | Commit message (Collapse) | Author |
|
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
|
|
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
|
|
Change-Id: I7508ee67a10b43686600b41dd58c1a8a5aa90c51
|
|
Change-Id: I0082d75aa2c00daa35d8d72e44fbb6da161f9774
|
|
Change-Id: I6a166a1691e39e21a4d765ca7dd0a7fcfba8126b
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
and
coverity#707419 Uncaught exception
coverity#707420 Uncaught exception
Change-Id: I98d752c14be5f7b1fccb4bdf2eeefb6bbfe12e0e
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
other patterns aren't really the same as this one
Change-Id: Ie26fd5c01d156004f755017a859679e904a29520
|
|
Change-Id: If9d635b7345683da0bf6ef7c7b0ffba0450f5dbd
|
|
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
|
|
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
|
|
Change-Id: I78c58822cc92c8964e0b69f44d841c5cdb84b1bb
|
|
Change-Id: Iffc4ba146ac8f851239e93a1ace53c6b34234824
|
|
and
coverity#1241356 Uncaught exception
coverity#1241415 Uncaught exception
coverity#1241449 Uncaught exception
coverity#1241146 Uncaught exception
coverity#1241169 Uncaught exception
coverity#1241408 Uncaught exception
coverity#1241452 Uncaught exception
coverity#1241443 Uncaught exception
coverity#1241236 Uncaught exception
coverity#1241157 Uncaught exception
coverity#1241283 Uncaught exception
coverity#1241409 Uncaught exception
coverity#1241229 Uncaught exception
coverity#1241387 Uncaught exception
coverity#1241050 Uncaught exception
coverity#1241371 Uncaught exception
coverity#1241048 Uncaught exception
coverity#1241112 Uncaught exception
coverity#1241351 Uncaught exception
coverity#1241370 Uncaught exception
coverity#1241329 Uncaught exception
coverity#1241162 Uncaught exception
coverity#1241103 Uncaught exception
coverity#1241342 Uncaught exception
coverity#1241271 Uncaught exception
coverity#1241219 Uncaught exception
coverity#1241245 Uncaught exception
Change-Id: I3418bb54b5c385110201a99a339eba0d0d3048f5
|
|
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
|
|
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html
Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
|
|
This has been supported by GCC and clang for a very long time.
Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
|
|
...from times when code used std::auto_ptr.
Change-Id: Ia4eca8b0b95a8846886884404009e895daba8a22
|
|
Change-Id: I779b7a172cecd927f7d18fcbbc0f898f18089d0a
|
|
Change-Id: I6e45a8b00952dc3ef54f29536cf333bfdcee787d
|
|
Change-Id: I437fdceedac57bbeea7fd2a5fb7098bb71e0b259
|
|
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iea517d2287bded4a702c73dfdd1f182023425d67
|
|
Change-Id: I97256c687c6d56beef2c3664bbba8c43f685228b
|
|
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.
Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
|
|
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I451bf13cbf39ec13152d083a6a6728cd043f9fbd
|
|
Change-Id: I333ffa13159eac5cc53c9f3985dde5a33daf8067
|
|
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef
Reviewed-on: https://gerrit.libreoffice.org/11256
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I6b7a9e15da83f1d53a5e59d26b643c363e652619
|
|
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
|
|
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
|
|
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
|
|
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
|
|
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
|
|
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
|
|
found by UCDetector
Change-Id: Ide8b3b5c9969048aff84eed16b9eea096abad349
|
|
found by UCDetector
Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
|
|
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
|
|
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
|
|
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
|
|
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
|
|
remove null check where null-analyis reveals the variable cannot be null
Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
|
|
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
|
|
Change-Id: Idbba5bb89bee4d88ed0306d5151e238a1bc19cec
|
|
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
|
|
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
|
|
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
|
|
where the return value is always cast to XMultiServiceFactory,
so just do the cast in the method and avoid noise at the call sites.
Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
|