Age | Commit message (Collapse) | Author |
|
(regression from a3f32769fc4bb23c64168b412dd10ec769a3854d)
Change-Id: Ic72b0e874ebf19e25e43af1f8750c63c04ed8a8e
(cherry picked from commit 3780738154b8c3b3f9d85c64cccf621d97574886)
Reviewed-on: https://gerrit.libreoffice.org/7581
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
(cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d)
Conflicts:
sc/source/ui/unoobj/nameuno.cxx
sc/source/ui/unoobj/styleuno.cxx
sfx2/source/appl/sfxhelp.cxx
stoc/source/security/permissions.cxx
sw/source/core/unocore/unocrsrhelper.cxx
(None of those bogus startsWith calls seem problematic enough to warrant
backporting also to libreoffice-4-2-0.)
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
Reviewed-on: https://gerrit.libreoffice.org/7578
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Convert code like:
defaultValue.matchAsciiL( RTL_CONSTASCII_STRINGPARAM( "nextval(" ) );
to:
defaultValue.startsWith( "nextval(" );
Change-Id: I77bdcbf46bec6ded3c16a8248634b1424a1eb4f0
|
|
Convert code like:
aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
aStrBuf.append( "ln(x)" );
which compiles down to the same code.
Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
|
|
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
|
|
Change-Id: Ie5374f2e81e1429294805f05ae432fba86cc50df
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
|
|
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
|
|
... it breaks dependency generation.
Change-Id: I524f1789c32a633e8930a4e36a893ce02de66390
|
|
Change-Id: I648399356bed41f6aa9d6ec276ee975f5d3b1fa4
|
|
Change-Id: Ib93120ec0cae76b5ea19f723054363771b27ab56
|
|
Change-Id: I44919cf592eee026116fc5fbc12e0d5baa4bda2b
|
|
Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
|
|
Convert code like
if( ! aStr.compareToAscii("XXX") )
to
if( aStr.equalsAscii("XXX") )
which is both clearer and faster.
Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
|
|
The GDrive OAuth2 key is now defined at configure time. If either the
client secret or client id is missing, the Google Drive connectivity
will be disabled at runtime.
Tinderboxes can set up a GDrive key, but they need to make sure it's
not persisting in the build log.
Change-Id: I09bc748641ec14eae890f273f05bffe4ed421dbb
|
|
The version creation date is more likely to be the
cmis:lastModifiedDate.
Change-Id: I15e81db6a4c5f638f3f472894608a8d6728dc2d2
|
|
Change-Id: Ic75e5aad03d66590e78275304c766c1c00179387
|
|
Convert code like:
if( aStr == OUString("xxxx") )
to this:
if( aStr == "xxxx" )
Change-Id: I8d201f048477731eff590fb988259ef0935c080c
|
|
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
This is both an optimisation and a cleanup.
This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")
Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.
Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
|
|
Change-Id: Ib504585572ae9bada60076828ade8197331d5fda
Reviewed-on: https://gerrit.libreoffice.org/6463
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Convert places that call
aStr[aStr.getLength()-1] == 'x'
to use the shorter form
aStr.endsWith("x")
Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
|
|
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
|
|
to cppu::supportsService
Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
|
|
Change-Id: I4c688a4aeedcae56ed6404574bd1bb392d4190cb
Reviewed-on: https://gerrit.libreoffice.org/6311
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0d3b3d8dfe160b00c70acb98bdf4e37d088dc4c6
|
|
Change-Id: Ia592c20c410b26ba40c7a255588ce53652c85cb5
|
|
...since 2eb36dc4b846ab5886ae71fd2978b56b2a2d1d08 "Hack to not leave SolarMutex
released after g_main_loop_run call."
Change-Id: Ib4eb92002531af423b3ed4f24f6f4b71dc9cdc0d
|
|
Change-Id: I26923469d08308233ce3fabe749806c16d75cecd
|
|
The reason of the crash is that the recent file opening
feature can't get the session automatically.
Change-Id: I6890c04cfdafc81d19c6b2b2024896df040fe091
|
|
The file picker can't go back folder if we use
ID mark in the URL.
Conflicts:
ucb/source/ucp/cmis/cmis_content.cxx
Change-Id: I6985feec71dc23848ee022e0bab9e8515a21ffd2
|
|
Change-Id: I10a9c3679ae2d6ca8183b68b60b52e91ecd8f91f
|
|
Change-Id: Ie863282062a6932a55543143e841917c54223ac9
Reviewed-on: https://gerrit.libreoffice.org/5925
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
|
|
Change-Id: Ibd476f9a60dcc15be3b330d738faf56781998dfc
|
|
Change-Id: I1391780715e7b29a33c3ee647a62780b0b2174a4
|
|
Change-Id: I0c93ca3875d8cd6fe009018e79847142b4e64bfd
|
|
Change-Id: Ie9ef3324bb7a9e954db57548d7862a90b070ebd3
|
|
Change-Id: Ifa2df0e2dcc193ae02202687c0d6b7ab930db58f
|
|
Change-Id: I3d7fc2c01d58da58eb984ad5c10435f86f87f56a
|
|
Change-Id: I556d03a5bbd74faa26d73a8e84147c9743c20507
|
|
Change-Id: I1bd183508b7f481feed641f8658c0baea6f743bd
|
|
Change-Id: Ife7562d52cc3070c8d409f2da68d4e2aa5faea69
|
|
Change-Id: I60cccb841fea5ce493f004c73ecf50468019f860
|
|
Change-Id: Iac68f67e94ddcc6b0bb2877763176b2efcc9b7d8
|
|
Change-Id: I936e497d88781b9e8fd43532fda23379ff56e25f
|
|
The document ID is needed in case the get object by path
of the CMIS document doesn't work (like Google Drive)
Change-Id: I151d5433a19caeaf4a542b69cd9e95dde58722e7
|
|
Change-Id: I19da6c1aeb7fada97166d37c68fa5ba242bbcaba
|