summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert ucb and svl from OSL_ASSERT to assertChris Sherlock
Change-Id: I34579b2ec0b9a2a98361108bc259ddb1fc1df7b5
2017-05-05loplugin:checkunusedparams in toolkit..vbahelperNoel Grandin
the extra argument on the runtimeexception method was only ever passed an "OUString()" Change-Id: I0ea19ae9328760918f1267f27ba103432fff0b47 Reviewed-on: https://gerrit.libreoffice.org/37274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:salunicodeliteral: ucbStephan Bergmann
Change-Id: I236cf168d144debef1ba46cb6294f109773d0636
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19file UCP: Dir entries can disappear during non-atomic traversalStephan Bergmann
...so allow for that by reporting failure to call osl::DirectoryItem::getFileStatus from TaskManager::getv, and make XResultSet_impl::OneMore ignore such lost entries. While there may be legitimate cases where getFileStatus in getv would fail (and thus SAL_INFO would be more appropriate), the broken, non-atomic design means that such failure is likely unexpected (and worth a SAL_WARN). Occasionally ran into this when building UBSan builds, which sometimes failed in one of the extras/Gallery_*.mk like > ucb/source/ucp/file/filrset.cxx:235:60: runtime error: load of value 96, which is not a valid value for type 'bool' > #0 0x7f079bff575e in fileaccess::XResultSet_impl::OneMore() ucb/source/ucp/file/filrset.cxx:234:60 > #1 0x7f079bff823e in fileaccess::XResultSet_impl::next() ucb/source/ucp/file/filrset.cxx:288:16 > #2 0x7f0800a109a8 in Gallery::ImplLoadSubDirs(INetURLObject const&, bool&) svx/source/gallery2/gallery1.cxx:291:36 > #3 0x7f0800a0c88c in Gallery::ImplLoad(rtl::OUString const&) svx/source/gallery2/gallery1.cxx:202:5 > #4 0x7f0800a0bfa5 in Gallery::Gallery(rtl::OUString const&) svx/source/gallery2/gallery1.cxx:167:5 > #5 0x522e13 in createGallery(rtl::OUString const&) svx/source/gengal/gengal.cxx:62:16 > #6 0x52979a in createTheme(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, std::__debug::vector<INetURLObject, std::allocator<INetURLObject> >&, bool) svx/source/gengal/gengal.cxx:76:16 > #7 0x52853d in GalApp::Main() svx/source/gengal/gengal.cxx:318:9 > #8 0x7f080f6f8c36 in ImplSVMain() vcl/source/app/svmain.cxx:191:35 > #9 0x7f080f706571 in SVMain() vcl/source/app/svmain.cxx:229:16 > #10 0x56aa0a in sal_main() vcl/source/salmain/salmain.cxx:41:12 > #11 0x56a99f in main vcl/source/salmain/salmain.cxx:35:1 > #12 0x7f07fbaf5400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #13 0x42e219 in _start (instdir/program/gengal.bin+0x42e219) > > SUMMARY: AddressSanitizer: undefined-behavior ucb/source/ucp/file/filrset.cxx:235:60 in > solenv/gbuild/Gallery.mk:58: recipe for target 'workdir/Gallery/education.done' failed presumably because some other part of the build changed instdir/share/config/ in parallel. (And doing > while (touch instdir/share/config/TEST && rm instdir/share/config/TEST); do :; done in parallel to 'make extras' indeed causes this issue to occur easily.) Change-Id: I115ac727f99eed209b223d828c33060b275daaaa
2017-04-13Removed duplicated includesAndrea Gelmini
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-10loplugin:inlinefields in ucb_impl::RegexpMapNoel Grandin
Change-Id: Id8cf4a9e7f85048dac37fc1256427214abe3ac8c Reviewed-on: https://gerrit.libreoffice.org/36265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10use unique_ptr in RegexpMapImplNoel Grandin
Change-Id: I150bd441281305346bf6be1844894ae857dd50f7 Reviewed-on: https://gerrit.libreoffice.org/36264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05tdf#106955: Open WebDAV resources on which PROPFIND failsMike Kaganski
When PROPFIND fails on a WebDAV resource, its IsDocument property stays undefined, and so stream creation fails. Proposed solution is to default to IsDocument=true for all WebDAV documents where we cannot get the property from server. Such resources also fail to return their locking options, so defaulting to server properties. When later locking is attempted on it, the attempt fails with user notification (a dialog saying that getting information from server failed). Proposed solution is to check Content-Disposition header in such resources, and in case it's attachment, disable lock on this resource. The rationale for this is that "In a regular HTTP response, the Content-Disposition response header is a header indicating if the content is expected to be displayed ... as an attachment, that is downloaded and saved locally" (see MDN: https://developer.mozilla.org/en/docs/Web/HTTP/Headers/Content-Disposition Also, Content::getProperties wasn't ready for PROPFIND returning empty result. Change-Id: I91dbffa8bdf0fe900c11d2f8c9c9394d2104bb49 Reviewed-on: https://gerrit.libreoffice.org/36090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-03use actual UNO enums in test..vbahelperNoel Grandin
Change-Id: I2e38462045efedc31903589a3fa4e6f62d74d8de Reviewed-on: https://gerrit.libreoffice.org/36042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-30NeonSession_NeonAuth(): avoid redundant OUString->OString conversionVitaliy Anderson
Change-Id: I6b8515c25d58a88a040d4e08e36ffbd442228828 Reviewed-on: https://gerrit.libreoffice.org/35915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ieea40e1b7282267157810f9f58ca083e68ae6715 Reviewed-on: https://gerrit.libreoffice.org/35659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-17cleanup double includes and declarationsJochen Nitschke
Change-Id: I770e09f48b1a3e8299f59a8e475ba3c18d436d7b Reviewed-on: https://gerrit.libreoffice.org/35312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-03-14try to fix webdav buildMarkus Mohrhard
Found by the "Random Condig" tb run #293. Change-Id: I8fa7b66444b9b57f289c963cb1da5e772341dc30 Reviewed-on: https://gerrit.libreoffice.org/35156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-13tdf#95416 remove ../ in #include headers of sfx2 filesJeevan
Change-Id: I5f3e1a8fe559500aec7ea9e38edaba42dff3f98b Reviewed-on: https://gerrit.libreoffice.org/35028 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-02Fix typosAndrea Gelmini
Change-Id: I139e6948e92a7bcdce5a2197b9d3754cb9549a33 Reviewed-on: https://gerrit.libreoffice.org/34781 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-25value returned from particular web server is not valid asciiCaolán McNamara
$1 = 0x1a24b90 "GET,HEAD,H\205\360),HEAD,POST,OPTIONS" from this url to a missing resource http://www.japan-net.ne.jp/%7Enagayama/image/14photo/omoide/0301fuji/01rot-s.jpg seen during soffice --headless --convert odt ooo26424-5.sxw Change-Id: If6429dc02ff42bae9372ae39cadf8b49f278f54d
2017-02-22Need <sys/stat.h> when HAVE_FEATURE_MACOSX_SANDBOXTor Lillqvist
Change-Id: I401679ae6cbc8f924126589cfb9f22fb244e7da2
2017-02-21fix the webdav=serf buildMarkus Mohrhard
Change-Id: I1e66f437d561e5a8838fd331c6add25f4e25655e Reviewed-on: https://gerrit.libreoffice.org/34525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-21loplugin:subtlezeroinit: ucbStephan Bergmann
Change-Id: Ic3ad7a45def131d94e7e2c356a47478a63f1c9d9
2017-02-21try to fix "random config" tbMarkus Mohrhard
Fixes #228
2017-02-21try to fix random config tinderboxMarkus Mohrhard
Change-Id: I825d16eec294e23847f5150cdf1c7bebeb54a67e Reviewed-on: https://gerrit.libreoffice.org/34228 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-16external/libcmis: Silence -Wdynamic-exception-spec errorsStephan Bergmann
...with Clang in C++17 mode Change-Id: I50a0568c13e3e7a2d37ebd739d587985b2f9bc8a
2017-02-15try to fix "random config" boxMarkus Mohrhard
Test run #211. Change-Id: I438ba57d69bcd46b9114c80e9ca4b7f7ac731963 Reviewed-on: https://gerrit.libreoffice.org/34286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-10remove unused enumerators from FTPErrors enumNoel Grandin
Change-Id: I30a2cc41d246b5048f2514eb38ee8e3bef0ed41c
2017-02-10convert InsertOperation to scoped enumNoel Grandin
and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01Revert "cancelCommandExecution - no need to pass exception by Any"Noel Grandin
This reverts commit 4739b31dafc5154a2c7d6b3f0ee90686863656f0. Apparently, passing a param of type css::uno::Exception to Any will record precisely a css::uno::Exception in that Any, losing any subtype information, which this commit changed.
2017-02-01cancelCommandExecution - no need to pass exception by AnyNoel Grandin
all the call sites are passing an uno::Exception subtype Change-Id: I6de1f00810e063e75ef620314561d7e2d6445ada Reviewed-on: https://gerrit.libreoffice.org/33657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31Revert "Avoid warning with Clang that doesn't have -Wunused-but-set-parameter"Stephan Bergmann
This reverts commit d69bc9c939b94718ac9e17a62f62ae7ae87776e5, which isn't needed any more now that 01aa52b5e91bac740ad21c31968c834c1530831e "Work around -Werror,-Wunknown-pragmas" makes the whole pragma block conditional on __GNUC__ >= 7 (which Clang does not fulfill).
2017-01-31Work around -Werror,-Wunknown-pragmasStephan Bergmann
...from GCC < 7 not knowing -Wunused-but-set-parameter Change-Id: I6494882085ad39df8d7b94fa062a7717bffacadb
2017-01-31Avoid warning with Clang that doesn't have -Wunused-but-set-parameterTor Lillqvist
Change-Id: I8d016e9959898a90bff9d1e4734cbef37592a97e
2017-01-31Silence GCC 7 warnings in libcmis/libcmis.hxxStephan Bergmann
Change-Id: If7114da10824300804a882fa31080a17e69fc36b
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT is always trueNoel Grandin
and has been for more than a decade Change-Id: I81dd8c6db0b3a961d2e2f2dfb4c0fb97704756d8
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27Don't worry, Kai, it's still in the git repoStephan Bergmann
57558f61e9aa1a45f12a2f72d7a0359303d00be2 "#i108938# - commented out unused member fuction." Change-Id: I4972d0ff98f8fa21de4fa6506bc1bcbc7088f6d3
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26loplugin: unnecessary destructor test..unotoolsNoel Grandin
Change-Id: I1fd8a3f39b875d1920759f42e37f4c9d6785d62e Reviewed-on: https://gerrit.libreoffice.org/33573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26loplugin:dynexcspecStephan Bergmann
Change-Id: I5e30befa9338bfd72e237e2bdb7c157526d32b85
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I5091c2b4550dee1f0b602a5337e17fe78b9d07f9
generated by cgit (git 2.34.1) at 2024-08-10 05:17:28 +0000