summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2017-02-06Add missing #includesStephan Bergmann
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01Revert "cancelCommandExecution - no need to pass exception by Any"Noel Grandin
This reverts commit 4739b31dafc5154a2c7d6b3f0ee90686863656f0. Apparently, passing a param of type css::uno::Exception to Any will record precisely a css::uno::Exception in that Any, losing any subtype information, which this commit changed.
2017-02-01cancelCommandExecution - no need to pass exception by AnyNoel Grandin
all the call sites are passing an uno::Exception subtype Change-Id: I6de1f00810e063e75ef620314561d7e2d6445ada Reviewed-on: https://gerrit.libreoffice.org/33657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31Revert "Avoid warning with Clang that doesn't have -Wunused-but-set-parameter"Stephan Bergmann
This reverts commit d69bc9c939b94718ac9e17a62f62ae7ae87776e5, which isn't needed any more now that 01aa52b5e91bac740ad21c31968c834c1530831e "Work around -Werror,-Wunknown-pragmas" makes the whole pragma block conditional on __GNUC__ >= 7 (which Clang does not fulfill).
2017-01-31Work around -Werror,-Wunknown-pragmasStephan Bergmann
...from GCC < 7 not knowing -Wunused-but-set-parameter Change-Id: I6494882085ad39df8d7b94fa062a7717bffacadb
2017-01-31Avoid warning with Clang that doesn't have -Wunused-but-set-parameterTor Lillqvist
Change-Id: I8d016e9959898a90bff9d1e4734cbef37592a97e
2017-01-31Silence GCC 7 warnings in libcmis/libcmis.hxxStephan Bergmann
Change-Id: If7114da10824300804a882fa31080a17e69fc36b
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-30NO_STREAM_CREATION_WITHIN_DOCUMENT_ROOT is always trueNoel Grandin
and has been for more than a decade Change-Id: I81dd8c6db0b3a961d2e2f2dfb4c0fb97704756d8
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27Don't worry, Kai, it's still in the git repoStephan Bergmann
57558f61e9aa1a45f12a2f72d7a0359303d00be2 "#i108938# - commented out unused member fuction." Change-Id: I4972d0ff98f8fa21de4fa6506bc1bcbc7088f6d3
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26loplugin: unnecessary destructor test..unotoolsNoel Grandin
Change-Id: I1fd8a3f39b875d1920759f42e37f4c9d6785d62e Reviewed-on: https://gerrit.libreoffice.org/33573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26loplugin:dynexcspecStephan Bergmann
Change-Id: I5e30befa9338bfd72e237e2bdb7c157526d32b85
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I5091c2b4550dee1f0b602a5337e17fe78b9d07f9
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I1fa141ee0d8d818f3ed5b31faa1ac578ba791e39
2017-01-26loplugin:salboolStephan Bergmann
Change-Id: I9c34c84d14084e84ab7d9fda78955cf2aebaf5dc
2017-01-20new loplugin: useuniqueptr: ucb..ucbhelperNoel Grandin
Change-Id: Ib19ca3225b96d1bfec8a43bb762e16597f33b690 Reviewed-on: https://gerrit.libreoffice.org/33297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, ucbStephan Bergmann
Change-Id: I39a50e3f066776ac670a99120e12624af39fa83a
2017-01-18use rtl::Reference in DynamicResultSetWrapperNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ia155ebcb856884461871d5992380c364da07a1d3
2017-01-18use rtl::Reference in ContentResultSetWrapperNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Iba7317e37046c62411bae9d943f9e81f23ff3554
2017-01-18use rtl::Reference in CachedContentResultSetNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I868530ba1697baae88a4322eda6c467c9f8e8eb6
2017-01-17use rtl::Reference OFileAccessNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I36f1788510e7233ae3de4610370528e24ca03e1d Reviewed-on: https://gerrit.libreoffice.org/33170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-17use rtl::Reference in SortedDynamicResultSetNoel Grandin
instead of storing both raw pointers and uno::Reference Change-Id: Ifcc9daf95d4b2583c9bc4b06deb65a2e618ac1e0 Reviewed-on: https://gerrit.libreoffice.org/33168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-09ucb: cmis::DataSupplier::queryContent() looks rather questionableMichael Stahl
It's not immediately obvious if the caller is responsible for checking the index validity here, but all the other sub-classes of ResultSetDataSupplier that i looked at do check the index so do the same here. Change-Id: Ib0c5c38cb28282f08752cdb03202e4d6f3566693
2017-01-09ucb: ReacquireableGuard::reacquire() is a no-opMichael Stahl
So remove this junk and use osl::ResettableGuard instead which actually works. Change-Id: Ieb49fab16c94f0a2847ee5a1b95b52f2c141c674
2017-01-09New loplugin:externvar: ucbStephan Bergmann
Change-Id: Idfab6f0d16b85ca280056db88264e5234361bce0
2016-12-30cleanup tailing backslashesJochen Nitschke
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30unexpected exception seen in tinderboxCaolán McNamara
#1 0x00002b464842f53a in __GI_abort () at abort.c:89 save_stage = 2 act = {__sigaction_handler = {sa_handler = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>, sa_sigaction = 0x2b4648169a60 <typeinfo name for com::sun::star::uno::RuntimeException>}, sa_mask = {__val = {47580863731936, 47582668825824, 47580850742064, 47580863731456, 2, 47580871027780, 0, 47582668825824, 47580863731456, 47580873315224, 47580863731936, 47582791173728, 47582791173728, 1, 33350960, 47582668313696}}, sa_flags = -1151509448, sa_restorer = 0x1fce530} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00002b4648e3efdd in __gnu_cxx::__verbose_terminate_handler() () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95 terminating = true t = <optimized out> #3 0x00002b4648e3ce56 in __cxxabiv1::__terminate(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:47 #4 0x00002b4648e3cea1 in std::terminate() () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:57 #5 0x00002b4648e3ceb6 in __cxxabiv1::__unexpected(void (*)()) (handler=<optimized out>) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:63 #6 0x00002b4648e3cae2 in __cxxabiv1::__cxa_call_unexpected(void*) (exc_obj_in=0x2b46b40ad4b0) at ../../../../libstdc++-v3/libsupc++/eh_personality.cc:759 info = {Start = 47582791163104, LPStart = 47582996646024, ttype_base = 0, TType = 0x2b46bb5d5e30 "", action_table = 0xffffffff <error: Cannot access memory at address 0xffffffff>, ttype_encoding = 1 ´\001´, call_site_encoding = 0 ´\000´} xh_lsda = 0x2b46c7aab0d4 "\377\233\261\201\200\200" xh_switch_value = -1 exc_obj = 0x2b46b40ad4b0 xh_terminate_handler = 0x2b4648e3ee70 <__gnu_cxx::__verbose_terminate_handler()> #7 0x00002b46c79c6af9 in webdav_ucp::DAVResourceAccess::GET(std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, webdav_ucp::DAVResource&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x2b46b410ceb0, rHeaderNames=std::__debug::vector of length 0, capacity 0, rResource=..., xEnv=uno::Reference to ((anonymous namespace)::UpdateInformationProvider *) 0x2b46bb153918) at /home/tinderbox/master/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx:497 errorCount = 0 bRetry = false xStream = empty uno::Reference Change-Id: Iaa3ec435af6bed267235a9025fc9334058f20475
2016-12-22Revert "[API CHANGE] createSecurityContext() was always called with an empty ↵Tor Lillqvist
string" I got cold feet. I don't want to have to revert this many years later instead, when some obscure 3rd-party software stops working. This reverts commit e1ce7bad62f07faf8f21adac6c3848d142f61953.
2016-12-21[API CHANGE] createSecurityContext() was always called with an empty stringTor Lillqvist
So drop the parameter then and propagate fallout in the Windows implementation in xmlsecurity. The NSS implementation already ignored the parameter completely. This interface is not 'published' and the parameter was even marked as 'reserved for internal use' so I doubt any external code has used it. Change-Id: I5915b941b79cfddadc8137c32ed07c20c9ccaa37
2016-12-19vcl: separate ImplImageTree - ImageTree singleton and public ifaceTomaž Vajngerl
ImplImageTree was used outside of VCL which is not consistent with the name and the header also contains a lot of implementation detail. This separates the implementation to ImplImageTree and the public interface and singleton to ImageTree only. Change-Id: I3a26444f0f6971a6b1d83472e9cef19c93192d3e Reviewed-on: https://gerrit.libreoffice.org/32134 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-12-14Merge shell into TaskManager base classStephan Bergmann
(arbitrarily decided to keep the latter, being the less odd class name) Change-Id: I5c061a0f12b8f3095e283b4896f7c910948ac50f
2016-12-13loplugin:staticanonymousTor Lillqvist
Change-Id: I8c08a303026219dbf87af7165a3f9a99134d5091
2016-12-13loplugin:salboolTor Lillqvist
Change-Id: Ia2a2c900bf8bf8ecee2edf130b8ca58f7f35b6aa
2016-12-13loplugin:stringconstantTor Lillqvist
Change-Id: Ifc100e8ece6ea826b745919583beac315c41b100
2016-12-13loplugin:nullptrTor Lillqvist
Change-Id: I2cd1e82d86d8776155db2f70bc92c7c448f81ce0
2016-12-13loplugin:overrideTor Lillqvist
Change-Id: Idb5e16bae0fe573b22c86d1c4d6d4ab8da790557
2016-12-13loplugin:refcountingTor Lillqvist
Change-Id: I5ca4c1599a1abc4281bac9a4d0164d4b0cb3e24a
2016-12-12-Werror,-Wimplicit-fallthroughTor Lillqvist
Change-Id: I7ea9c1af7568ce37f29df14f8dc4345031c20eb8
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-12coverity#1397041 Unchecked return valueCaolán McNamara
Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679
2016-12-11fix out of bounds accessJochen Nitschke
since commit 96ec36cf261eec3ec07f3caa2673a916571c4287 Date: Thu Dec 8 21:49:47 2016 +0100 ucb: replace "SimpleList" trash found by cppcheck Change-Id: I13d62bdb6cb1a714182f90078d4a2990c790301a Reviewed-on: https://gerrit.libreoffice.org/31856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-12-11cmis: add error handling on checkinThorsten Behrens
Change-Id: I3951a237789ee4b7697f70bc527ffbb6a626206a Reviewed-on: https://gerrit.libreoffice.org/31776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-12-09loplugin:refcountingTor Lillqvist
Fixes: "uno::Reference field with template parameter that does not contain ::static_type() css::uno::Reference<SerfInputStream>, parent is http_dav_ucp::SerfGetReqProcImpl, should probably be using rtl::Reference instead [loplugin:refcounting]" Change-Id: I43211bb397031a4961df77ee39038e6ef9da6bb1
2016-12-09ucb: replace "SimpleList" trashMichael Stahl
* pointless use of void* * stupid casting everywhere * ridiculously overloaded Remove() * defensively programmed implementation Change-Id: I1c86ffac636cafbe3e13e668a65a2b14377b6e95
2016-12-08OSL_TRACE -> SAL in sw..ucbNoel Grandin
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5 Reviewed-on: https://gerrit.libreoffice.org/31762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08-Werror=return-local-addrStephan Bergmann
(the first case with OUString would technically be OK, but better change all three of them) regression introduced with 0e4ca9b0cfe015f7ab3b964d1b90de7c2cba42de "Clean up uses of Any::getValue() in ucb"; thanks to tml for finding it via --enable-fuzz-options Change-Id: I79e70cff8d8b96e1eb6b0bacda52be06eb0f108b
2016-12-08loplugin:overrideparamTor Lillqvist
Change-Id: I9b70fbc344a02a058fbb7af694edad560244c930
2016-12-08loplugin:overrideTor Lillqvist
Change-Id: I57b5572d81e6da53d82fbbb6dbcb35c9802ec3f1
generated by cgit (git 2.34.1) at 2024-07-12 10:25:36 +0000