summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2016-03-18Remaining argument from loplugin:constantparam in ucbKorrawit Pruegsanusak
Still one remaining after b47cb646ff2a62fcd3fac0e453a7261bbaefbcb7 Change-Id: If1dfaa6bbc9f8582f7b2a7dab49815a0a4c6a7b8 Reviewed-on: https://gerrit.libreoffice.org/23355 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-18Restore WebDAV credential dialog functionality...Giuseppe Castagno
...that was broken in 3d264450989cecdc59a2e64f46a0328432ba0d08. Change-Id: Icd601196867258490f9241efc3d0d6ebea334a2a Reviewed-on: https://gerrit.libreoffice.org/23353 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed OSL_DEBUG_LEVEL > 1 conditionals and the g_warning() with SAL_INFO() and SAL_WARN Change-Id: Icb4ab72245111b52c59a47cc659dfdb79d5690ee Reviewed-on: https://gerrit.libreoffice.org/23232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966 redundant static keywords removed 6Wastack
Change-Id: Iaf034f3b2282a973f6503edea41cb3184543fb11 Reviewed-on: https://gerrit.libreoffice.org/23133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: Ic2c7cc2a78e8e58c3ca28acd9b6a35ddaceeab60
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I4d0dc49e44b9e9f7504008ea1d10876cd80e76f8
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I6c60905541de56229bc26e9dc6e589d4099e9266
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I75158ff7588452f38306b0bed351a6532b9c8d1f
2016-03-10Make CppunitTest name match *.mk file nameStephan Bergmann
...so "make CppunitTest_ucb_webdav_local_neon" works as expected. Change-Id: Iecdd5d1ad19be4789bca60d455a3dfdd8fee9cb3
2016-03-10These tests can just derive from plain CppUnit::TestFixtureStephan Bergmann
...and then no longer need to override any base class setUp/tearDown Change-Id: Iaea19dfb341325bb45062d0ac0b5fa1eed0d34e0
2016-03-09loplugin:constantparams in ucbNoel Grandin
Change-Id: I6b925336b13404ccf0f78f194bd3488a22f99b97
2016-03-08follow the boost lib naming scheme for DateTime tooDavid Tardon
Change-Id: Iae7967bd5f161ecbe888824a4bcb9b87ec8d947a
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:stringconstantStephan Bergmann
Change-Id: I1a594a3d62790125244d221aeaa6d989adf30d97
2016-03-03ucb: replace boost::bind with C++11 lambdasMichael Stahl
... and remove now unused comphelper::TNamedValueEqualFunctor. Change-Id: Ia6cac4ae4e34d2ba134e2f2a4a5b4daea58bf0b3
2016-02-29loplugin:unuseddefaultparam in ucbNoel Grandin
Change-Id: Ie0ea0b4dc13271a2bde5e3843bb3f8042ab880b4
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19new loplugin: find write-only fieldsNoel Grandin
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Fix tdf#97500 Reinstate missing file error dialog on WebDAVGiuseppe Castagno
Bug introduced with my fix to tdf#96669 in commit 5fc2910fc872bbd1184aaab7c842dff593d2449b. Reverted previous fix and write a new version in fpicker instead. On WebDAV better check if the stream opens first, then check IsDocument property, because it may be a folder name. Change-Id: I72ce728329e4194080db6fa4cc4d98fecf7672e9 Reviewed-on: https://gerrit.libreoffice.org/22214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-08loplugin:unusedmethodsNoel Grandin
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04fix typoMarkus Mohrhard
Change-Id: Iad24dfe97c9d360879d471606a9df340268860b2
2016-02-02boost::hash->std::hashNoel Grandin
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-30Related tdf#95217: Force HEAD method in Web access if PROPFIND failedGiuseppe Castagno
Change-Id: I9ad798aa8e0909b162f3e1e33c0bc19d4fc7f484 Reviewed-on: https://gerrit.libreoffice.org/21907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-30Related tdf#95217: Http header names are case insensitiveGiuseppe Castagno
Change-Id: I0d81e110a31f93f5f24a96f96c12f0ec9c95921b Reviewed-on: https://gerrit.libreoffice.org/21906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-29Fix typo, change misleading warning messageGiuseppe Castagno
Change-Id: I31537e9d73fa8a5d7c56efcc4832df041472ad5d Reviewed-on: https://gerrit.libreoffice.org/21891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-29sequence->vector in OInteractionRequestNoel Grandin
Change-Id: I995cb96e514e1aaa05a96f29344ef51e4ca83c64
2016-01-26Add initial cppunit test to webdav, 'local' only, neon versionGiuseppe Castagno
This is a 'local' test, meaning it can be done without a WebDAV server. It's the first one, so very trivial... Change-Id: Idf660c7482c86251be02536106f079ac6bdef4b4 Reviewed-on: https://gerrit.libreoffice.org/21658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-13loplugin:unusedmethods unused return value in ucb/Noel Grandin
Change-Id: Ib988c919a21f58b7dc302810ec6c63534a51f382
2016-01-12Related tdf#96174: save again on Google Drive.Giuseppe Castagno
Files can no longer be saved on Google Drive. The bug was introduced in 0398e1e3967332c49b6451b5d41bcf0357052d0b. Google Drive may have user name in the form: name.surname@domain.com In some places the user name should be escaped before using it. Change-Id: Idee3e57c0ad1dcbbd517b60c387868bfc706f27e Reviewed-on: https://gerrit.libreoffice.org/21198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-08cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-08tdf#96669: IsDocument should be true only if the document existsGiuseppe Castagno
Fixes a problem with Save to remote server dialog. Change-Id: I4ef2dbf12bb786f5617cb57ff021012e4d884230 Reviewed-on: https://gerrit.libreoffice.org/21010 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-01-05Related tdf#96833: breadcrumb: setting URL, host port gets lost.Giuseppe Castagno
At the same time added a log in WebDAV, useful to discover the issue. Change-Id: I3435f8d3da28f7d6b4c2e154cf2bb5ee33a9a690 Reviewed-on: https://gerrit.libreoffice.org/21047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-24loplugin:unusedfieldsNoel Grandin
Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-21loplugin:unusedfields UnoControls,ucbNoel Grandin
Change-Id: I2ff2db21d79d80785f3b6849c879537d5111a960
2015-12-16Related tdf#90700 Add configuration for web connection timeout.Giuseppe Castagno
Currently the connection timeout is governed by operating system default. LO timeouts will be used in place of the TCP socket operating system ones, only in operating system where this is currently possible. The timeouts to use can be changed in LO configuration: 'Tools > Options > Advanced > Expert Configuration'. Propriety names are ConnectTimeout and ReadTimeout. ConnectTimeout contains the timeout (in seconds) used when making a connection (max 180 s, min 2 s, default 20 s). ReadTimeout contains the timeout (in seconds) used when reading from a socket (max 180 s, min 20 s, default 60 s). Change-Id: Ide69ab137274c3bf71332b6e76666151ecac1f1e Reviewed-on: https://gerrit.libreoffice.org/20195 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-15tdf#95792: fix saving file the first time on some WebDAV servers.Giuseppe Castagno
Some WebDAV servers don't implement section 7.3 of RFC4918: <http://tools.ietf.org/html/rfc4918#section-7.3> This lack of implementation breaks 'Save As...' functionality when the target is a WebDAV server, by not locking the URL ('reserve the name for use', in RFC4918 parlance). The server not implementing this usually answers with one of '405 Method Not Allowed', '501 Not Implemented' or '412 Precondition Failed' http error codes. The fix should manage this lack of implementation. Change-Id: Ie4689a076aafa365106d02b3ea16459a28fcde65 Reviewed-on: https://gerrit.libreoffice.org/20600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-15Some WebDAV server answer without 'DAV:' XML namespace.Giuseppe Castagno
The call to assert() is not appropriate, better use a SAL_WARN_IF instead. The call to DAVProperties::createUCBPropName() method immediately after will take care of the missing namespace. The change to assert() was introduced in commit dd9c15b36f69bec4d4fc9b0049f7e496e5eb9e9d Change-Id: Ib9b85426fc84907fb12f70759a189cedcf117b3a Reviewed-on: https://gerrit.libreoffice.org/20380 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-14Fix tdf#90700 Notify connect timeout early.Giuseppe Castagno
Throws exception to manage timeout early in the first connection sequence. Change-Id: Ibf87f9d7607c808692509c694127266b6f542014 Reviewed-on: https://gerrit.libreoffice.org/20196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-10loplugin:nullptr: More NULL -> nullptr automatic rewriteStephan Bergmann
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
generated by cgit (git 2.34.1) at 2024-08-10 20:20:38 +0000