summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2016-11-07loplugin:unnecessaryvirtual in test..vbahelperNoel Grandin
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965 Reviewed-on: https://gerrit.libreoffice.org/30649 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01Cosmetic: Namespaces, better make use of the 'using-directive'Giuseppe Castagno
Change-Id: If27709a2d8d8f231be9be0231d522f2a71e5fcae Reviewed-on: https://gerrit.libreoffice.org/30457 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-31Omit comparator which is the same as default std::less<key_type>Takeshi Abe
Change-Id: I72a0b618577caececaaf3eb4df53d4cb192251da Reviewed-on: https://gerrit.libreoffice.org/30369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-27Cosmetic: Move function member around...Giuseppe Castagno
...so it's nearer to the other function member that uses the class variables it initializes. Change-Id: I199621fbcad36313e0948627d47445a1de211d02 Reviewed-on: https://gerrit.libreoffice.org/30313 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26const-ness fixesStephan Bergmann
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26WebDAV: Small cosmetic to unit checks.Giuseppe Castagno
Change server name in URI test strings. Pass by const lvalue reference [loplugin:passstuffbyref]. Change-Id: Ic0134f0690a8e6b9abb7d0764efaeeaf3a167bcf Reviewed-on: https://gerrit.libreoffice.org/30284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26loplugin:expandablemethods in ucb..ucbhelperNoel Grandin
Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2 Reviewed-on: https://gerrit.libreoffice.org/30266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23Fix typosAndrea Gelmini
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-21tdf#102499 (9): Fix eXo Platform WebDAV on 'Save Remote File'Giuseppe Castagno
Change-Id: I2d2aceed3804f653b79d48eeb02468fc77374eb7 Reviewed-on: https://gerrit.libreoffice.org/29884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-21tdf#102499 (8): Return empty property when not present.Giuseppe Castagno
Change-Id: If5afa4f33ac5b5dfec123960c2e9660183576256 Reviewed-on: https://gerrit.libreoffice.org/30142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-19loplugin:expandablemethods in UnoControls..vbahelperNoel Grandin
Change-Id: Iec2c5e13119d97c9ca87e083c0f7cb00227e5231 Reviewed-on: https://gerrit.libreoffice.org/29997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18ucb: fix handling of >>= with rhs AnyJochen Nitschke
>>= for rhs Any is always true, check result with hasValue() instead. bool convert<uno::Any>(...) always returns false and assigns the 3rd parameter to the 4th. do the assign directly and check result with hasValue(). Change-Id: I0ae985cc0837abf1108930d593edae69de2ae549 Reviewed-on: https://gerrit.libreoffice.org/29977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18loplugin:unusedmethodsNoel Grandin
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13tdf#102499 (7): Caching connect timeout or cannot connect.Giuseppe Castagno
An unofficial HTTP response status code is defined and used internally in LibreOffice WebDAV ucp provider in order to catch either the DAVException::DAV_HTTP_TIMEOUT state or the DAVException::DAV_HTTP_CONNECT state. Change-Id: Iec4927d18ace5384fed16a7ec2a2620dc8305c5b Reviewed-on: https://gerrit.libreoffice.org/29757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12tdf#102499 (6): Cache OPTIONS if not present or if lifetime differentGiuseppe Castagno
Add the OPTIONS information and response status code into the cache: - if the OPTIONS information is already cached, update the cache only if the lifetime is different; - if the OPTIONS information is not cached, cache it. Add some new functions in DAVOptions to support the change and remove a function no longer used. Change-Id: I2f28f0ee793ec7d898caa61cc0a4962334e6e068 Reviewed-on: https://gerrit.libreoffice.org/29733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-11tdf#102499 (5): Deal with HTTP unofficial response status codesGiuseppe Castagno
A reference can be found here: <https://en.wikipedia.org/wiki/List_of_HTTP_status_codes> (retrieved 2016-09-13). Changes done: Add set of 'HEAD method not available' before using fall back GET method. Add new method in OPTIONS cache. Add response status code if fall-back GET didn't succeeded. Add copy-assignement operator to DAVOptions. Fix behaviour of GET fall back when HEAD missing. Change-Id: I6aad0e22bb444abf37b90186588f64f79b03cc3d Reviewed-on: https://gerrit.libreoffice.org/29680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-05tdf#102499 (3): Change caching model for HTTP response status codeGiuseppe Castagno
Instead of caching only a single status flag, now both the HTTP response status code and the message accompanying it are cached. Change-Id: If7352f6b0cb7c7dab6af3cede96647308baa5ce2 Reviewed-on: https://gerrit.libreoffice.org/29538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-03tdf#101094 (36): Fix behaviour of GET in fetching Headers onlyGiuseppe Castagno
Implement a better way to GET only headers, as HEAD method substitute. Wrote a new version of GET, specifically for 'no payload' service because sometimes neon was returning an internal error about: 'Compressed response was truncated' but without a specific error state. Change-Id: I84a3e5635193c3f68d335eba7af41b05980f4192 Reviewed-on: https://gerrit.libreoffice.org/29502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-03loplugin:countusersofdefaultparams in sw..vclNoel Grandin
Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03tdf#101094 (35): Add OPTIONS as pre-check in direct WebDAV open() methodGiuseppe Castagno
The function call will act as a precheck on Web resource access error when accessing the open directly without the normal file open procedure, e.g. accessing Web resource property values first. An example of this direct open call are the extension fetching and the extension update check. Change-Id: I765a2fe29f432a07a649e5a35440ae351c681af9 Reviewed-on: https://gerrit.libreoffice.org/29454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-01Fix typosAndrea Gelmini
Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01tdf#101094 (34): Fix test and missing field value in comparision operatorGiuseppe Castagno
Change-Id: I6be4a7861f2a978c260defd54dcbc8d124017439 Reviewed-on: https://gerrit.libreoffice.org/29431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26tdf#102499 (2): Refactor the WebDAV resource access retryGiuseppe Castagno
Change-Id: Ia29560d54a61f1238f3b4e945d78308a3a68c483 Reviewed-on: https://gerrit.libreoffice.org/29269 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26tdf#101094 (33): Fix: use the correct exceptionGiuseppe Castagno
Change-Id: I41e7cc0a1e176e44cb1b3fb87269eb6e052c6478 Reviewed-on: https://gerrit.libreoffice.org/29273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-26convert CONTINUATION constants to typed_flags_setNoel Grandin
Change-Id: I38333e5d229aa520fbe0a8ad72007c503853956e
2016-09-25tdf#102499 (1): Add WebDAV test to check HTTP reponse status codes retryGiuseppe Castagno
Change-Id: I4ff36df3ac1cc0788322768378fb74f70892f922 Reviewed-on: https://gerrit.libreoffice.org/29245 Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19tdf#101094 (32): Use a partial GET as a fall-back for HEAD...Giuseppe Castagno
... partial GET means a GET with no data returned, to test for resource 'real' availability in case HEAD fails or is disabled. At the same time disable use of HEAD method on the resource for the whole access procedure. This change is needed to manage web servers that don't permit the use of either HEAD or OPTIONS methods. To accomodate pure web sites that enable only GET to fetch contents. Change-Id: If52316ddd6ce637fb7d2ef518423de246ee2dcfb Reviewed-on: https://gerrit.libreoffice.org/28992 Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-18Related: tdf#101094 (31): Add a simulated HEAD method: use GETGiuseppe Castagno
Some server have HEAD method disabled or not implemented. So we can use GET with no data, retrieving only the header info. The implementing code comes from LO WebDAV serf implementation. Change-Id: I3b3d81f5a07232c4f1647888685e820939bc978c Reviewed-on: https://gerrit.libreoffice.org/28982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-13tdf#101094 (30): Better explanation of OPTIONS errors in debug buildGiuseppe Castagno
Change-Id: Iea0eef5d3cd67c73325eb7af883ef8ce286187cd Reviewed-on: https://gerrit.libreoffice.org/28850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-09-07-Werror=unused-but-set-variableNoel Grandin
Change-Id: I1a7ed38a95b06029d821b000324b2cc880df1ebb
2016-09-07loplugin:constantparam in framework..vbahelperNoel Grandin
Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc
2016-08-29WebDAV: Make some SAL_WARN log wording a bit betterGiuseppe Castagno
Change-Id: Ib854d1ac74e952c786136176899e533804eb1e61 Reviewed-on: https://gerrit.libreoffice.org/28459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-29cppcheck: noExplicitConstructorGiuseppe Castagno
Change-Id: Ifa588c37added377d753cb7b32a6f1e6a3672c94 Reviewed-on: https://gerrit.libreoffice.org/28453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-28tdf#101094 (29) Fix for IIS 10.0 disabled OPTIONS methodGiuseppe Castagno
When OPTIONS methods (or verb) is disabled (or denied) on a IIS 10.0 web server, error 404 (e.g. 'Not Found') is emitted, so we need to deal with it. Change-Id: Ifd6df0ea4b89824133e212f73950d6c3acd00dd7 Reviewed-on: https://gerrit.libreoffice.org/28430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-26tdf#101094 (28): Put back the thread mutex guard...Giuseppe Castagno
...the one I wrongly removed in commit 72589082945e5a197f3fb4b884f48dd4ae275e5f Change-Id: I9f8e2f34a91b0fe481b1fe0f4655e3899a0589a6 Reviewed-on: https://gerrit.libreoffice.org/28412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-26tdf#101094 (27): Add a mutex guard to OPTIONS neon dispatch callsGiuseppe Castagno
This is a sort of follow up to commit: 510da29131e56ba0e1783e505e7131e6f7e0d6b4: "forced to make certain neon api calls thread-safe due to cups rhbz#637738 libgcrypt that's been initialized already by cups to be non-threadsafe is therefore then also non-threadsafe. neon uses libgcrypt. So in the (as this is the usual circumstance) case that cups is initialized before neon, then libgcrypt is not threadsafe even though neon attempt to initialize it as such." Change-Id: I1f868642ac15bf9fa25d3edd46390467d8fce1f5 Reviewed-on: https://gerrit.libreoffice.org/28401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-25cid#1371328 Misused comma operatorNoel Grandin
Change-Id: I3e585fb44612cb7ab2e6f04570b233310b01d8c8
2016-08-25cid#1371332 Misused comma operatorNoel Grandin
Change-Id: Ib7ba126d53e81dbd65451aa4bb33033f468ca295
2016-08-23Related: tdf#82677, remove cached element when appropriateGiuseppe Castagno
Change-Id: I6f9e1218c2767ec69ca371c4f5a12c2f385c7363 Reviewed-on: https://gerrit.libreoffice.org/28275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-23Related: tdf#82677, add cache use in Content::getProperties()Giuseppe Castagno
Change-Id: I47f583c808498aaf0f7cca1749fb5ef841ad10f3 Reviewed-on: https://gerrit.libreoffice.org/28274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-23Related: tdf#82677, implement a PROPFIND 'propname' request cacheGiuseppe Castagno
PROPFIND 'propname' is the special usage to retrieve all the properties available on the URI resource, their names only. See <https://tools.ietf.org/html/rfc4918#section-9.1> for PROPFIND 'propname' definition. Add cache usage in Content::getProperties as well. The caching model is simple: a simple lifetime limit of 10 seconds to declare the property name list stale and request another list, accessing the Net. This should reduce the number of PROPFIND calls on the Net. Change-Id: Ie4ebd946dd81583dc964a62c7744f3e2c716c737 Reviewed-on: https://gerrit.libreoffice.org/28273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-22ucbhelper::Std{In,Out}putStream are only used in ucb/source/ucb/cmis/Stephan Bergmann
...where their use of boost::shared_ptr (instead of std::shared_ptr) matches the use in libcmis, but makes them unlikely to be useful anywhere else. So move them into ucb/source/ucb/cmis/. Change-Id: I68359be6b43d6889af4f241dcdcbdc0d9d70d717
2016-08-21tdf#101094 (26): Fix possible early relase of cache mutexGiuseppe Castagno
Change-Id: If42393b2738ab107d380e55a0cbf2d6fa9940130 Reviewed-on: https://gerrit.libreoffice.org/28265 Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-08-19Some clang-tidy misc-move-constructor-initStephan Bergmann
...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
generated by cgit (git 2.34.1) at 2024-12-28 22:52:20 +0000