summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b Reviewed-on: https://gerrit.libreoffice.org/2835 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19coverity#982271 Copy-paste errorJulien Nabet
Change-Id: I42800a846ba0cb935f97f8e99f774f58f3b525f8 Reviewed-on: https://gerrit.libreoffice.org/2802 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-03-19Simplify equalsIgnoreAsciiCaseAscii[L] callsStephan Bergmann
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
Done with a perl regex: s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec Reviewed-on: https://gerrit.libreoffice.org/2832 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19trailing whitespacesThomas Arnhold
Change-Id: I3d0e2015e4c9f0ea6118fd92892022607fe4bde6
2013-03-18incorrect NEON_VERSION usageLuboš Luňák
First of all, NEON_VERSION is undefined, and second, it's actually a text string, so this is all broken. Change-Id: Iba841c78e9034bf9ef74eb4f31c9893608180b77
2013-03-15fprintf -> SAL_WARNStephan Bergmann
Change-Id: Ifab1415fafa93551d8bed1e77c38f04bec8d2eba
2013-03-15Revert "Conditionalize call of ne_debug_init() using the SAL_INFO() mechanism"Tor Lillqvist
It won't work, ne_debug_init() will be called always (in non-release builds). This reverts commit b6f6c3a2ed19cc34cce5d19c32c921227165bdd0.
2013-03-15Conditionalize call of ne_debug_init() using the SAL_INFO() mechanismTor Lillqvist
Instead of #if OSL_DEBUG_LEVEL>0. Change-Id: I2329de4deff4687fb1249c47f2e24eaf6ea6a248
2013-03-15Lock document that is opened for potential modificationTor Lillqvist
Part of fix for bnc#805901. (No locking of documents edited through WebDAV.) Seems to work, can it really be this simple... I am a bit unsure if any explicit UNLOCK operation happens, but WebDAV locks typically time out relatively quickly, don't they? And WebDAV implementations (often/always?) have the possibility for a user to force open a lock. Change-Id: Ia32d8b1517361f702b4f469d9f1aa17de6d7ba54
2013-03-15SAL_INFO instead of OSL_TRACETor Lillqvist
Change-Id: I40a2e6ea708aa037172bc6e9f9882c88f1d486c3
2013-03-15Use default set of root certificates, if available, when using SSLTor Lillqvist
Part of fix for the WebDAV https server authentication problem noticed when fixing bnc#805901. Change-Id: Ic54c59bdadaf34cdba32949400d5da69712017f3
2013-03-15Turn on Neon lock and SSL debugging too (when OSL_DEBUG_LEVEL>0)Tor Lillqvist
Change-Id: I4acb7ab1aeba31bfeedd4dfbcd76d6bf517b8944
2013-03-14remove legacy build.pl prj/build.lst files.Michael Meeks
2013-03-14fdo#54275: Fix GVFS UCP, so saving docs works againStephan Bergmann
Similar to 8722f0e7ef690205d042c8a6b1fdf342a34ecbe1 "rhbz#895690: Make GIO UCP less brittle, so saving docs works again" the alternative, older GVFS UCP (--enable-gnome-vfs --disable-gio, as used e.g. in distro-configs/LibreOfficeLinux.conf) no longer works well in LO 3.6 and later: * For one, "getPropertyValues" did not work for non-existing files, just like in the GIO UCP case. * For another, creating the .~XXX# lock file uses "insert" with !bReplaceExisting, which apparently never worked for the GVFS UCP. Change-Id: Ie4dc032225697ff7b866a75327891c796d559392
2013-03-13rhbz#895690: Make GIO UCP less brittle, so saving docs works againStephan Bergmann
966d20e35d5a2be2fce6c204af5c156c3ead7063 "CMIS ucp: write documents back to CMIS server" had introduced changes to sfx2/source/doc/docfile.cxx in LO 3.6 that changed the exact commands that this code issued for UCP content nodes. The GIO UCP was not prepared to handle that, causing saving of documents via it to fail with rather obscure error messages: * For one, docfile.cxx started to call "getPropertyValues" to obtain the "Title" of a non-existent content. That lead to an InteractiveAugmentedIOException instead of silently returning a void value. * For another, docfile.cxx started to call "transfer" on a folder content whose URL did not have a trailing slash, so the code computed a wrong URL for the child element, resulting in various problems depending on context. Change-Id: I1a9c0c094f5320456940e3af4c802711828ab5ac
2013-03-12Remove RTL_CONSTASCII_USTRINGPARAM in ucb/ucbhelperChr. Rossmanith
Change-Id: I7419a328012962b6b72d2596df034ff912fc12cd
2013-03-11use startsWith() instead of compareToAscii()Thomas Arnhold
brain damage... Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-09fdo#43460: use isEmpty()Thomas Arnhold
Change-Id: I01f503ea5268245cc4f98524931730cfa063d57e
2013-03-08some further OUString cleanupThomas Arnhold
Change-Id: I13eb94092e29ececc9fbf494074acde5f893b605
2013-03-06fdo#60724 change spelling error REMOVEABLE -> REMOVABLEKenneth Beck
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments. All other instances of the misspelling have remained the same. Example: AF_REMOVEABLE Change-Id: I391f4101bbc3e06689318235a37d616065bc1686 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-05Call ne_debug_init() in a debug buildTor Lillqvist
Change-Id: I08d540bdbe32ba9df994528bac97ac76e587795a
2013-03-05doubled usingThomas Arnhold
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-04doubled includesThomas Arnhold
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04Fix "may be used uninitialized" warningStephan Bergmann
Change-Id: I6d2ac90177bd3194e0e3c23ee7c8dd634bb64228
2013-03-04fdo#46808, convert singleton util::theOfficeInstallationDirectoriesNoel Grandin
.. to new-style UNO. And deprecate old service in favour of singleton. Change-Id: I67244097c22af02530214d7c529dd0d32f5964c1
2013-03-03Related to fdo#60724: correct spellingThomas Arnhold
Using the autocorrect list of LibreOffice extras/source/autotext/lang/en-US/acor/DocumentList.xml Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657 Script: http://pastebin.ca/2327716
2013-03-01Related rhbz#915743: Do not call into DAVResourceAccess with mutex lockedStephan Bergmann
...from webdav Content::getResourceType, as otherwise Content::abort would be blocked waiting for the mutex (in code that would call abort, which will be required to fix rhbz#915743 "thread deadlock/slow join in insert->hyperlink in impress"). This required to get the odd reference to enum return type of getResourceType straight. Also, propagate information about !shouldAccessNetworkAfterException from getResourceType out to getPropertyValues, to avoid further calls that would again block/fail. Change-Id: I8b9d43a61eb4078acb90079c4eb7aa98a59a8983
2013-03-01neon commands cannot be abortedStephan Bergmann
See <http://lists.manyfish.co.uk/pipermail/neon/2013-February/001533.html> "Re: About ne_set_read_timeout" for why ne_close_connection is not a solution here (and currently would not work anyway, for the thread calling abort would block on the aGlobalNeonMutex introduced with 510da29131e56ba0e1783e505e7131e6f7e0d6b4 "forced to make certain neon api calls thread-safe due to cups" until the blocking thread was done with its neon call) and "a new, dedicated, thread-safe ne_session_* API call will be needed to allow aborting of a running request." So enable DAVResourceAccess::abort again and instead disable the underlying NeonSession::abort. i#106766 "Crash when cancelling extension update" does not give any good rationale why DAVResourceAccess::abort had to be disabled, so it might well have been because the underlying NeonSession::abort was bogus to begin with. Change-Id: If8293b93a960907726208bb2f93c375d83357ed3
2013-02-28remove all d.lstMichael Stahl
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-28remove useless comment linesMarkus Mohrhard
Change-Id: I884a97d36ff2ed2f4526cf96af9cac214af4db31
2013-02-28coverity#705769: fix memory leakMarkus Mohrhard
Change-Id: I77454dd6c33c8309991108343a2895792095f95d
2013-02-25loplugin: unused variablesThomas Arnhold
Change-Id: I07b82471f0f32e9e894d4eb392beedeafc6be0c7
2013-02-24fdo#38838 searched, replaced and removed String::CreateFromInt32().Jean-Noël Rouvignac
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ And finally removed String::CreateFromInt32(). Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5 Reviewed-on: https://gerrit.libreoffice.org/2279 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-23Fix typo "fuction" -> "function"Julien Nabet
Change-Id: I369da2262d42fbc7cc3cfeeef4920606522237cd
2013-02-22s/the the/the/Tor Lillqvist
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-19coverity#983214 Resource leakMichael Stahl
... and some more general cleanup by using boost stuff. Change-Id: I90b2f429f864c39cda70d42d061da14c0faba8e5
2013-02-14CMIS: made it work with Lotus LiveCédric Bosdonnat
Making libcmis and LibreOffice work with Lotus Live service needed a few hacks to either better implement CMIS or workaround some bad implementations. As a general improvement, the CheckOut InfoBar isn't shown if the document can't be checked out.
2013-02-14CMIS: URL-decode username or it won't be shown properly in dialogCédric Bosdonnat
2013-02-13Some cppcheck cleaningJulien Nabet
Change-Id: I099171d85a51095f0ff6d592c1260d931f9769b2
2013-02-12CMIS: proxy was setin to ":-1" is no proxy is defined in the UICédric Bosdonnat
Don't output the port number if that one is not valid.
2013-02-11fdo#46808, Use singleton util::theMacroExpander new-style constructorNoel Grandin
And deprecate the old-style service util::MacroExpander Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
2013-02-08fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac
Change-Id: I6daea312198fae3a9717bd8d4fea6371aa4cd275 Reviewed-on: https://gerrit.libreoffice.org/1962 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-01-30Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRINGJean-Noël Rouvignac
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd Reviewed-on: https://gerrit.libreoffice.org/1924 Tested-by: Luboš Luňák <l.lunak@suse.cz> Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-28fdo#46808, Convert some bits to new-style UNONoel Grandin
Change-Id: I505910ae117588d54b79e72c12368224b4632fb9
2013-01-26gbuild: do not copy boost headers aroundMichael Stahl
- do not use gb_UnpackedTarball_copy_header_files for boost - adapt the optimization in concat-deps.c for new path - use boost_headers in all LinkTargets that require it - add explicit include paths to mysqlc, mysqlcppconn, libvisio, liborcus Change-Id: I0c43e73ed43cc9d2e6bce8faf55e992d655a0bb9
2013-01-26Remove redundant braces around for loopsStephan Bergmann
...that had once been workarounds for compilers that did not yet support the C++98 scoping rules for declarations in for-init-statements. Change-Id: I51dc42982b30bf3adea6de1a10a91c0b4b4acfbe
2013-01-24CMIS: use the proxy settings from the optionsCédric Bosdonnat
Change-Id: I5b856ac166b67097e1921ec71eb5b7e1819fec41
2013-01-21Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()Jean-Noël Rouvignac
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de Reviewed-on: https://gerrit.libreoffice.org/1784 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21gvfs UCP: silence -Werror=deprecated-declarationsMichael Stahl
Seems to me there's no point to that since GVFS itself is deprecated anyway. Change-Id: Ibceba3bbe33a3a37dd088d0f24bfdd4211095589