summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26avoid a global uno::Reference to the current XCommandEnvironmentCaolán McNamara
because the Env is kept until we exit, which we get away with now. But we won't get away with it if we set the parent window property of the InteractionHandler belonging to the Env. Because we then end up trying to destroy the vcl dialog well after all the vcl, etc infrastructure is torn down and crash on exit. Here I'm assuming that its safe to use a WeakReference because we're just using this to smuggle into the c-style callbacks a Reference to a Env currently belonging to something else Change-Id: I2d6b90ae23d5a24431dc49d4316bdc3194560403
2016-05-19loplugin:unusedmethods in ucb/ucbhelperNoel Grandin
Change-Id: I2935904e2cbecec6c928f4cbc88979bc2d1a40f8 Reviewed-on: https://gerrit.libreoffice.org/25090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16tdf#87938 libcmis: Google 2FA implementationSzymon Kłos
2 Factor Authentication for Google Drive, changes: + parsing additional page with challenge - pin code verification + calling the interaction dialog requesting the code + dialog title changed to more general: Authentication Code + dialog shows url field only if not empty Change-Id: Idb3ebbad6a12849b9e50af87b46324bfbe966bab Reviewed-on: https://gerrit.libreoffice.org/25002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Assign 0 explicitly, avoiding intermediate downcastsMatteo Casalin
Change-Id: I43a9adeaf7078551a3447032fbf65affab817b15
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06tdf#99426 Use correct path for lock in PUT methodGiuseppe Castagno
Change-Id: I2091024a601bebede5d2fb8596dda1054ca4ef3b Reviewed-on: https://gerrit.libreoffice.org/24691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-03tdf#98644 : better error message when wrong password enteredSzymon Kłos
Change-Id: Idf4da8000cce43cb66cb94fdfc8be8a3d6909fa6 Reviewed-on: https://gerrit.libreoffice.org/23475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann
Change-Id: I974a1c8d64f5b13b9052365c3219dcd2dc6927dc
2016-04-22Related tdf#88502 a better implementation than the one in...Giuseppe Castagno
...commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1. This commit reverts previous implementation in commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1 and makes use of a dedicated interaction wrapper instead. See comphelper::SimpleFileAccessInteraction for details. Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf Reviewed-on: https://gerrit.libreoffice.org/24275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-21new plugin stylepoliceNoel Grandin
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: Ib340ec1731cba5a4409f0e8d8bdde48753312672
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15Related tdf#88502 Add default XCommandEnvironment to ...Giuseppe Castagno
... Content::getResourceType During WebDAV operation the css::ucb::XCommandEnvironment is almost always needed. Depending on the operation, sometimes the client doesn't set it, in order to disable the exception processing that takes part in ucbhelper::cancelCommandExecution. Change-Id: Ib4bf6a7ca3a902437cab9050c3e310342c655ff2 Reviewed-on: https://gerrit.libreoffice.org/23327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in ucbNoel Grandin
Change-Id: I4ba18c767c67c9c8d23aac3f8de728b7a229804d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
2016-04-05These are SAL_INFO, at bestStephan Bergmann
Change-Id: I2f4c34de154aa71db721dc30da29173d6c37709f
2016-04-05loplugin:constantparam in ucbNoel Grandin
Change-Id: Ifa36b58a36232e6333a1c85d85d0372fb0de219b Reviewed-on: https://gerrit.libreoffice.org/23829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04unnecessary reallocNoel Grandin
Change-Id: Iafd6495a8b6a2b371cf004e4383ed92ac6ae4bd2 Reviewed-on: https://gerrit.libreoffice.org/23760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-29Avoid reserved identifiersStephan Bergmann
Change-Id: I210133e82bc72dcb89da5f7700314ddcf6bee269
2016-03-18Remaining argument from loplugin:constantparam in ucbKorrawit Pruegsanusak
Still one remaining after b47cb646ff2a62fcd3fac0e453a7261bbaefbcb7 Change-Id: If1dfaa6bbc9f8582f7b2a7dab49815a0a4c6a7b8 Reviewed-on: https://gerrit.libreoffice.org/23355 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-18Restore WebDAV credential dialog functionality...Giuseppe Castagno
...that was broken in 3d264450989cecdc59a2e64f46a0328432ba0d08. Change-Id: Icd601196867258490f9241efc3d0d6ebea334a2a Reviewed-on: https://gerrit.libreoffice.org/23353 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
I removed OSL_DEBUG_LEVEL > 1 conditionals and the g_warning() with SAL_INFO() and SAL_WARN Change-Id: Icb4ab72245111b52c59a47cc659dfdb79d5690ee Reviewed-on: https://gerrit.libreoffice.org/23232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14inline some use-once macrosNoel Grandin
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966 redundant static keywords removed 6Wastack
Change-Id: Iaf034f3b2282a973f6503edea41cb3184543fb11 Reviewed-on: https://gerrit.libreoffice.org/23133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: Ic2c7cc2a78e8e58c3ca28acd9b6a35ddaceeab60
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I4d0dc49e44b9e9f7504008ea1d10876cd80e76f8
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I6c60905541de56229bc26e9dc6e589d4099e9266
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I75158ff7588452f38306b0bed351a6532b9c8d1f
2016-03-10Make CppunitTest name match *.mk file nameStephan Bergmann
...so "make CppunitTest_ucb_webdav_local_neon" works as expected. Change-Id: Iecdd5d1ad19be4789bca60d455a3dfdd8fee9cb3
2016-03-10These tests can just derive from plain CppUnit::TestFixtureStephan Bergmann
...and then no longer need to override any base class setUp/tearDown Change-Id: Iaea19dfb341325bb45062d0ac0b5fa1eed0d34e0
2016-03-09loplugin:constantparams in ucbNoel Grandin
Change-Id: I6b925336b13404ccf0f78f194bd3488a22f99b97
2016-03-08follow the boost lib naming scheme for DateTime tooDavid Tardon
Change-Id: Iae7967bd5f161ecbe888824a4bcb9b87ec8d947a
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07loplugin:unuseddefaultparamsNoel Grandin
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:stringconstantStephan Bergmann
Change-Id: I1a594a3d62790125244d221aeaa6d989adf30d97
2016-03-03ucb: replace boost::bind with C++11 lambdasMichael Stahl
... and remove now unused comphelper::TNamedValueEqualFunctor. Change-Id: Ia6cac4ae4e34d2ba134e2f2a4a5b4daea58bf0b3
generated by cgit (git 2.34.1) at 2025-01-16 21:58:54 +0000