summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)Author
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-20java: remove some unused codeNoel Grandin
Change-Id: If1cdc67535b11d9309503b14ffad2aa3718661c6
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-09loplugin:staticmethodsNoel Grandin
Change-Id: I2177e424d54dc2b5e26b7bbfe073b524e9cc5bab Reviewed-on: https://gerrit.libreoffice.org/15187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-07cppcheck: should be passed by referenceCaolán McNamara
Change-Id: I3d606615769f70ed29884e4c83164ccf15478132
2015-04-07loplugin:staticmethodsNoel Grandin
Change-Id: Id3d6b50e07ea0850af18ab9bdadfffe0e4602aab
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-01Add support for cppu::UnoType<void>Stephan Bergmann
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann
Change-Id: I8d1a4fda1cdd679f20de37271f7b832da4fb0c9a
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: I4df86baf0106283c78942c40a4b5830dd9c91195
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Ibd269ae3147ce95f3f093e10ab736e8287e7098c
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I6a27fd990895ff36b35d2de6278ca0416e6c00f7
2015-03-24loplugin:constantfunction: variousNoel Grandin
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-17Fix various XServiceInfo implementationsStephan Bergmann
...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-04V813: Decreased performanceCaolán McNamara
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-03Improve loplugin:passstuffbyrefStephan Bergmann
Change-Id: I88ab4c51ff59312127681d3087d22b9c79192b94
2015-02-23file UCP: Ensure myLocalTime is initializedStephan Bergmann
When a file's time is epoch (1970-01-01 00:00:00, i.e., TimeValue temp is all zero) and the TZ is UTC or westward, osl_getLocalTimeFromSystemTime returns false and leaves myLocalTime uninitialized. That e.g. confuses getModuleByUrl (scripting/source/pyprov/pythonscript.py), potentially re-loading a Python script with epoch time (as happens e.g. for the share/Scripts/python/ files in an xdg-app installation of LO) every time it is accessed, falsely assuming it has changed on disk since last load. Change-Id: I8d4228feb28e2697a7021e3488ae2c09e8439ed8
2015-02-21Typo: trough->throughJulien Nabet
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
2015-02-10drop some unbuilt test codeCaolán McNamara
Change-Id: I7e0651ccb248034bafffb1c46e6266fa396eede1
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I2f0cbeebce5d3bb087128bae32816a89f1f1d222
2015-02-05try to avoid overflows in some compare functionsMichael Stahl
Change-Id: I6144d7d6527dc401b7f1b577d1a227361e39e7bb
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: ucbStephan Bergmann
Change-Id: I07c4b9b4bd61611ac11de6c70a0ca1c89cd10b3d
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b Reviewed-on: https://gerrit.libreoffice.org/13967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-15rhbz#1163106: tdoc_ucp: fix life cycle of OfficeDocumentsCloseListenerMichael Stahl
The tdoc_ucp::OfficeDocumentsManager lives until the service manager is disposed on shutdown, but if the database stuff isn't disposed in due time then a document may call the notifyClosing() on the listener after the OfficeDocumentsManager dies; probably something is leaking the ODatabaseContext... Change-Id: I59662b910589d7270697452b2f4ca6c960d22f22
2015-01-12java: simplify sleeping and waiting in testsNoel Grandin
- remove the SHORT_WAIT test parameter, no-one is using it - inline the various independent shortWait() methods - use the util.utils.shortWait() utility method everywhere Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
2015-01-02Fix simple typos.Andrea Gelmini
Change-Id: I1fdbe47ed7a6e05d2cf20f4c296bffad4bbc6599 Reviewed-on: https://gerrit.libreoffice.org/13719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-20onedrive: Improve fallback dialog and instructionsAdolfo Jayme Barrientos
Reviewed on: https://gerrit.libreoffice.org/13500 Change-Id: I95df1d1b5589f89bfaa48c0833d92e3225b497a6
2014-12-19ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I29c99157e9698e4af1d42a5c708cf4ec4753cf34
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Ie889b3e74160e9ba121ba8351d9e12f6d273c573
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15OneDrive authfallback request is now issuedMihai Varga
Change-Id: I9ee1f087322d80cbdf8ca369fccb6b6b0336062e
2014-12-15OneDrive binding settingsMihai Varga
Change-Id: I72c97931098c1a029d39532e3433c0aeaba73e3f
2014-12-12ucb: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I6839e032c981fcff472f29c51c84503d6370fd1c
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18Need <cppuhelper/queryinterface.hxx> here, too, I assumeTor Lillqvist
Change-Id: Ic91023c0a5a70072fcffaaa5e16fc2e415c2e1ee
2014-11-18Need <cppuhelper/queryinterface.hxx> nowTor Lillqvist
Change-Id: Ib5683580273430a61e4daff84cd03b3b559fac0f
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-18java: make fields final where possibleNoel Grandin
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06coverity#983989 Uncaught exceptionCaolán McNamara
Change-Id: I7508ee67a10b43686600b41dd58c1a8a5aa90c51