summaryrefslogtreecommitdiff
path: root/ucbhelper/source/client
AgeCommit message (Collapse)Author
2016-02-09Remove excess newlinesChris Sherlock
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-17use unique_ptr for pImpl in ucbhelper/Noel Grandin
Change-Id: Ibae75fc4d843bd38179d4c7afc6ddb532835c7a6
2015-11-15use initialiser for Sequence<OUString>Noel Grandin
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11com::sun::star->css in ucbhelper/Noel Grandin
Change-Id: I01e3046caefdcfbf630f4a794f12e8890be6db40 Reviewed-on: https://gerrit.libreoffice.org/19902 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I3003db8a411740db48c2e0c6ecd81a7fd9209e6c
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I970a03643f3c460110bc7caf1dc33c6dde1d78d5
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-05loplugin:stringconstantStephan Bergmann
Change-Id: I68c63d560cfd7ec82802cd3f073cdd0544cff99b
2015-10-05tdf#82744: fix WebDAV lock/unlock behaviour - part 3Giuseppe Castagno
Changes done to the code in sfx2, ucbhelper, ucb, unotools in no particular order - add method helpers to call the ucb lock/unlock - add lock/unlock 'real' management - make DateChange property retrieval working for WebDAV as well - add check for changed content of a WebDAV file, in order to reload it correctly when 'Edit Mode' command is activated from GUI - Unlock WebDAV file while saving only if explicitly enabled Needed in order to avoid the small window of file unlocked state that opens while saving a file. When saving LO actually does as follows: - unlock the prevoius version of the file - prepares operations to save the modified version - lock the new file - save the new version - the lock method is enabled if the DAV resource supports it. In case the lock is not supported, for example example DAV with lock disabled, the lock method is disabled. Exception: when the resource is first created and the lock is not supported: a lock command is sent anyway, because if the resource is not yet present, there is no method to detect the lock/unlock availability in this case. - cppcheck:noExplicitConstructor Change-Id: I0aa876c4e3364d86e5740977b97f3db9a01e4491 Reviewed-on: https://gerrit.libreoffice.org/17189 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-09-30Fix typosAndrea Gelmini
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34 Reviewed-on: https://gerrit.libreoffice.org/18990 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-15Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a Reviewed-on: https://gerrit.libreoffice.org/18580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann
Change-Id: If38423c29c7a9f4d740c244d350b83c471523797
2015-08-18Remove newly unused ucbhelper/fileidentifierconverter.hxxStephan Bergmann
Change-Id: I7c272383ecb115e19699ed96bf5622d979403a01
2015-08-18Remove obsolete getLocalFileURLStephan Bergmann
...vnd.sun.star.wfs is long gone Change-Id: I64da15a6c16e429aeda57c435e353891fb28f04d
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2014-12-18ucbhelper: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: Id5832f8ca20f5ff3179a25bc3c28be7b9fde5bfb
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-17Improve exception msgStephan Bergmann
Change-Id: I4edbecd0ca3006c24fd5920a9ef9ad1fdc6016fb
2014-09-12bug wrong order of test cause out of bound access.Norbert Thiebaud
Change-Id: If9c497473bc163677175b0fda1f3a8975cceb3dd
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-04-18Typo: s/cant/can't/Tor Lillqvist
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-17coverity#1202901 Uncaught exceptionCaolán McNamara
and probably gadzillions of other uncaught exception warnings this exception can't actually be thrown because all possible InsertOperation conditions are already handled. Change-Id: I176c5e253e8b1092a060fc066c2e03dae3cea343
2014-04-10warning C4101: 'e': unreferenced local variableMichael Stahl
Change-Id: I3fb8a4f2854fb034d6b184ee46c04e8a8d03ca6a
2014-04-04coverity#707355 Uncaught exception, help coverity out hereCaolán McNamara
hopefully loads of other ones too Change-Id: I8445602adc76205448926efe23c9770cef0eb5dc
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-09coverity#1078944 Uncaught exceptionCaolán McNamara
a false positive but easier to fix it by helping coverity out for any other cases it triggers Change-Id: I7c61298a95fa427d279599110b7aab263d039c5d
2014-03-08de-macroize ucbhelper commandenvironmentNorbert Thiebaud
Change-Id: I39c7ca30d483dab3eae0f39be15ef9586aef7851
2014-03-08de-macroize ucbhelper activedatastreamerNorbert Thiebaud
Change-Id: I55bbce1f8e3c0dcd92d0e2af03d7be5c7ac910c0
2014-03-06use WeakImplHelper for ActivaDataSinkNorbert Thiebaud
Change-Id: Ife32157ff876a0860b3920cadc24b7888200796b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-03-05kill XINTERFACE_IMPL_2Norbert Thiebaud
Change-Id: Ic735b7d6ddfaacab9af7405e4dacc62f818bed8c
2014-03-05de-macroize XINTERFACE_DECLNorbert Thiebaud
Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe Reviewed-on: https://gerrit.libreoffice.org/8454 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26Remove visual noise from ucbhelperAlexander Wilms
Change-Id: Id9396eca64069f2f0ba636ac9efa090f121afdd3 Reviewed-on: https://gerrit.libreoffice.org/8330 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-17ucbhelper: sal_Bool -> boolStephan Bergmann
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-01-28bool improvementsStephan Bergmann
Change-Id: Ia9f1b1d1a0fea7dbda8e2a322aaf86899bfd7fd3
2013-12-20typo fixesAndras Timar
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-07remove unnecessary use of OUString constructor in UCBHELPER moduleNoel Grandin
Change-Id: I3e3cfc69c14a300f330264ae40c135e8135adb97
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-09-04WaE: Unreachable code: Use SAL_WNOUNREACHABLE_CODE_PUSH/POPTor Lillqvist
Cleaner than my first attempt. This reverts commit 9c0ba0ba41cb3b814cc8bf7a33abf1245d4b241e. Change-Id: Iec9da427ab2a92cb0765f73af14d83a37f765290
2013-09-03WaE: Unreachable codeTor Lillqvist
This time noticed by the linker when doing link-time code generation (!). Change-Id: I9600571bef2a8cc30b2e28dd52b01633bab55f32
2013-09-02CMIS: add document ID when saving.Cao Cuong Ngo
The document ID is needed in case the get object by path of the CMIS document doesn't work (like Google Drive) Change-Id: I151d5433a19caeaf4a542b69cd9e95dde58722e7
2013-08-21finish deprecation of O(U)String::valueOf()Luboš Luňák
Compiler plugin to replace with matching number(), boolean() or OUString ctor, ran it, few manual tweaks, mark as really deprecated. Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-06-29remove OUString wrap for string literalsThomas Arnhold
For some functions and all kinds of Exceptions. CannotConvertException CloseVetoException DisposedException EmptyUndoStackException ErrorCodeIOException Exception GridInvalidDataException GridInvalidModelException IOException IllegalAccessException IllegalArgumentException IllegalTypeException IndexOutOfBoundsException NoMasterException NoSuchElementException NoSupportException PropertyVetoException RuntimeException SAXException ScannerException StorageWrappedTargetException UnsupportedFlavorException VetoException WrappedTargetException ZipIOException throwGenericSQLException throwIllegallArgumentException createInstance createInstanceWithContext forName getByName getPackageManager getPropertyValue getUnpackedValueOrDefault getValueByName hasPropertyByName openKey setName setPropertyValue supportsService bash command: for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx' | cut -d ':' -f1 | sort -u | xargs sed -i -e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g" -e "s/\($i.*\)\"+ /\1\" + /g"; done Change-Id: Iaf8e641b0abf28c082906014f87a183517630535 Reviewed-on: https://gerrit.libreoffice.org/4624 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-05use uno::Reference#clear() method...Noel Grandin
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e