Age | Commit message (Collapse) | Author |
|
This reverts commit d35840a2111beafe018851314a624e268e3cde6a, now that
43aef04d77aafb9d055957642e62b559231f3711 "Reliably wait for soffice to
terminate" makes sure that no soffice-related processes are left behind by
UITests. Using PR_SET_PDEATHSIG had the following drawbacks:
* It defeats debugging if a runaway process is forcefully killed by the test
framework. (And there are already higher-layer mechanisms in place for the
reliable termination of runaway tinderbox builds, see the commit message of
43aef04d77aafb9d055957642e62b559231f3711 mentioned above.)
* It is brittle in that it can terminate soffice-related processes too early, as
the signal is sent as soon as the parent's thread that spawned the child (and
not the parent process as a whole) terminates.
* It is Linux-only.
Change-Id: Ia07f5dbaafc824bad0dfbdb1a2aabe6d5508741b
Reviewed-on: https://gerrit.libreoffice.org/80186
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...to avoid leftover soffice-related processes (oosplash, soffice.bin) from
UITests, whose occasional presence on tinderboxes is discussed in the comments
to <https://gerrit.libreoffice.org/#/c/79854/> "uitest: make child soffice
process die when parent dies". Should sucha an soffice-related process fail to
terminate, the UITest will now fail to terminate too, and (a) a developer can
debug the hung processes or (b) a tinderbox can reliably kill all processes (cf.
<https://gerrit.libreoffice.org/plugins/gitiles/lode/+/
bea0738dbadfe8784e5d3c00f533acf101db4e7e%5E%21> "tb_slave_wrapper: trap signal
and kill -9 everything"). This is in line with the waiting in tearDown in
unotest/source/python/org/libreoffice/unotest.py, and with the corresponding
behavior of C++ and Java test frameworks in unotest.
Change-Id: Ieb5c48964428bc05fa8c0f83af9426641d6df693
Reviewed-on: https://gerrit.libreoffice.org/80175
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...which had gone missing with 98cbfb087eed0d1defa6ef26385fcf47f95c05fc "uitest:
kill the LibreOffice instance if it ignores terminate request".
(None != 0 is true, so there is no need to map from ret_attr to ret, and that
code can be cleaned up a bit.)
Change-Id: Ic5e429d61a10a2bbd5c28aeee9d8465cb05c1e4a
Reviewed-on: https://gerrit.libreoffice.org/80147
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
using PR_SET_PDEATHSIG.
Note that this can only be called by the child process in question, so
we have to pass a new command line argument down to activate it.
And we have to plumb it through the wrapper oosplash process.
I wonder where else our testing infrastructure could benefit from this
Change-Id: I55e8e9f7f4e6cc415046df04c804e51475b8a4c9
Reviewed-on: https://gerrit.libreoffice.org/79854
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I545154bddfd29194630d744b4aa4f5c385321531
Reviewed-on: https://gerrit.libreoffice.org/77138
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5496bf0bcce442c60d2ecd4207734d0e8b17935b
Reviewed-on: https://gerrit.libreoffice.org/61026
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
This is similar to gb_JunitTest_DEBUGRUN, i.e. allows running soffice in
gdb, and then connecting to that soffice from the test, instead of
starting an own one.
Change-Id: I023d6b0ede146837666c946cb865feb9046e5a94
Reviewed-on: https://gerrit.libreoffice.org/42756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Icc63deeb182f0c380780332793a3af1f7a51577b
|
|
Change-Id: I419dd9311bc4fbb9fcd2e73a83c5272ecbec242d
Reviewed-on: https://gerrit.libreoffice.org/38680
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: If4726804c2b967582cbf1a4e816c1c7bee01aeeb
Reviewed-on: https://gerrit.libreoffice.org/38626
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I7efdbc1278d27ed75d8e48a35a9fac0358144214
Reviewed-on: https://gerrit.libreoffice.org/38548
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: If24a995fe1e174d3ffc531021b290a455ae28512
Reviewed-on: https://gerrit.libreoffice.org/35729
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I594779ad7b3fe97a1055ad9c999fe6be126875fb
|
|
Seems that under really high load 5 seconds is not enough.
Change-Id: Ia0b2f7ff7bf469d188c9ceea0edc7f1d2d4002d3
Reviewed-on: https://gerrit.libreoffice.org/34666
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I90af25c89cb33d5dc75f73a3b4918605d47474f1
Reviewed-on: https://gerrit.libreoffice.org/34665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: I29296c90811f9a910c505a9dcd4db7f13a6130b8
Reviewed-on: https://gerrit.libreoffice.org/34664
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ib889604f1b6d11e874c27fb5d2757a792a687366
|
|
Change-Id: I941f5ba20a7e3176e8d9f5f64c64ada6551d533a
|
|
Change-Id: I1600a1e5d79b100a6469d9fa52c67e9e374258a2
|
|
Change-Id: I8180d131c2f4dbc9759ca1166192970bc06231c0
Reviewed-on: https://gerrit.libreoffice.org/32280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Idac32c3d788714533ee760782d2b6a328262f3f8
Reviewed-on: https://gerrit.libreoffice.org/31996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Bunch of these were setting C++ or Make modes and icky tabs...
Also, reportedly Emacs can figure out to enable python-mode
automatically.
Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
|
|
Change-Id: I03f78e592f3f182f34ea05829131357cabcc4c7b
|
|
This is the third part of the UI Test tutorial.
The code in uitest/libreoffice is generally useful UNO code that
allows to interact with LibreOffice. This code should be independent
of the UI testing framework and provide external developers a
helpful starting point to writer python extensions.
Change-Id: Ia1429577affd98dcf3f1aee3da3a7256499a1c78
|
|
Change-Id: Ic5d08f08c1fccc74be09cea7887d3acb910e7636
|
|
Change-Id: I1065acf0f2406881532e75459bfddbdb7967ad8b
|
|
Change-Id: I23fe7563b3d0fe8084541d702583bc38997413ac
|
|
Change-Id: I47c69878ebaa834eb75208ce8e5c26544e3e62bd
|
|
Change-Id: I8d6c2d9f2a9386d8eec64780b7d197c9675764aa
|
|
The uitest/uitest directory will be used for the actual uitest
framework.
The libreoffice directory should contain any common LibreOffice related
code.
Change-Id: I3f6394ff4be83b89a8764eab10a154e755237d35
|