Age | Commit message (Collapse) | Author |
|
Change-Id: Iaa329dff61db894e7d5fecd840e785a53a48b26f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160889
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Use Python 3.3's 'yield from', which should be OK, because the
baseline rhel8 has Python 3.6. If needed, older Python could
use replacement like this:
for dialog in self.wait_and_yield_dialog(event, xDialogParent, close_button):
yield dialog
Change-Id: Ic70bdf19fed730e41b7ce2868990ec88423eab33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160352
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Unneded since a4a1f2ecee2e7b1d50e0065e25090e262863e1c4
"Disallow crash reporting in UITests"
Change-Id: I661b6111bd5142e67ee73a82c0777771e7651300
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160324
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
After 8c39af455c4dee53c6f3c918b0497f80a4fb0f21
"uitest oneprocess mode: default to this and clean up one test"
Change-Id: Ib6e0fc3de2997beebc650253ae3ea19a3314ae09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158844
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
to make it easier to debug cases where the event.executed flag is not
sufficient to indicate that the dialog has finished opening
Change-Id: Ibcbd089372e47908e3692d452f4064edbc7f788d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158751
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... after commit 0d21e1075f0288a007cb427ce508d6fbbf8503dd (uitest:
add signal_handler function, 2023-10-04), which added handlers
unconditionally, for signals unavailable on Windows.
Change-Id: I8b177c4110f869781b2501ee6f15ae7ff4862a94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158050
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I7acba74ef0717bc07a675be17fc1909680138f00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157019
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Add the option to include the load properties
when invoked load_file function.
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I27cb31e2470bc76bcc5b760661e50f00fc334d64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157567
Tested-by: Jenkins
|
|
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I87098a438d476529aa25b6608408d07bbc98ce0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157557
Tested-by: Jenkins
|
|
install signal handler to analyze if the
soffice bootstrap has some issues.
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change-Id: I8b05b9c24bf531f4162554433180d80526cb2983
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157144
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157518
Tested-by: Jenkins
|
|
Before: 0m54,459s
After: 0m41,705s
Change-Id: Ie4cccff79b0df3bd4f01c10414c61ca46cade5d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157338
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Before: 7m37,421s
After: 5m29,121s
Also UITest_demo_ui: 1m43,126s -> 0m55,159s
Change-Id: Idf705fdcdb62e27b4d42287f4c95fcd3893cdd4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157106
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ieabf4d3173a7ce985a9164db8b2de4c8b6d0da36
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157029
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
We are not ready to get rid of it (e.g. undo does not work when it is
hidden). This flips the default introduced in:
commit e9cc014be4150a5adc9950f366c9bdfa50420dcf
Author: Khaled Hosny <khaled@libreoffice.org>
Date: Tue Sep 12 16:41:37 2023 +0300
starmath: Hide editing window by default and add a menu item to show
Change-Id: If84b25d186c8d133a9fa5cfc0c3d91162c66b389
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157004
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
We are enabling inline editing bu default, so this window is of no
interest by default.
Change-Id: I66fe988790fe4f174f6cb4f691af69888b0b05b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156852
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
Choosing which code path based on which widget has focus is not a very
good idea, and leads to unreliable UI tests as each code path inserts
the text slightly differently (one code path inserts plain text then
parses the whole equation again, while the other parses the new text
then inserts the parsed node directly).
Change-Id: Ib2ca942c537e466f6ff100be7f95adaead99f1d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156578
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
Add a sub case of Detect special numbers for import CSV (SC_IMPORTFILE),
paste unformated text (SC_PASTETEXT) and text to columns
(SC_TEXTTOCOLUMNS). Following cases are treated:
- If "Detect special numbers" is true, then "Detect scientific numbers"
must be true and all special formats are treated (date, time,
scientific notation) in addition to basic decimal numbers.
- If "Detect special numbers" is false and "Detect scientific numbers" is
true only scientific notation is treated in addition to basic decimal
numbers.
- If "Detect special numbers" and "Detect scientific numbers" are both
false only basic decimal numbers are recognized as numbers. It is the
new case treated by this change
The new option bDetectScientificNumber is append to ASCII options
Change-Id: I73dff9f75d2c7b07ce155daa29dcc4ca9f288664
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152072
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Execution time changes:
- UITest_writerperfect_epubexport: 20,023 -> 6,083s
- UITest_svx_table: 15,214s -> 14,378s
- UITest_cui_tabpages: 13,561s -> 12,503s
- UITest_math_demo: 19,737s -> 13,578s
Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
UITest_writer_tests6's
tdf124675.tdf124675.test_tdf124675_crash_moving_SwTextFrame_previous_page
failed in the SW_FORCE_FLY_SPLIT=1 case, since the current page after
typing was 3, not 2.
It seems this change is wanted, since the total page count increases by
2, so it's consistent that the current page increases similarly with
typing. Also, repeating the UITest in Word (after positioning the cursor
at the top paragraph in the document) also produces page 3 as the
current page.
Fix the problem by locally enabling split flys for this test and then we
can assert that we match Word. This requires a new context manager, but
that set_config() is really similar to other context managers in the
class that return no value.
The original purpose of the test was to make sure we don't crash,
anyway.
Change-Id: Id0dfde23a8726c8799950a6e4fdd1d85f135eafc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149315
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
A uitest suite may have several testcases and we spend a lot of time
spinning up a new soffice process for each testcase, while we typically
do such initialization only once for per testsuites in the cppunit case,
slowing down uitests.
The problem is that this way today's uitest cases don't really have to
clean up after themselves, since they know that the next testcase will
gets its own clean state (back to the start center).
Fix the problem by adding an opt-in way, so that a uitest suite can
declare that it's safe to run the entire suite with the same soffice
process. To be more specific:
- add a new --oneprocess for test_main.py, which will create a shared
connection to a soffice process
- UITest then closes the document (returning to the start center)
instead of disposing the component in the oneprocess case
- UITestCase won't create its own soffice connection in the oneprocess
case
- add a new gb_UITest_use_oneprocess method to gbuild, to request this
new, faster behavior
E.g. on my machine this means UITest_sw_styleInspector takes 26,345s
instead of 40,652s, probably such a speedup is worth the added
complexity.
This works nicely when the testsuite is a list of simple/boring test
cases, always loading one component/document at a time and always using
close_doc() to close it. It may not be safe for testsuites that do
something special (they may fail or hang), we'll see.
Change-Id: Ib14439d48aa547c92652245ee1c0cf37d2d7b6e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149134
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I4f5d0290e522fa6f3faccd26f74540abf848629b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147153
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Otherwise, changing it in one test might affect other tests
Use @contextmanager decorator to change it back to default 'Inch'
at the end of the test even if the test hits an assert
Change-Id: I1e7b35019cd19b490aa619c0a866bb9f93820950
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146583
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75
"uitest: introduce wait_until_file_is_available" as a blind
fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91
It turned out the root problem was caused by another test
and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385
"uitest: Always change doc info setting back to false"
Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The background tiling images become larger when
opening and closing Area tab: reopening the image
properties in the Area tab shows that the Width
and Height got reset to the original values of the
image.
Regression from commit 686349476e03f951f4a9ff9755b9f71951b64ea5
"[GSoC] Move all fill style tabs inside area tab".
Change-Id: Ibc4dfd73dedd81b1b7fe17574198dd4999aab967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143819
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I5943ec84a0b5ed6f44af9e3f972626813987a1cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142615
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
I used pyflakes to check for any unused imports and variables in python scripts under sc, sw, uitest directories, and then removed the unused imports and variables
Change-Id: I0690c9366087dc602ee8ea169bc1c9063033fef6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141421
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Use Markdown markup instead of reStructuredText for
uitest/packaging/README.rst
Change from reStructuredText to Markdown in setup.py is done according
to this guide:
Making a PyPI-friendly README
https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/
Change-Id: I12cbde53518d7ceadec034827d8cb00380df1547
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138555
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: I50d6e29c34e3cf72cdf0afc9f118fafc3c144eaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
and make uno:ElementsDockingWindow open the respective sidebar panel.
Change-Id: I9736d6804c579b83404636d5e327c49c2fdeb914
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138458
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
in preparation for https://gerrit.libreoffice.org/c/core/+/135110
Change-Id: I0bfa8ddd9b814239a0e284b1b219cf760ee34826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135733
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Allows to send individual images over the wire in lok case,
instead of sending full canvas at every scroll operation.
The control's horizontal and vertical modes (when it's docked to a
vertical or a horizontal parent window side) are now identical.
Some TODOs:
* Re-implement a11y - that needs to be implemented on IconView level;
* Make sure that sub-pixel positioning is not used when creating the
elements icons (makes elements look a bit slim on Windows);
* Maybe restore mouse hover indication; in non-GTK case, a call to
m_xIconView->SetHoverSelection would suffice in SalInstanceIconView.
Change-Id: Idbc35f4e38e2b49fd0848a96da557fa2c1a1f6e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134761
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... to not break on e.g. 4.0
Change-Id: I5b93f6138a5ca85891d2d60beca098b6bcfc15d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134435
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I7d0624f63e5d123d5013c14aa0f23355cd42dd0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134466
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9fe1a349a73790e7fa1c503112a27f76d238c0c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131538
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I7347619ce190778ca12e5bb56c23600efad3af95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131311
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
besides, fix it and remove duplicated tests
Change-Id: I15c6696c6cdd1c7e03647e105d8caf268555018a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131310
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I778f5f309495ee3806ed15dfb753bad2683f360d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131117
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Revert 9158d2d2f19cf7bccba12d2ad4cb340e882b51cc
< blind fix for UITest_impress_demo failed >
and 99d2ee15ad6fae7073a53f7df8868300328a36e7
< blind fix for UITest_impress_demo failures >
Instead of asserting the shapes' properties directly,
Use the Position and Size dialog
Change-Id: Ie9aec0dbd1f1fc2ccab0993b428c8ac17938b3b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130724
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
For export - import tests
See https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91
Change-Id: I3c2537a43cc69067355f18162d6463e268420090
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130530
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
No need for MAX_WAIT anymore
Change-Id: Ia063068bd7c47f79d8991922086c22250c01f77d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130527
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
it does nothing
Change-Id: I6fa67aa42b1de6199cbb49100624826f5b3b77d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130524
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... and close_button is empty
This was introduced in
2021-06-29 15:35:55 - ff641dc9e4d2aff1d1cbe4425cd9c03a2edc847e
< uitest: try harder to close the dialog when it fails... >
and later reverted in
2021-07-02 20:41:50 - 4f8748fc973acdb67790ff048a247717afa9b9c7
< Revert "uitest: try harder to close the dialog when it fails..." >
Reintroduce it again and also fix the problem why it was reverted.
Without this fix, it will hang when an assert is triggered inside
a dialog when close_button is empty
Change-Id: If643caea61139f69f72c9b429aaad5b9d7d78c72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130506
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I8406bdf375cf83d504e45a5c8f27ce2ceb1f9c51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130190
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
For example hyperlink dialog does not have numeric ids for tabs.
Now the rule matches both integers and "common identifiers" as per
https://textx.github.io/textX/stable/grammar/#textx-base-types
Parent argument was removed as it does not seem to be used and
it was empty in the case of the hyperlink dialog, causing the DSL
parser to fail.
More work is needed as self.xUITest.getTopFocusWindow() in a
hyperlink dialog opening test does not contain the child "tabcontrol"
and thus it errors out.
Change-Id: I1637f7300884881ee4d869e8f04700e56935f2d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130111
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
Change-Id: I9b476336349b67d3d9bb149d4ad4824740797eb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129370
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Rechecking again, I found out that the encoding problem described
in tdf#95217 was actually fixed by the same commit that fixed
tdf#146048 ( 3392f567be8d52804b187b0bced47204ef38fa3c
< tdf#146048: detect UTF-16 without BOM > )
This commit partially reverts d7fb6b22cf7e66eb2594001cc42c6bff8b5a49e2
< tdf#95217, tdf#142600: sc: Add UItest > since we don't
have to create any http server to reproduce the issue
Change-Id: I2f0177f8450f77de5df756354d48505193a6ba3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127742
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
for that, launch an http server in a separate thread
Change-Id: I9d78c9a4349620a9de31b3963f2a31ff1d354f86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127592
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
<@x1sc0> _rene__, I guess we could use assertAlmostEqual with delta=1 there,
but maybe once we add it, the next assert also fails for you?
Change-Id: Ic64641ccdf9ca721997b4a842b646cf4b9e30f16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121641
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: René Engelhard <rene@debian.org>
Tested-by: René Engelhard <rene@debian.org>
Tested-by: Jenkins
|
|
Change-Id: Id3355be0e763217a4915b53d22220c30536415e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
also fix the license header
Change-Id: Icc759c695f192e1768210f66bff57a936df5fc4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126219
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|