Age | Commit message (Collapse) | Author |
|
Change-Id: Ie75beb4e282a4d1b784a5847262e39cf9c851527
Reviewed-on: https://gerrit.libreoffice.org/29440
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
|
|
Change-Id: I8f7fb8bba65f99732bb172b45e309868047f545c
|
|
find methods with default params with only zero or one call site
Change-Id: Ie5b30f60e9fe00ba1acf0dfc79b005ded46f05a0
Reviewed-on: https://gerrit.libreoffice.org/27512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Iac3011e99956d1ebb288184fd93555973c76ccdc
|
|
Change-Id: I112f5e7c845184b9aa5285ecfa40b5bbb34ffde1
|
|
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough. (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)
Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.) C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.
Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
|
|
Change-Id: I02e177e07fc5fef225351392c9cd5743a2212967
|
|
Change-Id: Ic3c60325a722422912d06fe21d072c5f5c4bccb1
Reviewed-on: https://gerrit.libreoffice.org/23322
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I1dd71d6e35ac2dc5f27a11a3dd269247b1b35d39
|
|
Change-Id: I9c2e0a10699580026fbf38f0c857ac148de74f9c
|
|
...to make it a better replacement for SDK's regcompare
Change-Id: I7b5eee3d449b8dc7c03601083d06a6d13e4607be
|
|
Change-Id: I006e3c8f411b480917d9cfb9c4f3d082b79c833d
|
|
Change-Id: I06921ce068a3ffc9c1502326f03e9b13ee1c6ef6
|
|
Change-Id: I7c8f90ae3cb496def3bee9a8a84974dd63478af3
|
|
Change-Id: Ide3aec7a352786ed441be1f506a5cf488843ea29
|
|
Change-Id: I95f00b63f21b29bc3c22a4891ebc5668fed723fc
|
|
Change-Id: I36e2194c304adae5b5c3377519eccc5ef78fd9ea
|
|
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
|
|
Change-Id: Iae44d45d749c6f51be72c0b2d16639c7287c42b2
|
|
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
|
|
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.
So far, I have only run the plugin up till the VCL module.
Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.
Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
|
|
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
|
|
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx>
(and don't make use of it themselves), but many other files happen to depend on
it. Cleaned up some, but something like
grep -FwL sal/log.hxx $(git grep -Elw \
'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx)
shows lots more files that potentially need fixing before the include can be
removed from rtl/string.hxx and rtl/ustring.hxx.
Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
|
|
Change-Id: I8320f6f42d5579fbd09450ddca61c4c066de98e4
|
|
Change-Id: I81599570698eb92abf14fa6386d8545c2031e863
|
|
Change-Id: Ifef0aaae6208f18c1352fef7c471deb60a97820d
|
|
Change-Id: I55977c38578cb59deb195d91f8948da2e0905b6a
|
|
Change-Id: Ic672e75db4d7323760577b19490ffa28d38965b6
|
|
Change-Id: I11d92218c5e0678d497f8964723033e2bd8b3300
|
|
Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
|
|
Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
|
|
Change-Id: I6ff256e091770d67f98b1b6b8d447a22fd720d4e
|
|
Change-Id: I0a1fcebb268bea942d4bc2d6bf835c3ffb24df3e
|
|
...but is not, for performance reasons.
Change-Id: I2518eb1f1a2f84cfd836c390a418a2fcb516b82c
|
|
...in unoidl-read, although it would be better (but more expensive at start-
up) to check consistency in unoidl::Manager.
Change-Id: I5f5894fcd51af3aa999fe30621f52bfd11d0e610
|
|
(For types, only checks their syntax, but not whether they semantically fit in a
certain situation, e.g., "boolean" cannot be used as a base interface.)
Change-Id: I12f617e74ca13ce2afcec8f611bfdb4912c62960
|
|
Change-Id: I50227c41c5b4c5c410939ddfa078b996b5804965
|
|
This reverts commit d4810a814c7c7f3db2df15b62367bd1edc7040f6.
Change-Id: Ia062e070c7d7dac5cc4388d1c8e812fb97851d52
|
|
Change-Id: Ia80682aeb87225b9bde7398186e121b1d3bdc2ad
|
|
Change-Id: I5b362ad374dad5fd4a79b8a7706defb749e25eb3
|
|
Change-Id: I4afe86dc29788a7b2d2d9c438f182726f80b1cbd
|
|
Change-Id: Ic87cc3d968447051e52012e59d92e95280d9d35a
|
|
Change-Id: If5e8b90f32c167bafeb3649f4bc6c31198635947
|
|
Change-Id: I9a787065898004ece4bd55839c563b7395e3a314
|
|
Change-Id: I539ba11497a8c7384b5ca8ee4792548dca139811
|
|
Change-Id: I17379f596fd8b48bd1015538eacc5265cfa83a82
|
|
Change-Id: I587ef2c38fd9377eef2073a49cd8497b2bd4bf9f
Reviewed-on: https://gerrit.libreoffice.org/10076
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ibf78e5cd1620f0b61cae030e3870be4a6f87e71d
|
|
Change-Id: Ic6ad3e2c7f69dd123077a913f35f1971f1e8ca13
|