Age | Commit message (Collapse) | Author |
|
Change-Id: Ie6ed784bb9676b9de8a51762aa58d0c75e071cfd
|
|
Change-Id: Icee10aae97e9bcef7a3db7e966c1c4ef6780fc1d
|
|
and we can include a few less headers
Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
|
|
Change-Id: I2acc5cd6a57bb6a18f3f20177b3bcf2b8469a834
Reviewed-on: https://gerrit.libreoffice.org/14272
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
|
|
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
|
|
found by looking for unused parameters (in Eclipse)
Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
Change-Id: I449587dd8e6e625e886e4ffc6419c612adffcfde
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib4f262f4c8cffc9790001618ce8050eda75ae559
|
|
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
|
|
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
|
|
The PythonTest_dbaccess_python may fail in incremental builds because of
stale JVM path in workdir/unittest/user/config/javasettings_Linux_X86_64.xml
so it's better to use the fresh UserInstallation that is already passed
in from PythonTest.mk. To make that work, tolerate non-existing path in
SubstitutePathVariables::SetPredefinedPathVariables() at least when
running in the build environment, which is probably better than
effectively running with "/" as UserInstallation anyway...
This partially reverts commit 6dbb6275ebd1a4299099c3b6bc82ec4ee0e1fb86.
Change-Id: I4d42d53c049056590662828360c4ce5a29af0f4b
|
|
Thanks to Stephan for helping with the test environment setup:
sbergman@redhat.com: Do the same "set UserInstallation to user profile dir in
test/user-template" in UnoInProcess's setUp as is done in
test::BootstrapFixtureBase::setUp (unotest/source/cpp/bootstrapfixturebase.cxx)
for CppunitTests. That way, these tests all use the workdir/unittest/
UserInstallation concurrently, but they at least do not run into the gotcha in
SubstitutePathVariables::SetPredefinedPathVariables
(framework/source/services/substitutepathvars.cxx) to only set the
PREDEFVAR_USERPATH if PATH_EXISTS.
Change-Id: Iad058098a4c69cb567e2d3222af3c7d4ba993271
|
|
Change-Id: I73c4945dec1db4c206948f27ba3d19fa08eedd46
Reviewed-on: https://gerrit.libreoffice.org/11742
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.
Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I00b0f5624f5b03d53ff01660ca96dc355238b10c
Reviewed-on: https://gerrit.libreoffice.org/11685
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
|
|
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
|
|
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
|
|
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
|
|
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
|
|
.. actually thrown
Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
|
|
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
|
|
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
|
|
Change-Id: Ib04cadafab0f3d0cd9e6bb550d846a3a1ca8ea76
|
|
Change-Id: I7e619daf8743d3471ece72d81f6cf1bb61741646
|
|
To prevent rogue DocBasicItem objects (which are global objects) from
attempting to stop listening after the main app is dead.
Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
|
|
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
|
|
Change-Id: I2e8d8773703df67d090059be8bd9f3c7c7335f78
|
|
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
Change-Id: I34d98f086d1a041516174a26cbf37fc3d75da155
Reviewed-on: https://gerrit.libreoffice.org/8333
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic113564f9d30e59b0292d97318f15e9b04813ce3
|
|
Change-Id: I4ddad27d1e5a4de9885956b80db37f1e2f80a96e
|
|
Change-Id: I1250581d69423030bd0a93a1529458b8d424ce3e
Reviewed-on: https://gerrit.libreoffice.org/7329
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
For now, this is only implemented for the Writer RTF filter.
Change-Id: I0c7ae5b0e544bd4738652a38474f4d262ce65661
|
|
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
Change-Id: Ic4f2d36ce901b88b47b43fdebba197daf8bd0373
|
|
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
|
|
Change-Id: Ib550126d190e9436cf77e6c51eaf869ecd75a18b
|
|
Change-Id: I8fb3c25cd583b688104a0ee8620696e7b2958ab5
|
|
This also means that this code now gets bounds checked in debug builds.
Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
|
|
... it is an abbreviation of "Solar Version".
Since nobody can remember that:
remove OUTDIR OUTDIR_FOR_BUILD SOLARVER SOLARVERSION solarpath
and any mention thereof.
Change-Id: Idb3031c4f25a76ac05b22ec67e3ca3e1e8e512ad
Reviewed-on: https://gerrit.libreoffice.org/6515
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: Idd6420a855fec8b44fce6c0694b491d5f1eec95e
|
|
Change-Id: I4d2a93fa7395354fbf2893df9e254ab39fa365af
|
|
Change-Id: If1f41f9c25600199ba4fb8c2f75ddd7c8ce8c8b3
|
|
Change-Id: Iecc42e79b72e99f9222ba2419226b0f655a5af7d
|
|
Change-Id: Icbbe9096c60def4687b137a37bfe86c4de9b3f22
|
|
Change-Id: Id6d67f820226da15d90b95aa047767926583cc2e
|