Age | Commit message (Collapse) | Author |
|
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
Change-Id: I43d0881bbd2a99e018e027e166dcb7b0bffa5ff5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144395
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Temp files created from OTempFileService are always opened with StreamMode::SHARE_DENYALL.
So normally you can't open them twice.
But the JunitTest_unotools_complex unit test used to work because it exploited a pessimisation in OTempFileService,
where that code would close the file when we read to the end.
Which meant that the unit test could open it again and read it.
However, in
commit 218f36dd614cf828e949f605faaf6a6fd615da26
Date: Sun Jun 20 18:51:12 2021 +0200
tdf#135316 remove OTempFileService pessimisation
I removed that pessimisation.
So make the share mode a little more permissive.
Change-Id: I297a5c9c0505816b399fad29414077d03231ec72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118146
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Closing the temp file when we read to the end, and then opening
it again later actually is quite expensive, just leave it open.
This takes my load time from 22s to 19s
Also clean up the unit-test that failed, so that I can get
a useful stack trace out of it when something fails,
specifically
(*) throw an exception when something goes wrong, instead
of just writing a message to stdout
(*) don't catch exceptions and write useless messages - just
let the exception flow up to the JUnit handler, which will log
a nice stacktrace with line numbers.
Change-Id: If55c997f91eea4e703e92c632961d68b3453076d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117517
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
|
|
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
|
|
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13
Reviewed-on: https://gerrit.libreoffice.org/13405
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ic49f95117b54929f95984aff0f69e47b90daee7c
Reviewed-on: https://gerrit.libreoffice.org/13404
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ib0709da830788f8169282e45552af4fdc300ccf9
Reviewed-on: https://gerrit.libreoffice.org/13096
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
|
|
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
|
|
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
|
|
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
|
|
Change-Id: I1285c4e47ad381934adc3aea6671e7c95d820c39
Reviewed-on: https://gerrit.libreoffice.org/8334
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
|
|
|
|
|
|
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
|
|
|
|
2008/03/31 13:03:37 rt 1.2.24.1: #i87441# Change license header to LPGL v3.
|
|
2008/03/31 13:03:37 rt 1.3.4.1: #i87441# Change license header to LPGL v3.
|
|
|
|
2007/10/18 11:40:05 mav 1.1.2.1: #i47532# TempFile service
|
|
2007/10/18 11:40:54 mav 1.1.2.1: #i47532# TempFile service
|
|
2007/10/18 11:40:45 mav 1.1.2.1: #i47532# TempFile service
|
|
2007/10/18 11:40:35 mav 1.1.2.1: #i47532# TempFile service
|
|
2007/10/18 11:40:25 mav 1.1.2.1: #i47532# TempFile service
|
|
2007/10/18 11:40:15 mav 1.1.2.1: #i47532# TempFile service
|