summaryrefslogtreecommitdiff
path: root/unotools/qa
AgeCommit message (Collapse)Author
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-01-17tdf#97362 Convert unotools tempfile tests to PythonChenxiong Qi
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com> Change-Id: I43d0881bbd2a99e018e027e166dcb7b0bffa5ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144395 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-10-05unotools: test ConvertChar::RecodeString()Chris Sherlock
Change-Id: I1f82afe7e1ac57004723f67412f1a7007d107eff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140938 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-23Fix utl::splitLastFromConfigurationPathStephan Bergmann
* Fix regressions introduced with 5edefc801fb48559c8064003f23d22d838710ee4 "use more string_view in unotools". (Notably, misuses of two-argument std string_view rfind are something to watch out for, see the commit message of 93e234c45c62af9d57041de676d888f7695ac0e8 "Fix a misuse of two-argument std string_view rfind" for details.) * Bring the implementation some more in accordance with the documentation, by being stricter about handling invalid paths, and making sure to really assign all of the input _sInPath to the output _rsLocalName in case of an invalid path. * Only &...;-decode the names of set elements in ['...'] and ["..."], not anything else. Change-Id: If01f4b34af42b0a594994b732d54f26695329286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-23Add tests for utl::splitLastFromConfigurationPathStephan Bergmann
...documenting how the implementation is in discordance with the documentation for some corner cases and how things got recently broken with 5edefc801fb48559c8064003f23d22d838710ee4 "use more string_view in unotools", in preparation for an upcoming improvement of that function's implementation Change-Id: Ia47243c64b724009c5ed5eecb9d890820287e9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140492 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-11In O[U]StringBuffer, make string_view params replacements for OUString onesStephan Bergmann
...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads. That way, loplugin:bufferadd and loplugin:stringviewparam found many further opportunities for simplification (all addressed here). Some notes: * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer (as that goes via user-defined conversions through string_view now), which was most noticeable in copy initializations like OStringBuffer buf = someStr; that had to be changed to direct initialization, OStringBuffer buf(someStr); But then again, it wasn't too many places that were affected and I think we can live with that. * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to get them in line with their counterparts taking O[U]String. * I added an OUStringBuffer::lastIndexOf string_view overload that was missing (relative to OUStringBuffer::indexOf). * loplugin:stringconstant needed some addition to keep the compilerplugins/clang/test/stringconstant.cxx checks related to OStringBuffer::append and OStringBuffer::insert working. * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea "loplugin:stringviewparam extend to new.." Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-30fix failure in JunitTest_unotools_complexNoel Grandin
Temp files created from OTempFileService are always opened with StreamMode::SHARE_DENYALL. So normally you can't open them twice. But the JunitTest_unotools_complex unit test used to work because it exploited a pessimisation in OTempFileService, where that code would close the file when we read to the end. Which meant that the unit test could open it again and read it. However, in commit 218f36dd614cf828e949f605faaf6a6fd615da26 Date: Sun Jun 20 18:51:12 2021 +0200 tdf#135316 remove OTempFileService pessimisation I removed that pessimisation. So make the share mode a little more permissive. Change-Id: I297a5c9c0505816b399fad29414077d03231ec72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-21tdf#135316 remove OTempFileService pessimisationNoel Grandin
Closing the temp file when we read to the end, and then opening it again later actually is quite expensive, just leave it open. This takes my load time from 22s to 19s Also clean up the unit-test that failed, so that I can get a useful stack trace out of it when something fails, specifically (*) throw an exception when something goes wrong, instead of just writing a message to stdout (*) don't catch exceptions and write useless messages - just let the exception flow up to the JUnit handler, which will log a nice stacktrace with line numbers. Change-Id: If55c997f91eea4e703e92c632961d68b3453076d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-26New loplugin:stringliteralvarStephan Bergmann
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for details. (Turned some affected variables in included files into inline variables, to avoid GCC warnings about unused variables.) Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use char16_t string literalsStephan Bergmann
Change-Id: I0a8b577957ac1d4cad5fc1163f244012a8391a77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-21tdf#128276 Font names are not localized on macOS CatalinaTomofumi Yagi
1. We would like to call CTFontDescriptorCopyLocalizedAttribute function simply. We don't need to compare language settings of LibreOffice UI to OS lang- uage settings. This comparison was a way to save users from confusion, but it was bad idea. Because CTFontDescriptorCopyLocalizedAttribute function before macOS Catalina returns RFC 3066 bis as a language tag, but LibreOffice and macOS Catalina uses BCP 47 as a language tag. CTFontDescriptorCopyLocalizedAttribute function use the language setting for the operating system, therefore Users will change it if needed. 2. Fix font aliases on macOS Catalina I added some entries because I notice that those doesn't working with a Hiragino Sans font alias. Change-Id: Ie05a96f45cba13a19fcc1b855bd908f397e585a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/81145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-15tdf#42949 Fix IWYU warnings in unotools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also recheck include/unotools/* Change-Id: I3b8489aca69fbe80fa4a21748ac3c872d0d266c4 Reviewed-on: https://gerrit.libreoffice.org/71883 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2017-10-23loplugin:includeform: unotoolsStephan Bergmann
Change-Id: I019d7fefcd83b306a1847ae4a7ec581435412fc4
2017-10-03new loplugin:blockblockNoel Grandin
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-25Fix typosAndrea Gelmini
Change-Id: Ieea40e1b7282267157810f9f58ca083e68ae6715 Reviewed-on: https://gerrit.libreoffice.org/35659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-05java: combine nested if statementsNoel Grandin
Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-04-04Typo: creat->createJulien Nabet
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
2015-01-26don't strip font names of apparent script suffixes anymoreCaolán McNamara
e.g. "CM Roman CE" should be left alone. bump font cache id to invalidate old cached lists I think this practice stems from Window 3.1/Word 95 where the encoding was included in the font name http://www.webcenter.ru/~kazarn/eng/fonts_ttf.htm#charsettbl Microsoft Office still generates RTF files with weird-ass Win 3.1 style fontnames but any actual existing fonts that happen to have names that fall into that pattern should be left alone now. Change-Id: Ibb704048d63b33ce510d6b1076700c6e94a0af2a
2015-01-05java: remove dead codeNoel Grandin
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove some comment noiseNoel Grandin
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13 Reviewed-on: https://gerrit.libreoffice.org/13405 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: the TempFileTest interface is unnecessaryNoel Grandin
Change-Id: Ic49f95117b54929f95984aff0f69e47b90daee7c Reviewed-on: https://gerrit.libreoffice.org/13404 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-24java: unused local varsNoel Grandin
Change-Id: Ib0709da830788f8169282e45552af4fdc300ccf9 Reviewed-on: https://gerrit.libreoffice.org/13096 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-21unotools: correct filename spelling - testGetEnglishSearchName.cxxChris Sherlock
Change-Id: I9d8bc0b8d9257e8bd2453a0707081c134cc775c3
2014-10-20fix font testsCaolán McNamara
Change-Id: I2738ea2a5c6714d8e43c06aa2eb4c53500a5afe9
2014-09-09fdo#82854 extended unit-testsMichael Jaumann
Conflicts: unotools/qa/unit/testGetEnlishSearchName.cxx Change-Id: Ie721cbc275998b37a4f6206079d55734b85308b0 Reviewed-on: https://gerrit.libreoffice.org/11348 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-08fdo#82854 - cleanup & review bits.Michael Meeks
Change-Id: Ia5b2628adb62013a22cf6c5e384154c54abc2294
2014-09-08fdo#82854 - use OUStringBuffer in fontdefs.cxx plus unit-test.Michael Jaumann
Change-Id: Ia3a4814467ed98bd3b1889991cc3644c0c23f515
2014-08-14java: remove commented out codeNoel Grandin
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-08java: remove unnecessary semi-colonsNoel Grandin
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05java: remove various unused variablesNoel Grandin
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-02-26Remove visual noise from unotoolsAlexander Wilms
Change-Id: I1285c4e47ad381934adc3aea6671e7c95d820c39 Reviewed-on: https://gerrit.libreoffice.org/8334 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2012-06-21re-base on ALv2 code.Michael Meeks
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2011-06-16CWS gnumake4: convert unotools to new build systemMathias Bauer
2010-06-07sb123:#i111449# cleanups in unotools qa/complex testsLars Langhans
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2008-10-01CWS-TOOLING: integrate CWS sb93Vladimir Glazounov
2008-04-11INTEGRATION: CWS changefileheader (1.2.24); FILE MERGEDRüdiger Timm
2008/03/31 13:03:37 rt 1.2.24.1: #i87441# Change license header to LPGL v3.
2008-04-11INTEGRATION: CWS changefileheader (1.3.4); FILE MERGEDRüdiger Timm
2008/03/31 13:03:37 rt 1.3.4.1: #i87441# Change license header to LPGL v3.
2008-03-20License header addedRüdiger Timm
2008-01-04INTEGRATION: CWS fwk77 (1.1.2); FILE ADDEDOliver Bolte
2007/10/18 11:40:05 mav 1.1.2.1: #i47532# TempFile service
2008-01-04INTEGRATION: CWS fwk77 (1.1.2); FILE ADDEDOliver Bolte
2007/10/18 11:40:54 mav 1.1.2.1: #i47532# TempFile service
2008-01-04INTEGRATION: CWS fwk77 (1.1.2); FILE ADDEDOliver Bolte
2007/10/18 11:40:45 mav 1.1.2.1: #i47532# TempFile service
2008-01-04INTEGRATION: CWS fwk77 (1.1.2); FILE ADDEDOliver Bolte
2007/10/18 11:40:35 mav 1.1.2.1: #i47532# TempFile service
2008-01-04INTEGRATION: CWS fwk77 (1.1.2); FILE ADDEDOliver Bolte
2007/10/18 11:40:25 mav 1.1.2.1: #i47532# TempFile service
generated by cgit (git 2.34.1) at 2025-02-05 19:15:37 +0000