summaryrefslogtreecommitdiff
path: root/unotools/source
AgeCommit message (Collapse)Author
2023-02-21osl::Mutex->std::mutex in FmSearchConfigItemNoel Grandin
Change-Id: Ic7d805f05f906a1f61ad958d33de0102d6835a36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-16Drop 'using namespace ::std' in dirs [u-x]*Gabor Kelemen
Change-Id: I8c044369826b00241496cfc7ba2463e507c0d1a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147077 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-02-16osl::Mutex->std::mutex in UcbLockBytesNoel Grandin
Change-Id: Ia84af116b705299ff4b9070f145e149c1a8a2c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147101 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-21fix ZipPackageHelper::addFileNoel Grandin
after commit a04bf69bccfbc266643b418ef57030a42bbb5c05 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Jan 16 10:36:59 2023 +0200 XUnoTunnel->dynamic_cast in ZipPackageEntry it no longer implements XUnoTunnel. And add an assert, the createInstance call should never fail. Change-Id: I9a0698862ba783057a299b9c52ebc2b828cc2ac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-13XUnoTunnel->dynamic_cast in comphelper::ByteReader and comphelper::ByteWriterNoel Grandin
Change-Id: I1f8c864a939dff1252ba15f517f63b62d1a1e1fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-31tdf#152676 Writer: Compatibility options no longer saved as defaultNoel Grandin
regression from commit 78adf246d5e99d0f5d91d2e03c1379b154289d8d Date: Mon Jul 26 10:54:36 2021 +0200 return SvtCompatibilityEntry from SvtCompatibilityOptions::GetList where I mistakenly assumed that the bIsDefault flag in SvtCompatibilityEntry was being set by the SvtCompatibilityOptions code. Rather remove this field if it is not going to be maintained properly. Change-Id: I23963ae885563d5abc8a99cfd144d7fe00c6f192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-12-30tdf#136306 offapi linguistic: add options to disable rule-based compoundingLászló Németh
Add two new spell checking options to disable rule-based closed and hyphenated compound word recognition with Hunspell dictionaries: com::sun::star::linguistic2::XLinguProperties::IsSpellClosedCompound com::sun::star::linguistic2::XLinguProperties::IsSpellHyphenatedCompound For professional proofreaders, it can be more important to avoid of the mistakes of the rule-based compound word recognition, than to speed up proofreading. Disabling the following two new options will report all rule-based closed compound words (default in Dutch, German, Hungarian etc. dictionaries) and rule-based hyphenated compound words (all languages with BREAK usage in their Hunspell dictionaries): - "Accept possible closed compound words" - "Accept possible hyphenated compound words" For example, disabling the second one, dictionary word "scot-free" will be still correct word in English spell checking, but not the previously accepted compound "arbitrary-word-with-hyphen". Note: the second option works with the update to Hunspell 1.7.2. Change-Id: Id879610927d5e8269fda5ad207c1c2fe1f57a0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144875 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-12-28Introduce lo_get_app_data_dir() for Emscripten, tooTor Lillqvist
And not just Android. Hardcoded to return "/instdir" to match what is in the emscripten_fs_image. Change-Id: I26d4ec5e02ec9900e35ca47f1565a13ad2b723b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144849 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-12-16i18n: fix build with Boost 1.81.0Đoàn Trần Công Danh
Boost.Locale since 1.81.0 switch to enum classes for facet type [1]. Switch our resource manager accordingly. 1: https://github.com/boostorg/locale/commit/e5ed439ea39a4de915e9fb939cca95cae7d9d8d1 Change-Id: Ief215363ceb79b2019606b20a7cde55c8df6a042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143343 Reviewed-by: Heiko Becker <heirecka@exherbo.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-01loplugin:unusedfields make some fields privateNoel Grandin
Change-Id: Ia30e3b7f10ae11c7a74e6860ac0a6115caaa439f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-11-18rename IsStarSymbol to IsOpenSymbolCaolán McNamara
Change-Id: If525ba9826f5bc2d860233cbabf58d1d290be054 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-11-08A better fix for C++23 P2266R1Stephan Bergmann
After 6d6a143913603b040c10a5db83c2103557899011 "Address some of the sprintf in vcl/source/fontsubset/cff.cxx", --with-latest-c++ builds that pick up a C++23 compiler that implements <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" started to fail with something like > vcl/source/fontsubset/cff.cxx:2061:16: error: no viable conversion from returned value of type 'char[64]' to function return type 'OString' > return aDefaultGlyphName; > ^~~~~~~~~~~~~~~~~ [...] > include/rtl/string.hxx:313:5: note: candidate constructor [with T = char[64]] not viable: expects an lvalue for 1st argument > OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() ) > ^ etc. So I figured there should be something better than 433ab39b2175bdadb4916373cd2dc8e1aabc08a5 "Adapt implicit OString return value construction to C++23 P2266R1" (which this commit reverts, modulo its conflicts in comphelper/source/xml/xmltools.cxx and sc/source/filter/xcl97/XclExpChangeTrack.cxx) to address the underlying issue in a way that keeps code that works up to C++20 also working in C++23. (The fix is only relevant for non-explicit constructors that involve NonConstCharArrayDetector and non-const lvalue references, not for other functions involving those. OUString has a similar constructor but which is explicit, and OUStringBuffer doesn't have any similar constructors at all, so this only affects OString and OStringBuffer constructors.) Change-Id: I31cf16b9507899f5999243f8467dfa24bc94c5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142455 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-11-06tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macrojsala
Also change some range based for. Change-Id: I32c5cbe0033c40cde3f1fc86ec8af90e558f2652 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141666 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-11-01-Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Change-Id: I8887a8c151f628c65bb24e63b03893c7b27c0c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142088 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-10-24tdf#133768 speed up temp file creationNoel Grandin
Use DELETE_ON_CLOSE attribute, so we can avoid calling osl_removeFile. Shaves 5% off the export time. Change-Id: I4fef8f181ef7a92c4805cc5996c3a17800a22602 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141718 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-22tdf#133767 speed up temp file creationNoel Grandin
Use a GUID so we can avoid needing to check if the filename already exists. Shaves 2% off the export time. Change-Id: Id08104b187365eb35c84639254263329a8218a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141664 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-21tdf#133767 use more TempFileFastServiceNoel Grandin
Change-Id: I58728f0b7971e3247cd555dd701461824707d15d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-21loplugin:referencecasting look for a new patternNoel Grandin
Change-Id: Ib7ded8db2c513909159f0876389f63b60082a529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-21tdf#133767 new service TempFileFastServiceNoel Grandin
to use in places where we know we can use the TempFileFast mechanism. Speeds up export to EPUB from 43s to 17s on my windows machine. This is essentially a copy of OTempFileService, but it does not implement XTempFile (because these temp files have no name on Windows). Also remove a couple of calls to Flush() (which is not necessary now), and TellEnd(), which is a little slow on Windows. Change-Id: Iced300bf8121eae08c7a011d62ec68b93330d84c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141598 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-10-19crashtesting: temp files accumulating over timeCaolán McNamara
Change-Id: I922ba92d0a9278b366b4bec38170a776830c1682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-06[API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics"Heiko Tietze
Option is out-dated and access via UI confusing * UI access removed from Tools > Options > General (Impress, Calc) resp. > Compatibility (Writer) * Unit tests updated * Tip-Of-The-Day cleaned-up * remove UsePrtMetrics value Change-Id: Ib645f6e1f648455e0536a437be14c2c6a7b25a49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139863 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-09-29split utl::TempFile into fast and named variantsNoel Grandin
which makes it easier to know what each variant requires to stay on it's happy path Change-Id: I3275a2543573367714bc78092e882f6535507285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-27tdf#123990 sc condition: use GetTransliteration, not GetCollatorJustin Luth
Thanks Eike Eike said "This should not use collation (which should only be used in sorting context) but ignore case transliteration instead." I had just copied ancient code from commit 952c2b02c73b30b011306faf2f0d6f2b4a935955 Author: Eike Rathke on Date: Wed Mar 14 14:57:39 2001 +0000 use CollatorWrapper instead of International Apparently that code should also be changed in a follow-up commit. Interestingly, a \x000 - \x008 etc must be isEqual(""), so an attempt to ScGlobal::getCharClass().lowercase all variables at the beginning and use regular OUString comparisons didn't work. Also, a "" startsWith and endsWith each string. In Excel, a "" is also contained in every string, but not (yet) in Calc. Change-Id: I44a07c482d2d67a76a939ba2d593a003398d52c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140633 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-09-23Fix utl::splitLastFromConfigurationPathStephan Bergmann
* Fix regressions introduced with 5edefc801fb48559c8064003f23d22d838710ee4 "use more string_view in unotools". (Notably, misuses of two-argument std string_view rfind are something to watch out for, see the commit message of 93e234c45c62af9d57041de676d888f7695ac0e8 "Fix a misuse of two-argument std string_view rfind" for details.) * Bring the implementation some more in accordance with the documentation, by being stricter about handling invalid paths, and making sure to really assign all of the input _sInPath to the output _rsLocalName in case of an invalid path. * Only &...;-decode the names of set elements in ['...'] and ["..."], not anything else. Change-Id: If01f4b34af42b0a594994b732d54f26695329286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-23tdf#123990 sc condformat: case insensitive begins/ends/containsJustin Luth
This is how Excel handles these. At first I was afraid that this would upset LibreOffice users, but then I realized that equals already is case insensitive, so this change ought to be more consistent, and thus there should be fewer outcrys. Change-Id: Ia3de78d5888672ba8b774866d41ecd65293397c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140484 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-22cid#1515531 Out-of-bounds accessCaolán McNamara
Change-Id: I543c9a14dcba3b448c2bd1197e46fae8e3b76ab8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140401 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-22this originally checked for > 0Caolán McNamara
Change-Id: I3babab9dc6257ed9e07911e346fd1e56e26dc7c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140400 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-21bogus OSL_ASSERT: nPos != std::u16string_view::npos ... warningsCaolán McNamara
since: commit 5edefc801fb48559c8064003f23d22d838710ee4 Date: Tue Sep 20 11:37:12 2022 +0200 use more string_view in unotools Change-Id: I095de3a1156613e95c96ad0d1375885e8f36d61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140312 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-20use more string_view in unotoolsNoel Grandin
Change-Id: Iaf91f9c63a0a666250e92a5ba7bebdb06dffb258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140233 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-18use more string_view in utl::TempFileNoel Grandin
Change-Id: I151c66479053b9b5b7699a4938a622b4320aeaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140104 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-14crashtesting: SvMemoryStream::PutData assertCaolán McNamara
crashtesting logs contain a pile of SvMemoryStream::PutData assert failures with the last ~90 documents some experimentation suggests that the fallback path in TempFile::GetStream is getting taken to use a SvMemoryStream if there was no filename. presumably there is no filename because there is no inodes left in /tmp (see. https://gerrit.libreoffice.org/c/core/+/139881 to remove left over OSL_PIPE when killed) or some other similar problem. But the SvMemoryStream ctor used gives a Stream which cannot be written to because it's given an empty buffer to use and isn't allowed to resize it. this went wrong at: commit 7f8f277b94704a289fbbd1b836e4e5d66311580d Date: Wed Jan 7 09:28:42 2015 +0200 fdo#84938: convert STREAM_ #defines to 'enum class' with - pStream = new SvMemoryStream( eMode ); + pStream = new SvMemoryStream( NULL, 0, eMode ); which selected ctor a) SvMemoryStream(void* pBuf, std::size_t nSize, StreamMode eMode); Previously eMode was just a sal_uInt16 typedef and this gave a fairly arbitrary but useable nInitSize to select the other ctor of b) SvMemoryStream(std::size_t nInitSize=512, std::size_t nResize=64); Using eMode as nInitSize was bogus and worked by chance, that was introduced with: commit 160f790791d6e839919f0d0f9277cb047fe020ae Date: Mon Oct 4 19:30:08 2004 +0000 INTEGRATION: CWS mav09 (1.14.114); FILE MERGED 2004/07/08 08:29:38 mav 1.14.114.3: RESYNC: (1.15-1.17); FILE MERGED 2004/04/29 16:50:04 mav 1.14.114.2: RESYNC: (1.14-1.15); FILE MERGED 2004/04/29 11:03:41 mba 1.14.114.1: #i27773#: no SvFileStream please Change-Id: I23ca3e8033400f6b016a802037dad3443df8af34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139926 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-14move ErrCode to comphelper and improve debug output stringNoel Grandin
need to move it, because modules "below" vcl want to use the debug output method Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-13Empty string has no characters of any typeEike Rathke
Change-Id: Id7244032d52360d2b0ea57fba023dff162a29d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139831 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2022-09-13Fix everything using XCharacterClassification::getStringType() and don't use itEike Rathke
See note in offapi/com/sun/star/i18n/XCharacterClassification.idl The brain dead implementation is useless but API ... its use in isAlphaNumericType() and similar never returned what would had been expected. Change-Id: I278f2468182dab94c32273ef69cf9634bc002cb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139809 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-31Remove comment that has been outdated since 2001Tor Lillqvist
The "empty comments" the comment referred to were removed in 24f7917d9dc493ba35b504172f1ea3cfcd4d1486. Change-Id: I32b37224bbe02892af1a1d8c8898e40c005110da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139080 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-22Resolves: tdf#150288 Do not prepend the locale's full date acceptance patternEike Rathke
... if it wasn't present as first, but take the date acceptance patterns as specified by the user. Change-Id: Ife2fd39731bac0e0b121f22392f22b48ffc9c978 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138694 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-22elide some makeStringAndClear() callsNoel Grandin
Change-Id: I3b7ae370b41638c0a67374d5132b7bdf56e7c672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13loplugin:unusedmethodsNoel Grandin
Change-Id: Ifa9c3fe86e7bad6d3839fd3fdfdb8c1f7b5053c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-08[API CHANGE] Drop css::accessibility::XAccessibleStateSetNoel Grandin
which is internal API, unused (as far as I can tell) by external users. This state is purely a bitset (as implemented by utl::AccessibleStateSetHelper) so we can just return it as a 64-bit value. This shaves significant time off the performance profiles of code that loads very complex shapes, because this state is frequently used, and we no longer need to allocate a return value on the heap for every call. Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-28use utl::TempFile directly in packageNoel Grandin
so we can (a) control the lifetime of the temp file properly and (b) we don't need to use file URLs which means we stay on the efficient path on Windows Change-Id: I2b1eed5f5afc8f89f53bde35ebb44e9922889817 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-15Revert "Load the locales from config file for languagetool"Xisco Fauli
This reverts commit c3ed41752237a7a70c856dfb0d618f1c2eacea5a. Jenkins fails in CppunitTest_sw_core_draw on Mac and Windows Change-Id: I3e2b6359f3238a1b8af2e98d3cb5eee7aa864bae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135859 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-14Load the locales from config file for languagetoolMert Tumer
Locales needs to be read again in the Preferences/Writing Aids section and since this is a network operation it can cause a problem. Better to list all the supported locales in the xcu and load it right away. Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ifff624334627f7be259b677f9b416d6ddedfb2c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135598 Tested-by: Jenkins
2022-06-12crashtesting: forum-mso-de-92960 GetEnglishSearchFontName varying resultsCaolán McNamara
depending on if it's called once, or twice on the input string. The first converts from Full-Width Characters to equivalent lower ASCII range with non letters retained. And then the second iteration would convert to lower case ASCII with non letters filtered out. Presumably the intention is the Full-Width case should get directly to the same results as multiple calls. Change-Id: Idba4ebe04c907c160ee53abf6d5551550da032dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-12split out the code that extracts a lower-ascii version of a fontnameCaolán McNamara
Change-Id: I77778ecd075712c41bd29324be090ab4a8351ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135677 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-03tdf#146988 Opening at cursor position doesn't work in large documentsNoel Grandin
regression from commit 07021596acb3d104ba129d371b1ae0b79f67a6a4 (HEAD) Date: Sat Jun 12 18:57:51 2021 +0200 tdf#142242 Forename imported with trailing space Change-Id: I792fbe5955de464f41ac61c85f1ca651121b4a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-03Fix type of impl_getISO8601TimeToken etc. string index parametersStephan Bergmann
...after 6fc3dfd3f1b5cb13101299df42444f2ff0493846 "use more string_view" Change-Id: I0f4fb75e90d18ed3331f0c857dce1cfcb7482d65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-30no need to allocate LocaleDataWrapper separatelyNoel Grandin
Change-Id: Icceaf255a3a71d612b17dad41d04b1906550a7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-30clang-tidy modernize-pass-by-value in unotoolsNoel Grandin
Change-Id: Ifa67ab7198f5d3b06171869f57703acdaa959f7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23cache ref to GlobalEventConfigNoel Grandin
so we avoid repeated allocation Change-Id: I9541c52e73878cf515c9159477bd3d2fda9e0078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-10 14:38:51 +0000