summaryrefslogtreecommitdiff
path: root/unotools
AgeCommit message (Collapse)Author
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ic764a6499b8f5ecac62d326151b0957c53866e08
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22tdf#81833: form protection can be modified as compatibility optionOliver Specht
ProtectForm is supported to prevent editing outside of form controls but could only be imported from doc and stored in odt but not changed. Now it is part of Writer's compatibility settings dialog. Change-Id: I7337fb3f0774d3c1d26cd8e1485958399b2a70e2 Reviewed-on: https://gerrit.libreoffice.org/24294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I57c1bd476183c941a70cc0c60fd4e42bbe95ccb2
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I5390fe81a7b35d62a27cd1ec6fb00ea012e70dd9
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in unotoolsNoel Grandin
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
2016-04-04loplugin:constantparam in unotoolsNoel Grandin
Change-Id: I0501e6e7eadd735b1666a8ecb2c5e6da73ce7e67 Reviewed-on: https://gerrit.libreoffice.org/23728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04reduce unnecessary reallocingNoel Grandin
Change-Id: I62368cf733ca6397099a843f3bbae3da08552798 Reviewed-on: https://gerrit.libreoffice.org/23761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-24don't allocate and destroy a LocaleDataItem for each cell, tdf#97989Markus Mohrhard
Change-Id: I8bcdc7a42c87d17fde1dc9c79bc361bb625f992b Reviewed-on: https://gerrit.libreoffice.org/23480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-16loplugin:constantparam in unotools/Noel Grandin
Change-Id: I016cf96af3a93c8f2114657a7e59599f68446ddc Reviewed-on: https://gerrit.libreoffice.org/23296 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15define ODFSVER_LATEST at a central placeEike Rathke
It's already enough to have to adapt the SvtSaveOptions::GetODFSaneDefaultVersion() mapping for new ODFDefaultVersion values, get rid of the SvXMLExport::getSaneDefaultVersion() place. In the hope that DO NOT USE is taken seriously.. Change-Id: I1eeae698249f68cc375b22cc4cc799107bc14e41
2016-03-13quieten debugging soffice startupCaolán McNamara
Change-Id: I3f9ef32d789b7b344cc09bbed6f344e428a31ca4
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I6ac0dfb8bb013e8106bdeb9df00aef3abe4d3af6
2016-03-08tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar
Updates pointed by Sweet5hark Change-Id: I747e92ca9ee39a027b1e9b27b131f249a33b77db Reviewed-on: https://gerrit.libreoffice.org/22980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-02unotools: handle classification path in SvtDefaultOptionsMiklos Vajna
With this, it's possible to reset a custom classification path back to its default value. Change-Id: If0230fa6bb6ab014634dcdface8c470321163097
2016-03-02sfx2 classification: use SvtPathOptionsMiklos Vajna
In preparation to be able to edit the policy path from SvxPathTabPage. Change-Id: I7a8e03e9acf2e8096a5e00d1424c75fe31735c1d
2016-02-29loplugin:unuseddefaultparam in unotoolsNoel Grandin
Change-Id: Icb2dc74263026d90b7998b3fd880fd5d2c67a3b7
2016-02-26add missing commaEike Rathke
this ended up as IsSearchFormattedIsUseWildcard ... Change-Id: Iaa39f51b0e5ef49d65a636b0a2d926d30a2a1dd8
2016-02-25prepare SearchOptions config with IsUseWildcardEike Rathke
Change-Id: Ifba836f259358d7480502e1701f902c2702b4263
2016-02-24convert EConfigurationModes to scoped enumNoel Grandin
Change-Id: I1e81c8d637e738f536f7efad8b67d0c9183e6483
2016-02-23SearchFlags::WILD_MATCH_SELECTION, SearchOptions2::WildcardEscapeCharacterEike Rathke
At least '\' (search in Word) and '~' (search in Excel) should be supported as escape character. Being able to restrict a match to entire selection instead of substring speeds up the Calc match whole cell scenario. Change-Id: Ice242b9cd59009f172b724e03c2cc08feda4cd3c
2016-02-23new loplugin: commaoperatorNoel Grandin
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-11OTempFileService: avoid manually deleting mpTempFileMiklos Vajna
Change-Id: Ic2f83fd4ff83795a77dd9b97b98e2635e5c447c0
2016-02-05nitpick, mention function name in assertEike Rathke
Change-Id: Ifd5b544ad1374f13e3efc8c7a51601fadf1e14b6
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18loplugin: unused return valuesNoel Grandin
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-15loplugin:unusedmethods unused return value in include/unotoolsNoel Grandin
Change-Id: I3b2281dc713bff92eb3d80fddef04a8a39838aa8 Reviewed-on: https://gerrit.libreoffice.org/21484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14unotools: This list is constantTakeshi Abe
Change-Id: Ib97a824cf482ba48204447f25102d112b90d3064 Reviewed-on: https://gerrit.libreoffice.org/21463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-13loplugin:unusedmethods unused return value unotools/Noel Grandin
Change-Id: I5fbb0fe5910d4f430fe4885eae5689592c366500
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05new loplugin rangedforcopy - use reference in range based forAndrzej Hunt
Inspired by 6e6ae9803796b120e95f6e89575e03c5fd0ed3c2 Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01 Reviewed-on: https://gerrit.libreoffice.org/20190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05let us try to use the pid as well on windowsMarkus Mohrhard
I'm a bit worried that some of our random test failures are related to trying to reuse the same temp file in different tests. Change-Id: I0ca4ace088a96530e6a62d01f979fefe63822b22 Reviewed-on: https://gerrit.libreoffice.org/21090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-01-04remove unnecessary ;Markus Mohrhard
Change-Id: I0e16305cac5cd5e4824a4e2bab7e4ac10d2bd469
2015-12-24OModule::onFirstClient is unusedNoel Grandin
also move the MutexGuard in revokeClient. No need to hold it while doing an osl_atomic_increment. Save it until we actually need to call onLastClient. Change-Id: Ia87f24b66b0430604a2fe717c95223ff1f5ece6d Reviewed-on: https://gerrit.libreoffice.org/20919 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-21loplugin:unusedfields unotools,unoxmlNoel Grandin
Change-Id: I824193a9f4b0196ce1127c5cbf16b0064dbb3446
2015-12-21loplugin:unusedmethodsNoel Grandin
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-14Silence warning C4334 under --enble-64-bit MSVCStephan Bergmann
("'<<' : result of 32-bit shift implicitly converted to 64 bits") Change-Id: I738fe94ec559e2a35ffc32fb91c22c06094cff9f
2015-11-26loplugin:unusedfields variousNoel Grandin
Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
2015-11-25add const in ranged forAndrzej Hunt
Change-Id: I0f55705e101e39e9e6e5286f21cad8ccb96e7fad
generated by cgit (git 2.34.1) at 2025-02-03 03:45:52 +0000