summaryrefslogtreecommitdiff
path: root/unotools
AgeCommit message (Collapse)Author
2016-06-28loplugin:singlevalfields in variousNoel Grandin
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-27Clean up uses of Any::getValue() in unotoolsStephan Bergmann
Change-Id: I2e1d98c5947d0d72c369fa6b2df17eb2eec1f64c
2016-06-20Mark these functions as finalXisco Fauli
Comment from Michael Stahl in Gerrit: "to prevent potential disasters if somebody adds a sub-class and overrides ImplCommit, which is then not called here." Change-Id: I2d991c713734fd516827a5dd6c8929aa64e59409 Reviewed-on: https://gerrit.libreoffice.org/26278 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-06-18tdf#89329: use shared_ptr for pImpl in moduleoptionsXisco Fauli
Change-Id: I2dfcdde6ef1782edc22ca6d70d353549706eb14f Reviewed-on: https://gerrit.libreoffice.org/26322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17tdf#89329: use shared_ptr for pImpl in dynamicmenuoptionsXisco Fauli
Change-Id: I66bdeeee7f70e6ca16a39e8804aaf8a5f0d08205 Reviewed-on: https://gerrit.libreoffice.org/26327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16properly prefix various global variables and hide themMichael Stahl
Change-Id: I6b97e6a4c6ac4c0e26bcbb2b132b333920c16f19
2016-06-16Local linkage for static var (and drop misleading "m_" prefix)Stephan Bergmann
Change-Id: Ibb66eadf4d10fa4e67dae09287e82dcc937bfea3
2016-06-16tdf#89329: use shared_ptr for pImpl in pathoptionsXisco Fauli
Change-Id: Id932a0886f0a8a3cb05a3d0474e29a2e0b84ad4e Reviewed-on: https://gerrit.libreoffice.org/25630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in historyoptionsXisco Fauli
Change-Id: I0020b7e66fe8e09db9a96127a77c3792afab63a8 Reviewed-on: https://gerrit.libreoffice.org/26324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in localisationoptionsXisco Fauli
Change-Id: I9b2f7f7e59a71c056608635773c4b4fb2120a902 Reviewed-on: https://gerrit.libreoffice.org/26323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in securityoptionsXisco Fauli
Change-Id: I91c9c9dcbb9df644836c87d4789521d668c2ba49 Reviewed-on: https://gerrit.libreoffice.org/26319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in cmdoptionsXisco Fauli
Change-Id: Ie6297cf8c26964a6c7cc017c1257c61825c2c791 Reviewed-on: https://gerrit.libreoffice.org/26320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in printwarningoptionsXisco Fauli
Change-Id: I0b202ae78d2afe5fad4aa4bb4a3323f2672b1b93 Reviewed-on: https://gerrit.libreoffice.org/26321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in extendedsecurityoptionsXisco Fauli
Change-Id: I3d344c4872bbed9527f254a4eabc48534e38452f Reviewed-on: https://gerrit.libreoffice.org/26326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-16tdf#89329: use shared_ptr for pImpl in fontoptionsXisco Fauli
Change-Id: I844f23d7674fe6e564575b150ba1f94754da4d3b Reviewed-on: https://gerrit.libreoffice.org/26325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-15Use SAL_WARN on swallowed exceptionsStephan Bergmann
Change-Id: If4d7b51de338c026b3308a733c8f4a41478158b2
2016-06-14loplugin:overrideStephan Bergmann
Change-Id: Ib66e1f58eaa383a66660a28e39cdbd11dade2972
2016-06-14tdf#89329: use shared_ptr for pImpl in misccfgXisco Fauli
Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39 Reviewed-on: https://gerrit.libreoffice.org/26237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in compatibility...Xisco Fauli
... and remove some, at least from my point of view, useless comments Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75 Reviewed-on: https://gerrit.libreoffice.org/26235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in defaultoptions...Xisco Fauli
instead of unique_ptr as in commit 7bc1c79c26e52d5196fb36eee5c2f12f12d49ba6 Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03 Reviewed-on: https://gerrit.libreoffice.org/26236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-14tdf#89329: use shared_ptr for pImpl in syslocaleXisco Fauli
Change-Id: I646495e3538cb438a06765fe8cde252bad667bea Reviewed-on: https://gerrit.libreoffice.org/25969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13loplugin:sallogareasStephan Bergmann
Change-Id: I97fe4a566531015fe6c9fd275aaa46723aee9513
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Resolves: tdf#89394 revert attempt to ditch missing file from recent filesCaolán McNamara
this reverts commit 93eefe54f5d6b6092371bad1e86444489d29eee2 Author: Krisztian Pinter <pin.terminator@gmail.com> Date: Fri Sep 6 14:45:13 2013 +0200 Make SvtHistoryOptions not return files if they can't be opened which seemed like a good idea, but was only really to fix a cosmetic problem, while the outcome was a more serious issue Change-Id: Ic9c9c136e1e50f5e28fe377b64f56e501fb836ca
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in configvaluecontainerXisco Fauli
Change-Id: Ide38cacc59a44515287d51dadb23836eaac14518 Reviewed-on: https://gerrit.libreoffice.org/25904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in accessiblestatesethelperXisco Fauli
Change-Id: I768bfd5a19a2633e6d6cd37f919c20cbfc76824e Reviewed-on: https://gerrit.libreoffice.org/25905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tdf#89329: use unique_ptr for pImpl in accessiblerelationsethelperXisco Fauli
Change-Id: I29578afa206e869a5b2e6fb42c7f5ebf4a6f2fe8 Reviewed-on: https://gerrit.libreoffice.org/25906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove some manual ref counting in svx and xmloffNoel Grandin
Change-Id: Ica0b6ff8ff7fa9e65cd758160d6e3ea7110ebb46 Reviewed-on: https://gerrit.libreoffice.org/25824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Some clean up of uses of css::uno::Any::setValueStephan Bergmann
Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
2016-05-30tdf#89329: use unique_ptr for pImpl in fltrcfgXisco Fauli
Change-Id: Icbb7d122d7f553215de562a98b0127764b30faa1 Reviewed-on: https://gerrit.libreoffice.org/25628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#89329: use unique_ptr for pImpl in defaultoptionsXisco Fauli
Change-Id: I355888c44d1413f8d0ebd7a247649b79647c38ec Reviewed-on: https://gerrit.libreoffice.org/25629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24tdf#99973 - Crash when changing Locale Setting in optionsNoel Grandin
regression from commit 0f672545 "clang-tidy modernize-loop-convert in toolkit to uui", probably because the list is being modified while the loop is executing Change-Id: I18cd21001aee132e06d577c469aed5eb46a16a7f Reviewed-on: https://gerrit.libreoffice.org/25368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20clang-tidy misc-assign-operator-signatureNoel Grandin
Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in unotoolsNoel Grandin
Change-Id: I5729c2a20dd5fb310570cb9e4bb0e0874dbc8049 Reviewed-on: https://gerrit.libreoffice.org/25102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ifa990214aaf749d039043aa51d3301dc0f1f0e4f
2016-05-12Silence -Werror,-Wimplicit-fallthrough under NDEBUGStephan Bergmann
Change-Id: Iff742ad9a53086028049dd2df3bf63303c32c317
2016-05-11Fix horrible codestyleSamuel Mehrbrodt
Change-Id: I3bbeb625abd9ba130fc6fea97689ead682fa074b Reviewed-on: https://gerrit.libreoffice.org/24893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-10-Werror=empty-bodyStephan Bergmann
("suggest braces around empty body in an ‘else’ statement") Change-Id: I7c6de1ed2cc1c2cc39e2c8f530866c31ab038907
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: Ic764a6499b8f5ecac62d326151b0957c53866e08
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22tdf#81833: form protection can be modified as compatibility optionOliver Specht
ProtectForm is supported to prevent editing outside of form controls but could only be imported from doc and stored in odt but not changed. Now it is part of Writer's compatibility settings dialog. Change-Id: I7337fb3f0774d3c1d26cd8e1485958399b2a70e2 Reviewed-on: https://gerrit.libreoffice.org/24294 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann
Change-Id: I57c1bd476183c941a70cc0c60fd4e42bbe95ccb2
2016-04-14loplugin:passstuffbyref in variousNoel Grandin
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifiersStephan Bergmann
Change-Id: I5390fe81a7b35d62a27cd1ec6fb00ea012e70dd9
generated by cgit (git 2.34.1) at 2025-02-06 06:05:01 +0000