summaryrefslogtreecommitdiff
path: root/unotools
AgeCommit message (Collapse)Author
2015-08-11loplugin: defaultparamsNoel Grandin
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
2015-07-23loplugin:stringconstantNoel Grandin
Change-Id: I02aa11489a993b9788dc1038d9772672f1d2ecef
2015-07-22tdf#82744: fix WebDAV lock/unlock behaviour - part 2Giuseppe Castagno
Changes done to the code in framework, comphelper and unotools, in no particular order - add an interaction handler dedicated to WebDAV The stock interaction handler can be missing depending on the need of the framework performing its tasks, so a dedicated handler is provided, this one is always present. - force opening of a WebDAV file. A WebDAV file sould be open r/o even if explicitly requested to open as r/w. This is a limitation of current WebDAV implementation, not of the standard. This change is needed in order to reopen correctly a file as requested by a 'Edit Mode' GUI command. Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082 Reviewed-on: https://gerrit.libreoffice.org/17182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-21Miscellaneous typosAdolfo Jayme Barrientos
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-16why bring ucb into the tempfile story when its always a file://Caolán McNamara
Change-Id: I48d51cd24831072af647dd0172a2fd2e4a9ed2a5
2015-07-16WaE: -Wmaybe-uninitializedCaolán McNamara
Change-Id: Ie49c6a8067c5223bbe3c86505aa909c2bd5d3c93
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-06loplugin:unusedmethods unotoolsNoel Grandin
Change-Id: Ieb73b50471263212285b9c3883c082477c1ad656 Reviewed-on: https://gerrit.libreoffice.org/16729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-01tdf#92431 Keep thumbnail for modified but unsaved docMaxim Monastirsky
A regression of 1166966eb4112fdf332c656eae5082d82a3ec2f2. We need to consider 2 use-cases: 1. Protecting an existing document with a password (by overwriting the original file). In this case we don't want to generate a thumbnail from the now encrypted file, but we do want to erase the stored thumbnail and show a generic icon instead. 2. Closing a modified document without saving the changes. Here we don't want to generate a thumbnail either, because it may contain the unsaved changes, but either we don't want to replace the stored thumbnail, because most likely it correctly represents the last saved state of the document. Change-Id: Ia7b1f3dbc9fbbc2ef1d87442c1dee25306f65826 Reviewed-on: https://gerrit.libreoffice.org/16659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann
Change-Id: Ia9386f30413950b42fdbc9849e41e958f9282693
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann
Change-Id: I45fcbcdf15134585443e528e8af2c9486d0b3bbe
2015-06-23LinkUpdateMode is a global settingStephan Bergmann
Change-Id: Ida1257337c6e0916f2228fe053d9c9f085183af6
2015-06-18Fix typosAndrea Gelmini
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-08add (and call before dtor) Commit to SvtSearchOptionsCaolán McNamara
i.e. follow up to commit 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Author: Michael Stahl <mstahl@redhat.com> Date: Wed Mar 11 16:39:24 2015 +0100 do not call virtual Commit() from dtors of utl::ConfigItem subclasses ~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not invoking its subclasses' ImplCommit() but its own. to avoid assert in SvtSearchOptions dtor Change-Id: I0eaf93450e1daddb81a9463f2c1df48a334dfb22
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann
Change-Id: Ic05bc081ec190cc80d8821630e94f51c8db225b6
2015-05-28new clang plugin: loopvartoosmallNoel Grandin
Idea from bubli - look for loops where the index variable is of such size that it cannot cover the range revealed by examining the length part of the condition. So far, I have only run the plugin up till the VCL module. Also the plugin deliberately excludes anything more complicated than a straightforward incrementing for loop. Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-26cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
2015-05-22loplugin:constantfunctionNoel Grandin
Change-Id: I7cb5b0c2cf9ade557173ca596ea5d42d853ff448
2015-05-15tdf#91064: Revert "tdf#89790 DOCX: saving LO version number in app.xml"Joren De Cuyper
This reverts commit 480ca7434a330b2678f9ef287cffd6d9cf27bed5. Change-Id: I69a16425fc36979d49f409bbd7921495a22a35dc Reviewed-on: https://gerrit.libreoffice.org/15737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-08lopluign:staticmethods: Handle DECL_LINKStephan Bergmann
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-07fix for CONFIG_MODE constant -> enum conversionNoel Grandin
in my commit b35828ba7dc33af81d17c8c870ec981d18a57b08 "convert CONFIG_MODE constants to scoped enum" Change-Id: Iafb6b1643920eb066a2d50150f408161331f9d04
2015-05-06fix windows buildNoel Grandin
warning C4334: '<<' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) after my commit 60e659ae355d073b05b3b9c8d2ac3bdc5f76020d "convert IMPL_FONT_ATTR constants to scoped enum" Change-Id: I83f1ea5869fa60c89dbc706020f68cc2c4277f48
2015-05-06Add comments about ImplFontAttrsTor Lillqvist
Change-Id: I32d8b8f4301188245721d31fd234bb1784a1ae8d
2015-05-06convert USER_OPT constants to scoped enumNoel Grandin
Change-Id: I85a1c9f89ac79e0e54fcd8dfd1908325fae9a8ac
2015-05-06convert DEFAULTFONT_ constants to scoped enumNoel Grandin
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06convert SUBSFONT_ to scoped enumNoel Grandin
Change-Id: Ic66191ac4cdfa753dc784e7bd1a6dd20f50def6b
2015-05-06convert FONTTOSUBSFONT constants to scoped enumNoel Grandin
Change-Id: I994bfc76d709d01406404991dbfbd49b15bd03f4
2015-05-06convert IMPL_FONT_ATTR constants to scoped enumNoel Grandin
Change-Id: I2b5986ea69dc09e6ba18b23a80029f6551b48152
2015-05-06convert CVC_ flags to scoped enumNoel Grandin
Change-Id: Iadc9b6240121e9fee91de299b94a9f8629656507
2015-05-06convert CONFIG_MODE constants to scoped enumNoel Grandin
Change-Id: I1b0fb976e7bf8d7de06da0c30012e8bba1320498
2015-05-05loplugin:staticmethodsNoel Grandin
Change-Id: I97160fc51dc16ff92b06d44570298eeec637e132
2015-05-01tdf#89790 - DOCX: saving LO version number in correct tag in app.xmlRadu Ioan
Converted existing method that provides application name and version in two functions Change-Id: I93b70da7c78ee5db3d6eb710a2a2a9f4b7b4fb86 Reviewed-on: https://gerrit.libreoffice.org/15151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-30Gradually typed LinkStephan Bergmann
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-29rhbz#1213173: connectivity: Calc driver: prevent document being disposedMichael Stahl
... by adding a XCloseListener that vetoes any attempt to close it. The Calc document can be opened by the user in the UI and closed again. Change-Id: Ied427b67274d925c911e516c0a50a4c0b2b18db9
2015-04-29convert STR_EVENT constants to scoped enumNoel Grandin
- also add needed infrastructure to o3tl::enumarray so we can use std::find on it - move the Impl inside the .cxx file, no need to expose it in the header Change-Id: I7758a6175849f46723d97b1e657f846524c3b7cd
2015-04-28SvtSecurityOptions_Impl::m_nSecLevel is of type sal_Int32Stephan Bergmann
Change-Id: I82576e00de006caa6f7f6e414e5399d035aed1bf
2015-04-24loplugin:simplifyboolStephan Bergmann
Change-Id: I56557cd02bbb97d3c3aa4053608cf2dd48c35e7a
2015-04-23Improved loplugin:literaltoboolconversion looking into cond. exprs.Stephan Bergmann
...automatic rewriter fixes Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-21try to find a unique naming scheme for temp filesMarkus Mohrhard
This should hopefully avoid name clashes during the test runs. During the test runs two tests can try to access the same temp file which causes one test to fail. Using the pid as part of the temp file name should avoid that problem. Change-Id: I696c3d34e33a5d8e9234238d86f1201ecdfa66ec Reviewed-on: https://gerrit.libreoffice.org/15455 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-04-16improve commentStephan Bergmann
Change-Id: I451ab0fb0e7ee1a6d20091caa9c1142b16796dc7
2015-04-16tdf#89394. fix hangs because of unavailable Windows UNC path.Jan Kantert
UNC: \\server.domain\file.odt is stored as file://server.domain/file.odt. Windows local: C:\folder\file.odt is stored as file:///C:/folder/file.odt. Linux: /home/user/file.odt is stored as file:///home/user/file.odt. I cannot find any case where we only have file:// (but not a third slash) on a local file. Change-Id: Ib15b3380cb40f1cd37123be7a38426b74fbde5cf Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-07convert SvtModuleOptions::EModule to scoped enumNoel Grandin
Change-Id: I9665fc003cb3a44f4db857b24584fa3a70487259
2015-04-07convert SvtModuleOptions::EFactory to enum classNoel Grandin
and fix issues in iterating through o3tl::enumarray Change-Id: Ia59ef9be44d8c92c2e406fa71aa92269578e26e3
2015-04-04Typo: creat->createJulien Nabet
Change-Id: I5e57e6d506504933096f4c8e371b0ddc93c04cbd
2015-04-03Fix "unknown factory" log, declare and use FACTORYNAME_BASICJulien Nabet
Also use FACTORYNAME_STARTMODULE in SvtModuleOptions::ClassifyFactoryByServiceName Change-Id: I1ab87f13a9a1d071bf6abaae137fc6470101d711 Reviewed-on: https://gerrit.libreoffice.org/15113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-20 10:54:09 +0000