summaryrefslogtreecommitdiff
path: root/unoxml
AgeCommit message (Collapse)Author
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann
Change-Id: Ia275bf01d6c72e01e9144a99121f4a9858e88c8a
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann
Change-Id: Ie12eb8940ebb6059d234f5af25800812c085002a
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann
Change-Id: I85007c6fdceca1c070ca9b4cb62715a5c92bfe15
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-02-06fdo#75757: Remove inheritance from std::vectorMatthew Pottage
Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-28remove unused typedefsNoel Grandin
found with some minor modifications to find/find-unused-defines.sh Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd Reviewed-on: https://gerrit.libreoffice.org/14194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-22loplugin:cstylecastStephan Bergmann
Change-Id: I126e06a0c7b442dfc4fcad7c05ff6caf07896a8f
2015-01-20Some more loplugin:cstylecast: unoxmlStephan Bergmann
Change-Id: I7467e033c998d9ee4283a146088c3b09d161f3cd
2015-01-19fdo#39440 reduce scope of local variablesMichael Weghorn
This addresses some cppcheck warnings. Change-Id: I1cd8b118e2598b8b18fb445851a3bb41e554267b Reviewed-on: https://gerrit.libreoffice.org/13967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-02boost::unordered_map->std::unordered_mapCaolán McNamara
you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19java: static fields that should not be staticNoel Grandin
Found by FindBugs. Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
2014-12-18unoxml: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: I6be6717b1714e2f7115ec8e27c5026a439bf1b05
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15java: remove some unused fields and variablesNoel Grandin
Change-Id: I5d6071096307adbe7df0178000346cf915afa3e7 Reviewed-on: https://gerrit.libreoffice.org/13477 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15unoxml: Use appropriate OUString functions on string constantsStephan Bergmann
Change-Id: If4467034e026409dc9d6f0b5ffcafcf98ff8778e
2014-12-11document 440749 Explicit null dereferencedCaolán McNamara
Change-Id: I9f2e97504953742f09981632b7901fcd2fae6747
2014-12-11java: reduce visibility of fields and methodsNoel Grandin
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: improve use of WrappedTargetException to set cause properlyNoel Grandin
since we introduced the new constructors that pass the cause all the way up to java.lang.Throwable. Also simplify some exeception printing sites, because Throwable will correctly print out child exceptions for us. Change-Id: Ibbecce3c6f971fbc80d6de2052ab4f33a4503c0a
2014-12-10java: simplify the getMSF() methodsNoel Grandin
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18cppu: clean up public headers with include-what-you-useMichael Stahl
Unfortunately iwyu gets quite confused by the weird cyclic dependencies between various foo.h/foo.hxx and cppumaker generated headers, so it's not obvious if any improvement here is realistic... Change-Id: I0bc66f98b146712e28cabc18d56c11c08418c721
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-03coverity#705527 drop testlistener that logs to c:\listener.outCaolán McNamara
Change-Id: Id9eab9e44d4b0e705289fa45be0fc2343903de09
2014-11-03coverity#982488 unchecked dynamic_castDavid Tardon
Change-Id: I7008b3a96400a4d1520a03d985c0b421ff587bcb
2014-10-13coverity#707458 Uncaught exception (better fix)Michael Stahl
getStatementsGraph_NoLock() cannot throw the exception because of the i_Internal=true parameter, which may confuse Converity; but possibly xIter->nextElement() could throw this in a multi-threaded scenario... Change-Id: I204c0e5b38fee919d6cfe9247bde76b6ea78ed0f
2014-10-10coverity#707458 Uncaught exceptionCaolán McNamara
Change-Id: Ia446cc0b8b26bb158b36ca64cbf45bf172f37bdf
2014-10-01coverity#1242932 Uncaught exceptionCaolán McNamara
Change-Id: I13ef24dfa1c82ad14737dac77b18e92d3abeb96b
2014-10-01unoxml: std::auto_ptr -> std::unique_ptrStephan Bergmann
Change-Id: Ib7da2401529bbff92611abdab44d26ff009e38b3
2014-09-26Remove unused files and move test to qa/Matúš Kukan
Change-Id: Ia8c022c958f5547d710f9cb196672b89292bbb49
2014-09-25unoxml: domtest needs unotest library on WNTMichael Stahl
Change-Id: I9614e1495e6d990e050c651c2aed0ba0e43d51fe
2014-09-25fdo#39625 Make existing CppUnit tests workTobias Madl
As in the ticket description, this test is now working, but some parts of it are still commented out, because they are waiting for a fix of another bug (Bug 84237). Once it is fixed, it should be possible to just uncomment them, and then they should work. Change-Id: I73d1cc7391080e357c08cb3442616e2901070c1f Signed-off-by: Stephan Bergmann <sbergman@redhat.com> (with minor amendments)
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-14java: remove commented out codeNoel Grandin
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-12java: add @Override annotation to overriding methodsNoel Grandin
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-05java: remove commented out codeNoel Grandin
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05java: remove various unused variablesNoel Grandin
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-07-25coverity#1158284 Uncaught exceptionCaolán McNamara
Change-Id: I19e541707fa91d6a651b8642585276cbdbb2dca8
2014-07-18loplugin:saloverrideMiklos Vajna
Change-Id: I27600820acb4a432840ef9bc7220fc3d4bb6a273
2014-07-17fix memleak circular dependency of CElementList and CElementCaolán McNamara
launching impress leaks 70+k ==1458== 78,741 (152 direct, 78,589 indirect) bytes in 1 blocks are definitely lost in loss record 24,296 of 24,315 ==1458== at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==1458== by 0x4C3895D: rtl_allocateMemory_SYSTEM(unsigned long) (alloc_global.cxx:270) ==1458== by 0x4C38A64: rtl_allocateMemory (alloc_global.cxx:303) ==1458== by 0x2DCC0B67: cppu::OWeakObject::operator new(unsigned long) (weak.hxx:85) ==1458== by 0x2DCCB3D3: DOM::CDocument::getElementsByTagName(rtl::OUString const&) (document.cxx:714) ==1458== by 0x25DC99D6: SdDrawDocument::InitLayoutVector() (drawdoc.cxx:1008) because the CElementList owns the CElement via m_pElement and m_pElement owns the CElementList via the addEventListener. Use a WeakEventListener pattern to let the CElement own that helper which itself doesn't own the CElementList but is owned by it instead, and forwards the events to the CElementList In order to use that pattern the CElementList must be have a m_refCount of 1 when the addEventListener is called, i.e. post ctor, so rename the original CElementList as CElementListImpl and call its registerListener from a wrapper CElementList Change-Id: Ibd4f19b619543a4ef580366c69efb61b526696ab
2014-07-01clang scan-build: various warningsCaolán McNamara
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-27remove more unnecessary use of OUString constructorNoel Grandin
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-22update_pch: add unoxmlThomas Arnhold
Change-Id: Ib695a664356baf288f74fcefac35927726def0c7