summaryrefslogtreecommitdiff
path: root/vcl/aqua
AgeCommit message (Collapse)Author
2013-12-06Re-organize OS X and iOS code in vcl a bitTor Lillqvist
Now with the ATSUI code gone is a good time for some re-organisation. Get rid of "aqua" in file names and the separate "coretext" folders. CoreText is all we use now for OS X (and has always been so for iOS), so no need for a "coretext" folder, we can keep the CoreText-using code under "quartz". Keep OS X -specific code in "osx". Ditto for headers. Keep "Aqua" as part of class names for now, though. This is also preparation for planned further unification between OS X and iOS code. Change-Id: Ic60bd73fea4ab98183e7c8a09c7d3f66b9a34223
2013-12-05Fix fallout from 461e0f9eaf9895ecd0eba67b35a4d2cec8a5e5c5Tor Lillqvist
Change-Id: Iffa0c948356e705f610e057892c84d43d0d3490b
2013-12-05Resolves: #i123795# variable names should not confuse vcl...Herbert Dürr
Window and cocoa NSWindow types VCL's Window type and Cocoa's NSWindow type are quite different. Naming variables as if they were the same introduces gratuitous complexity especially when debugging stacks where both types are used. The names of NSView type variables have been adjusted too. (cherry picked from commit 5e6120c21a979c05bc6b9297035e31a47b98b785) Conflicts: vcl/aqua/source/app/vclnsapp.mm vcl/aqua/source/gdi/salgdi.cxx vcl/aqua/source/gdi/salgdiutils.cxx vcl/aqua/source/window/salframe.cxx vcl/aqua/source/window/salobj.cxx vcl/inc/vcl/sysdata.hxx vcl/source/window/syschild.cxx vcl/source/window/window.cxx Change-Id: Ic4143dfddfa9502a529c871ac4ce0bea413b6ce9
2013-12-04Rename coretext/salgdi2.* to coretext/salgdi.*Khaled Hosny
The "2" part was a temporary measure so an older version of the file, that is long gone, can coexist. Change-Id: I3a22b287bfb1351bb73e9dabbfa67100fe17bb97
2013-12-04Add a commentTor Lillqvist
Change-Id: Icd7ecafa46392133b8f6b82574a699e843ce588f
2013-12-04Bin ATSUI codeTor Lillqvist
TDF has been shipping a CoreText-using LO since 4.1 and the sky hasn't fallen. Getting rid of the ATSUI code will make other needed refactoring easier. Change-Id: I494096c3988ea26fa2b336621857d32b64b040f0
2013-12-04Device-specific font substitution is not usedKhaled Hosny
This was only used for printer built in fonts, which was dropped in the previous commit. Change-Id: Iff62786284470ff3873c8d4b0aae0614bf69c7f3 Reviewed-on: https://gerrit.libreoffice.org/6859 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-03vcl: fix sal_Int32 GetTextBreak harderMichael Stahl
Change-Id: I75181d12ca8b883055e5314504633af38b5e49c7
2013-12-03longparas: convert GetTextBreak to sal_Int32Caolán McNamara
Change-Id: I693e4c9916e1968c33ebd922829662f6efc27bfb
2013-12-02No idea what maOwnContextMemory isTor Lillqvist
Change-Id: I8ebda0c7da3cb663802fb8b05a98115db7589e09
2013-12-02Make include guards sane in vclTor Lillqvist
We have a convention. Use it. Kill copypasta. Change-Id: I512e1c8e75b5da20b6756ffc88209a27674ad7c7
2013-11-29Fix bit-rot in the ATSUI codeTor Lillqvist
But do we want to keep that code still around? I would love to drop it. Using only CoreText would make some planned refactoring of OS X and iOS code much simpler. Change-Id: I9514c254791ea462d528e3e83b4927ac62a9f6ca
2013-11-25Resolves: fdo#41169 fix MacOSX non-Latin keyboard layout with Latin shortcutsCaolán McNamara
Change-Id: I168de52d6185d5df9c41fd2d7a68c0ff3f733852
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-14remove unnecessary sal_Unicode casts in VCL moduleNoel Grandin
Change-Id: I79da72097e8bc86891075d1484a59b5599a063d0
2013-11-13fdo#68174: Default to large icons on OSX too, regardless of the DPI.Jan Holesovsky
Change-Id: Id7a8ebe6642e032e370dce2832ccaa2350fdcba8
2013-11-10fdo#71321: We should not actually use the delta-is-pixels concept on OS XTor Lillqvist
Despite the comment in salwtype.hxx, and despite it being set, before 4e7495ac2cb6b015ad492def45fd24f4ba0f54f8 the mbDeltaIsPixel flag had not been used for anything on OS X (or other desktop OSes). So when the code was modified for the sake of touch devices to do take mbDeltaIsPixel into consideration, that code path was incorrectly taken also on OS X leading to incorrect scrolling. Change-Id: I7cbca4656037eefce963e976f6acf8fbb32d5269
2013-11-07remove unnecessary use of OUString constructor in VCL moduleNoel Grandin
Change-Id: Ie2b9aca5c3db46b43c53f72699fe828b28daeaa1
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28fixincludeguards.sh: vclThomas Arnhold
Change-Id: I3858c2152267474afab8e5a72b9f5da0ac623012
2013-10-22aqua String remnantsCaolán McNamara
Change-Id: Ic574acda26775848918dc42ce3bce43c731ae267
2013-10-22sneaky macosx StringsCaolán McNamara
Change-Id: I4baa3c144c357d3622c1d6b6a32435e52059d897
2013-10-21String -> OUStringStephan Bergmann
Change-Id: Iabb80c72f9e6aab3b58590299ce9f22e0ae1a5fa
2013-10-21Remove GetKernPairs() with no implementationKhaled Hosny
I left only the Windows one because it being called (as GetKernPairs(0, NULL), but may be it does something, who knows). Change-Id: Iec05d61c8f0cd311a1158bb1cb07e4ee977f32fe Reviewed-on: https://gerrit.libreoffice.org/6260 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2013-10-16cleanupThomas Arnhold
Change-Id: I7bfd221f89718ba8634417c93a26b3a199178694
2013-09-27Related: fdo#38838 remove UniString::SearchBackwardCaolán McNamara
Change-Id: Ia474ee07b1bd411eae8cd1ddd55c4fa83dbd5f47
2013-09-06Fix misspelled text with VoiceOver on 10.9Boris Dušek
More in Apple's docs (Application Kit Release Notes for OS X v10.9, section "New Accessibility constants"). Change-Id: I92fb6d552e86997bfc789723f32626d908d11419 Reviewed-on: https://gerrit.libreoffice.org/5831 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2013-08-24Fix a11y logging with 10.6 SDKBoris Dušek
The compiler in 10.6 SDK complains about ambiguous overload for operator<<. Compilers in newer SDKs don't. Change-Id: Id0b710a8668021d15754fa6eaea492a91557e34e Reviewed-on: https://gerrit.libreoffice.org/5604 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-22The AppleRemote code is blocked by sandboxing so bypass it in that caseTor Lillqvist
Change-Id: I0e86c82fb81732468cf0a60eb8ff1d0579986767
2013-08-21Fix build with compiler from OS X 10.6 SDK (hopefully)Boris Dušek
The compiler in 10.6 SDK probably still requires methods to be defined in such an order that one should not reference a method from a line of code that precedes the one where the method is defined. Compilers in newer SDKs support arbitrary order, as long as the requested method is defined anywhere. This is consistent with other methods in the same file that are not declared anywhere (just defined and used apparently in the order I wrote above). Change-Id: I14ba699056b6cdd2e804dbc87cfedaef47663664 Reviewed-on: https://gerrit.libreoffice.org/5576 Reviewed-by: Boris Dušek <me@dusek.me> Tested-by: Boris Dušek <me@dusek.me>
2013-08-21WaE: 'valueOf' is deprecatedTor Lillqvist
Change-Id: I4ede98469af655dfbac64eee719869f8f3c8d473
2013-08-19fdo#39007: Brute force fix: Unlink a potential restorecount.plist fileTor Lillqvist
It is not completely clear to me whether we really still might be leaving such files around. After all, we now in *two* places (at least in current master) tell our NSWindows to not be restorable... Norbert's code in AquaSalFrame::initWindowAndView() *and* Herbert Dürr's code in -[SalFrameWindow initWithSalFrame:]. On the other hand, Cocoa does seem to create the file and keep it around for a short while before removing it (in responce to our setRestorable:NO calls?), so there is a slight time window where if LO crashes, the file will be left around. Such a file might also be around from an older LO version, or manually planted there by somebody wanting to reproduce the bug... Of course, the *real* fix for this problem would be to make LO a *proper* Cocoa document centric application, that would use NSDocument, NSApplication etc like native applications are supposed to, and that *would* handle window restoration the Cocoa way. I.e., work with the system instead of against it. Change-Id: I9ed058130ddddf49cf0221d899bef3e2654589c7
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-08-16Fix build breakage for 64-bit where NSPoint == CGPointTor Lillqvist
Change-Id: I2dc86331cd1ddf3a9b9ea28dcd881d23789d60d6
2013-08-12Make VoiceOver announce paragraph alignmentBoris Dušek
Change-Id: I7d9d012e0af3b5685421ca2f10d2d8cb3420cc15 Reviewed-on: https://gerrit.libreoffice.org/5352 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-12fdo#67980 - VoiceOver does not inform about misspelled textBoris Dušek
Change-Id: I4aefa1c013e62942801dd38a06034103c0df24be Reviewed-on: https://gerrit.libreoffice.org/5351 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-12Add XAccessibleTextMarkup to AquaA11yWrapperBoris Dušek
Change-Id: Ic15aeb46b384531c4d64d6ec8a103f3e44068cf1 Reviewed-on: https://gerrit.libreoffice.org/5350 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-12Refactoring: remove 3 unneeded ivarsBoris Dušek
The default font size, font name and font traits were stored as ivars of AquaA11yWrapper, but they are in fact only needed as temporary state for the createAttributedStringForElement:inOrigRange: method of AquaA11yTextAttributesWrapper. So remove these 3 ivars and instead introduce a class that holds these 3 properties and make createAttributedStringForElement:inOrigRange: use instance of this class to hold the needed state instead. I checked that the default font size, font name and font traits ivars are really only used in AquaA11yTextAttributesWrapper at that one place. Change-Id: Id2e45977c394db116f3fb0636136300c23e71f25 Reviewed-on: https://gerrit.libreoffice.org/5346 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-12fdo#67957: Font name reported in AXFont always Times New RomanBoris Dušek
This is a partial fix. Now VoiceOver does report changes in font faces but it works correctly only when the paragraph text style has font "Times New Roman". If it has not, then parts of the text with "Times New Roman" have not change in font reported, but parts with font different both from the paragraph style font and "Times New Roman" do have font change reported. In other words, the default font for paragraph is still "Times New Roman" in accessibility even though sometimes it's not true. This also fixes font size being reported only when bold or italic is set, and has more robustness for handling mixed bold/italic when at least one of them is set in the paragraph style as well. Change-Id: Id0715727d04cd9b814aa0e4093939cd3e6abe897 Reviewed-on: https://gerrit.libreoffice.org/5344 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2013-08-10fdo#67680: Impossible to search for text attributes with VoiceOverBoris Dušek
Change-Id: I02ae12233aa37830106eeffd16876670413f4627 Reviewed-on: https://gerrit.libreoffice.org/5334 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-10Transform left SAL_DEBUG output to SAL_INFOBoris Dušek
Change-Id: Ic3528a8a349ec8e6929ceed8c5e3ec8d2a6232c1 Reviewed-on: https://gerrit.libreoffice.org/5333 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-07Use NSAccessibilityActionDescription for action descriptionsBoris Dušek
Change-Id: I26a233e72274be7afc2e3e41e13a6743f75e695f Reviewed-on: https://gerrit.libreoffice.org/5238 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-07Fix accessibility of text attributes on OS XBoris Dušek
The applyAttributesFrom:... method takes range parameter that specifies a range in the 'string' parameter passed to that method, not in the whole string of the UI element as retrievd in createAttributedStringForElement:... (the former string is a substring of the latter). In other words, the 'range' parameter in applyAttributesFrom: is relative to the string passed to that method, not to the whole string of the UI element. This enables proper reading of text attributes in Writer - when moving cursor through text, VoiceOver now announces e.g. "bold" or "plain" to indicate changes in text formatting. Change-Id: I21a633af0bf426759f639435581fcd3bfeafa598 Reviewed-on: https://gerrit.libreoffice.org/5236 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-07Add debugging output for OS X accessibilityBoris Dušek
In case someone needs to debug accessibility on OS X, provide ready debugging messages to be enabled by changing #if 0 to #if 1. Change-Id: I4d0c0b11d12aa2419c53da7656a881f43c436d87 Reviewed-on: https://gerrit.libreoffice.org/5237 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-04Revert "fdo#54320: VoiceOver does not follow keyboard focus"Boris Dušek
The code was correct (and docs confusing). The code did not work because 67410 was not fixed at that moment. With 67410 fixed, the code works as it was originally. Also in the meantime I discovered a comment in the NSAccessibility.h header telling that NSAccessibilityPostNotification should be passed the newly focused element and that the function itself will make sure to post the notification on the NSApp element instead. This reverts commit e9257fa0e642de2f1c79f2c80387334010812dab. Change-Id: I7f76ebde963cf57879273d9848ff195877759524 Reviewed-on: https://gerrit.libreoffice.org/5239 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-02NSAppKitVersionNumber10_7 is not surprisingly not defined in 10.6 SDKNorbert Thiebaud
Change-Id: I68cba736de084a19d1dc92a3ccdd66b653f975c6
2013-08-01fdo#67410: VoiceOver does not provide typing or cursor movement echo in textBoris Dušek
Change-Id: Ief39aecd247b612c52cd970b6c5911f34d8cb69e Reviewed-on: https://gerrit.libreoffice.org/5208 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-30Adapt to NSPrintInfo API changeTor Lillqvist
Change-Id: Idce313b30b46a81847e116c380f6fe8eb2953a35
2013-07-30WaE: cast to 'id' from smaller integer type 'int'Tor Lillqvist
Change-Id: I0106bac830416ef9743787b309ca2821dd6adc89
generated by cgit (git 2.34.1) at 2024-08-04 21:40:07 +0000