summaryrefslogtreecommitdiff
path: root/vcl/inc/svimpbox.hxx
AgeCommit message (Collapse)Author
2023-08-23tdf#146619 Remove unused includes from vcl/incGabor Kelemen
Change-Id: I8fbe02547d5045cfdb5021720b10ddd10106209a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155750 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-07-05loplugin:constantparamNoel Grandin
Change-Id: Ib7bba815fcd4d2d4092bdd96055517468f6c6b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-09move scrbar.hxx to vcl/toolkitCaolán McNamara
Change-Id: I77038cbf500976703ad41365da9a675a698863a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137979 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-01Introduce weld::IconView::insert_separatorMike Kaganski
Needed to eventual re-implementation of starmath's SmElementsControl using IconView. This required re-implementation of IconViewImpl, to layout entries by iteration, because now it's impossible to find an entry position just based on its index. This coincidentally fixed some visual glitches in non-gtk IconView implementation from commit 5813660e7bfe128ac076e592fe31de64a6863780 Author Szymon Kłos <eszkadev@gmail.com> Date Tue Feb 16 16:03:30 2016 +0100 icon view for RemoteFilesDialog where any selected element could become first in row when scrolling. SvTreeListBox::SetEntryHeight taking a SvTreeListEntry const* had to be renamed to CalcEntryHeight, to avoid both virtual and non-virtual overloads, additionally having different accessibility. A TODO is implement separators in GtkInstanceIconView. I couldn't find a GTK API for separators in IconView, so possibly a workaround would be needed with some non-selectable narrow elements. Change-Id: Ie8dc35d94049a1c48e4eb49697681ffbe93c17f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135112 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-11GetDontKnowNodeBmp is always emptyCaolán McNamara
so this is dead code, remove most of it, but recover setting aControlValue.setTristateVal(ButtonValue::DontKnow) when the possibility of expansion resulting in children is unknown Change-Id: Idc2abd9af70402a92d02ed2273ab1df6684b16fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30loplugin:constmethod handle more casesNoel Grandin
remove some of the naming limitations, and handle pointer parameters better. I only let the plugin run up till vcl/ Change-Id: Ice916e0157031ab531c47f10778f406b07966251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-18tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButtonArmin Le Grand (Allotropia)
The original method SvTreeListBox::StartDrag always triggers a MouseButtonUp event and tries to initiate a Drag of a Line of a TreeListBox (on MouseMove, btw). This is not wanted if the last MouseButtonDown started a ButtonActive mode and activated CaptureMouse, prepared to trigger Action on that Button on MouseButtonUp. It leads to unwanted/strange behaviour of Buttons/CheckBoxes when used in TreeListBoxes. The behaviour is also dependent on the UI implementation used under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all (unfortunately) behaving differently, but a first suggestion/ step to enhance the situation. Found now for gen/qt5/kf5 that when on the LineEntry, but not on the CheckBox, on MouseButtonUp the other line gets switched. Corrected that. Also moved call to base class method MouseButtonDown in SvTreeListBox to the end of function due to that call may lead to current incarnation getting disposed. That was the reason for the crash described in tdf#143749 Note: for gtk3_kde5/gtk3 there remains the problem that the CheckBoxes get switched on MouseButtonDown, butt these are generic widgets and this needs to be solved differently. Change-Id: I9b73d9a7230469664dd6041f81b399e7d933852b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120593 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-08-16Revert "tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton"Julien Nabet
This reverts commit ca7dab5d96e73b7b4b045e2460e0b2ee150757db. It created tdf#143749 + the dup tdf#143865 Change-Id: Ibd68c45213491b0df7dc36f0418de307412499c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120531 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-31tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButtonArmin Le Grand (Allotropia)
The original method SvTreeListBox::StartDrag always triggers a MouseButtonUp event and tries to initiate a Drag of a Line of a TreeListBox (on MouseMove, btw). This is not wanted if the last MouseButtonDown started a ButtonActive mode and activated CaptureMouse, prepared to trigger Action on that Button on MouseButtonUp. It leads to unwanted/strange behaviour of Buttons/CheckBoxes when used in TreeListBoxes. The behaviour is also dependent on the UI implementation used under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all (unfortunately) behaving differently, but a first suggestion/ step to enhance the situation. Found now for gen/qt5/kf5 that when on the LineEntry, but not on the CheckBox, on MouseButtonUp the other line gets switched. Corrected that. Note: for gtk3_kde5/gtk3 there remains the problem that the CheckBoxes get switched on MouseButtonDown, butt these are generic widgets and this needs to be solved differently. Change-Id: If4cfe894b716185293beff64fc7e482d6f6313d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119644 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-06-10loplugin:unnecessaryreturn SvImpLBox::SetMostRightNoel Grandin
Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-20tdf#139115 vcl tree list: add new toggle behaviorsAttila Szűcs
at clicking on list items with checkboxes to clean-up generic VCL plugin commit 2471d6f44c7e8ecbe86a90eeb593b899a08a7408 (tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)). This limits the new toggle-always to ScCheckListMenuControl (e.g. AutoFilter). set_clicks_to_toggle() options to set the effect of the click on a treeview list item: 0 == clicking never toggles the checkbox (default setting) 1 == clicking always toggles the checkbox 2 == clicking only toggles the checkbox of a selected list item, i.e. the first click selects a not selected list item, and only the second click toggles its checkbox. It would be better if we could set this information in the .ui files, but I did not find a good way for that. A good place in the code to call this function can be found by searching for the .ui filename. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I5c72d710508fc397f2b6f959d7680b23f8dc6f67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108947 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-19use tools::Long in vclNoel
Change-Id: Ice1055021e8568634e9a66ba89d3bb4ef4e731df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel
Change-Id: If7fbb25037343e18081a8ee7064840d75e9a45a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104010 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I4cd20d1a449196b68c7dbe153c60e68b9563bea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17loplugin:unusedmethodsNoel Grandin
Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:unusedmethodsNoel Grandin
Change-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08loplugin:virtualdeadNoel Grandin
Change-Id: Ib2a4ebad50e9c6f0d71a9ac3a1bc8ac11e775496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-19compact namespace: vclNoel Grandin
Change-Id: Ic861003f522e76431fffaadc408d0a153b12d0e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-06focus rect in treeview doesn't match the selected areaCaolán McNamara
regression from... commit 753084a3f73bb8a88412feac7aa40a2750e6e9f3 Date: Wed Dec 11 12:56:57 2019 +0200 loplugin:singlevalfields which detected that m_bIsCellFocusEnabled is always false but inadvertently make a change of -void SvImpLBox::CalcCellFocusRect( SvTreeListEntry const * pEntry, tools::Rectangle& rRect ) +void SvImpLBox::CalcCellFocusRect( tools::Rectangle& rRect ) { - if ( !(pEntry && m_bIsCellFocusEnabled) ) - return; which treats m_bIsCellFocusEnabled as always true. Always false would make CalcCellFocusRect a no-op so just remove the method to fix things. Change-Id: I46bfa122058a9e4384d2b1e2dc9e844ada22cc69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-16loplugin:unusedmethodsNoel Grandin
Change-Id: I52187eccf6170f64d38c673a86dc80818813efa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16Drop redundant member functionMike Kaganski
SvImpLBox::GetCurrentEntry was identical to GetCurEntry Change-Id: I2ede6ecd8516a2a76fe504e30b5195f3950b340e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92294 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-02loplugin:unusedmethodsNoel Grandin
Change-Id: I906234a38b96c6ba6eaadf7693abd33e98debf50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-27these methods can take a const argumentCaolán McNamara
Change-Id: I0ec68d40dcc34075c72c0d60d3a4b6e8262a8e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03loplugin:constantparamNoel Grandin
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-31loplugin:singlevalfieldsNoel Grandin
Change-Id: I77ccf3f36363e182a644b98cdf720f1381a5cceb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-13loplugin:unusedmethodsNoel Grandin
Change-Id: I4eae284cf763b260dd9349bf8d31f46612916de1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13loplugin:singlevalfieldsNoel Grandin
Change-Id: Idec5a7a732d5dc868ad3f9a147e18ee9685645e2 Reviewed-on: https://gerrit.libreoffice.org/85076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12loplugin:finalclassesNoel Grandin
Change-Id: Ia9865271cf0a75ebf4b885ff376f7d0a152b2555 Reviewed-on: https://gerrit.libreoffice.org/84925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17loplugin:unusedmethodsNoel Grandin
Change-Id: I04deb5a1dee5b8a9a4508d28552ffe0b67288993 Reviewed-on: https://gerrit.libreoffice.org/82977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-16loplugin:singlevalfieldsNoel Grandin
Change-Id: I31fd6b251dee9d1ee1a9ac59964034d0136e1f3e Reviewed-on: https://gerrit.libreoffice.org/82978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-07loplugin:unusedmethodsNoel Grandin
Change-Id: I65354c7476dfaede1a607441d7c1b0c7ad038df4 Reviewed-on: https://gerrit.libreoffice.org/82186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29svimpbox.hxx now only included by vclCaolán McNamara
Change-Id: I0dd7691d0be8a3f54a7bcace17a36dce0ed17931 Reviewed-on: https://gerrit.libreoffice.org/81677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-03 20:52:59 +0000