summaryrefslogtreecommitdiff
path: root/vcl/inc
AgeCommit message (Collapse)Author
2021-12-11tdf#145322, tdf#144378 fix printing for vertical writingMark Hung
Printing still uses ExTextOutRenderer to render text because Skia haven't yet support printing and DWriteTextRenderer can't bind the printer DC. ExTextOutRenderer uses win32 API ExtTextOutW. In order to renderer upright CJK text in vertical writing with that API, the HFONT created with CreateFontIndirectW needs a font name prefixed with '@'. OTOH, use '@' prefixed font with Skia break the vertical writing unit test. - WinSalGraphics::ImplDoSetFont: use '@' prefixed font name if the requested font is vertical and is for printing. - ExTextOutRenderer: use SetTextAlign and text metric tmDescent to adjust vertical glyphs. It's not consistent with Skia or DWriteTextRenderer, and is still incorrect in many cases. The patch is adapted from reverting commit 5686c1aca40beb9514d40c86b4a3780a8a1334ba Author: Mark Hung <marklh9@gmail.com> Date: Sun May 2 14:45:45 2021 +0800 vcl: use DWriteTextRenderer for vertical writing. Change-Id: Ib2d3df8b68cad4bebe0672c9da0a16b62aed99e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125978 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126545 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-10-06Related: tdf#141633 similiarly support match combo/listbox font sizesCaolán McNamara
to the desired zoomed font size in the table control Change-Id: Iaf3b004544fdb0311b6c67baad612ba648e8c546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123052 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-05tdf#144846 launch gtk3 menubar menus from LibreOffice codeCaolán McNamara
rather than using the builtin gtk mechanism so we can avoid duplicate mnemonics in the sidebar getting used instead. Change-Id: I6c761ae63ae25d835de9444b0e298c63996a83a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122928 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-04tdf#141633 set correct font sizes in tableview child widgetsCaolán McNamara
Change-Id: Ic96a0ad8203bf3903546c0c2f07d96254ca01e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 61050c6d7b8bceef2704eba0bfe4473ee75e669d) contains... Related: tdf#141633 PointFont gets overwritten by ControlFont Change-Id: I26ffffe7917d109ddc61fd2d2646db0988937c7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4e2306a5e336e2b43759c9712535626d0f2c168f) Related: tdf#141633 support setting a custom font for TextView Change-Id: I4c27a21c5c682fc73c37594749627e4cc7c0822d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4d445ac9aa43b3399a579e3dbb1aac94507c9520) tdf#141633 multiple line entry font size/zoom not taking effect The "sample db" example (Mockup.odb) has multiline entries used in its "Journal Entry" column. Those are painted by taking snapshots of a never-really-shown textview widget. But the textview is always drawn using its original default font size and changing the page zoom and/or font size had no effect on the size of text in the "Journal Entry" column. explicitly emit style_updated to get the GtkTextView to sync its font size from the css changed by the set_font Change-Id: Ic7d644b13c28f30a2c646b9d4098ea6e7f0dab81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 36d5e26549b273118cea8969c43ef5ad3845f8df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123041 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-09-25tdf#144585 Qt5 restore old VCL popup handlingJan-Marek Glogowski
So while it works with X11, the Wayland situation seems much worse. Eventually we want to use Qt::Popup as a window type, because that implies special handling for Wayland, but the additional private Qt mechanisms this implies conflict with VCL handling, especially input + focus handling with ComboBox. I'll re-check (again) how Qt itself implements this and maybe that solution is adaptable to VCL. This re-introduces the problem, that "DropDown/PopUp stays open and in FG when changing app on Linux desktop (keyboard, ALT+TAB)", original reported as part of tdf#143114, which is some kind of kf5 catchall bug report. Just revert for 7-2. Hope we find a better solution on master, which can be backported later. This revert includes: - "tdf#144037 Qt5 just close popup with mouse outside" commit 7c1f4284562e905372b5c14b6017f1eb438f54b5 - "tdf#143580 Qt5 don't use Qt::Popup for FLOAT wins" commit ea2f19827db330a21c7962bdd13b1b838821bd4c - "Qt5 fix Qt::Popup window handling" commit 7e6fee830116823b9cd8e46d6962df4ea2bc1ea6 Change-Id: Ibf56187e00232f6c75cdbbc82ce915f80214a136 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122356 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-23tdf#144624 Prevent infinite recursion when loading SVG iconAleksei Nikiforov
When Generic/X11 VCL backend plugin loads SVG icon, it creates virtual device for rasterizing an SVG icon, which in turn tries to load an SVG icon, and thus infinite recursion happens. Change-Id: I7559b6255e6718e64ef4a6e7c79d597375e5823a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9b4478e62c712ef0f75c4a001e260dfdd6b3ca4c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122518
2021-09-06tdf#144289 invert / disable default OpenGL supportJan-Marek Glogowski
... and as a result drop setting a default in SalSvpInstance. This is also more consistent: now you must explicitly implement CreateOpenGLContext() and set "m_bSupportsOpenGL = true". Change-Id: I591580bf134907213b8308e0843c278d2f470ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 50238bddf0e95169007cb90479cca86849a19007) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121635 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-08-25tdf#143957 Qt5 always create an OpenGLContextJan-Marek Glogowski
Nothing checks the result and a lot of code just uses it. Change-Id: I1a672e98d42673fd684538ead831622f6a14e9f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120761 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 0f7fed9249e988ca34c5401d746887822b4aa9ce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120776 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25VCL allow plugins to declare OpenGL supportJan-Marek Glogowski
... and get rid of the whole GetBackendCapabilities, which was just overkill. Maybe this should even be some bitmap + enum + set/get function, but I'm too lazy... In the end add a bool for the OpenGL support of the VCL plugin (or maybe sticking it into ImplSVData, which is already some catchall for common VCL data). Change-Id: I9f0ececac482d8e2a94ef6024628e9631b49e773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9ca30cd1d04cf39411c3ede687805c28ebe2a980) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120775 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-30tdf#143580 Qt5 don't use Qt::Popup for FLOAT winsJan-Marek Glogowski
Main problem is, that Qt::Popup grabs the focus and therefore generates a focus-out event for the combobox, which then closes the just shown popup window. The grab happens inside QWidget private code and there is no way around it. But instead of "faking" Qt::Tooltip, this uses Qt::Widget with additional flags. Regression from commit 7e6fee830116823b9cd8e46d6962df4ea2bc1ea6 ("Qt5 fix Qt::Popup window handling"). Change-Id: Ia1f8e33d98f7ec36cf1ebc350886121dfaadd658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119691 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 9dcf5816c90e9819861332f11e014ef7b78e2fe7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119621 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-21tdf#143298 Qt5 send SalEvent::KeyModChange eventsJan-Marek Glogowski
I originally omitted this in the Qt implementation, as I couldn't find any non-working use case. The implementation got a bit hacky, because Qt doesn't have a non- native way to identify different L/R modifier keys, so we must process the X11/xkb keycode ourself, which obviously won't work on Wayland... but most times this is not relevant, so the default modifier notification may be good enough. P.S. it's basically the same code then X11 and Gtk... Change-Id: I37fbfde4a33a966b6017f3e0c280e2c7ea91e4db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119235 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119191
2021-07-21tdf#143334 Qt5 don't reset buffer on style changeJan-Marek Glogowski
This bug was "unveiled" by commit 963f252cd1ea9c268a6ced68a3454b10cbee1a89 ("Qt5/KF5 get rid of unneeded own grahics handling"). I'm not sure why I ever came up with that code. Eventually we would need a paint event, but at least changing the theme correctly updated LO UI, so that seems to be handled correctly. Change-Id: I528b551180be184427eeeeeb2977e2b7da073ce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119237 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit ec77a2ed0283cb3446f6e352fc329afd3dfb785c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119190
2021-06-29tdf#143088 multiple Application::EventListeners is expensiveCaolán McNamara
use a Window level Listener and a WindowChild Listener instead An example for the need to listener to children is the calc conditional formatting dialog where clicking on any subentry of an collapsed entry is expected to expand that entry Change-Id: Ifead2fc1b75457d3ad314fdf15d343395afae6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-24tdf#142560 handle cached glpyh items in ImplGlyphFallbackLayoutMark Hung
Fallback layout beyond level1 isn't generated because pre-caculated glyph items does not contain glyph items that needs to fallback, i.e. when calling ImplLayoutArgs::PrepareFallback. Hence it produce no maFallbackRuns and maRuns. The patch changes ImplLayoutArgs::PrepareFallback so that it use pre-caculated glyph items in the next level to create maRuns to ensure the same fallback layouts are genrated as layouts generated without pre-caculated glyph items. Change-Id: I672f3be6c4915892792b3cb968ad4a325465ccc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117105 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit 10ea27faec115d4cffd6f66cee8f688399e1e0b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117570 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-10loplugin:unnecessaryreturn RoadmapWizardNoel Grandin
Change-Id: I269fd92a6076fe9ebe18646e537e7031aec47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116976 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SvImpLBox::SetMostRightNoel Grandin
Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SalX11Display::DispatchNoel Grandin
Change-Id: I270f6538d921ad2116cc29ada3e4543027531764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10loplugin:unnecessaryreturn SalFrame::SetPluginParentNoel Grandin
Change-Id: If927a834f5b5d722fc36cce40e161597af6234ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-10avoid possible repeated cairo surface creationLuboš Luňák
Doing the frame size adjustments only after the if condition meant that in headless mode the surface could be destroyed and created again for the same size. Also AcquireGraphics() passed different frame size to SetGraphics() than SetPosSize(). Change-Id: I9d6884a3917dfbd7b2cfe4fcd4e350c8bc9f4305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116272 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-06add x-office-calendar to allow symbolic namesCaolán McNamara
for gen map to existing sc/res/date.png Change-Id: Id85f5df27fd93deb7d1e653ae6cac1fb471d3470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use sfx2/res/menu.png for open-menu-symbolicCaolán McNamara
which we do already in additionsdialog etc and is a better match for open-menu-symbolic Change-Id: I5b466945b9f045cc2bdf122b05ae4e85485bbef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-06use open-menu-symbolic for menubutton gear menusCaolán McNamara
https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-03split .ui conversion code into its own fileCaolán McNamara
Change-Id: Ie27990a497e39ab2fd82a711fa4ec49b472616f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-01drop unused Widget::set_secondaryCaolán McNamara
Change-Id: I63e69ca9daa8a452eee28333d8639d1db093e826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31gtk4: enable cut and paste into other applicationsCaolán McNamara
Change-Id: I9924a9af10532254dc368e274e4a20c6706e4239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-31cid#1485136 Structurally dead codeCaolán McNamara
Change-Id: Ic02110bd0e4387ed41b2852cba7d070fb7014bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-30gtk4: inch towards providing clipboard contentCaolán McNamara
inheriting from GdkContentProvider and implementing a replacement get_value like gtk_text_buffer_content looks the way to go. Change-Id: Ic376a586b77b7f00385e5744c0bc2923f2a72c94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116397 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-29std::unique_ptr->std::optionalNoel Grandin
Change-Id: Ie3e0eb7cb7ca25536e825e30c53e112bf537b325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116379 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-29vcl: Implement static vclplug usageJan-Marek Glogowski
.. and convert Android to it. Will also be used by WASM. It's also kind of a followup on commit f5af2104fc490b90510e36bbf1d2adec8017c594. Change-Id: I3a1b5bc2eae2692e706da10c6352534433c61e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116385 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-27no need to allocate PrintFont separatelyNoel Grandin
Change-Id: I8bc213e096ad6ae83d88c548ff8685a872c5ea91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26gtk[3|4] gtk_widget_get_root returns null when no rootCaolán McNamara
unlike gtk_widget_get_toplevel which returns itself if that is the case Change-Id: If977440265bd8ae2c892ee5d52091ebf16ad03cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk4: make opengl slide transitions work againCaolán McNamara
Change-Id: Id64d8759d1c98a973445f52ccfc5df9f0e084743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116060 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk4: restore GtkFixed container for SalObjectsCaolán McNamara
put the DrawingArea into an Overlay so the overlay will take the size of the DrawingArea. Put a GtkFixed into that overlay which will then also mirror the size of the DrawingArea. Keep that GtkFixed because the SalObject stuff is set up to use a GtkFixed and its just easier to do it this way than use the overlay directly. Change-Id: I937b3740fd809660ee0edef56d5cf036f2503892 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116059 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk[3|4] separate the idea of a drawing widget and a container widgetCaolán McNamara
which were the same thing in gtk3, lets try an overlay for now as the gtk4 container Change-Id: Id368ddf5ef80a17453ea7fb5662b23897975d21e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116058 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk[3|4] add a queue_draw to avoid GtkFixed castCaolán McNamara
Change-Id: I093b62f9530b28ae932338163606e78fca5752d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116057 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk[3|4] wrap gtk_im_context_set_client_[widget|window] variantsCaolán McNamara
Change-Id: I939786e45929ca81dcda479d0fc897f449f890ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk[3|4] wrap surface_create_similar_surface variantsCaolán McNamara
Change-Id: Iaa101b1d691fa84693b350460a4c69a1f5aad245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk[3|4] wrap gtk_widget_get_window/gtk_native_get_surfaceCaolán McNamara
Change-Id: I21c1cf9ab65e056242f09c8c2bbd84afa9ac42e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116044 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk4: get DrawingArea working enough for tip of the day dialogCaolán McNamara
Change-Id: Ifd2f4029b521d8f513f4fa738e4ce1e59c0ade0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116042 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24fix Skia Windows text renderingLuboš Luňák
This is quite some trial and error, but now it seems all CJK text rendering works properly. I tested tdf#136081, tdf#137907, tdf#103785, tdf#106295, tdf#114209 and tdf#141715. Change-Id: I40e893f66281b0a1a0e814feec3f782ceeb0c535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115620 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-05-24fix font scale width handling for Skia/X11 (tdf#136081)Luboš Luňák
We get width+height, for vertical text width is the font "height". This means we need to use two different fonts, one for "normal" glyphs and one for vertical glyphs. Change-Id: I9d190fc28286055a18c3d5c3ec75515c7c1d4373 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115618 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-05-24gtk4: make generic paste work againCaolán McNamara
Change-Id: Ic78a674f8cb0bf846a5cd90bb1b2cd27c7cb2151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24rename m_aMimeTypeToAtom to m_aMimeTypeToGtkTypeCaolán McNamara
Change-Id: I91d1031ec2feb2c434bb7c2fa18e632738a315b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116024 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-24gtk4: make basic text pasting work againCaolán McNamara
Change-Id: I23b029f7accb7ee65f1dfdf1eaa2643faafff14a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116023 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-23gtk4: add clipboard_get for differing ways to get clipboardsCaolán McNamara
inch a little closer to cut-and-paste Change-Id: I1e334a0ef4dca274e619376bad8eef7d9caa2cee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-22gtk[3|4] there's only two options, 'clipboard' or 'primary'Caolán McNamara
Change-Id: I70d8426a3864551b7632d535864e3639065d0be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-22gtk4: reenable TextViewCaolán McNamara
assume for now that old workarounds can remain disabled Change-Id: I64a566985f227db9a2c2d3ef760b4fc324815b2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20move some headers inside modulesNoel Grandin
Change-Id: I2baa9e9334850cf72e8ea1e96a2177a1c052e589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>