summaryrefslogtreecommitdiff
path: root/vcl/inc
AgeCommit message (Collapse)Author
2017-04-26use strong_int for LanguageTypeNoel Grandin
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25fix attempt to load converted bitmap resource uses from vclCaolán McNamara
Change-Id: I9be76bc1ec87b6837df30c2e73729ae1d5cca690
2017-04-25remove chart2 bitmaps from .src filesCaolán McNamara
Change-Id: I8ae690b510e69df65e7383e38f054580b8a5ab9d
2017-04-25remove bitmaps from .src filesCaolán McNamara
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25loplugin:checkunusedparams in vclNoel Grandin
Change-Id: I26661684e634aa15a18f78442de15c9db832f319 Reviewed-on: https://gerrit.libreoffice.org/36886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24tdf#107205 vcl: don't always use D2DWriteTextOutRendererMichael Stahl
... because it cannot rotate text. (regression from commit df556aa47da22f96b3fcd356c12419d3035cba3c) Change-Id: If9bc6e98b8979c5eb02f1a5cfc12b4d19bdc481b
2017-04-22Don't keep gGlobalGlyphCache, gTextureCache around until exitStephan Bergmann
Those static variables had been introduced with 56c5a0ba7781a325123852737970fa7f0179ff7f "tdf#94682 limit the number of textures for the glyph texture atlas" and dea885f80a80c6a5839ee5dbf8521487186a9522 "opengl: cache native widget textures also for Windows", but at least the clang-cl build crashed on exit from soffice.bin with > Exception thrown at 0x00007FFF3906AA84 (opengl32.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000898. > opengl32.dll!glGetString() Unknown > epoxy.dll!epoxy_glGetString_dispatch_table_rewrite_ptr(unsigned int name) Line 46456 C > epoxy.dll!epoxy_glGetString_dispatch_table_thunk(unsigned int name) Line 46456 C > epoxy.dll!epoxy_is_desktop_gl() Line 299 C > epoxy.dll!gl_provider_resolver(const char * name, const gl_provider * providers, const unsigned short * entrypoints) Line 7323 C > epoxy.dll!epoxy_glDeleteTextures_resolver() Line 14646 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_rewrite_ptr(int n, const unsigned int * textures) Line 45813 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_thunk(int n, const unsigned int * textures) Line 45813 C > vcllo.dll!TextureState::unbindAndDelete(unsigned int nTexture) Line 59 C++ > vcllo.dll!ImplOpenGLTexture::~ImplOpenGLTexture() Line 182 C++ > [External Code] > vcllo.dll!PackedTextureAtlasManager::~PackedTextureAtlasManager() Line 129 C++ > vcllo.dll!GlobalGlyphCache::~GlobalGlyphCache() Line 67 C++ > [External Code] > vcllo.dll!??__FgGlobalGlyphCache@GlyphCache@@0V?$unique_ptr@UGlobalGlyphCache@@U?$default_delete@UGlobalGlyphCache@@@std@@@std@@A@YAXXZ() Line 48 C++ > [External Code] resp. > Exception thrown at 0x00007FFF3A5AAA84 (opengl32.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000898. > opengl32.dll!glGetString() Unknown > epoxy.dll!epoxy_glGetString_dispatch_table_rewrite_ptr(unsigned int name) Line 46456 C > epoxy.dll!epoxy_glGetString_dispatch_table_thunk(unsigned int name) Line 46456 C > epoxy.dll!epoxy_is_desktop_gl() Line 299 C > epoxy.dll!gl_provider_resolver(const char * name, const gl_provider * providers, const unsigned short * entrypoints) Line 7323 C > epoxy.dll!epoxy_glDeleteTextures_resolver() Line 14646 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_rewrite_ptr(int n, const unsigned int * textures) Line 45813 C > epoxy.dll!epoxy_glDeleteTextures_dispatch_table_thunk(int n, const unsigned int * textures) Line 45813 C > vcllo.dll!TextureState::unbindAndDelete(unsigned int nTexture) Line 59 C++ > vcllo.dll!ImplOpenGLTexture::~ImplOpenGLTexture() Line 182 C++ > [External Code] > vcllo.dll!OpenGLTexture::~OpenGLTexture() Line 313 C++ > [External Code] > vcllo.dll!TextureCombo::~TextureCombo() Line 51 C++ > [External Code] > vcllo.dll!std::pair<ControlCacheKey, std::unique_ptr<TextureCombo, std::default_delete<TextureCombo> > >::~pair() Line 145 C++ > [External Code] > vcllo.dll!o3tl::lru_map<ControlCacheKey, std::unique_ptr<TextureCombo, std::default_delete<TextureCombo> >, ControlCacheHashFunction>::~lru_map() Line 34 C++ > vcllo.dll!??__FgTextureCache@?A@@YAXXZ() Line 738 C++ > [External Code] Change-Id: I0198f657f5d59314c5f662c214504ed3e1523567 Reviewed-on: https://gerrit.libreoffice.org/36801 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-19only one use of GetStandardTextCaolán McNamara
Change-Id: I384e3ccb6bfaf491a4616ee89c714a510f1f670b
2017-04-19remove freshly unused menu support from src filesCaolán McNamara
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b Reviewed-on: https://gerrit.libreoffice.org/36646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-14remove the remaining unused mouse cursorsCaolán McNamara
which are not used by us directly or aliases of published awt constants Change-Id: Ic4f009715d71a2f986b8ef8d64b4b2e64986bf3b
2017-04-14revert removal of apparently unused mouse cursorsCaolán McNamara
partial revert of... commit 65b7b6322b662785bf032e66c76abc36c9a2bb0e Date: Wed Feb 8 10:40:28 2017 +0200 loplugin:unusedenumconstants read-only constants in vcl because we cast the com::sun::star::awt::SystemPointer values to PointerStyle in VCLXPointer::setType and we've at least lost the PEN as used in the slideshow context menu's pen mode "toolkit/source/awt/vclxpointer.cxx" 74L, 2181C Change-Id: I5ef677f70ebc491b50403de0f92179ea4ae3bb14 Reviewed-on: https://gerrit.libreoffice.org/36526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-13tdf#106933 vcl: delete D2DWriteTextOutRenderer before exit()Michael Stahl
As it happens this DirectWrite stuff is using some thread pool internally, and that must be shutdown before exit(), as Win32 will terminate all other threads at that point, and then the thread pool wants to talk to threads that don't exist any more. https://blogs.msdn.microsoft.com/oldnewthing/20120427-00/?p=7763/ So convert this from a global variable that is deleted from DllMain() to a member of SalData, so it is deleted from DeInitVCL(). Change-Id: I51408a07c78758cf0c193ab66b9214d0c9dbd9e3
2017-04-08vcl: Bitmap processor test - test converting to "disabled" imageTomaž Vajngerl
Change-Id: I7146d2c667ec439a07e709e0aba96c37dc780db4 Reviewed-on: https://gerrit.libreoffice.org/36293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-04-07tdf#39468 Translate German commentsJens Carl
Translate German comments and terms in dbaccess/, extensions/, formula/, include/, reportdesign/, rsc/, sd/, svtools/, and vcl/ Change-Id: Ie20dadda0eeb0786eb328c6c652287d5481c5e3b Reviewed-on: https://gerrit.libreoffice.org/36249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-04tdf#99352: assert on stray VclPtrs past DeInitBjoern Michaelsen
- ignore on Windows for now, as it is acting up Change-Id: I98dbb887ed556b58188870c3eb3de1327bc58109 Reviewed-on: https://gerrit.libreoffice.org/35816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-03iOS update for Rectanglejan Iversen
Updated Rectangle to tools::Rectangle Change-Id: I1577dffe8d51ac3a33bbc2e0771b338d5fdd0220
2017-03-31vcl android: more adaptions to tools::RectangleMiklos Vajna
Change-Id: Id85ee2a943047c22f77a758238e51e580b7d079b
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29loplugin:unusedmethodsNoel Grandin
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:singlevalfieldsNoel Grandin
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28ofz#954 out of memoryCaolán McNamara
Change-Id: Ib27f2dfe0d0837544910208f38a1bc11a35e3cb4 Reviewed-on: https://gerrit.libreoffice.org/35794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28Resolves: tdf#106155 avoid opengl for toplevel X window iconsCaolán McNamara
because an opengl context requires a toplevel window so it recurses to death. Only the gen/kde4 vclplugs are affected here Change-Id: If5396d183d90d1872931b170dc90c3a70d8ea6b6
2017-03-25Fix typosAndrea Gelmini
Change-Id: I623135cd4c76dd6569f4ee521f97dee41de4cb1e Reviewed-on: https://gerrit.libreoffice.org/35660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24ofz: explicitly release fontconfig options on every iterationCaolán McNamara
fontconfigs alloc mechanism is too complicated for lsan/valgrind so force the fontconfig options to be released at the end of every iteration, they are demand loaded so will be recreated if necessary on next use Change-Id: I061117b1fb8136298593a165847f78eabe008f0f
2017-03-24shared_ptr->unique_ptrCaolán McNamara
Change-Id: I89aa885c2d5a5c1150ac83b515c0bb84ff2ce039
2017-03-19This can move out of the header as wellKhaled Hosny
Change-Id: I995ad7fb040e11363a70ee2b5cd88e068f06771c
2017-03-19Remove GetVerticalOrientation declaration from header.Mark Hung
Change-Id: Icedd82e7a0092c18e1ff5b4ad4be22f2a30c33e2 Reviewed-on: https://gerrit.libreoffice.org/35384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19vcl: have AcquaSalInstance use osl::Condition instead of oslConditionChris Sherlock
Condition is deprecated already, but there is no need for the AcquaSalInstance class to use the low-level C-API, when in fact there is a C++ fascade that calls on this via the C++ abstraction, osl::Condition. This will make it much easier to switch to using std::condition_variable in the future. Change-Id: Ic495c4120a59480bf50a8c5b73608874fc4228ea Reviewed-on: https://gerrit.libreoffice.org/35392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18Use char instead of unsigned charJulien Nabet
to avoid some reinterpret_cast + prepare to replace some alloca calls + replace C cast by using plain char assignment Change-Id: Iff65b9a324ca1cc936c9effd2b3b71596d6e9b0f Reviewed-on: https://gerrit.libreoffice.org/35398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18vcl: make GtkData use osl::Condition instead of oslConditionChris Sherlock
Condition is deprecated already, but there is no need for the GtkData class to use the low-level C-API, when in fact there is a C++ fascade that calls on this via the C++ abstraction, osl::Condition. This will make it much easier to switch to using std::condition_variable in the future. Change-Id: Iddd2cad0e1137c0b458ebe25b506d463847a6dc0 Reviewed-on: https://gerrit.libreoffice.org/35389 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-16fix tinderbox build, ends up using gen backend and icons are missingCaolán McNamara
put the icons back, and replace the bare 1 etc which hid the usage Change-Id: Id90de7b29a29141b448107adb4028407ed203e2a
2017-03-16KDE fix various clang plugin complainsJan-Marek Glogowski
Fixes clang plugin reported problems in the KDE and KDE4 backend. Change-Id: I0280beae9dd6f33ee59bdbe89cd38222f33fdc68
2017-03-16remove unused defines from HRC files in vclNoel Grandin
Change-Id: Ic61bce94fe784d345b8c66ee2132dcc78f199808 Reviewed-on: https://gerrit.libreoffice.org/35220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-08valgrind: fix leakCaolán McNamara
Change-Id: I174225a93a15a5300a94347faf9132f01e52cfe7
2017-03-08const this upCaolán McNamara
Change-Id: Ie070a3f5c07cd7947d441ee67ca662b9d5764251
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-06Restore "pPos and pGetNextGlypInfo always have the same value"Caolán McNamara
and... "pEraseRect is always null" This reverts commit b398dacbb471913e573e9b0b4cd31d94a9109223. Change-Id: I5e7c07eefff0b6bd39d9ed7492134ea062e90fdf Reviewed-on: https://gerrit.libreoffice.org/34907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-05Revert "pPos and pGetNextGlypInfo always have the same value"Caolán McNamara
This reverts commit 7453cb58df4ce434a1252567f961cfe497064aca. and... Revert "pEraseRect is always null" I suspect the problem is the change to D2DWriteTextOutRenderer::operator in 7453cb58df4ce434a1252567f961cfe497064aca aborts during windows tinderboxes CppunitTest_dbaccess_empty_stdlib_save etc This reverts commit 073d920ef5914b5dfe491dbaf7fb18ba56293b85. Change-Id: I372e104bd09e49bcf08306169db9777f2f26fff5
2017-03-05Handle Tr vertical orientation before shapingKhaled Hosny
See https://github.com/behdad/harfbuzz/issues/355 Change-Id: Ic82d74046980fae3e7a973fee90fe5bb4f2b8588
2017-03-04pPos and pGetNextGlypInfo always have the same valueKhaled Hosny
Change-Id: Iec46e0aefff71cbeb2face4f55e5c3a4d6698995
2017-03-04pEraseRect is always nullKhaled Hosny
Simplify the code accordingly and make it return true for success. Change-Id: I661eea739e23b59ebff2573f52036b25ecb5a1ed
2017-03-04SalLayout::GetBoundRect() works just fine hereKhaled Hosny
Change-Id: Idce9a8f374f62bd92756d7391ccca3122c89683e
2017-03-04Drop dead codeKhaled Hosny
We don’t try to render vertical text with DirectWrite any more, so all of this is dead code now. Change-Id: If9f513f6b96fd65d275b9ec46c6e349f1c335bcf
2017-03-04Avoid needless dynamic_cast’sKhaled Hosny
It is all CommonSalLayout() for sometime now. Change-Id: I3d4ad56df195f51242c3d007bc5257c071a03a50
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03tdf#103831, tdf#100986: Force using GDI when neededKhaled Hosny
Our DirectWrite renderer is incomplete and can’t handle rotated text or text with horizontal scaling, so route these two through GDI for now. Change-Id: I87b85796a29e3acce782e01b4c629fec6f1a9e25 Reviewed-on: https://gerrit.libreoffice.org/34848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-02Fix typosAndrea Gelmini
Change-Id: I72db7ff99cde394bc161dfd835bfb0d9a47a53d1 Reviewed-on: https://gerrit.libreoffice.org/34780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>