summaryrefslogtreecommitdiff
path: root/vcl/inc
AgeCommit message (Collapse)Author
2017-03-25Fix typosAndrea Gelmini
Change-Id: I623135cd4c76dd6569f4ee521f97dee41de4cb1e Reviewed-on: https://gerrit.libreoffice.org/35660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24ofz: explicitly release fontconfig options on every iterationCaolán McNamara
fontconfigs alloc mechanism is too complicated for lsan/valgrind so force the fontconfig options to be released at the end of every iteration, they are demand loaded so will be recreated if necessary on next use Change-Id: I061117b1fb8136298593a165847f78eabe008f0f
2017-03-24shared_ptr->unique_ptrCaolán McNamara
Change-Id: I89aa885c2d5a5c1150ac83b515c0bb84ff2ce039
2017-03-19This can move out of the header as wellKhaled Hosny
Change-Id: I995ad7fb040e11363a70ee2b5cd88e068f06771c
2017-03-19Remove GetVerticalOrientation declaration from header.Mark Hung
Change-Id: Icedd82e7a0092c18e1ff5b4ad4be22f2a30c33e2 Reviewed-on: https://gerrit.libreoffice.org/35384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-19vcl: have AcquaSalInstance use osl::Condition instead of oslConditionChris Sherlock
Condition is deprecated already, but there is no need for the AcquaSalInstance class to use the low-level C-API, when in fact there is a C++ fascade that calls on this via the C++ abstraction, osl::Condition. This will make it much easier to switch to using std::condition_variable in the future. Change-Id: Ic495c4120a59480bf50a8c5b73608874fc4228ea Reviewed-on: https://gerrit.libreoffice.org/35392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-18Use char instead of unsigned charJulien Nabet
to avoid some reinterpret_cast + prepare to replace some alloca calls + replace C cast by using plain char assignment Change-Id: Iff65b9a324ca1cc936c9effd2b3b71596d6e9b0f Reviewed-on: https://gerrit.libreoffice.org/35398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-18vcl: make GtkData use osl::Condition instead of oslConditionChris Sherlock
Condition is deprecated already, but there is no need for the GtkData class to use the low-level C-API, when in fact there is a C++ fascade that calls on this via the C++ abstraction, osl::Condition. This will make it much easier to switch to using std::condition_variable in the future. Change-Id: Iddd2cad0e1137c0b458ebe25b506d463847a6dc0 Reviewed-on: https://gerrit.libreoffice.org/35389 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-03-16fix tinderbox build, ends up using gen backend and icons are missingCaolán McNamara
put the icons back, and replace the bare 1 etc which hid the usage Change-Id: Id90de7b29a29141b448107adb4028407ed203e2a
2017-03-16KDE fix various clang plugin complainsJan-Marek Glogowski
Fixes clang plugin reported problems in the KDE and KDE4 backend. Change-Id: I0280beae9dd6f33ee59bdbe89cd38222f33fdc68
2017-03-16remove unused defines from HRC files in vclNoel Grandin
Change-Id: Ic61bce94fe784d345b8c66ee2132dcc78f199808 Reviewed-on: https://gerrit.libreoffice.org/35220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-08valgrind: fix leakCaolán McNamara
Change-Id: I174225a93a15a5300a94347faf9132f01e52cfe7
2017-03-08const this upCaolán McNamara
Change-Id: Ie070a3f5c07cd7947d441ee67ca662b9d5764251
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-06Restore "pPos and pGetNextGlypInfo always have the same value"Caolán McNamara
and... "pEraseRect is always null" This reverts commit b398dacbb471913e573e9b0b4cd31d94a9109223. Change-Id: I5e7c07eefff0b6bd39d9ed7492134ea062e90fdf Reviewed-on: https://gerrit.libreoffice.org/34907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-05Revert "pPos and pGetNextGlypInfo always have the same value"Caolán McNamara
This reverts commit 7453cb58df4ce434a1252567f961cfe497064aca. and... Revert "pEraseRect is always null" I suspect the problem is the change to D2DWriteTextOutRenderer::operator in 7453cb58df4ce434a1252567f961cfe497064aca aborts during windows tinderboxes CppunitTest_dbaccess_empty_stdlib_save etc This reverts commit 073d920ef5914b5dfe491dbaf7fb18ba56293b85. Change-Id: I372e104bd09e49bcf08306169db9777f2f26fff5
2017-03-05Handle Tr vertical orientation before shapingKhaled Hosny
See https://github.com/behdad/harfbuzz/issues/355 Change-Id: Ic82d74046980fae3e7a973fee90fe5bb4f2b8588
2017-03-04pPos and pGetNextGlypInfo always have the same valueKhaled Hosny
Change-Id: Iec46e0aefff71cbeb2face4f55e5c3a4d6698995
2017-03-04pEraseRect is always nullKhaled Hosny
Simplify the code accordingly and make it return true for success. Change-Id: I661eea739e23b59ebff2573f52036b25ecb5a1ed
2017-03-04SalLayout::GetBoundRect() works just fine hereKhaled Hosny
Change-Id: Idce9a8f374f62bd92756d7391ccca3122c89683e
2017-03-04Drop dead codeKhaled Hosny
We don’t try to render vertical text with DirectWrite any more, so all of this is dead code now. Change-Id: If9f513f6b96fd65d275b9ec46c6e349f1c335bcf
2017-03-04Avoid needless dynamic_cast’sKhaled Hosny
It is all CommonSalLayout() for sometime now. Change-Id: I3d4ad56df195f51242c3d007bc5257c071a03a50
2017-03-03Remove redundant 'inline' keywordStephan Bergmann
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03tdf#103831, tdf#100986: Force using GDI when neededKhaled Hosny
Our DirectWrite renderer is incomplete and can’t handle rotated text or text with horizontal scaling, so route these two through GDI for now. Change-Id: I87b85796a29e3acce782e01b4c629fec6f1a9e25 Reviewed-on: https://gerrit.libreoffice.org/34848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-02Fix typosAndrea Gelmini
Change-Id: I72db7ff99cde394bc161dfd835bfb0d9a47a53d1 Reviewed-on: https://gerrit.libreoffice.org/34780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-23m_nExtStyle isn't used in gtk[2|3]Caolán McNamara
Change-Id: Id03d0ee0d4aa29df85c7fcbcb59e1f769b63862f
2017-02-21GtkSalPrinter_Impl must be complete for the definition of ~GtkSalPrinterStephan Bergmann
Change-Id: Ieafd639e6665025e17f6a2eb3bd5a05167de07ea
2017-02-21loplugin:unusedmethodsNoel Grandin
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21try to fix "random config" tbMarkus Mohrhard
Fixes #229. Change-Id: I6e74d41f83cacb628356cba57a49165c41113723
2017-02-21CommandInfoProvider can be a namespaceMaxim Monastirsky
Change-Id: I8b56423724360f49e1f361cb95056b391a9a3a42
2017-02-20remove unused Box from ConvolutionKernelType enumNoel Grandin
Change-Id: I9f8610bc9ed7d5c175c369973dc8906179ae042d Reviewed-on: https://gerrit.libreoffice.org/34456 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-20remove unused ModalDialogue from WMWindowType enumNoel Grandin
Change-Id: I22269d6d1868b744f48274ff53ca46fa93ce9fc1 Reviewed-on: https://gerrit.libreoffice.org/34455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-12tdf#42029 Use a floating toolbar to show clipped itemsMaxim Monastirsky
Change-Id: I6b366f115258ef8497807163179d3e08ab3d5e6f Reviewed-on: https://gerrit.libreoffice.org/34180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-02-09restore constant to VerticalOrientationNoel Grandin
Removed in commit f4826959c1a5b0e6d2849d4240668b2087582848 "new loplugin:unusedenumconstants". And add a comment. Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359 Reviewed-on: https://gerrit.libreoffice.org/34057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09remove ConnectionIdentifierType enumNoel Grandin
since we only use the AsciiCString enumerator. Consequently simplify the GetConnectionIdentifier method Change-Id: I9e1a1318d2f12bfd18edeb8479e0e7171b22d0f1 Reviewed-on: https://gerrit.libreoffice.org/34026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09convert PaintMode to scoped enumNoel Grandin
and drop unused INVERT enumerator Change-Id: I6db12ff76a5515bcb4691403b8fb380f9d74c1c9 Reviewed-on: https://gerrit.libreoffice.org/34055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-09convert FontType to scoped enumNoel Grandin
Change-Id: Ieb8f90be8effde5f25bc872784c3ea2177b14bf9 Reviewed-on: https://gerrit.libreoffice.org/34056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08Outdated comment, we are returning a reference!Khaled Hosny
Change-Id: I4061f9f421666064f918d8a46375f7f770626ab6
2017-02-08This is only used within vclKhaled Hosny
Change-Id: I64d7e39506495e9fcc78bb670b897338a01a9ae1
2017-02-08Move the typedef where it is usedKhaled Hosny
Change-Id: I275e96ce3761b61b62748a1e75f1a7a88640e7cf
2017-02-08loplugin:unusedenumconstants read-only constants in vclNoel Grandin
Change-Id: I8c81444cbecdc103cc47d9a4133b0b4d9010e0c2 Reviewed-on: https://gerrit.libreoffice.org/34018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08convert WMWindowType to scoped enumNoel Grandin
and drop read-only ModalDialog enumerator Change-Id: Ie295e4863381401c73bd2a4151b94ad529c261fd Reviewed-on: https://gerrit.libreoffice.org/34023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08drop unused enum TTCreationFlagsNoel Grandin
there is only one method using it, and all of the call sites pass 0 Change-Id: I5d71b36cf890fbcf0be9d795756da0cfd61ae309 Reviewed-on: https://gerrit.libreoffice.org/34024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08coverity#1400144 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie7031679c60b70eb8a79062cdd0353c3da1550e4
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I0c2cc9df85932e25dbfed88727d3b83d299671c7
2017-02-07revert unready stuffCaolán McNamara
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I5f11f9b3196c3d42c82ac03bc332ef84189f3737
2017-02-07tdf#104101 Improve the session management handlingJuergen Funk
- Set the current time to the SessionID - Split the SetProperties-Data, and send DeleteProperties for DiscardCommand (above both topic is the same as kate and plasma-desktop to do) - in statusChange the saveDone was not called, and call only once the saveDone - in shutdownCanceled must be send the saveDone too Change-Id: I42855c75b88b5d651ef8091947e359dc2c3f9209 Reviewed-on: https://gerrit.libreoffice.org/33215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-02-06loplugin:unusedenumconstants in vclNoel Grandin
- drop TTCR_GLYPHSEQ - drop ImageType::Invalid - give preedit_data_t a default constructor, so my plugin spots that the eState field is being initalised to DontKnow effectively by a memset - document ToolbarIconSize::Small as unused, but can't remove since it might be stored in a user-setting somewhere Change-Id: I94b34bba83a04de16f95e4faec95b4bd29f3c652 Reviewed-on: https://gerrit.libreoffice.org/33887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>