summaryrefslogtreecommitdiff
path: root/vcl/inc
AgeCommit message (Collapse)Author
2018-07-06Qt5 implement 4bit => 32bit bitmap conversionJan-Marek Glogowski
Some of the PNG icons are 4bit palette based PNG images. This implements the conversation function for the most common 4bit case, so we don't rely on some generic handling. All other non-4bit conversions can be handled by Qt. Change-Id: I4ddd744fb7166fc3a6992b6be6c250c2adb99ca5
2018-07-06Qt5 flesh out font handlingJan-Marek Glogowski
Fills some more FontAttributes based on the QFont. Also implements initial font rotation support. Something is still strage with the vertical font in Writers vertical ruler. Text looks correct in vertical text boxes FWIW. The toRectangle bug is embarrassing; I was wondering for quite some time, which glyphs had strange size rects :-) While at it, move the Qt5Font header to vcl/inc/qt5. Change-Id: I67fa400486981035be6f98c5ab56e82d69c42065
2018-07-06Some cleanup and commentsJan-Marek Glogowski
Change-Id: Ic1dda9b0e5d7896703b65d0d43be340196bcb871
2018-07-03Use cairo's OVER operator to preserve transparencyKatarina Behrens
Change-Id: I1afae266a5308fa0dbf2488777ddb963e99199c7
2018-07-03Implement native modality for modal dialogsKatarina Behrens
instead of hack with hiding the window and showing it again (otherwise modality change has no effect and worse yet, weird things happen) it would be much easier to use QDialog Change-Id: Ie7029ca66380495c4aad246d02f4b96cb55eb01e
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-29Fix typosAndrea Gelmini
Change-Id: If6fafa1ef192411a9d59ef9a4ef4d7f522c67f66 Reviewed-on: https://gerrit.libreoffice.org/55964 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-28Clean up ownership tracking of SalVisual's visual (in X11 Visual base class)Stephan Bergmann
GCC trunk towards GCC 9 emits -Wdeprecated-copy because SalVisual has implicit copy functions but a user-declared dtor. The implicitly-defined copy functions are actually used (so cannot be deleted), but in fragile interaction with the semantics of the user-provided dtor in the SalColormap(sal_uInt16) ctor. Changing SalVisual into a move-only class (moving the "this instance must delete its visual member" information) doesn't work well, as SalDisplay::ScreenData is used as a supply of SalVisual instances (but which will never be of the "this instance must delete its visual member" variety) that are then copied into SalColormap::m_aVisual. As only SalColormap creates SalVisual instances of the "this instance must delete its visual member" variety, what actually works is to track that information in SalColormap instead of directly in SalVisual, and make SalColormap a move-only class. Change-Id: Ib968a38c40b660ce91981b3c7b281f4add6ece6b Reviewed-on: https://gerrit.libreoffice.org/56579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-27This should be a const NSString* so that we can pass such variables to itTor Lillqvist
Change-Id: I017c100f83faac64ad3a8430010c226b438e6a07 Reviewed-on: https://gerrit.libreoffice.org/56529 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-25weld SwWatermarkDialogCaolán McNamara
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-24vcl: treat description of cv** & ss** font features speciallyTomaž Vajngerl
To avoid adding descriptions for each of font features cv** and ss**, where ** is a number between 00-99, process them separately and just use one description for each. This simplifies translation as we don't need to add 99 copy-paste translations but add a bit more complexity when looking up the descriptions. Change-Id: Ia6e9554af20355c90c73afeec33fd18c694865b9 Reviewed-on: https://gerrit.libreoffice.org/56317 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-21take the surface directly from the SvpSalVirtualDeviceCaolán McNamara
Change-Id: I5e0d46fa863a9a74063063cc3d22ea15d2544d8b Reviewed-on: https://gerrit.libreoffice.org/56208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21merge GenericSolarMutex and SolarMutexNoel Grandin
Since nothing else is implementing the SolarMutex abstract class. Change-Id: I2a41254af3e9c7534033cdd0bece9dd8e0258b9d Reviewed-on: https://gerrit.libreoffice.org/56153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-18Skip required features from the features dialogKhaled Hosny
Many OpenType features are required features that are applied to certain context determined by the layout engine, or should always be on. There is no value in presenting these features to the user and they just clutter the dialog for fonts that usually have many of such features (e.g. Arabic or Indic fonts). Change-Id: Idc3d7d3a9eb1c4f693ea6fdf9f26f0264b910f91 Reviewed-on: https://gerrit.libreoffice.org/55951 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-18tdf#108523 Remove @author annotationsAbhyudaya Sharma
Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc Reviewed-on: https://gerrit.libreoffice.org/55263 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-06-18vcl: share GfxLinkAshod Nakashian
When importing PDF as images, we store the PDF stream in the GfxLink. For large PDFs storing a copy of the full PDF with each page is overkill. For example a 10MB PDF with 200 pages will consume 2GB of memory! Change-Id: I99913514cf5c562683080bc817668095bee69427 Reviewed-on: https://gerrit.libreoffice.org/55571 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-06-17gtk3: Correctly mirror popovers in rtl uiMaxim Monastirsky
e.g. formula prompt or fill series in Calc. The reason is that for this particular vcl::Window, HasMirroredGraphics() != IsRTLEnabled(). Change-Id: Icd4bb2d22ba77d64c32b243d9c07745824e5e558 Reviewed-on: https://gerrit.libreoffice.org/55936 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-16tdf#58941 implement retrieving font features and structuresTomaž Vajngerl
This adds the following: - Retrieving of features using HarfBuzz - Retrieving of feature definitions from graphite fonts - Adds description texts of OpenType features - Tests for retrieving features (Linux Libertine G graphite font) and making sure the features and definitions are what we expect. Change-Id: I51573fe086e59c6228cb546bbfac95ac53824c47 Reviewed-on: https://gerrit.libreoffice.org/55892 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-14loplugin:unusedfieldsNoel Grandin
Change-Id: I7d9966d11f8272034523d9804ecf76e119552780 Reviewed-on: https://gerrit.libreoffice.org/55796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14Adapt --enable-qt5Stephan Bergmann
...to 8447d31e529985ef7fc71933f0e55685530f9fc9 "return SalBitmap using std::shared_ptr" Change-Id: I7ef70eda5c2f5931b421852d938ae54d6e133e6d
2018-06-14return SalBitmap using std::shared_ptrNoel Grandin
since we hold it like that in Bitmap anyway Change-Id: I6264dfaaae6210cb008df5db8a421fc80c508f5b Reviewed-on: https://gerrit.libreoffice.org/55458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-14wayland: Make popup menus not show off-screenMaxim Monastirsky
Depends on gtk 3.22 for gtk_menu_popup_at_rect. Had to rework the toolbar context menu to not execute async, as otherwise it just closes immediately. (Basically it's same as rhbz#1342823, except that I couldn't find a way to feed gtk_menu_popup_at_rect with the correct timestamp). Change-Id: I779d8803c80314d93a342f1294c7280f1adf4c98 Reviewed-on: https://gerrit.libreoffice.org/55772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-13Removed duplicated includeAndrea Gelmini
Change-Id: I045b6815a36837aa03293b98f53534c13960875b Reviewed-on: https://gerrit.libreoffice.org/53963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-12revert part of "loplugin:unusedmethods"Noel Grandin
revert part of commit d4d037619638e1915d15dba81c38a1c9b3157972 loplugin:unusedmethods SvpSalGraphics::drawBitmap is used by KDE5 code Change-Id: I2a935aa88d7301c35f3fedec13a9785c497b8eb0 Reviewed-on: https://gerrit.libreoffice.org/55673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11tdf#117175 wayland: Make popup windows not show off-screenMaxim Monastirsky
Depends on the gtk-3-24 dev branch, for the public gdk_window_move_to_rect symbol. Change-Id: Ic7a34ceb3d133ecac2addac54cf5f635eea332ed Reviewed-on: https://gerrit.libreoffice.org/55612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I26a0da1ec9cda9030371977596053a45303756a0 Reviewed-on: https://gerrit.libreoffice.org/55609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11new loplugin:shouldreturnboolNoel Grandin
look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I2ff0f1fff7302cbf884e35879c72df0dc09eede4 Reviewed-on: https://gerrit.libreoffice.org/55597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11drop PhysicalFontFace::CloneNoel Grandin
since we are now holding these via reference counting, no need to clone them Change-Id: I7b0bd86f4a5bca428f7dcd989f838a9aa0c7e179 Reviewed-on: https://gerrit.libreoffice.org/55427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-10qt5: hold LogicalFontInstance with rtl::ReferenceKacper Kasper
Build fix after c4c56de1b0e62ec866b519b2b24c5e805f0a86d3. Change-Id: I49303528ccbe49894a0fbae3c24d3f3d08c016eb Reviewed-on: https://gerrit.libreoffice.org/55547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09rename SalPrinterQueueInfo::mpSysData to mpPortNameNoel Grandin
and simplify, most places can just leave it alone Change-Id: Id938ec12d21ef244a15b5e5a72626c5ad0d0e124 Reviewed-on: https://gerrit.libreoffice.org/55499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalMenu by std::unique_ptrNoel Grandin
and drop DestroyMenu, all the implementations just delete the object Change-Id: I673997ea1a9c5216b100cafdc70a8f697732769b Reviewed-on: https://gerrit.libreoffice.org/55501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return and hold SalMenuItem by std::unique_ptrNoel Grandin
and drop DestroyMenuItem, all the implementations were just deleting the pointer Change-Id: I058817b963988b1e399279f61f45716a2cdba023 Reviewed-on: https://gerrit.libreoffice.org/55500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalPrinter with std::unique_ptrNoel Grandin
and remove DestroyPrinter, doesn't not anything beyond delete'ing the object Change-Id: I25e14b962e65a0e131fae3ff5771c82920a4e375 Reviewed-on: https://gerrit.libreoffice.org/55498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09return SalSession with std::unique_ptrNoel Grandin
Change-Id: I85527407c0cd2d3b94565fd7e24b0616948c9b0f Reviewed-on: https://gerrit.libreoffice.org/55497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-09hold and return SalI18NImeStatus using std::unique_ptrNoel Grandin
Change-Id: I3657980045290a4d65b2944afac04d610c0a94fd Reviewed-on: https://gerrit.libreoffice.org/55496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-08hold LogicalFontInstance with rtl::ReferenceNoel Grandin
instead of manual reference counting. Also the releasing of not-currently-in-use LogicalFontInstance objects from the cache is made less aggressive - we now only flush entries until we have less than CACHE_SIZE instances, instead of flushing the whole cache. Change-Id: Ib235b132776b5f09ae8ae93a933c2eebe5fa9610 Reviewed-on: https://gerrit.libreoffice.org/55384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07vcl: refresh font cache only on real changeAshod Nakashian
GTK3 emits way too many style-updated, which triggers font cache updates. The avoidance of unecessary font cache updates was first implemented in 29c55564. Unfortuantely, it seems that the current font-options was never set as last-seen font-options, so still to many fonts-changed were emitted Change-Id: I01a47d4d7fb033e335b1a49ffa6e1bb98f7fd28d Reviewed-on: https://gerrit.libreoffice.org/55287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-07manage PhysicalFontFace by rtl::ReferenceNoel Grandin
Change-Id: I8f66b5afb066fe83abb83c56ebde6f21197f894b Reviewed-on: https://gerrit.libreoffice.org/55333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-07vcl: svx: preserve the imported PDF page number in GraphicAshod Nakashian
Change-Id: I1bb3fa7d44d5f92df2bb8c4ed4b85ccd984c2617
2018-06-07sd: import PDFs as images using Pdfium new SdPdfFilterAshod Nakashian
LOK now opens PDFs as images using Pdfium, which has a superior accuracy and support to poppler, the default pdf reader. Change-Id: Ifbbecf7f048f001836fb98886705cba47e6bed4e
2018-06-07pdf: share pdf data in GraphicAshod Nakashian
Change-Id: I8146aa4e206788afff71142e1877fd7a885f4652
2018-06-04Qt's interpretation of transparency is different from vcl's oneKatarina Behrens
thanks Sergei Reznikov for pointing this out Change-Id: Ib07d144bb50b178ee7b36f2c7b2eaede27ed10bc (cherry picked from commit e56c81cc996747e3768cf171d0d6e94753b7d2af)
2018-06-02share the cairo clipping codeCaolán McNamara
Change-Id: I2dc8f55fd2612b5fc4440b46ee3184341fd56859 Reviewed-on: https://gerrit.libreoffice.org/55180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-02share the cairo polyline drawing codeCaolán McNamara
Change-Id: I35c04f33f3a87962a3d0e731213228d5b2e8590e Reviewed-on: https://gerrit.libreoffice.org/55179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-01Remove unused Qt5MenuItem::mpVCLMenuStephan Bergmann
Change-Id: Ia7f28a54f253f0263cc781feb5997bb51bb640b2 Reviewed-on: https://gerrit.libreoffice.org/55193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01Various trivial loplugin fixes in --enable-qt5Stephan Bergmann
Change-Id: I9539eb77f663e1174919ae801495801f81571710
2018-06-01remove old "convert to SVM1" code only active in debug modeNoel Grandin
Change-Id: I1d83e6ea5f8eb998f95e6ec334a695eb1df78df1 Reviewed-on: https://gerrit.libreoffice.org/55173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01Make clang-format happy, remove vcl/unx/kde5 from blacklistKatarina Behrens
just between us girls, I hate you clang-format Change-Id: I4cd041eff7a9fa01eb9192cf357e3f07a26fa6ad