| Age | Commit message (Collapse) | Author |
|---|
|
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for macOS-only code
Change-Id: I0b4c0ba12df487107661a6af54fba42122e8f023
|
|
Change-Id: I60cdcdc7fc38c175243c071f34295efa8739b717
|
|
But actually I strongly suspect that this is dead
code.
[AquaA11yTextWrapper rTFForRangeAttributeForElement:forParameter:] is
called only from [AquaA11yWrapper rTFForRangeAttributeForParameter:],
and that is not called from our code, nor do I see any mention of
either rTFForRangeAttributeForElement or
rTFForRangeAttributeForParameter in documentation or when googling.
The NSView documentation does talk about accessibilityRTFForRange,
though. Could this be some copy/paste error since initial commit, code
that has never been tested? Would not surprise me a bit.
Change-Id: Ia1351c293e51e0b75d8b222f78ea19f7801a7c18
|
|
in objc, explicit comparison with nil isn't necessary and can produce errors like:
comparison between distinct pointer types (...) and 'objc_object*' lacks a cast
upd: thanks Norbert Thiebaud for suggestion
``hitChild is a Reference so hitChild = nil was !hitChild.is() right?''
Change-Id: I105be50e5a37bb63e360622e590ec4916fa8a84f
Reviewed-on: https://gerrit.libreoffice.org/11891
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
It turns out that almost none of them were necessary.
Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
(cherry picked from commit 0a4564b42de0fc61253ae4e69039860c09e53eba)
Conflicts:
vcl/osx/a11ytextattributeswrapper.mm
Change-Id: I786815feb847a2a340d2e3d24c9a8a01bb7ace7c
|
|
Now with the ATSUI code gone is a good time for some
re-organisation. Get rid of "aqua" in file names and the separate
"coretext" folders. CoreText is all we use now for OS X (and has
always been so for iOS), so no need for a "coretext" folder, we can
keep the CoreText-using code under "quartz". Keep OS X -specific code
in "osx". Ditto for headers.
Keep "Aqua" as part of class names for now, though.
This is also preparation for planned further unification between OS X
and iOS code.
Change-Id: Ic60bd73fea4ab98183e7c8a09c7d3f66b9a34223
|
