summaryrefslogtreecommitdiff
path: root/vcl/osx
AgeCommit message (Collapse)Author
2016-06-08Convert ButtonValue to scoped enumNoel Grandin
Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Teach loplugin:stringconstant about RTL_CONSTASCII_STRINGPARAMStephan Bergmann
Change-Id: I8ff0e104aad045f3835dc8facc760a8339b1d088
2016-06-03Follow-up fix (odd missing ~TheAquaA11yFocusTracker error)Stephan Bergmann
Change-Id: I18501185f52ab4e90d16313cba299b7501106db3
2016-06-03loplugin:refcountingStephan Bergmann
Change-Id: Ia7bd500728e122f1f4c7ff4c020cc067e72613ca
2016-05-31Convert ControlType to scoped enumNoel Grandin
Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30Resolves: tdf#100097 dbaccess self-dnd depends on getting its own transferableCaolán McNamara
on drop that it set on drag. It does some uno tunnel foo to drag the data it needs back out of it in some grotesque fashion. So we have to follow the same style of hackery as under MacOSX to detect on drop that there is an active drag started by ourself and so use that active drag's transferable as the source transferable for the drop, rather that use the intermediate universal GtkDnDTransferable. Change-Id: I3c3a94416db908603bde8f15dc5b1c9d726b8dbd
2016-05-30Convert ApplicationEvent::Type to scoped enumNoel Grandin
Change-Id: Ie65951d5fd1e155e3d3b36d4725792fb95fb9a52 Reviewed-on: https://gerrit.libreoffice.org/25608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30convert TransparentType to scoped enumNoel Grandin
Change-Id: I25ec59fd41b5aa8741a9e864b5204481a84c3ba6 Reviewed-on: https://gerrit.libreoffice.org/25601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I1938ffb82038d90bd34ba14148663ef8a1494d96
2016-05-21split GLWindow into platform dependent parts and move to respective backendsCaolán McNamara
Change-Id: I636d9bdac907000e4089aebdc5548ea89ec58083 Reviewed-on: https://gerrit.libreoffice.org/25252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-21Split OpenGLContext up into SalInstance specific classesCaolán McNamara
which, at least theoretically, allows there to be vclplug specific ones. i.e. a gtk3 specific one which doesn't assume gtk3 is running under X Change-Id: I6c007a87abbd3049b6fffc70d349e3b7ac445eec
2016-05-12Replace comment with SAL_FALLTHROUGHStephan Bergmann
Change-Id: Ibc5937b852ee8220d5d347e18a824df4c97ade40
2016-05-11convert SAL_FRAME_TOTOP to scoped enumNoel Grandin
Change-Id: Id996e1e6fc29f6323bd4e82785386de26d075cae Reviewed-on: https://gerrit.libreoffice.org/24834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11convert EXTTEXTINPUT_ATTR to scoped enumNoel Grandin
Change-Id: I94706bdea91d367fc8c2bbd482f6b4d8f55449d7 Reviewed-on: https://gerrit.libreoffice.org/24821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Fix typosAndrea Gelmini
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10more OSX fixNoel Grandin
Change-Id: I585ff0105f00793a80e0b5fa25e7dd08fb2fc95f
2016-05-10more OSX fixNoel Grandin
Change-Id: Id9500cf86988614d9dfa04a52b73decd2a4855e0
2016-05-10fix OSX and Windows buildsNoel Grandin
after my "Convert SALEVENT to scoped enum" commit Change-Id: Ib4a3f0e18fa5d8160446d5b5cd505bae651da7d5
2016-05-10Convert SAL_EVENT to scoped enumNoel Grandin
Change-Id: I4e605e7acfe9d4fe409d32f20880b4c0e85a0ea7
2016-05-10convert WINDOWSTATE_STATE to scoped enumNoel Grandin
Change-Id: I5448c7e46042850f18970c7613ec5a37df57bce7
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-06vcl: oops, so there was a macro thereMichael Stahl
Change-Id: I824fa3c83a5bc8b68a6554c9bfe5ce5b3c2d711f
2016-05-06sd: replace boost::enable_shared_from_this with std::enable...Michael Stahl
Change-Id: Ia4f31a03b20bb0abe7e0ff8e423a0b046a828607
2016-05-01tdf#49853 Some shortcuts should always end up in the viewMaxim Monastirsky
... because they are also used internally by vcl controls, so we want let those controls handle them when they are focused. [VCL_NSApplication sendEvent] is more natural place for this probably, but doing it there we'll lose the "blinking" effect of the menu bar, even when the focus is in the document area. So try harder, and handle it inside the menu code. If this will create any trouble, we can always switch to the simpler solution. Change-Id: I827ab0585aabe1ed53fc31c5b8e1dddadef3361d
2016-04-22loplugin:salboolStephan Bergmann
Change-Id: I4298f1da63d29133412962a9e4552a7ed473ad28
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-06revert to fix tdf#98783 missing menubarCaolán McNamara
Change-Id: Ia322149a7ed461f528af856d9907fe4620f9e97f
2016-03-29vcl: replace boost::shared_array with std::shared_ptrMichael Stahl
The boost::bind here looks totally pointless too. No idea why this uses rtl_allocateMemory, let's keep that. Change-Id: If51ba9837a318f11094ee39225233212a848a955 Reviewed-on: https://gerrit.libreoffice.org/23502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-16Related: tdf#98637 make this a tractable problemCaolán McNamara
This is just too hard, it would all be much easier if the ActionGroup existed right from the start of the entire process. So smuggle in to the ctor the toplevel frame that the menubar will be inserted into so we can use its ActionGroup from the start. That would suggest that we could then just keep the hierarchy in sync as it is created rather than finding opportune moments to update /generate it. Change-Id: I550f94a994210423ab9cea1986e643056cb5bd29 Reviewed-on: https://gerrit.libreoffice.org/23287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26loplugin:fpcomparisonStephan Bergmann
Change-Id: I5ef9d7bcff3fcc2b01c0e5578487a293c6e315df
2016-02-12nothing needs GetClipRegionType or uses SAL_OBJECT_CLIP_INCLUDERECTS nowCaolán McNamara
Change-Id: Ie43eb3b2c449891fef1031e7df3f381cecb4b4f9
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-09Formatting changes across all modulesChris Sherlock
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08vcl: cmdevt.[hc]xx -> commandevent.[hc]xxChris Sherlock
Change-Id: I77b30f28ae5a6fad360d7cada9acfaa9c324408b Reviewed-on: https://gerrit.libreoffice.org/22216 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Remove old non relevant commentNiklas Johansson
The code that the comment is talking about was removed by the commit: fb6edeb20de56359be3d45316a2d665ad8d424a2 Let's remove the comment to spare our selfs from confusion Change-Id: I7bdefb0ead5139be009bfb8dd7d9ad7c6821e3e8 Reviewed-on: https://gerrit.libreoffice.org/22120 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-01Resolves: tdf#93821 assume mbNoSaveBackground as true everywhereCaolán McNamara
Change-Id: I126aa5e9b96299eb25c2240d097859b3c0756535
2016-01-26Blind fix for OSXMatteo Casalin
Change-Id: Ieaf3333e8df5d67299615e279151b29744ddd180
2016-01-26sal_uLong/sal_uIntPtr to sal_uInt32 (printer GetCapabilities)Matteo Casalin
Change-Id: I1324c89be2a1d4954b0ddf4a9b06a8a97d5c335e
2016-01-26Convert SAL_JOBSET_* defines to new JobSetFlags enum classMatteo Casalin
Change-Id: Id59dd767c09c0757b6c94c7dd4b3e832f11cf615
2016-01-25more usage of C++ osl::Mutex, osl::MutexGuardNoel Grandin
Change-Id: Ibdc54fdccf70a9d60ad0fdcb9898bcd6d7bda368
2016-01-22tdf#96407 Provide OS X version info for About boxDouglas Mencken
since commits 56a9594649872f4076b6891f & 52856b6ea7b6b01e8a8455ed the about box now includes information about a version of operating system Change-Id: Iaf28b555ec1eb3dfe8c6e9b9567fa0dda18741db Reviewed-on: https://gerrit.libreoffice.org/21564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-18loplugin: unused return values in vcl/Noel Grandin
Change-Id: I879bd3bec4dd2cf002681f1e50b6c33cce0934a9
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-12provide autorelease pool to avoid leakingDouglas Mencken
fixes “Object ... autoreleased with no pool in place - just leaking” Change-Id: I8bb10adf779f57a9c7c9f1a38415d61e391d181e Reviewed-on: https://gerrit.libreoffice.org/21370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-11tdf#96875 Make OS X native context menus compatibleMaxim Monastirsky
... with how framework::MenuBarManager works, following my work of converting context menus to use it instead of SfxPopupMenuManager (see tdf#93837). MenuBarManager sets menu item properties/select handler when the menu activates - in MenuBarManager::Activate, but it was never called for submenus. The solution is to adapt the menuNeedsUpdate delegate to call Menu::Activate. This makes submenu items work, but doesn't update their visual state (e.g. title). The reason is that AquaSalMenu::ShowNativePopupMenu is creating a copy of the NSMenu, so AquaSalMenu::SetItemText is modifying the wrong NSMenu instance. Another problem is that AquaSalMenu::ShowNativePopupMenu tries to removes (via removeUnusedItemsRunner function) all disabled items, but the correct state is set by MenuBarManager only when the menu activates. So we must handle disabled items only after MenuBarManager::Activate did its job. Turns out that we can just hide items in NSMenu instead of removing them, so no need to clone the NSMenu anymore. Change-Id: If0785b7f9d5f0ad98ced23585379039a51dc13bf Reviewed-on: https://gerrit.libreoffice.org/21374 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-01-10Fix typosAndrea Gelmini
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-17remove newly unused WB_NEEDSFOCUS and fragile FLOAT_FOCUSABLECaolán McNamara
Change-Id: Idce03318fbc01039a6c0638879785607970993c0 Reviewed-on: https://gerrit.libreoffice.org/20746 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-08Bin the pointless and thin OS X specific wrapper namespace 'OpenGLWrapper'Tor Lillqvist
Besides, the namespace was confusingly named the same as the public cross-platform OpenGLWrapper struct (which is effectively just a namespace, too). Change-Id: I9a5255ec446dcdb5086d92a742f29327d0780685