summaryrefslogtreecommitdiff
path: root/vcl/osx
AgeCommit message (Collapse)Author
2014-08-12fdo#39477: Mac Keyboard shortcut Option key ko in Customize dialogJulien Nabet
There's still a problem of order of symbols between menu shortcut and the 2 shortcuts in Customize dialog Change-Id: I7d8235130e8ddb8aa510a20cf803fbe81038b023 Reviewed-on: https://gerrit.libreoffice.org/10600 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-04loplugin:externandnotdefinedStephan Bergmann
Change-Id: I5337cd288e3f5d6f7c42d7a1f5c9b2dbce5f06b4
2014-08-04loplugin:externandnotdefinedStephan Bergmann
Change-Id: I5f0c34a44898637b3c0d3d507777cbc7ace8b656
2014-07-11new loplugin: externalandnotdefinedNoel Grandin
Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11-Wdeprecated-declarations: first deprecated in OS X 10.10rbuj
vcl/osx/salframeview.mm:201:16: warning: 'useOptimizedDrawing:' is deprecated: first deprecated in OS X 10.10 [-Wdeprecated-declarations] Change-Id: I6025de6c23a73c625ddfe8398dfd91bd838fe83c Reviewed-on: https://gerrit.libreoffice.org/10122 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-11-Wdeprecated-declarations: first deprecated in OS X 10.10rbuj
vcl/osx/printaccessoryview.mm:362:37: warning: 'NSScaleProportionally' is deprecated: first deprecated in OS X 10.10 - Use NSImageScaleProportionallyDown instead [-Wdeprecated-declarations] Available in OS X v10.0 and later. Deprecated in OS X v10.10. enum { NSScaleProportionally = 0, NSScaleToFit, NSScaleNone }; Available in OS X v10.5 and later. enum { NSImageScaleProportionallyDown = 0, NSImageScaleAxesIndependently, NSImageScaleNone, NSImageScaleProportionallyUpOrDown }; Change-Id: I457196e3e8f2ebcc10e9e0fa87755e5e3dba207c Reviewed-on: https://gerrit.libreoffice.org/10121 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10use SimpleReferenceObject in vcl/osx moduleNoel Grandin
to replace hand-rolled version Change-Id: Idf3f2dd20bacd3cb3de64931027ef62d9116200f
2014-07-02fix 'NSCursor' may not respond to operationNotAllowedCursor,dragCopyCursorDouglas Mencken
related commit: e4653eee7680831e6d0995d51d80fb63309c03ab Change-Id: Iba30c90336bf08d15d5990d6e1380867eee3564e Reviewed-on: https://gerrit.libreoffice.org/10013 Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-02fix 'NSImage' may not respond to '-lockFocusFlipped:'Douglas Mencken
related commit: b3818f53812053e94196a58bbe474e2c3b72ac69 Change-Id: Ica27b3c2e474ebb85a69149e35021835f8183b69 Reviewed-on: https://gerrit.libreoffice.org/10011 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-06-30Remove double assignmentPeter Senna Tschudin
The semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ expression i,f; position p1,p2; @@ ( (<+...i++...+>) = ...; | (<+...++i...+>) = ...; | (<+...i--...+>) = ...; | (<+...--i...+>) = ...; | i = <+...f(...)...+>; | i@p1 = ...; ( i = <+...i...+>; | i = <+...f(...)...+>; | i@p2 = ...; ) ) @@ expression i; position r.p1,r.p2; @@ * i@p1 = ...; i@p2 = ...; // </smpl> Change-Id: Ifacb878d58486f2645560592484ce24b2bc0bd6f Reviewed-on: https://gerrit.libreoffice.org/9968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-26Related: #i122471# make the Mac lookup feature handle the correct wordHerbert Dürr
(cherry picked from commit 0a4564b42de0fc61253ae4e69039860c09e53eba) Conflicts: vcl/osx/a11ytextattributeswrapper.mm Change-Id: I786815feb847a2a340d2e3d24c9a8a01bb7ace7c
2014-06-23Resolves: #i124970# fix DocumentFocusListener::notifyEvent's...Herbert Dürr
handling of IndexOutOfBoundsException the DocumentFocusListener::notifyEvent() throw list only allows a RuntimeException to propagate. The methods called in notifyEvent() allow IndexOutOfBoundsException though, so it must be handled in all cases to prevent C++ from invoking its unexpected() abort mechanisms. Ceterum censeo, non-empty throw lists should be removed altogether... (cherry picked from commit 4da0e442f0fd4838e93e7316c24cfeef9289207d) Conflicts: vcl/osx/documentfocuslistener.cxx vcl/unx/gtk/a11y/atkutil.cxx Change-Id: Ie0b783832314ee5ec376a0c3c2cd67e4a70e218b
2014-06-18fix 'NSWindow' may not respond to '+windowNumbersWithOptions'Douglas Mencken
conditionally reverts 1b89f986f0e7e6303c4e44cb1ca5d42a5c78c8d4 Change-Id: I13aa24286dab52c9e4af798c8b6d9bf407bb7069 Reviewed-on: https://gerrit.libreoffice.org/9760 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-16fix keyboard input on OS X < 10.6Douglas Mencken
Since commit e4dc93f5, LibreOffice just beeps on any key press: it's impossible to add symbols by using keyboard. This patch fixes that. conditionally reverts e4dc93f5d8d0df50f1a8b4594220d0c57703e03d Change-ID: Id30e30775c0d0224954b8a1f05fd0d8d5f39cd4e Reviewed-on: https://gerrit.libreoffice.org/9793 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-13Don't use the CoreUI private framework when sandboxed (i.e., for App Store)Tor Lillqvist
This conditionally reverts 0c7e6080519014f1fb345ed25e2f12c9a043b3ae. Change-Id: I462016cd43c489fced7fb3739aa98c521d52f78e
2014-06-13loplugin:staticcallStephan Bergmann
Change-Id: Id5c17212031b6710f38413c833c0df2b33f42475
2014-06-13fix build error "error: NSPrintJobSavingURL was not declared in this scope"Douglas Mencken
see commits: c5c317ed20933c6508b35c34039df31669943f1c Change-Id: I3a886bde11dc3620cffeb3e2e579c7b37285d9c5 Reviewed-on: https://gerrit.libreoffice.org/9759 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-12'NSNoUnderlineStyle' & ‘NSSingleUnderlineStyle’: Deprecated in OS X 10.9rbuj
Change-Id: If18df0c06a1bdec5ea54307f9c452a1edf533e15 Reviewed-on: https://gerrit.libreoffice.org/9740 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-05various: remove SAL_THROW macroNoel Grandin
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-03WaE: 'convertBaseToScreen:' is deprecated: first deprecated in OS X 10.7Tor Lillqvist
Change-Id: I04cc155e69d25021d294bccc588450b1f20e1fde
2014-06-03WaE: 'scrollerWidth' is deprecated: first deprecated in OS X 10.7Tor Lillqvist
Change-Id: I2451687c10f91e7d5242b04974cb7bdd745de51c
2014-06-03WaE: 'NSPrintSavePath' is deprecated: first deprecated in OS X 10.6Tor Lillqvist
Change-Id: I810b42da1d62c66c2ab6fb7bb6f71d1d00115dfa
2014-06-03WaE: comparison of two values with different enumeration typesTor Lillqvist
Change-Id: I611eefd20043386d00984f76a28d111e1c0495f1
2014-06-03WaE: 'setFlipped' is deprecated: first deprecated in OS X 10.6Tor Lillqvist
Not sure if using lockFocusFlipped: has the same effect, but will see... Change-Id: I957874bcf59c2c521bd5b2b2ca6f44fb0400e64f
2014-06-03WaE: case value not in enumerated type 'NSEventSubtype'Tor Lillqvist
Change-Id: Iaf5de07b7f0da7294681b9cdc152575a756a73c7
2014-06-03Initial attempt at implementing NSTextInputClient instead of NSTextInputTor Lillqvist
NSTextInput was deprecated in 10.6. Change-Id: I6bce9e91a68014a6ca28bff6a820c27817f9baaf
2014-06-03WaE: 'NSCountWindows' is deprecated: first deprecated in OS X 10.6Tor Lillqvist
Change-Id: I7163d3821ac0dfc0d471cf31e98f72953c78d878
2014-06-01fdo#68849: Add header guards to all include filesJens Carl
Added header guards to files in directory vcl/ Change-Id: I76ad0c34f2b107d56e92c5a6a8f4c61554c93e2f Reviewed-on: https://gerrit.libreoffice.org/9597 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-29remove more unnecesary OUString constructor useNoel Grandin
when throwing exceptions Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-25cppcheck: unusedFunctionThomas Arnhold
Change-Id: I81f2a4be65bbc9359e51accccb746f1e8ea48c4f
2014-05-23Related: #i124191# small cleanup for salframeview.mmHerbert Dürr
clean up some minor warts while the behaviour remains unchanged. (cherry picked from commit 8ba6a0be8a0ac9075b2faa68bf71245f4aff0d16) Conflicts: vcl/osx/salframeview.mm Change-Id: I613bf0f40429db6516f82e79438e86bffb7f71cb
2014-05-20Don't use two separate names for the same thingTor Lillqvist
Change-Id: Iad76d452d5dbaa03099c1a649d7f278b0151f340
2014-05-20We don't support the Apple Remote in sandboxed modeTor Lillqvist
Change-Id: Ie0a456647376b9d249850227d3481be5b4ee991d
2014-05-17Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part15Julien Nabet
Change-Id: I38e855966598342eb2352e70e04f7a5e09e54f83
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-14loplugin:passsequencebyrefStephan Bergmann
Change-Id: I3a6656117b2d2aa9d9cdcadc53a804e963f805a7
2014-05-11Fix previous commit (vcl/MacOsX part)Julien Nabet
Change-Id: I65998bbbba01943eeb41fd8ee4f1ed5fe2eb91b1
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-09Fix typo, thanks to Cor Nouws for noticingTor Lillqvist
Change-Id: Ib20fa5dbbc8bfbd399c3266c175ba1971e9a4774
2014-05-05Correct keycode mappings for KEY_QUOTE{LEFT,RIGHT}Tor Lillqvist
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h says that 0x27 is kVK_ANSI_Quote, which we call KEY_QUOTERIGHT, i.e. the plain ASCII apostrophe, while 0x32 is not the ASCII tilde but kVK_ANSI_Grave, which we call KEY_QUOTELEFT. Makes the Command-' binding (see Kohei's 56cce6fd8151a916e1be540ac18724b46d1b15fc) work at least for the US English keyboard. But not for the Finnish keyboard, for instance, where the key labeled with an apostrophe (or "ASCII-style" single quote) generates a different keycode than the single quote key on the US English keyboard. (Which, I guess, isn't surprising as it after all is a different physical key.) In other words, situation normal, using keycodes is a horror as always... Change-Id: Ibf8f994370fec75849391e1dba30c7b7d54d237f
2014-05-05Untabify and remove trailing spacesTor Lillqvist
Change-Id: I2acd44d54966dd227f5dc23ca4acde3c50ca8347
2014-05-05Align table entries into equal-size columnsTor Lillqvist
Change-Id: I9fd2980a32bd0a3eb4849a53f29cc10b9a371f4c
2014-05-05GetKeyName for KEY_{TILDE,BRACKET{LEFT,RIGHT},SEMICOLON,QUOTERIGHT}Tor Lillqvist
Change-Id: Id320bc41fefff17035c8a30115dc94af5cbf9503
2014-05-05Add more unmapped VCL keycodes to the commentTor Lillqvist
Change-Id: If417d8091896c9f6c9650cf7d6036ffacbcc0884
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-14typo: suiteable -> suitableThomas Arnhold
2014-04-14OLD_TAB_STYLE never definedThomas Arnhold
2014-04-11Remove unused functionStephan Bergmann
Change-Id: I150cbe9ca96f0fb9a6b1116f79a0711d78252ba5
2014-04-10Kill the ImplSVGDIData::mbNoXORClipping flagTor Lillqvist
Instead, act as if it was true on all platforms. Don't do XOR clipping on any platform. Simpler code is better code, and XOR tricks are generally very much out of fashion these days, I have been told. Didn't seem to have any visible ill effects on Linux at least. Change-Id: I6192006c77a4a81363ec7b3292f72d512d5e9b53 Reviewed-on: https://gerrit.libreoffice.org/8901 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>