summaryrefslogtreecommitdiff
path: root/vcl/qa
AgeCommit message (Collapse)Author
2016-01-14vcl: Create mutator for bullet offset attribute in FontMetricChris Sherlock
Mutator created for bullet offset attribute in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set bullet offset attribute - check equality operator on FontMetric after setting bullet offset attribute Change-Id: I87a76982a8b3ed697664299cb340fa35fb514c0e
2016-01-14vcl: Create mutator for slant attribute in FontMetricChris Sherlock
Mutator created for slant attribute in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set slant attribute - check equality operator on FontMetric after setting slant attribute Change-Id: I5490a40dba4c86386d59a42f2d04303b3fc4d536
2016-01-14vcl: Create mutator for line height attribute in FontMetricChris Sherlock
Mutator created for line height in attribute FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can get and set line height attribute - check equality operator on FontMetric after setting line height attribute Change-Id: I86dff217fa24850b5f9d04a17ddda464dfb0156a
2016-01-13vcl: Create accessor and mutator for ascent and descent in FontMetricChris Sherlock
Accessor and mutator created for ascent and descent spacing in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set font ascent and descent spacing - check equality operator on FontMetric after setting both ascent and descent font spacing Change-Id: I714363b14bdc61ddfa37a619fe4b03f4e4e96f7a Reviewed-on: https://gerrit.libreoffice.org/21458 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for builtin font flag in FontMetricChris Sherlock
Accessor and mutator created for builtin font flag, removed the existing bit field. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set builtin font flag - check equality operator on FontMetric after setting builtin font flag Change-Id: Iac3f4270f86d10f9dcd0bb6e3951c0e983a4f22f Reviewed-on: https://gerrit.libreoffice.org/21414 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for full stop centered in FontMetricChris Sherlock
Accessor and mutator created for full stop centered flag, removed bit field. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set full stop centered flag - check equality operator on FontMetric after setting full stop centered flag Change-Id: I9cacb0fbf9ea65cfebcaebdc9f0481c0a796cbcf Reviewed-on: https://gerrit.libreoffice.org/21413 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-13vcl: Create accessor and mutator for font scaling in FontMetricChris Sherlock
This is fragile code! There are actually *two* classes that do almost precisely the same thing, they are: - ImplFontMetric, and - ImplFontMetricData They both have much in common, including their class name, and even most of their functionality. In fact, they both have common accessor functions. When I look at the code, it looks like OutputDevice is actually given an ImplFontMetricData object, which it then uses to populate an ImplFontMetric object... Basically, I'm going to merge these classes. To do so, I'm going to do the following: Step 1: Implement accessor functions for ImplFontMetric and FontMetric (then remove the friendship of this class to OutputDevice!) Step 2: Write a unit test for each accessor function in ImplFontMetric Step 3: Ensure that ImplFontMetric and ImplFontMetricData use some sort of smart pointer (probably an intrusive_ptr like I did ages ago with FontCharMap) Step 4: Merge the two classes together once their class interfaces are the same and I am satisfied they do the same thing Step 5: Find all instances of inefficient usage - for instance, I can do away with the code that copies the ImplFontMetricData attributes into an ImplFontMetric object. Change-Id: I07c1cb848774b130fa2ca60b51da53e07754dd00 Reviewed-on: https://gerrit.libreoffice.org/21399 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-11Remove BitmapFilterStackBlur, which is unused...Stephan Bergmann
...ever since it got introduced with 28c61871e876e6a2cac47439f768504b1a4c94a0 "vcl: stack blur implementation + basic test & performance test" Change-Id: I78672cf74c24930df92121baecb9886df4382036
2016-01-10Cleanup FontCharMapPtr variable prefixesChris Sherlock
Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1 Reviewed-on: https://gerrit.libreoffice.org/21306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-05RC4 encrypt some WMF and TIFF test filesMichael Stahl
Reportedly some virus scanners warn about some of these files. Use a new "RC4" name prefix since the files don't come from external sources. http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/69200 Change-Id: I6d4cff2fdd5c0134bf2c77558ea09b3196b39be9
2016-01-04vcl: split classes out of metric.hxxChris Sherlock
Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9 Reviewed-on: https://gerrit.libreoffice.org/21069 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-11Fix test on FreeBSD which uses the same backend as LinuxBaptiste Daroussin
Change-Id: Ibc43b9f3d0fc9e343b0ff9abd627ee9afb881d69 Reviewed-on: https://gerrit.libreoffice.org/20624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-10Calm unit test down for GL row-strides.Michael Meeks
Change-Id: Ie4123fc692f4fac33f082bb2d86b949d834f1858
2015-12-07Resolves: tdf#96224 don't fiddle around with a separate alpha bufferCaolán McNamara
use a format that supports alpha directly now we can unify the android and linux cases as well and drop the BGRX support Change-Id: I3c845913691d8194822423005d308cfa7ef13ec3 Reviewed-on: https://gerrit.libreoffice.org/20440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-24Resolves: tdf#95962 incorrect scanline strideCaolán McNamara
we were reusing the stride of the surface we were cloning, but the new surface has a different underlying size. remove the custom stride argument and just change our stride calculation to use the same scheme that cairo and GDI uses, which remove another platform/drawing-system variable Change-Id: I257dac9757b121642e9ccfde7db0911edc9f3fb1 Reviewed-on: https://gerrit.libreoffice.org/20149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-23establish that Virtual Devices either match Physical Device depth or ...Caolán McNamara
are 1 or (rarely) 8 bit and lock that down. Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-17loplugin:unnecessaryvirtualNoel Grandin
update the plugin with lessons learned from the mergeclasses plugin and re-run it Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711 Reviewed-on: https://gerrit.libreoffice.org/20015 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10tdf#95650: Replace wrong assertion with conditionMike Kaganski
When UniscribeLayout::LayoutText(ImplLayoutArgs & rArgs) is run with BiDiRtl flag, and some skipped VisualItems was reversed in lines 908-927, it's possible that they will arrive in reverse order to the code adjusting mnSubStringMin, so this assertion may fire. This situation is not erroneous, so simply replacing the assert with "if". Change-Id: Icb244502dd00b4c08a2c5192369ee66d743b0dcc Reviewed-on: https://gerrit.libreoffice.org/19835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I7ac150458a72963f3336d30ef9d99d7c0d81c024
2015-11-05afl-eventesting: deref of null mpTextObjCaolán McNamara
Change-Id: Icdb7d1cc250640f428984b96b0a51ac950013cb2
2015-11-05fix compiling of this java classNoel Grandin
(even though it's not being built right now) Change-Id: I237cce48ea50b1184b166a8a8132ae425597bffe
2015-11-02afl-eventtesting: crash close impress with spelling dialog activeCaolán McNamara
Change-Id: I1085b655a9a589f2e92edfdacfea6621d2f67d9c
2015-10-23afl-eventtesting: crash on undoing insert new page in impressCaolán McNamara
this is an intermittent crash in the real world but under event testing we can see that the PaintView is informed that the page has been deleted, but doesn't clear its use of the page if it so happens that there was earlier modification events that caused the fire-modification-timer to be launched If there happens to be no such events then the page is correctly cleared If the timer is active, then the page is not cleared, but eventually the timer will fire and access the deleted page and fall over and die minimal change for backporting ease, follow ups now Change-Id: I090ad62cc175545902574c93dec7082225d97ab7
2015-10-21afl-eventtesting: crash if you close shell behind running presentationCaolán McNamara
Change-Id: Ib8f02ddfe3b74e97145e22aa88e6f97d52c39f7a
2015-10-21afl-eventtesting: crash when accelerator processed after frame is disposedCaolán McNamara
Change-Id: I8c3dcca53d5fb18e9f1da0499a071d35a859a9de
2015-10-21move afl examples/test-cases to dedicated dirCaolán McNamara
Change-Id: I36f09cd19ea721ee69e62fac4cf0744827e8cefb
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I3e5ee77b51eb8e1207d3f95e6a1d9d8272532ba6
2015-10-15cppcheck:variableScopeNoel Grandin
Change-Id: I9b671637fbe0f32e695d22b74bfb40a39a9fe884 Reviewed-on: https://gerrit.libreoffice.org/19364 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-01Fix typosAndrea Gelmini
Change-Id: I8fd769ca61d1ec1a915a012c0c2244056dc5bcb8 Reviewed-on: https://gerrit.libreoffice.org/18992 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-28wmf spec says that these are only allowed bitcount valuesCaolán McNamara
Change-Id: Ia174feec73ee676567a3632d2f88b11c176b6363
2015-09-17bmp failure not detected as such because of svg fallback testCaolán McNamara
I thought it was suspicious that everything was a pass Change-Id: I10b98cc19d2e23bd5d518113785aeca3a0ea346a Reviewed-on: https://gerrit.libreoffice.org/18662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17make CalcMaskShift a verifiable operationCaolán McNamara
and check it on untrusted data Change-Id: I7c97a27d70f91b9686adf9dcb8b68c5aa25c2b4c Reviewed-on: https://gerrit.libreoffice.org/18637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-16don't crash with unknown out color spaceCaolán McNamara
Change-Id: Ib066ff1fad686d611a86510e768b1109ef7a5e75
2015-09-11vcl: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I4499569f73b04cc7444787d51bf804c090a5c951 Reviewed-on: https://gerrit.libreoffice.org/18478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-01Fixup CRC related unit tests for now.Michael Meeks
Change-Id: If15e30908103780d5d01191ee98f390dbebfc1d3
2015-09-01Tweak VCL unit tests for OpenGL.Michael Meeks
Change-Id: Ia36f8424226da4e66ae991abd4d6f24604db324c
2015-09-01Modified CRC test in order to fix test failure on OSXMarco Cecchetti
Change-Id: Ic3fa76557746242ca99e3ce63ea73ec1d2b11f50
2015-09-01tdf#93532 - Bitmap CRC unit tests.Michael Meeks
Change-Id: Ic75801d7ad941ba802ffe418d5c666b1e7b0e94f
2015-08-31tdf#93750 allow for EMF+ record padding up to 11 bytesMike Kaganski
When an array of EMF+ has extra bytes in the end, that are less than 12, they should not be treated as another EMF+ record, but simply ignored. Change-Id: I34701c00916812c8a6a4b69730f602da81719b35 Reviewed-on: https://gerrit.libreoffice.org/18110 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-08-31check stream statusCaolán McNamara
Change-Id: I27bb289288d319a93201e9c3d703114924ca258c
2015-08-28Disable the higher frequency timer tests more effectively.Michael Meeks
Change-Id: Ibd832d85ce4b7e6747f95297d3c96d071aff41e2
2015-08-28Add a newline and fflush so that it actually shows up in the outputTor Lillqvist
Change-Id: Iea123118614ecf038883a0d51337042574ebc6b2
2015-08-27vcl: print an error message in timer test watchdogMichael Stahl
The CPPUNIT_ASSERT will actually crash the process because in the spawned thread there is nothing to catch the exception, which means that when the watchdog triggered there is no indication why the test failed. Change-Id: Id7d2a99fe62326c817f100e0755679861cb37788
2015-08-27don't loop on overly-short nEndPosCaolán McNamara
Change-Id: I60d3388ece28a69c31a85b9e3b495cbe8a03e7dc
2015-08-27vcl: increase timeout for timertest hang by someThorsten Behrens
Change-Id: I7e61051ca8d7ae2314514e60097ff86481d4ceae
2015-08-27coverity#1320471 Infinite loop coverity[loop_top] - Application::YieldCaolán McNamara
Change-Id: I83634fa276048607cc0572178964417ce7373e0c
2015-08-25vcl: disable randomly failing timer unit testsThorsten Behrens
Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f
generated by cgit (git 2.34.1) at 2025-01-29 10:38:47 +0000