summaryrefslogtreecommitdiff
path: root/vcl/qa
AgeCommit message (Collapse)Author
2023-10-11cool#7318 Calc rendering accelerationNoel Grandin
we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs, and most of that is inserting into the GlyphsCache, which has a very very large key. Shrink that key a little bit on 64-bit machines, where tools::Long is 64-bit, which is quite unnecessary for FontMetric fields. Change-Id: I64983d191ba9aeb76671671443ea90f90fd2c401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-11Delete OUString UTF-16 string literal ctor/assignment opStephan Bergmann
...that have been made unused by 7ef3d937415185ef66e32dd3043783eddcd03db5 "loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literals". (And which means we can remove the relevant code from that plugin again.) (This also found a handful of remaining uses that had been hard for the plugin to discover, along the lines of > std::map<OUString, int> m = {{u"foo", 0}}; being represented by a > DeclStmt 0xdaca578 <line:103:5, col:50> > `-VarDecl 0xdac9150 <col:5, col:49> col:29 s11 'std::map<OUString, int>':'std::map<rtl::OUString, int>' cinit destroyed > `-ExprWithCleanups 0xdaca548 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>' > `-CXXConstructExpr 0xdaca508 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>' 'void (initializer_list<value_type>, const std::less<rtl::OUString> &, const allocator_type &)' list std::initializer_list > |-CXXStdInitializerListExpr 0xdaca480 <col:35, col:49> 'initializer_list<value_type>':'std::initializer_list<std::pair<const rtl::OUString, int>>' > | `-MaterializeTemporaryExpr 0xdaca468 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' xvalue > | `-CXXBindTemporaryExpr 0xdaca448 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' (CXXTemporary 0xdaca448) > | `-InitListExpr 0xdac9df0 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' > | `-CXXConstructExpr 0xdaca408 <col:36, col:48> 'const std::pair<const rtl::OUString, int>' 'void (const char16_t (&)[4], int &&) noexcept(_S_nothrow_constructible<const char16_t (&)[4], int>())' list > | |-StringLiteral 0xdac91b8 <col:38> 'const char16_t[4]' lvalue u"foo" > | `-MaterializeTemporaryExpr 0xdaca3f0 <col:46> 'int' xvalue > | `-IntegerLiteral 0xdac91d8 <col:46> 'int' 0 > |-CXXDefaultArgExpr 0xdaca498 <<invalid sloc>> 'const std::less<rtl::OUString>':'const std::less<rtl::OUString>' lvalue > `-CXXDefaultArgExpr 0xdaca4b8 <<invalid sloc>> 'const allocator_type':'const std::allocator<std::pair<const rtl::OUString, int>>' lvalue Clang AST.) Change-Id: I496fe9d4d5e1a033cb7b27b4e04b303f8ddbed4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-10tdf#157182 vcl,filter: PDF/A export: fix crash due to SE ID mismatchMichael Stahl
The SE IDs in PDFExtOutDevData and PDFWriterImpl are supposed to match. If PDF/A-1 is exported then RemoveTransparenciesFromMetaFile() is called and that does unspeakable things to the Metafile and then we just throw away the PDF related data for the page in PDFExtOutDevData::ResetSyncData(). This means that then EnsureStructureElement are called on PDFExtOutDevData but not on PDFWriterImpl, so on the next page the IDs will no longer match, which is noticed if there is no transparency to be removed on that page. pdfextoutdevdata.cxx:347: bool vcl::PageSyncData::PlaySyncPageAct(): Assertion `id == -1 || id == mParaInts.front()' failed. Guess the easiest way to deal with this is to have the premature ResetSyncData() replay only the EnsureStructureElement actions, which is only possible because they don't really require any extra data stored in the ridiculous vectors in PageSyncData; PDFWriterImpl will eventually remove the elements as they are never initialised. (regression from commit 07d790ca473cd6e71f0343419b819fa6b485dc01) Change-Id: I8eb295504067edff00608e28fd86b0c86d547083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157748 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-08Fix buildMike Kaganski
See e.g. https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/148996/consoleFull#699387013baec2b5c-2b20-4190-a3fa-ceac4be9cf93 > error: use a _ustr user-defined string literal instead of constructing an instance > of 'rtl::OUString' from a UTF-16 string literal [loplugin:ostr] Change-Id: Ia813425bc75e4351add73b8665355d02222ccf78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157629 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-10-04vcl,drawinglayer,sw: PDF/UA export: footnote-container-in-list problemMichael Stahl
The problem is that if there is a footnote in a list, the footnote container becomes a child of the LI element that contains the footnote anchor, which is of course nonsense. This is because SwTaggedPDFHelper::CheckReopenTag() stopped using SetCurrentStructureElement(), but unfortunately it's required so that once the list ends, the correct parent element is restored for whatever follows the list. There is a similar problem in VclMetafileProcessor2D. (regression from commit d467f1aa3d028f399826c97e2eecedcd79efcf65) Change-Id: I03dee5dc2e11accb97279e5f325808c5b85507a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157501 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-10-03replace ErrorInfo with simpler mechanismNoel Grandin
Instead of returning ErrCode class everywhere, return a new class ErrrCodeMsg, which combines an ErrCode with the other parameters that are used to control the error reporting. I do not change everything that uses ErrCode here, I started from SfxBaseController/SfxMedium and worked outwards. This change serves two purposes (1) Replace the extremely whacky ErrorInfo mechanism we were using to smuggle information into the error handler reporting mechanism with a very straightforward approach of just combining it into the error class. (2) Allow us to capture the source location that produced the error, which makes debugging the source of a problem soooo much easier. Change-Id: I978b8f00c9851b41a216c7ebdef2ef94251d5519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157440 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-26tdf#124591: Update Noto Naskh Arabic to v2.016Khaled Hosny
from: https://github.com/notofonts/arabic/releases/tag/NotoNaskhArabic-v2.016 Change-Id: Ic5d23046afddb8d7230ed3f71363cb178f572124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157271 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-09-20tdf#156842 increase scale for external PDF dataPatrick Luby
For some unknown reason, the scale is 8 times larger than for non-external PDF XObjects. This fix also allows the CppunitTest_vcl_pdfexport to run successfully on macOS. Change-Id: I166914e6ac575c50985efba3fb7a38ec758dea1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157090 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-09-12tdf#149545: increase svg check sizeXisco Fauli
otherwise it will fail to open documents like the one in tdf#149545 with long comments before "<svg" Change-Id: Ia46dad92052ae4ef7fee791098bf96df03257282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156844 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-09-12add a unit test for AlphaMask::BlendWithNoel Grandin
Change-Id: Id4602470292d0ba66601c5d2446a06df7e4b508b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-01tdf#157028 sw: PDF/UA export: reduce the number of Span ILSEsMichael Stahl
Currently every text portion produces its own Span ILSE, which means there's at least one per line. But that seems a bit excessive, let's try to merge the portions and create new Spans only when needed, i.e. when the formatting properties that are exported change. ILSEs may even be nested, e.g. a Span may contain Link or Span. This will only merge within one SwTextFrame; merging across split SwTextFrames looks too difficult to implement. Change-Id: Id9b02332c580266f78da048be80ecceff1b28eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156299 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-01sw: PDF/UA export: produce nested Sect SEs for nested sectionsMichael Stahl
Change-Id: I5b142acf00629ffd00562e2c8791587b7a7761df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156357 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-01adjust VclTextTest::testSimpleTextNoel Grandin
on my machine, after a recent update, the text is scaled slightly differently (Ubuntu 23.04) Change-Id: I5ac5e0c76a4cc4c0468a9f0e9186f95004d4d24f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156398 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-08-25This copy ctor should probably take its arg by const refStephan Bergmann
It was introduced in 3426dcfec2b4d5c755024c355f323ecc9f656e4a "vcl gtk3: Introduce AT-SPI2 tests for the GTK3 accessibility layer", and caused at least a build with recent GCC 14 trunk to failed with > In file included from vcl/qa/cppunit/a11y/atspi2/atspiwrapper.cxx:10: > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx: In member function ‘Atspi::Accessible::iterator Atspi::Accessible::iterator::operator++(int)’: > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:524:20: error: cannot bind non-const lvalue reference of type ‘Atspi::Accessible::iterator&’ to an rvalue of type ‘Atspi::Accessible::iterator’ > 524 | return other; > | ^~~~~ > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:508:28: note: initializing argument 1 of ‘Atspi::Accessible::iterator::iterator(Atspi::Accessible::iterator&)’ > 508 | iterator(iterator& other) > | ~~~~~~~~~~^~~~~ Change-Id: Ia9a1e3f58d67db1fc9851fe8a844f2076ff740c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156075 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-08-22vcl: Fix dumping meta file layout flags to XMLKhaled Hosny
These are bit flags, so we were always writing #0000, so now it does bitwise check for the flags and while at it write the names of the flags not the numeric values. Change-Id: I13cae38c0e549b2da1f834a264e3a3255bfa5c5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155793 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-11Initial APNG export supportParis Oplopoios
Change-Id: I27877d4bdf27cd92bdd939fd25e3820edad10f9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155387 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-08-04gtk3 a11y tests: Increase DBus timeoutColomban Wendling
We apparently get recurrent spurious timeout failures in the CI related to DBus timeout, so increase that value. The chosen value is a bit arbitrary, but is below the maximum recommended by the documentation (even though the recommendation hardly applies to our use case), and more than 3 times larger than the default. That will hopefully be enough. Change-Id: I244f711f46353009743015d00b303aeb87332936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155310 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-08-02vcl: Drop unused FontAttributes::GetMapNames()/AddMapName()Khaled Hosny
Change-Id: I50e06ad24e95cab39009a8affb876ebc920c1c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155168 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-02vcl: Drop unused PhysicalFontFamily::GetAliasNames()Khaled Hosny
Change-Id: Ide306f0656230460f976daef0ed213f734136030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155167 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-08-01Fix reversed expected and actual unit test resultsKhaled Hosny
Change-Id: Ie7eaec7ce9ad6f85b02edc831f1d138f45c18220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155152 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-30tdf#156528: Fix handling PDF page scaling factor after large pagesMike Kaganski
The map mode wasn't set when current page's user unit was 1, which meant that it used the unchanged value from the previous page, where it could be different. Change-Id: Id1f1515dceac25cddc12081a86fabf8b32d633f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155025 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-30tdf#107612: Include NNBSP and Mongolian characters in the same fallback runKhaled Hosny
When a Mongolian character is preceded by a Narrow No Break Space (NNBSP), it is used to trigger special letter forms, but when we do font fallback NNBSP is always taken from the main font (HarfBuzz synthesises it when missing from the font, so we almost never use font fallback for it). We now check if the start of the fallback run is a Mongolian character and the previous is NNBSP and extend the fallback run to include it. Change-Id: I7607dba37ee51ff62bc9e86c3dbc555cd77e8d5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155060 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-28Fix typoAndrea Gelmini
Change-Id: I1973ac5efd12b2071a92a97d8d669f1e46b9c594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155020 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-28Fix typoAndrea Gelmini
Change-Id: Ia8d0859088614c29ae358fed46d0c750d5a54e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155023 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-27vcl gtk3: Introduce AT-SPI2 tests for the GTK3 accessibility layerColomban Wendling
Add tests for the GTK3 accessibility platform layer. These tests compare the internal LO representation with what is visible to the platform, and thus the user's accessibility tools. In most cases the tests are fairly trivial as LO's internals are not far off AT-SPI2's expectations. There are however notable exceptions like for example the text attributes, that have a wildly different representation and require more complex checks matching what LO's platform layer does, the other way around. These tests use libatspi2 directly, but as the C API is awful to work with regarding resource management, there are wrappers to handle the complexity using RAII. The resulting API is fairly trivial to use. As these tests require using the GTK3 VCL plugin and for the a11y tree to be visible to AT-SPI2, they are run under XVFB using a separate dbus session through dbus-launch. Working on this has already lead to reporting and/or solving some issues: * https://gerrit.libreoffice.org/c/core/+/151303 * https://gerrit.libreoffice.org/c/core/+/151650 * https://gerrit.libreoffice.org/c/core/+/152456 * https://gerrit.libreoffice.org/c/core/+/152457 * https://bugs.documentfoundation.org/show_bug.cgi?id=155625 * https://bugs.documentfoundation.org/show_bug.cgi?id=155705 * https://gerrit.libreoffice.org/c/core/+/152748 Only a subset of the a11y APIs are covered for the moment, but the current state should make it easy to extend upon. Change-Id: I1a047864ce8dc1f1bc3056ad00159f7fd5e5b7d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153069 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin
(Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-23vcl: Drop now unneeded DevicePoint typedefKhaled Hosny
It has been always typedef'd to basegfx::B2DPoint since: commit 5e218b5c51f7d9cd10bd9db832879efca41b9c75 Date: Wed Jan 12 21:19:32 2022 +0000 always use B2DPoint for DevicePoint Change-Id: I9f5202d5a71c77dd79f1759923917c26bf68a9af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154632 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-23vcl: Use doubles for glyph item coordinatesKhaled Hosny
Change how glyph coordinates are represented inside VCL to use floating point instead of integers. Should make no functional difference because we are still rounding them. Change-Id: I5480ee3dec3afab50194954095fd6829ebaa4a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154499 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-23vcl: Set font size to UPEM in some testsKhaled Hosny
Reduces the chance of rounding differences. Change-Id: I4ad3e00a41c2dba01fe113ba1261dcf12f0b19f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154381 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-23vcl: Use HarfBuzz to get glyph bounding rectangleKhaled Hosny
For consistent cross-platform results that also matches our glyph advances since platform functions might be using hints which we don’t use. Change-Id: I4aebd3e7c5f460dff584f5eba74f7a11bab0f9b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154388 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-23Make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf108963 less sensitiveKhaled Hosny
The test does not need all that precision, without the bug fix for tdf#108963 it fails with: double equality assertion failed - Expected: 245 - Actual : 255.401992797852 - Delta : 0.999 Change-Id: Iae20417465e7c43f5be2819f710f768645dc3253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154522 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-21tdf#154955 svx: PDF/UA export: tag SdrObjGroup properlyMichael Stahl
ISO 14289-1:2014, 7.3 Graphics Graphics that possess semantic value only in combination with other graphics shall be tagged with a single Figure tag for each group. Also produce the missing alt-text. Change-Id: I78e802d8e17a29c2d19fcf3a7ec9961f8f04e391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154684 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-14tdf#154982 drawinglayer,svx,sw,vcl: PDF export: hell flys and shapes...Michael Stahl
... should be below their anchor paragraph in the structure tree. Refactor SwEnhancedPDFExportHelper (etc.) to use the new EnsureStructureElement()/InitStructureElement() functions instead of SetCurrentStructureElement() for the frames, and allow it for flys that don't have their anchor paragraphs created yet because the hell layer is exported before the document body. Change-Id: I1be3b54002e8196772e6f9d81dd0fd0c85b6e34b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154399 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-11tdf#152234 vcl: Role values are lowercaseMichael Stahl
Old version 3 of PAC throws exceptions if these are capitalized; presumably this is case sensitive, and all-lowercase unlike everything else. Change-Id: Ifc0cef38e333123e810376ab6a7630443d253841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154282 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-11tdf#154939 sw: PDF/UA export: produce Link StructElem inside FigureMichael Stahl
... for a fly frame with a hyperlink set. Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 1 Links shall be tagged according to ISO 32000-1:2008, 14.8.4.4.2, Link Element. A Link annotation is nested within null tag instead of Link Change-Id: I7a2bef8d6100adffb1f40085bba8f18fc68bd8d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154280 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-06make tools::Poly*gon single-arg constructors explicitNoel Grandin
which will help avoid ambiguity in method calls in an upcoming patch Change-Id: Ic7607ac7d95559e0942a84fb3226cfdd6ade22bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154146 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-04tdf#156016: vcl_graphic_test: Add unittestXisco Fauli
Change-Id: I0b8a9c8d8440e5084f1cce6e666e20d4508cc691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153963 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-04CppunitTest_vcl_graphic_test: use CPPUNIT_TEST_FIXTURE()Xisco Fauli
Avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I8a310a6aca3e575f93737cc50e0614592a7ffc8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153958 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-04CppunitTest_vcl_graphic_test: Demultiplex test codeXisco Fauli
and relax hack a bit, enabling webp based on testname is dirty since they might change Change-Id: Id933095701d01426d2802d6a194d6f74c07baaa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153957 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-04tdf#152235 filter,vcl: PDF/UA export: tag watermark as ArtifactMichael Stahl
Change-Id: I64e57a832678be935b69a5cea328cc252a4bf29d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153951 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-04Fix typoAndrea Gelmini
Change-Id: I14c4862788b3fe28f9c2f6b0ef41601192f5560e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153881 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-03tdf#48707: Explicitly set overline color in PDF exportKhaled Hosny
Like we do with underline color, so that color does not leak from elsewhere. Change-Id: I3716a117a0d0a1260e47cbfed2242f401a09d7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153877 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-03tdf#152231 vcl: PDF/UA export: content of comments in the marginMichael Stahl
... is also Artifact. The problem is that ImpEditEngine::Paint() always produces tags, it can't easily check if it's inside a layout environment that is an Artifact. But it looks like PDFWriterImpl::beginStructureElement() already wants to handle and suppress a structure element inside a NonStruct, except that it calls endStructureElementMCSeq() before checkEmitStructure(), so no structure marked content sequence is produced, but the content is outside the Artifact marked content sequence, and possibly a second Artifact marked content sequence will be opened once the structure element is finished. (btw, it's allowed to nest marked content sequences in PDF, but nesting a structure element inside an Artifact appears dubious) Change-Id: Ib3eef9c611e28242854c712ce974fd8cfecd8ac2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153810 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-21Use Unicode hex instead of string literal in readmeKhaled Hosny
Apparently the string literal in command line argument does not work everywhere. Change-Id: I4d742f53757699a69d9ba13326a54478f18e51a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153403 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2023-06-20tdf#107718: Fix script itemization of vertical textKhaled Hosny
Mixed script vertical text was not correctly splitting runs at script changes, resulting in Hangul text being mixed with Han text in the same run breaking the Hangul composition. Change-Id: I09c3f799bede6aa8a19684779d500504a9813af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153313 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-16tdf#146547 sfx2: allow read-only documents to be modifiedMichael Stahl
This is particularly useful for a Writer document that contains a section that is set to be editable in a read-only document, so that the user is warned when closing such a document without saving it. Originally this check was added in commit 27db57efc51487b3976fbf73df1868b8fb78d201 "CWS fwkbugfix05" "#i39869#: readonly docs should never become modified" but the actual problem there was that the read-only document was displayed in a wizard dialog, not in a document view, so let's instead check that the document is some kind of "internal" document. Also the dialog's Save button should do something, and since the document is read-only, a Save As dialog appears appropriate. Change-Id: I339cbe92a2c9eb74a1f5061246f921037a47f79c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153180 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-15tdf#155161: Add testKhaled Hosny
The test document embeds Cantarell font because we don’t bundle any fonts with CFF2 table (or CFF table for that matter). Change-Id: Icdbab58ea3999baa75bc85fad60172218d9f6058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153054 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-06-13tdf#153440: Add testKhaled Hosny
Change-Id: I0c036cd1d8022e6ff265aa67ab177c57eba0c4ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152934 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-02 10:39:53 +0000