summaryrefslogtreecommitdiff
path: root/vcl/qa
AgeCommit message (Collapse)Author
2019-03-29fix testConvert for OpenGLTomaž Vajngerl
Change-Id: Id78ef9fd05bc158b52aa465c932869c0ef1c55d7 Reviewed-on: https://gerrit.libreoffice.org/69921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29add bitmap test with a custom 8bit paletteTomaž Vajngerl
Change-Id: I83d7f1f28c7b0dc707ef26675449d5f3654dacda Reviewed-on: https://gerrit.libreoffice.org/69922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29tdf#107966 vcl opengl: fix not drawn 1px wide polypolygonsMiklos Vajna
Visible at e.g. in Calc: Format Cells/Borders/Line Styles. The problem was that first commit 2e99e4e11d33679aed674eea0d6054d16d39d6df (opengl: use MVP matrix in vertex shaders, pixel offsets, 2015-07-08) introduced the concept of pixel offsets, setting the value (implicitly) to 0 in OpenGLSalGraphicsImpl::DrawTrapezoid(), but using 0.5 in OpenGLSalGraphicsImpl::FlushLinesOrTriangles(). This is fine, but then later commit 2003076c4318511a3d621558d3b44b4e8e6c6529 (opengl: batch draw polypolygons, 2016-05-29) changed OpenGLSalGraphicsImpl::drawPolyPolygon() to use deferred drawing instead of DrawTrapezoid(), without doing any translation of the input polypolygon. This resulted in loss of those polygons when used in the above mentioned dialog, which has a listbox of bitmaps, where each line style preview is drawn on a virtual device with a height of 1px. So at the end the 1px offset meant the previews were simply missing. ('make CppunitTest_vcl_gen SAL_USE_VCLPLUGIN=gen SAL_FORCEGL=1' is needed on Linux to see the test failing without the fix.) Change-Id: Ia9f3d6e7cb38a43fe2f8a41746b538af68add43c Reviewed-on: https://gerrit.libreoffice.org/69920 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-29check that jpeg export of 8bit grayscale worksLuboš Luňák
This is a simpler check for 77146ca8193a8e258dbb0dae0793497a66734ff1 (related to tdf#121615). Change-Id: I33b92f07bebeb735466e0728c6c51b79fc0b5bb8 Reviewed-on: https://gerrit.libreoffice.org/69820 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-28check that jpeg export of 8bit non-grayscale worksLuboš Luňák
This checks what I fixed in 1893024c54ab173ec6262d77a05cad285c17a617 (related to tdf#116888). Change-Id: I721017fd037d62ba75cbc962fdd9316e02085624 Reviewed-on: https://gerrit.libreoffice.org/69819 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-28make ReadTexture() also handle 8-bit non-grayscale images (tdf#116888)Luboš Luňák
The missing case caused BitmapReadAccess to work with random data (together with a follow-up bug that didn't deallocate data properly after ReadTexture() failed). Change-Id: I4546ee4ca85d6a0b01cc41636c257008c9f19587 Reviewed-on: https://gerrit.libreoffice.org/69745 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-26CppunitTest_vcl_complextext: work around lo_daily_update_gandalf failureMiklos Vajna
I'm not sure why #if HAVE_MORE_FONTS guard is not enough, but in any case, the purpose of the test is to see if the final assert succeeds or not, so if layout fails completely, that's not interesting here. Change-Id: Ie663f82b86e101167cd7317d25345b2d48960cbb Reviewed-on: https://gerrit.libreoffice.org/69736 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-26Rename DrawCommand* to WidgetDrawAction*, remove unused circ drawTomaž Vajngerl
Change-Id: Icef900e75255d477812a198fdb29e0cdebba35b8 Reviewed-on: https://gerrit.libreoffice.org/69654 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-25fix grayscale jpeg writing in pdfexport (tdf#121615)Luboš Luňák
If the bitmap to be written is non-8bit, e.g. in case of using OpenGL (on Linux the test requires "SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen", on Windows it's probably the default case), then the bitmap is not in native format for 8bit. This was done correctly by 45e8e0fbee40f that introduced it but somehow it got lost later (I can't even find where). Change-Id: Ib1810cb9cf12e373c1cb41da40fa28e96ad7db28 Reviewed-on: https://gerrit.libreoffice.org/69213 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-22Related: tdf#124109 vcl: make glyph item caching work with kashida glyphsMiklos Vajna
This was broken because GenericSalLayout::LayoutText() sets the SalLayoutFlags::KashidaJustification flag as a side-effect of building the glyph list. So in case we cache the list and not build it, the flag will be missing. This means that later in GenericSalLayout::ApplyDXArray() kashida glyphs won't be inserted. With this, the workaround in sw can be removed. Change-Id: Ic18211bf50ca673daa238e8950a381915e4b3096 Reviewed-on: https://gerrit.libreoffice.org/69566 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-12tdf#123304: Allow the full feature syntax as pre 6.2Khaled Hosny
Fix regression from: commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Date: Fri Jun 15 19:32:15 2018 +0200 vcl: parser of font features included in the font name Where hb_feature_from_string() was replaced by a simple parser that supports avery limited subset of the syntax it supports (as documented in https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-feature-from-string) Change-Id: I613190a677d24183e8c718fcfcaf9cf9b37a1e8f Reviewed-on: https://gerrit.libreoffice.org/69062 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2019-03-10widget theme: draw listheader button and arrowTomaž Vajngerl
Also adds support for signaling if arrow points up or down, which is signaled through extra attribute. Change-Id: I5a87cdb31e18150495df521bf925c7b983e2313a Reviewed-on: https://gerrit.libreoffice.org/69013 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-09Separate style colors from WidgetDefinition into its own classTomaž Vajngerl
Change-Id: I11cd695da81bae7b49b2319b89e5c560ba64f04e Reviewed-on: https://gerrit.libreoffice.org/68975 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-08tdf#121120 vcl opengl: handle 8-bit palette bitmap as 24 bit RGB textureMiklos Vajna
This fixes the black rectangle instead of actual image content in the bugdoc. An alternative would be to handle this in the PNG import, but commit 66dbd4da3afcadb1393daf9be9cecff71b86509a (tdf#113918: Workaround: Load 1bpp indexed PNG as 8bpp indexed Bitmap, 2017-11-20) already tried something similar and failed, leading to the revert in commit 25cd843664919974f0d21ca7a0b02cc43e9eeabb (tdf#115297: alternative fix for displaying 1bit images, 2018-02-27). The test is especially useful with SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen specified on Linux, so the GL codepath is triggered. Change-Id: Ia9d049d09dce2ac34826ee427f74616a96a35c88 Reviewed-on: https://gerrit.libreoffice.org/68925 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-08new loplugin constvarsNoel Grandin
detect static variables that can be made const. Thanks to mike kaganski for suggesting this. Here I introduce a new plugin feature - using markers in nearby comments to disable the plugin for specific vars. Some of this stuff was old debugging code. I removed the stuff that was older than 5 years. Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c Reviewed-on: https://gerrit.libreoffice.org/68807 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-06Support first, last tab item for the widget definitionTomaž Vajngerl
Add "extra" parameter for the widget definition states with the default set to "any". For tab item, the extra parameter can be "first", "last", "middle" and "first_last" (only one). This is needed to draw first and last tab item differently. Change-Id: I46b6897b485b4df94ab6fe9521925c3715eaa24e Reviewed-on: https://gerrit.libreoffice.org/68817 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-05Add support for <image> draw definition to draw a SVG imageTomaž Vajngerl
Attribute "source" is used to get the relative path to the image. Path is relative to the definition file. Change-Id: I6ca0c113385e26ad74b928e1f56635b4b0cef995 Reviewed-on: https://gerrit.libreoffice.org/68712 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-04Refactor so we have only one definition map and ControlTypeAndPartTomaž Vajngerl
Until now we had multiple maps, each for a specific ControlType (maPushButtonDefinitions for example) which had multiple parts identified by the string. To simplify matters, this changes that we have just one map for a specific ControlType and ControlPart which are identified by ControlTypeAndPart structure. Change-Id: I90a2e5c8f83d697d26049054eacab250e2768c03 Reviewed-on: https://gerrit.libreoffice.org/68690 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-04separate WidgetDefinitionReader from the actual WidgetDefinitionTomaž Vajngerl
This separates the functionallity to read the definition from the definition itself. This is needed to have both responisibilities separated so it's easier to work with and test. Change-Id: Id0dd9c17852a8b7479e9d01d4c1726e915d3dc6e Reviewed-on: https://gerrit.libreoffice.org/68681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-04Update WidgetDefinitionTest for RadioButton and button valueTomaž Vajngerl
Change-Id: I04fde55661f81d3d230cda3eb5cc2dcec72a1309 Reviewed-on: https://gerrit.libreoffice.org/68655 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-04Read style colors from a xml widget definition fileTomaž Vajngerl
WidgetDefinitionReader is responsible to read the definitions from an xml file. The first implemented definitions are style colors. They are read from the file and stored into class fields. This also adds the unit test which tests that the reader is functioning as expected for a small certain subset of colors. Change-Id: Icd44cb465b084c32db8323e2f2f7dfa57823d559 Reviewed-on: https://gerrit.libreoffice.org/68642 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-01Some more WIN32 -> _WIN32Stephan Bergmann
...at least some of which have presumably been missing from ce43d0ae9279edbf1ad108fe0d8325327a038d49 "use consistent #define checks for the Windows platform" by accident (and some just clean up comments) Change-Id: I5532685c7df96ae3c8a25b73d8064d7433964a9b Reviewed-on: https://gerrit.libreoffice.org/68580 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-16Fix typosAndrea Gelmini
Change-Id: Ic0ab859d7b9bfbce8d55c1c9dc11bfae760626f3 Reviewed-on: https://gerrit.libreoffice.org/67898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-15disble test of rendering BitmapEx with alpha on Windows for nowTomaž Vajngerl
Tinderboxes fail, but Jenkins was fine so we must have problems with rounding errors in some code paths. Change-Id: I38a457c0ee7a079bebaa599794b0e65c433dfe64
2019-02-14vcl: test rendering of bitmaps with alphaTomaž Vajngerl
Change-Id: I6fde9581793fe85fc30d0660de3d62f0ddbfe9fd Reviewed-on: https://gerrit.libreoffice.org/67807 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13Improve the algorithm of disabled image creationTomaž Vajngerl
Main change is to not change alpha channel at all. For RGB channels, calculate the luma value and map the value into 160-224 range. Much simpler and better result. Change-Id: Ied108c2135f98d78f230a2c0b305bd3396d9ccfd Reviewed-on: https://gerrit.libreoffice.org/67791 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09add PngImageFilter that uses libpng for PNG loadingTomaž Vajngerl
This adds loading of PNG images that uses libpng instead of our own solution. It always loaded the image as either RGB or RGBA image and if the source PNG is using something else, libpng converts to either RGB or RGBA. In addition this adds tests for loading of various PNG files to make sure the resulting bitmaps are using pixel data as expected. (especially needed to check the RGBA bitmaps) Change-Id: I194321caf76c2ec2365bb6075c79c5e84983658a Reviewed-on: https://gerrit.libreoffice.org/67571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-30Consistently skip "Import the bugdoc and print to PDF" testsStephan Bergmann
At least some local Linux x86 32-bit build of mine with --disable-cups (which might or might not be relevant) kept failing the CPPUNIT_ASSERT(pPdfDocument); in the recently added PdfExportTest::testSofthyphenPos, apparently because the generated temp file (maTempFile) was empty. But PdfExportTest::testTdf107868 is an older test that already gets skipped if !pPdfDocument, so make PdfExportTest::testSofthyphenPos be consistently skipped in the same way (instead of trying to find out why exactly it failed for me). Change-Id: Ifc1c507fbfb00e32ed3bf94d8d520f9c60d5c4fe Reviewed-on: https://gerrit.libreoffice.org/67163 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-01-30Resolves: tdf#122958 bmps with weird compression values that work in msoCaolán McNamara
Change-Id: Ie1887288cba7c1d56b807dbc9ddb886b9d20ff33 Reviewed-on: https://gerrit.libreoffice.org/67143 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-26vcl: test gradient draw into a metafile, extend the dumperTomaž Vajngerl
Change-Id: I87600c8cb648686b80092a9526a07ed71b324907 Reviewed-on: https://gerrit.libreoffice.org/66918 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-24tdf#96892 vcl: add unit test for misplaced soft-hyphen ...Michael Stahl
... due to incorrectly exported font size. Change-Id: If06dccc000530427be767fc7a5031f5ebe6fd431 Reviewed-on: https://gerrit.libreoffice.org/66803 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-15vcl: protect more outdev functions for disposed stateMiklos Vajna
This is similar to commit c612c3b0aed9ad7f7f42b4313f821b71995ead15 (protect more printer code-paths., 2015-03-20), but handles more OutputDevice member functions. The user-level problem was that in case a macro creates a dialog with an embedded Chart document and the user clicks on e.g. the chart title (so an sdr::overlay::OverlayManager is created), then it can happen during closing the dialog that the overlay manager calls these functions after the output device is disposed. Change-Id: I8021fb795704f19e52d70505804d68725c636ce0 Reviewed-on: https://gerrit.libreoffice.org/66403 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-11tdf#114441 Convert use of sal_uLong to sal_uInt32Gabor Kelemen
Convert the return type of GetScanlineSize to sal_uInt32 since the type of the mnScanlineSize member of the BitmapBuffer struct is "long" Convert places that are using the value returned by this method Change-Id: I222ce30b8e8f88402ddfd25286ca3b7548a8e8fb Reviewed-on: https://gerrit.libreoffice.org/65779 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-10Revert "Try fixing VclComplexTextTest::testArabic by rescheduling"Mike Kaganski
Apparently, this patch was ineffective, and wrong, as Jan-Marek told. https://ci.libreoffice.org/job/gerrit_windows/25682/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25549/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25531/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25489/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd https://ci.libreoffice.org/job/gerrit_windows/25434/consoleFull#1607778044d893063f-7f3d-4b7e-b56f-4e0f225817cd This reverts commit 68259f3663ba61a5f15f04793ac32a200100a8a5. Change-Id: Ibcb804b0b52339d6977c80129b10adb309514dbc Reviewed-on: https://gerrit.libreoffice.org/66088 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-08convert "*xxx.get()" to "*xxx"Noel Grandin
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9 Reviewed-on: https://gerrit.libreoffice.org/65951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-03svm xml dumper: move this from test to vclMiklos Vajna
This is very useful functionality, this way it can be invoked from the debugger and/or nested into an outer xml dump (sw/sd doc model dump) more easily. Change-Id: If6c83b11d0f3e65fcce71e8d820c6bc354f64d68 Reviewed-on: https://gerrit.libreoffice.org/65834 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-25Try fixing VclComplexTextTest::testArabic by reschedulingMike Kaganski
The test keeps sporadically falling on Windows; it just has failed twice in a row for me at line 98, with actual values 90 and 76, instead of 72. Unfortunately, in subsequent testing, the test keeps working OK, so no reliable reproducing. I suspect some problem with initialization possibly missing; so try to fix it by inserting an Application::Reschedule(). I am not an expert in this code, so this change could of course make no sense. I reenable tests that were skipped because of the instability; if the fix is wrong, hopefully this will make it apparent sooner to revert it. Change-Id: I939375de6046e3698574be019f6ea512af53dacd Reviewed-on: https://gerrit.libreoffice.org/65594 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-12-11tdf#121962 Don't treat closing bracket as invalid syntaxSamuel Mehrbrodt
Somehow there is a difference how the formula looks when converting via command line vs exporting from UI. In UI the sum formula looks like: 'sum( (0) ) (0|0|0|0)' while in cmd line it looks like: 'sum( (0) ) () ' Both look sane, so just don't treat the second one as error. Change-Id: I345c062a9e7c8b9c849885bc6cb88167a3491dd8 Reviewed-on: https://gerrit.libreoffice.org/64941 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-12-03Revert "Check against concrete expected values in PdfExportTest::testTdf115262"Stephan Bergmann
This reverts commit 3bb64c0b26962f3c62dc82353b8ca13479c409be, at least Jenkins' lo_tb_master_win builds started to fail with > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/vcl/qa/cppunit/pdfexport/pdfexport.cxx(1581) : error : Assertion > Test name: `anonymous namespace'::PdfExportTest::testTdf115262 > equality assertion failed > - Expected: 199 > - Actual : 198 (<https://ci.libreoffice.org/job/lo_tb_master_win/19796/>).
2018-11-28Check against concrete expected values in PdfExportTest::testTdf115262Stephan Bergmann
With d464d505fbf6e53a38afdd3661d320fac8c760d6 "Refactor calc non-linear ViewToDevice transform", the problems with my macOS build that I described in the commit message of (abandoned) <https://gerrit.libreoffice.org/#/c/61651/> "Omit 'Calc adjust to grid hack' when not rendering for the screen" are apparently solved: `make CppunitTest_vcl_pdfexport test` succeeds, and opening vcl/qa/cppunit/pdfexport/data/tdf115262.ods and exporting it to PDF while the on-screen Calc document is displayed at varying zoom levels leads to effectively identical files now. Assuming that 232 is the universally correct value for nFirstImageTop now (nRowTop appears to have always evaluated to 199), it looks cleaner to me to have the expected values spelled out explicitly in the test code. Change-Id: Idb9f30f4ab9641b5b5325ddd90084e4112e1b572 Reviewed-on: https://gerrit.libreoffice.org/64171 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-24disable more vcl pdfexport test on winNoel Grandin
Change-Id: I32fe34dc5d3d80dc26a5a2237c56155576789709 Reviewed-on: https://gerrit.libreoffice.org/63940 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Don't check page size on Win for tdf#112690 unit testAron Budea
Since ec11c1aee04eacb00d94a6359f959b990ddb6923, lo_tb_master_win consistently fails in CppunitTest_vcl_pdfexport with double equality assertion failed, expected: 793.7, actual: 793, delta 0.01. The difference is significant, previously before tdf#112690 fix the incorrect width was 793.67, but the reason is unknown. Let's disable the check in Win for now. Change-Id: If1569131217d83054875b7cb72787e1a6ef7023c Reviewed-on: https://gerrit.libreoffice.org/63726 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-08Fix typoAndrea Gelmini
Change-Id: Id76063b32ba37d42608cf7a19cbdf53d46fcbcc4 Reviewed-on: https://gerrit.libreoffice.org/63035 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-07ifdef out more fontfeature test on windowsNoel Grandin
tb72 fails this regularly Change-Id: I4c5fb8f4955e8479c31d0a3b67123b34ecc889aa Reviewed-on: https://gerrit.libreoffice.org/62993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-05tdf#118244 pdfexport: radio buttons can group with same nameJustin Luth
The old implementation grouped radio buttons if their object name was the same, and didn't have a groupname property. The old implementation still works - so that still needs to be supported, which this patch ensures. Change-Id: Ied6ddc52d1c4ab5bca56b14da51258460ca2120c Reviewed-on: https://gerrit.libreoffice.org/62812 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-05tdf#118244 pdfexport: radio buttons use groupname nowJustin Luth
The previous implementation grouped radio buttons if their object name was the same. Likely this is a very old implementation, because the current radio buttons have a groupname property which links them together (although that too needed fixing in doc/docx), and their object names are unique. The old implementation still works - so that still needs to be supported, but I think I'll do that in a separate patch, so that it can be easily reverted if the old implementation is deprecated. Edge cases tested: -groupID of 0 works fine - doesn't have to be 1-based. -empty group name works fine (but breaks the old impl). -writer, calc, Change-Id: I84aebdac18b9edfa5ffcbfb23c15d0f37fcd47d1 Reviewed-on: https://gerrit.libreoffice.org/62742 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-29loplugin:oncevarNoel Grandin
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-13 11:06:12 +0000