| Age | Commit message (Collapse) | Author |
|---|
|
Use the existing OCommonAccessibleComponent::ensureAlive
instead of reimplementing the logic here.
Change-Id: I24d66e4c577a58619d968a4efcb1bad7a19aed7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180897
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Similar to how
commit 7107db3fe773629cc511eb5922bc9c28c9c5c60a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jan 24 18:57:58 2025 +0100
toolkit a11y: Use OAccessibleComponentHelper for grid control
did for AccessibleGridControlBase, also derive
from OAccessibleComponentHelper for Paragraph
to make use of the logic already implemented there
instead of having to implement all the XAccessibleComponent
and XAccessibleEventBroadcaster methods manually.
Paragraph::getBounds already
provides what is needed to implement
Paragraph::implGetBounds, so just rename it.
Drop all of the other overrides that are no longer
needed as the implementation is now provided by
the OAccessibleComponentHelper base class.
No change in behavior intended or observed when
testing this with Accerciser and Orca and the qt6
VCL plugin with the IDE editor ("Tools" -> "Macros"
-> "Edit Macros").
Change-Id: I88ac869d115ceb13ccf48932f6d66d95bbd2fc9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180896
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Drop the "accessibility" namespace in which the classes
moved to vcl from the earlier separate accessibility
module were, see
commit 9283da858506fe3b4383e4cfe0506e470a4356f6
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Dec 17 12:04:04 2024 +0100
a11y: Merge accessibility module into vcl
In an upcoming Gerrit change [1] that namespace was
now causing ambiguity in source files using
using namespace css::uno;
because a simple `accessibility` namespace specifier
could now be for either the `accessibility` namespace
removed with this commit or `css::uno::accessibility`.
Sample from Windows CI failure [2]:
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/accessibility/vclxaccessiblecomponent.cxx(112): error C2872: 'accessibility': ambiguous symbol
C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\vcl\inc\accessibility/accessibletablistbox.hxx(29): note: could be 'accessibility'
C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/vclxaccessiblecomponent.hxx(31): note: or 'com::sun::star::accessibility'
C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/accessibility/vclxaccessiblecomponent.cxx(112): error C2039: 'XAccessibleContext': is not a member of 'accessibility'
Drop the namespace to avoid having to always specify
the whole namespace (`css::uno::accessibility` vs `::accessibility`).
(`git show --ignore-space-change` shows the "actual
changes" more clearly as some code was using an
extra indentation level due to the namespace
that has been removed along with the namespace.)
[1] https://gerrit.libreoffice.org/c/core/+/180848
[2] https://ci.libreoffice.org/job/gerrit_windows/192770/consoleFull#1759204403cbd6b0d4-2729-45f4-a019-828721d0af3e
Change-Id: I6ca85c2660c001f9bc45700f2f13bd0b6707f8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180870
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Now that the accessibility module no longer
depends on toolkit and svtools and there's
therefore no more cyclic dependency, merge it
into the vcl library, where the vcl widgets are located,
for which the classes in the accessibility
module (primarily) provide the a11y classes.
Initially, take over the existing UNO service
"com.sun.star.accessibility.comp.GetStandardAccessibleFactoryService"
to vcl as is. It used to be necessary to break the cyclic
dependency between the vcl, svtools, toolkit and
accessibility module. (vcl is the lowest and
accessibility used to be furthest up in the dependency
chain; yet vcl needed it to create the objects
providing the XAccessible/XAccessibleContext
for its widgets.)
Further simplification can happen in upcoming commits.
Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178647
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
