summaryrefslogtreecommitdiff
path: root/vcl/source/edit
AgeCommit message (Collapse)Author
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-07vcl: Make it noncopyable by deleting copy ctor & coTakeshi Abe
Change-Id: Ia141d1d48d915f1ecc0351e47d7b9700891ebad2 Reviewed-on: https://gerrit.libreoffice.org/23891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-01loplugin:constantparam in vclNoel Grandin
Change-Id: I5af0906ced6d0e917b54dee22577fa40d134464c Reviewed-on: https://gerrit.libreoffice.org/23719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I751e75e0b63e95cc92be7b61a77ed21eeb52bc1f
2016-03-04loplugin:unuseddefaultparams in vcl and xmloffNoel Grandin
and teach the plugin about code that takes the address of a function Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc Reviewed-on: https://gerrit.libreoffice.org/22861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-26loplugin:unuseddefaultparams in /include/vclNoel Grandin
Change-Id: I36daccd90bfa6ba0ee8b9e76bff2bd8494155a04 Reviewed-on: https://gerrit.libreoffice.org/22710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22loplugin:commaoperator in vcl/Noel Grandin
Change-Id: Ia5bbce27d9e9526122ce1e27389c7845e6709f27
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-04this does not make senseEike Rathke
Either we pass the modified aOptions that isn't used anywhere else or we eliminate that and pass the unmodified rSearchOptions. Assume that the intention actually was to use the current locale. Change-Id: I121c28163f0df4305d13ba18e32e18237bb49ade
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-18loplugin: unused return values in vcl/Noel Grandin
Change-Id: I879bd3bec4dd2cf002681f1e50b6c33cce0934a9
2016-01-08vcl: cleanup namespace in vcl/source/edit/textview.cxxChris Sherlock
Change-Id: If33d4e30d39f9382eab2deb4f4ceb6f65211b912
2016-01-05tdf#96687 - force validation after External InputJustin Luth
After external input (EndExtTextInput), the selection was marked as invalid, but bFormatted remained true, so all the functions that re-evaluated and marked the portion as valid again were skipped and therefore the invalid portion was not painted. Change-Id: Ibb2208bdaeb8ed17a4a34fa378a2fc750abf1b07 Reviewed-on: https://gerrit.libreoffice.org/20986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2015-12-27Prefer switch-case to cascaded ifsMatteo Casalin
Change-Id: I0848676dcdf6f96fe90f34be018b1c3d9d3d370a
2015-12-01tdf#94138 Use correct fonts for multiline edit when printingTomaž Vajngerl
When drawing a multiline edit we need to use a different device (current window) to get the correct font and adjust for the Draw method's input device. Change-Id: I7993790c02d10e4283c7a4e2caefff0c7747e978
2015-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-18com::sun::star->css in vcl/Noel Grandin
Change-Id: Ifad76177673cf93746ba221838be80ff76fed228 Reviewed-on: https://gerrit.libreoffice.org/20032 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17use unique_ptr for pImpl in vcl,vbahelper,uuiNoel Grandin
Change-Id: Icb7573c24c681a8fc0570d61b6a30dab91378eb8
2015-11-12vcl: boost::ptr_vector->std::vectorNoel Grandin
Change-Id: Ib75e4dffb35032f273b9482341a438ccb9b00397
2015-11-12vcl: boost::ptr_vector->std::vectorNoel Grandin
Change-Id: I21f90c8d4b3d52b7119d664cb7af471b33f27649
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I7ac150458a72963f3336d30ef9d99d7c0d81c024
2015-10-20loplugin:defaultparamsStephan Bergmann
Change-Id: I3e5ee77b51eb8e1207d3f95e6a1d9d8272532ba6
2015-10-16convert Link<> to typedNoel Grandin
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6 Reviewed-on: https://gerrit.libreoffice.org/19405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I68ab6da7c90b869499f1b7a4d2433dac77d36889
2015-10-09clang-analyzer-deadcode.DeadStoresStephan Bergmann
Change-Id: I499f00e13543d2191008a0d7a4aa0391d6889315
2015-10-01Fix typosAndrea Gelmini
Change-Id: I8fd769ca61d1ec1a915a012c0c2244056dc5bcb8 Reviewed-on: https://gerrit.libreoffice.org/18992 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29tdf#94559: first step to remove rtti.hxxOliver Specht
replaced use of PTR_CAST, IS_TYPE, ISA in avmedia, basctl, basic, cui, dbaccess, vcl,xmloff Change-Id: If4496762e82e896b6fbc362e6626502703c245f5 Reviewed-on: https://gerrit.libreoffice.org/18905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-10coverity#1323752 Logically dead codeCaolán McNamara
Change-Id: Ic7b0e9c6a1e4e1ce37d49358828a660fdfc63a1d
2015-09-04convert Link<> to typedNoel Grandin
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4 Reviewed-on: https://gerrit.libreoffice.org/18306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03clang-tidy clang-analyzer-deadcode.DeadStoresStephan Bergmann
...given that setting bCalcPortion to false is always followed by a break out of the while loop ever since the code's inception in 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import," bCalcPortion is apparently always true when read Change-Id: I83ba29a78512360500a0c9c8c1baf1ccbad87951
2015-08-16sal_uLong to sal_Int32/longMatteo Casalin
Change-Id: Ia4ae190da37351b8c2b7ee9fc953508c5b1ab062
2015-08-16Avoid unnecessary OUString copiesMatteo Casalin
Change-Id: Ic76c9b75bcc72d8ae6a54d6ebba49acb77073bea
2015-08-16sal_uLong to sal_uInt32Matteo Casalin
Change-Id: Ifcde090747127680a9e4b810ff062d024663632c
2015-08-16Use constants instead of (possibly wrong) magic numbersMatteo Casalin
Change-Id: I0829d271337b9fe77341c62a1c2ef4d6ae62c727
2015-08-16sal_uLong to sal_uInt32 as TextPaM paragraph numberMatteo Casalin
Applied also to related functions. Also fix a couple of minor issues while at it. Change-Id: I615094d047c87a0f4854054e720492d3ab25c575
2015-08-16sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: Ia693dcbcfaa0349ef13466bb2eed877c5823f5bb
2015-08-16sal_uInt16/short to sal_uInt16, minor optimizationsMatteo Casalin
Change-Id: If52de6e7fbfef92ab53086c6dcc405dad6cffe2d
2015-08-16sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: I5b2f0e0a0c75eea14903e333eb17613d0499f458
2015-08-16Simplify by using range-based for loopsMatteo Casalin
Change-Id: I716d8b190aa4b65b878559a4e5e88a126a56bf99
2015-08-16sal_uInt16 to sal_Int32Matteo Casalin
Change-Id: If23175eebaccc4bfce2d921ed8d1ae66832178de
generated by cgit (git 2.34.1) at 2024-08-01 01:41:16 +0000